@yemi33/minions 0.1.2180 → 0.1.2181

package/dashboard/js/refresh.js

@@ -1167,21 +1167,16 @@ document.addEventListener('visibilitychange', function() {
 // Ring buffer capturing the last 50 /api/status poll cycles so a user
 // reporting "the dashboard didn't auto-update when X changed" can paste
 // `window._refreshDiagnostics()` from devtools or click the "diag" footer
-// chip to surface a table. Gated behind feature flag
-// `dashboard-refresh-diagnostics` (engine/features.js) — disabled in
-// production, enabled in dev. When disabled, the helpers below are no-ops
-// (the boolean check is the first line of every collection path) so the
-// steady-state poll loop is byte-identical to its pre-flag behaviour.
+// chip to surface a table. The capture is cheap (in-memory ring buffer,
+// no network, no DOM writes) and always on (P-c1d4e8b6 deleted the
+// per-flag gate that had shipped default ON since v0.1.2034) so the next
+// staleness complaint can be diagnosed immediately from
+// window._refreshDiagnostics without a settings flip.
 const _DIAG_RING_SIZE = 50;
 const _refreshDiagBuf = [];
 let _prevRefreshTs = 0;
 let _diagHiddenSinceMs = 0; // ts when tab last went hidden; 0 when visible
 let _lastVisibilityChangeAt = 0;
-function _isRefreshDiagOn() {
-  try {
-    return !!(window.MinionsFeatures && window.MinionsFeatures.isOn('dashboard-refresh-diagnostics'));
-  } catch { return false; }
-}
 function _pushDiagEntry(entry) {
   _refreshDiagBuf.push(entry);
   if (_refreshDiagBuf.length > _DIAG_RING_SIZE) _refreshDiagBuf.shift();
@@ -1191,7 +1186,6 @@ function _pushDiagEntry(entry) {
 window._refreshDiagnostics = function() { return _refreshDiagBuf.slice(); };
 window._refreshDiagnosticsClear = function() { _refreshDiagBuf.length = 0; };
 document.addEventListener('visibilitychange', function() {
-  if (!_isRefreshDiagOn()) return;
   const now = Date.now();
   const vs = document.visibilityState;
   let hiddenForMs = null;
@@ -1220,11 +1214,10 @@ async function refresh(opts) {
   // console-spam and adds load to whatever's wedged).
   if (_nextPollAllowedAt && Date.now() < _nextPollAllowedAt) return;
   _refreshInFlight = true;
-  const _diagOn = _isRefreshDiagOn();
-  const _t0 = _diagOn ? Date.now() : 0;
-  const _gap = _diagOn && _prevRefreshTs ? _t0 - _prevRefreshTs : null;
-  if (_diagOn) _prevRefreshTs = _t0;
-  const _diagEntry = _diagOn ? {
+  const _t0 = Date.now();
+  const _gap = _prevRefreshTs ? _t0 - _prevRefreshTs : null;
+  _prevRefreshTs = _t0;
+  const _diagEntry = {
     ts: _t0,
     kind: 'refresh',
     gap_since_prev_ms: _gap,
@@ -1239,7 +1232,7 @@ async function refresh(opts) {
     changed: null,
     render_duration_ms: null,
     error_message: null,
-  } : null;
+  };
   try {
     const headers = {};
     if (_lastStatusEtag) headers['If-None-Match'] = _lastStatusEtag;
@@ -1253,16 +1246,14 @@ async function refresh(opts) {
     if (res.status === 304 && _lastStatusData) {
       // Cache hit — reuse last payload, skip parsing entirely.
       data = _lastStatusData;
-      if (_diagEntry) {
-        _diagEntry.response_status = '304';
-        _diagEntry.bytes_received = 0;
-        // D2: capture etag on 304 so the diag table can show whether the
-        // server's ETag advanced even when we're reusing the cached body.
-        // Without this the "etag↓" column is blank on every 304 row and the
-        // operator can't tell server-side advancement from a pinned cache.
-        const etag304 = res.headers && (res.headers.get ? res.headers.get('etag') : null);
-        if (etag304) _diagEntry.etag_received = etag304;
-      }
+      _diagEntry.response_status = '304';
+      _diagEntry.bytes_received = 0;
+      // D2: capture etag on 304 so the diag table can show whether the
+      // server's ETag advanced even when we're reusing the cached body.
+      // Without this the "etag↓" column is blank on every 304 row and the
+      // operator can't tell server-side advancement from a pinned cache.
+      const etag304 = res.headers && (res.headers.get ? res.headers.get('etag') : null);
+      if (etag304) _diagEntry.etag_received = etag304;
     } else {
       data = await res.json();
       const etag = res.headers && (res.headers.get ? res.headers.get('etag') : null);
@@ -1270,12 +1261,10 @@ async function refresh(opts) {
         _lastStatusEtag = etag;
         _lastStatusData = data;
       }
-      if (_diagEntry) {
-        _diagEntry.response_status = String(res.status);
-        _diagEntry.etag_received = etag || null;
-        const cl = res.headers && (res.headers.get ? res.headers.get('content-length') : null);
-        _diagEntry.bytes_received = cl != null && cl !== '' ? Number(cl) : null;
-      }
+      _diagEntry.response_status = String(res.status);
+      _diagEntry.etag_received = etag || null;
+      const cl = res.headers && (res.headers.get ? res.headers.get('content-length') : null);
+      _diagEntry.bytes_received = cl != null && cl !== '' ? Number(cl) : null;
     }
     // Auto-reload policy (2026-05-29):
     //   - dashboardStartedAt change → reload  (covers `minions restart`)
@@ -1302,31 +1291,26 @@ async function refresh(opts) {
     _consecutiveStatusFails = 0;
     _nextPollAllowedAt = 0;
     if (_unreachableSince) _markDashboardReachable();
-    const _renderStart = _diagOn ? Date.now() : 0;
-    let _diagChanges = null;
-    if (_diagOn) {
-      _diagChanges = {};
-      _lastChangedFlags = _diagChanges;
-    }
+    const _renderStart = Date.now();
+    const _diagChanges = {};
+    _lastChangedFlags = _diagChanges;
     try {
       _processStatusUpdate(data, opts);
     } finally {
-      if (_diagOn) {
-        _lastChangedFlags = null;
-        _diagEntry.render_duration_ms = Date.now() - _renderStart;
-        _diagEntry.changed = _diagChanges;
-        _diagEntry.workItems_changed = !!(_diagChanges && _diagChanges.workItems);
-        // Post-slim, data.workItems is undefined; read from the dedicated
-        // endpoint cache.
-        _diagEntry.workItems_count = (window._lastWorkItems || []).length;
-        _diagEntry.statusCacheVersion = (data.version && data.version.statusCacheVersion) != null
-          ? data.version.statusCacheVersion
-          : null;
-      }
+      _lastChangedFlags = null;
+      _diagEntry.render_duration_ms = Date.now() - _renderStart;
+      _diagEntry.changed = _diagChanges;
+      _diagEntry.workItems_changed = !!(_diagChanges && _diagChanges.workItems);
+      // Post-slim, data.workItems is undefined; read from the dedicated
+      // endpoint cache.
+      _diagEntry.workItems_count = (window._lastWorkItems || []).length;
+      _diagEntry.statusCacheVersion = (data.version && data.version.statusCacheVersion) != null
+        ? data.version.statusCacheVersion
+        : null;
     }
   } catch(e) {
     console.error('refresh error', e);
-    if (_diagEntry && !_diagEntry.response_status) {
+    if (!_diagEntry.response_status) {
       _diagEntry.response_status = (e && e.name === 'AbortError') ? 'abort' : 'error';
       _diagEntry.error_message = String((e && e.message) || e);
     }
@@ -1346,7 +1330,7 @@ async function refresh(opts) {
   }
   finally {
     _refreshInFlight = false;
-    if (_diagEntry) _pushDiagEntry(_diagEntry);
+    _pushDiagEntry(_diagEntry);
   }
 }
 
@@ -1394,15 +1378,11 @@ switchPage(currentPage);
 window.MinionsRefresh = { refresh };
 
 // ── Refresh-diagnostic footer chip + modal (W-mphejzx100081972) ───────────
-// Injected only when the dashboard-refresh-diagnostics feature flag is on
-// (engine/features.js → MINIONS_FEATURES.flags). The chip floats bottom-right
-// and opens a simple table view of the ring buffer plus a "send to engine"
-// button that POSTs the snapshot to /api/diagnostics/refresh. No DOM is
-// touched (and no listeners installed beyond the visibilitychange handler
-// above, which itself short-circuits when the flag is off) when the flag is
-// disabled — production behaviour stays untouched.
+// Always installed (P-c1d4e8b6 deleted the per-flag gate that previously
+// guarded this). The chip floats bottom-left and opens a simple table view
+// of the ring buffer plus a "send to engine" button that POSTs the
+// snapshot to /api/diagnostics/refresh.
 (function installRefreshDiagChip() {
-  if (!_isRefreshDiagOn()) return;
   try {
     const chip = document.createElement('button');
     chip.id = 'refresh-diag-chip';

package/dashboard-build.js

@@ -74,19 +74,51 @@ const SLIM_JS_ORDER = [
   'command-send', 'status', 'members', 'modals-tiles', 'history', 'pinned',
 ];
 
+// Cache for the assembled slim source fragments (layout/css/body/js). Keyed on
+// the input file mtimes so dev edits still take effect on the next request
+// without a server restart, while production serves repeated requests without
+// re-reading the ~14 fragment files each time. Phase 3 perf audit (P-a7b8c9d0)
+// measured `buildSlimHtml()` at ~7.7 ms/req pre-cache; post-cache it's ~14
+// cheap fs.statSync() calls + one string substitution per request (~sub-ms).
+let _slimPartsCache = null;
+
+function _slimSourcePaths(slimDir) {
+  return [
+    path.join(slimDir, 'layout.html'),
+    path.join(slimDir, 'styles.css'),
+    path.join(slimDir, 'body.html'),
+    ...SLIM_JS_ORDER.map(f => path.join(slimDir, 'js', f + '.js')),
+  ];
+}
+
+function _statMtimeOrZero(p) {
+  try { return fs.statSync(p).mtimeMs; } catch { return 0; }
+}
+
 function buildSlimHtml(opts) {
   const slimDir = path.join(MINIONS_DIR, 'dashboard', 'slim');
   const layoutPath = path.join(slimDir, 'layout.html');
   if (!fs.existsSync(layoutPath)) {
     throw new Error(`Slim layout not found: ${layoutPath}. The dashboard/slim/ directory must exist.`);
   }
-  const layout = safeRead(layoutPath);
-  const css = safeRead(path.join(slimDir, 'styles.css'));
-  const body = safeRead(path.join(slimDir, 'body.html'));
-  // Join with a newline so a fragment that loses its trailing newline can't
-  // glue two statements together (e.g. `}var foo`). Parts share one IIFE
-  // scope, so order is load-bearing — see SLIM_JS_ORDER.
-  const js = SLIM_JS_ORDER.map(f => safeRead(path.join(slimDir, 'js', f + '.js'))).join('\n');
+  const paths = _slimSourcePaths(slimDir);
+  const mtimes = paths.map(_statMtimeOrZero);
+  if (!_slimPartsCache
+      || _slimPartsCache.mtimes.length !== mtimes.length
+      || _slimPartsCache.mtimes.some((m, i) => m !== mtimes[i])) {
+    const [lp, cp, bp, ...jsPaths] = paths;
+    _slimPartsCache = {
+      mtimes,
+      layout: safeRead(lp),
+      css: safeRead(cp),
+      body: safeRead(bp),
+      // Join with a newline so a fragment that loses its trailing newline
+      // can't glue two statements together (e.g. `}var foo`). Parts share one
+      // IIFE scope, so order is load-bearing — see SLIM_JS_ORDER.
+      js: jsPaths.map(p => safeRead(p)).join('\n'),
+    };
+  }
+  const { layout, css, body, js } = _slimPartsCache;
 
   // Feature-flag bootstrap (window.MINIONS_FEATURES) injected at the top of the
   // slim IIFE. serveSlimUx passes the live flags as JSON via opts.featuresJson;
@@ -103,4 +135,8 @@ function buildSlimHtml(opts) {
     .replace('/* __JS__ */', () => js);
 }
 
-module.exports = { buildDashboardHtml, buildSlimHtml, SLIM_JS_ORDER };
+// exported for testing — lets tests reset the module-scope cache so they can
+// observe a cold first call without depending on test execution order.
+function _resetSlimPartsCacheForTest() { _slimPartsCache = null; }
+
+module.exports = { buildDashboardHtml, buildSlimHtml, SLIM_JS_ORDER, _resetSlimPartsCacheForTest };

package/engine/features.js

@@ -78,24 +78,6 @@ const FEATURES = {
     addedIn: '0.1.1916',
     requiredCcRuntime: 'copilot',
   },
-  // dashboard-refresh-diagnostics — W-mphejzx100081972. Enables the in-browser
-  // /api/status poll telemetry ring buffer in dashboard/js/refresh.js: per-cycle
-  // ETag/status/bytes/render-duration capture, visibility-transition tracking,
-  // a small "diag" footer chip that opens a table modal, and a "send to engine"
-  // button that POSTs the buffer to /api/diagnostics/refresh for offline triage.
-  // Default ON (W-mphlr4lv0008c24f) — the diagnostic capture is cheap (in-memory
-  // ring buffer, no network, no DOM writes) and is gated by _isRefreshDiagOn()
-  // at the top of refresh() so the disabled path remains byte-identical to the
-  // pre-flag steady state. Having it always-on means the next staleness
-  // complaint can be diagnosed immediately from window._refreshDiagnostics
-  // without needing a settings flip first.
-  // Disable via config.features['dashboard-refresh-diagnostics']: false or
-  // env MINIONS_FEATURE_DASHBOARD_REFRESH_DIAGNOSTICS=0.
-  'dashboard-refresh-diagnostics': {
-    description: 'Capture the last 50 dashboard /api/status poll cycles (timing, ETag, status code, render duration, per-renderer change flags) in a browser-side ring buffer accessible via window._refreshDiagnostics, a footer "diag" chip, and POST /api/diagnostics/refresh.',
-    default: true,
-    addedIn: '0.1.2034',
-  },
 };
 
 const ENV_TRUTHY = new Set(['1', 'true', 'on', 'yes']);

package/engine/queries.js

@@ -1516,6 +1516,14 @@ function getKnowledgeBaseEntriesSnapshot() {
 }
 
 async function _scanKnowledgeBase() {
+  // V8 sliced-string + regex-capture footgun (P-b8c9d0e1, Phase 2 audit):
+  // `String.prototype.slice` and `match()` capture groups both produce
+  // sliced strings that retain the entire `content` (100-400 KB per file)
+  // alive in heap as long as any short derivative is referenced. The
+  // Phase 2 heap snapshot measured ~6.5 MB retained per process across
+  // ~30 large KB entries. `_flat()` materialises a fresh flat string via
+  // Buffer round-trip so the cached entry no longer pins the parent file.
+  const _flat = (s) => Buffer.from(String(s || ''), 'utf8').toString('utf8');
   const entries = [];
   for (const cat of KB_CATEGORIES) {
     const catDir = path.join(KNOWLEDGE_DIR, cat);
@@ -1527,19 +1535,19 @@ async function _scanKnowledgeBase() {
         fsp.stat(filePath).catch(() => null),
       ]);
       const titleMatch = content.match(/^#\s+(.+)/m);
-      const title = titleMatch ? titleMatch[1].trim() : f.replace(/\.md$/, '');
+      const title = _flat(titleMatch ? titleMatch[1].trim() : f.replace(/\.md$/, ''));
       const agentMatch = f.match(/^\d{4}-\d{2}-\d{2}-(\w+)-/);
       const dateMatch = f.match(/^(\d{4}-\d{2}-\d{2})/) || content.match(/^date:\s*(\d{4}-\d{2}-\d{2})$/m);
       const sourceMatch = content.match(/^source:\s*(.+)/m);
       const sortTs = (stat && stat.mtimeMs) || 0;
-      const displayDate = dateMatch ? dateMatch[1] : (sortTs ? new Date(sortTs).toISOString().slice(0, 10) : '');
+      const displayDate = dateMatch ? _flat(dateMatch[1]) : (sortTs ? new Date(sortTs).toISOString().slice(0, 10) : '');
       return {
         cat, file: f, title,
         agent: agentMatch ? agentMatch[1] : '',
         date: displayDate,
         sortTs,
-        source: sourceMatch ? sourceMatch[1].trim() : '',
-        preview: content.slice(0, 200),
+        source: _flat(sourceMatch ? sourceMatch[1].trim() : ''),
+        preview: _flat(content.slice(0, 200)),
         size: content.length,
       };
     }));

package/engine/shared.js

@@ -3018,10 +3018,6 @@ function resolvePollFlag(engineCfg, granularKey, legacyMacroKey) {
 // (CLI chooses)" option (which submits an empty string) clears the override
 // instead of pinning the runtime to nothing.
 
-function _isMeaningful(v) {
-  return v !== undefined && v !== null && v !== '';
-}
-
 /**
  * Resolve the CLI runtime for a per-agent spawn. Priority:
  *   1. `agent.cli`              — per-agent override
@@ -3031,8 +3027,8 @@ function _isMeaningful(v) {
  * Does NOT fall through to `engine.ccCli`. CC and agents are independent paths.
  */
 function resolveAgentCli(agent, engine) {
-  if (agent && _isMeaningful(agent.cli)) return String(agent.cli);
-  if (engine && _isMeaningful(engine.defaultCli)) return String(engine.defaultCli);
+  if (agent && agent.cli !== undefined && agent.cli !== null && agent.cli !== '') return String(agent.cli);
+  if (engine && engine.defaultCli !== undefined && engine.defaultCli !== null && engine.defaultCli !== '') return String(engine.defaultCli);
   return ENGINE_DEFAULTS.defaultCli;
 }
 
@@ -3046,8 +3042,8 @@ function resolveAgentCli(agent, engine) {
  * it's a fleet-wide singleton.
  */
 function resolveCcCli(engine) {
-  if (engine && _isMeaningful(engine.ccCli)) return String(engine.ccCli);
-  if (engine && _isMeaningful(engine.defaultCli)) return String(engine.defaultCli);
+  if (engine && engine.ccCli !== undefined && engine.ccCli !== null && engine.ccCli !== '') return String(engine.ccCli);
+  if (engine && engine.defaultCli !== undefined && engine.defaultCli !== null && engine.defaultCli !== '') return String(engine.defaultCli);
   return ENGINE_DEFAULTS.defaultCli;
 }
 
@@ -3068,7 +3064,8 @@ function resolveCcCli(engine) {
  *   4. ENGINE_DEFAULTS.ccUseWorkerPool — final fallback
  *
  * Strict boolean check on the override so a literal `false` opts out even on
- * Copilot, matching `_isMeaningful` semantics for boolean flags.
+ * Copilot, matching the "treat empty/null/undefined as unset" semantics used
+ * throughout the resolve* helpers for boolean flags.
  */
 function resolveCcUseWorkerPool(engine) {
   // Guard 1 (W-mphlriic00095f69): pool transport is ACP-only. If CC runtime
@@ -3093,8 +3090,8 @@ function resolveCcUseWorkerPool(engine) {
  * to the user's `~/.copilot/settings.json` model).
  */
 function resolveAgentModel(agent, engine) {
-  if (agent && _isMeaningful(agent.model)) return String(agent.model);
-  if (engine && _isMeaningful(engine.defaultModel)) return String(engine.defaultModel);
+  if (agent && agent.model !== undefined && agent.model !== null && agent.model !== '') return String(agent.model);
+  if (engine && engine.defaultModel !== undefined && engine.defaultModel !== null && engine.defaultModel !== '') return String(engine.defaultModel);
   return undefined;
 }
 
@@ -3105,8 +3102,8 @@ function resolveAgentModel(agent, engine) {
  *   3. `undefined`              — let the runtime adapter pick
  */
 function resolveCcModel(engine) {
-  if (engine && _isMeaningful(engine.ccModel)) return String(engine.ccModel);
-  if (engine && _isMeaningful(engine.defaultModel)) return String(engine.defaultModel);
+  if (engine && engine.ccModel !== undefined && engine.ccModel !== null && engine.ccModel !== '') return String(engine.ccModel);
+  if (engine && engine.defaultModel !== undefined && engine.defaultModel !== null && engine.defaultModel !== '') return String(engine.defaultModel);
   return undefined;
 }
 
@@ -3233,14 +3230,12 @@ let _legacyCcModelMigrationLogged = false;
 function applyLegacyCcModelMigration(config, { logger = log } = {}) {
   if (!config || !config.engine || typeof config.engine !== 'object') return false;
   const e = config.engine;
-  if (_isMeaningful(e.defaultModel)) return false;
-  if (!_isMeaningful(e.ccModel)) return false;
+  if (e.defaultModel !== undefined && e.defaultModel !== null && e.defaultModel !== '') return false;
+  if (!(e.ccModel !== undefined && e.ccModel !== null && e.ccModel !== '')) return false;
   e.defaultModel = e.ccModel;
   if (!_legacyCcModelMigrationLogged) {
     _legacyCcModelMigrationLogged = true;
-    try {
-      logger('warn', 'ccModel is now a CC-specific override; set defaultModel to apply fleet-wide');
-    } catch { /* logger may not be wired during tests — best-effort */ }
+    logger('warn', 'ccModel is now a CC-specific override; set defaultModel to apply fleet-wide');
   }
   return true;
 }
@@ -3332,7 +3327,7 @@ function runtimeConfigWarnings(config, registeredRuntimes) {
   // 1. Unknown CLI values across the fleet.
   const seen = new Set();
   const checkCli = (label, value) => {
-    if (!_isMeaningful(value)) return;
+    if (!(value !== undefined && value !== null && value !== '')) return;
     const key = `${label}:${value}`;
     if (seen.has(key)) return;
     seen.add(key);
@@ -3376,7 +3371,7 @@ function runtimeConfigWarnings(config, registeredRuntimes) {
     const ccCli = resolveCcCli(engine);
     let ccRuntime = null;
     try { ccRuntime = require('./runtimes').resolveRuntime(ccCli); } catch { /* unknown runtime — skip */ }
-    if (ccRuntime?.capabilities?.bareMode === true && !_isMeaningful(engine.ccSystemPrompt)) {
+    if (ccRuntime?.capabilities?.bareMode === true && !(engine.ccSystemPrompt !== undefined && engine.ccSystemPrompt !== null && engine.ccSystemPrompt !== '')) {
       warnings.push({
         id: 'bare-mode-misconfig',
         message: `engine.claudeBareMode is true but CC runs on ${ccCli} (which honours --bare) with no engine.ccSystemPrompt — CLAUDE.md auto-discovery is suppressed and CC will lose project context.`,
@@ -5102,11 +5097,7 @@ function sanitizeBranch(name) {
 // of side-effecting child_process imports at module load.
 
 function getOperatorLogin(config) {
-  try {
-    return require('./operator-identity').resolveOperatorLogin(config || {});
-  } catch {
-    return null;
-  }
+  return require('./operator-identity').resolveOperatorLogin(config || {});
 }
 
 function deriveWorkItemBranchName(item, config) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2180",
+  "version": "0.1.2181",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"