@yemi33/minions 0.1.2179 → 0.1.2181

package/dashboard/js/settings.js

@@ -422,6 +422,22 @@ async function openSettings() {
       'Permission bypass is runtime-owned: Claude agents use <code>--dangerously-skip-permissions</code>; Copilot agents use <code>--autopilot --allow-all --no-ask-user</code>. There is no dashboard permission-mode setting.' +
     '</div>';
 
+  // Harness propagation knobs (PL-seamless-harness-invocation, P-2bd84e91).
+  // All three flags govern what the spawned agent inherits from the operator's
+  // local CLI harness (user-scope skills/commands/MCPs, project-local-on-main
+  // assets, Claude workspace .mcp.json pre-approval). See docs/harness-propagation.md.
+  const paneHarness =
+    '<h3>Harness Propagation</h3>' +
+    '<div class="settings-pane-sub">Controls what the spawned agent sees from your local CLI harness (skills, commands, MCPs). Defaults match the docs/harness-propagation.md contract — flip these only if you understand the tradeoff. The Tools tab\'s Harness diagnostics view shows the live propagated surface.</div>' +
+    '<div class="settings-stack" style="margin-bottom:12px">' +
+      settingsToggle('Propagate project-local harness on main', 'set-harnessPropagateProjectLocal', e.harnessPropagateProjectLocal !== false,
+        'P-08b62d49: surface uncommitted <repo>/.claude/skills, <repo>/.copilot/commands, etc. into the worktree dispatch via extra --add-dir entries. Default ON closes the worktree-uncommitted footgun. Turn OFF to fall back to the legacy "only committed assets are visible" behavior.') +
+      settingsToggle('Claude: pre-approve workspace .mcp.json', 'set-claudePreApproveWorkspaceMcps', e.claudePreApproveWorkspaceMcps !== false,
+        'P-7d31a06b: pre-warms ~/.claude.json projects.<worktree>.enabledMcpjsonServers on every Claude spawn so the first invocation in a brand-new worktree skips the "trust this server?" prompt — which would otherwise be invisible behind --dangerously-skip-permissions and silently drop workspace MCPs. Claude-only (no-op on Copilot/Codex). Best-effort: failures never block dispatch.') +
+      settingsToggle('Hermetic harness (drop user-scope assets)', 'set-hermeticHarness', !!e.hermeticHarness,
+        '⚠ P-49e1c8b7 fleet-wide opt-out: when ON, --add-dir is exactly [minionsDir] (user-scope skill/command/MCP roots dropped), project-local propagation skipped, and Claude workspace .mcp.json pre-approval skipped. Use when you want a known-empty harness surface (reproducible CI runs, debugging "works in my CLI" bugs). Per-agent override available via agent.hermeticHarness. Default OFF.') +
+    '</div>';
+
   const paneBudget =
     '<h3>Budget</h3>' +
     '<div class="settings-pane-sub">Fleet-wide spend ceiling. Per-agent monthly caps live in the Agents table on the Runtime &amp; Models tab.</div>' +
@@ -522,6 +538,7 @@ async function openSettings() {
     { id: 'worktree', label: 'Worker Pool & Worktrees', html: paneWorktree },
     { id: 'copilot', label: 'Copilot Tuning', html: paneCopilot },
     { id: 'claude', label: 'Claude Tuning', html: paneClaude },
+    { id: 'harness', label: 'Harness Propagation', html: paneHarness },
     { id: 'budget', label: 'Budget', html: paneBudget },
     { id: 'maxturns', label: 'Max Turns', html: paneMaxTurns },
     { id: 'features', label: 'Feature Flags', html: paneFeatures },
@@ -1025,6 +1042,12 @@ async function saveSettings() {
       copilotSuppressAgentsMd: !!document.getElementById('set-copilotSuppressAgentsMd')?.checked,
       copilotStreamMode: document.getElementById('set-copilotStreamMode')?.value || 'on',
       copilotReasoningSummaries: !!document.getElementById('set-copilotReasoningSummaries')?.checked,
+      // Harness propagation knobs (P-2bd84e91). Booleans round-trip through
+      // handleSettingsUpdate's auto boolean-fields loop because all three live
+      // in ENGINE_DEFAULTS as booleans.
+      harnessPropagateProjectLocal: !!document.getElementById('set-harnessPropagateProjectLocal')?.checked,
+      claudePreApproveWorkspaceMcps: !!document.getElementById('set-claudePreApproveWorkspaceMcps')?.checked,
+      hermeticHarness: !!document.getElementById('set-hermeticHarness')?.checked,
       maxBudgetUsd: (document.getElementById('set-maxBudgetUsd')?.value ?? '').trim(),
       disableModelDiscovery: !!document.getElementById('set-disableModelDiscovery')?.checked,
       qaDualWriteJson: !!document.getElementById('set-qaDualWriteJson')?.checked,

package/dashboard/pages/engine-memory-panel.html

@@ -46,4 +46,11 @@
             <div id="memory-dashboard-sparkline" style="height:60px;width:100%;color:var(--fg)"></div>
           </div>
         </div>
+        <div id="memory-heap-snapshot-panel" style="margin-top:12px;padding:10px;border:1px solid var(--border);border-radius:4px;background:var(--surface2)">
+          <div style="display:flex;align-items:center;gap:10px;flex-wrap:wrap">
+            <button type="button" id="memory-heap-snapshot-btn" class="btn" style="cursor:pointer">Capture heap snapshot</button>
+            <span style="font-size:var(--text-sm);color:var(--muted)">Stalls engine + dashboard for several seconds, writes a 50–200 MB <code>.heapsnapshot</code> per process under <code>engine/diagnostics/</code> (load in Chrome DevTools → Memory → Load). Rate-limited to 1 / 60 s; only the 5 most-recent per process are kept.</span>
+          </div>
+          <div id="memory-heap-snapshot-result" style="margin-top:8px;font-family:monospace;font-size:var(--text-sm);color:var(--muted);white-space:pre-wrap"></div>
+        </div>
       </section>

package/dashboard/pages/tools.html

@@ -2,7 +2,15 @@
         <h2>Minions Skills <span class="count" id="skills-count">0</span> <span style="font-size:var(--text-sm);color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">discovered from runtime native dirs, plugin installs, and configured project repos</span></h2>
         <div id="skills-list"><p class="empty">No skills yet. Agents create these when they discover repeatable workflows.</p></div>
       </section>
+      <section>
+        <h2>Slash Commands <span class="count" id="commands-count">0</span> <span style="font-size:var(--text-sm);color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">discovered from runtime native command dirs, plugin installs, and configured project repos</span></h2>
+        <div id="commands-list"><p class="empty">No slash commands discovered.</p></div>
+      </section>
       <section>
         <h2>MCP Servers <span class="count" id="mcp-count">0</span></h2>
         <div id="mcp-list"><p class="empty">No MCP servers synced.</p></div>
       </section>
+      <section>
+        <h2>Harness Propagation <span style="font-size:var(--text-sm);color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">what each runtime sees, what's attached via --add-dir, and which assets won't propagate to a fresh worktree</span></h2>
+        <div id="harness-diag"><p class="empty">Loading harness diagnostics…</p></div>
+      </section>

package/dashboard-build.js

@@ -74,19 +74,51 @@ const SLIM_JS_ORDER = [
   'command-send', 'status', 'members', 'modals-tiles', 'history', 'pinned',
 ];
 
+// Cache for the assembled slim source fragments (layout/css/body/js). Keyed on
+// the input file mtimes so dev edits still take effect on the next request
+// without a server restart, while production serves repeated requests without
+// re-reading the ~14 fragment files each time. Phase 3 perf audit (P-a7b8c9d0)
+// measured `buildSlimHtml()` at ~7.7 ms/req pre-cache; post-cache it's ~14
+// cheap fs.statSync() calls + one string substitution per request (~sub-ms).
+let _slimPartsCache = null;
+
+function _slimSourcePaths(slimDir) {
+  return [
+    path.join(slimDir, 'layout.html'),
+    path.join(slimDir, 'styles.css'),
+    path.join(slimDir, 'body.html'),
+    ...SLIM_JS_ORDER.map(f => path.join(slimDir, 'js', f + '.js')),
+  ];
+}
+
+function _statMtimeOrZero(p) {
+  try { return fs.statSync(p).mtimeMs; } catch { return 0; }
+}
+
 function buildSlimHtml(opts) {
   const slimDir = path.join(MINIONS_DIR, 'dashboard', 'slim');
   const layoutPath = path.join(slimDir, 'layout.html');
   if (!fs.existsSync(layoutPath)) {
     throw new Error(`Slim layout not found: ${layoutPath}. The dashboard/slim/ directory must exist.`);
   }
-  const layout = safeRead(layoutPath);
-  const css = safeRead(path.join(slimDir, 'styles.css'));
-  const body = safeRead(path.join(slimDir, 'body.html'));
-  // Join with a newline so a fragment that loses its trailing newline can't
-  // glue two statements together (e.g. `}var foo`). Parts share one IIFE
-  // scope, so order is load-bearing — see SLIM_JS_ORDER.
-  const js = SLIM_JS_ORDER.map(f => safeRead(path.join(slimDir, 'js', f + '.js'))).join('\n');
+  const paths = _slimSourcePaths(slimDir);
+  const mtimes = paths.map(_statMtimeOrZero);
+  if (!_slimPartsCache
+      || _slimPartsCache.mtimes.length !== mtimes.length
+      || _slimPartsCache.mtimes.some((m, i) => m !== mtimes[i])) {
+    const [lp, cp, bp, ...jsPaths] = paths;
+    _slimPartsCache = {
+      mtimes,
+      layout: safeRead(lp),
+      css: safeRead(cp),
+      body: safeRead(bp),
+      // Join with a newline so a fragment that loses its trailing newline
+      // can't glue two statements together (e.g. `}var foo`). Parts share one
+      // IIFE scope, so order is load-bearing — see SLIM_JS_ORDER.
+      js: jsPaths.map(p => safeRead(p)).join('\n'),
+    };
+  }
+  const { layout, css, body, js } = _slimPartsCache;
 
   // Feature-flag bootstrap (window.MINIONS_FEATURES) injected at the top of the
   // slim IIFE. serveSlimUx passes the live flags as JSON via opts.featuresJson;
@@ -103,4 +135,8 @@ function buildSlimHtml(opts) {
     .replace('/* __JS__ */', () => js);
 }
 
-module.exports = { buildDashboardHtml, buildSlimHtml, SLIM_JS_ORDER };
+// exported for testing — lets tests reset the module-scope cache so they can
+// observe a cold first call without depending on test execution order.
+function _resetSlimPartsCacheForTest() { _slimPartsCache = null; }
+
+module.exports = { buildDashboardHtml, buildSlimHtml, SLIM_JS_ORDER, _resetSlimPartsCacheForTest };