@yemi33/minions 0.1.2176 → 0.1.2178

package/engine/lifecycle.js

@@ -1472,7 +1472,14 @@ async function findOpenPrForBranch(meta, config) {
   if (!meta?.branch) return null;
   const projectObj = resolvePrFallbackProject(meta, config);
   if (!projectObj) return null;
-  const host = projectObj.repoHost || 'ado';
+  // BUG-H14 (P-h14-repohost): no silent 'ado' default — if the resolved
+  // project doesn't declare repoHost, bail rather than mis-routing a GitHub
+  // project's branch lookup through the ADO PR-search path.
+  const host = projectObj.repoHost || null;
+  if (!host) {
+    log('debug', `Skipping branch PR lookup: project ${projectObj.name} has no repoHost configured`);
+    return null;
+  }
   if (host === 'github') {
     const ghSlug = projectObj.prUrlBase?.match(/github\.com\/([^/]+\/[^/]+)\/pull/)?.[1];
     if (!ghSlug) return null;
@@ -1981,13 +1988,26 @@ async function updatePrAfterReview(agentId, pr, project, config, resultSummary,
   // The poller will pick up the real status on the next cycle (~3 min).
   let postReviewStatus = null; // null = don't change
   let liveStatus = null;
+  // BUG-H14 (P-h14-repohost): resolve repoHost from the PR's canonical id
+  // FIRST. The previous code derived hostForChecks from the fallback project
+  // (`reviewProject || getProjects(config)[0]`) and silently defaulted to
+  // 'ado' on miss — so a github:* PR found in the central pull-requests.json
+  // (reviewProject=null) with an ADO project as projects[0] was mis-routed to
+  // ado.checkLiveReviewStatus. The fallback project is still consulted when
+  // the id is unparseable, but there is no silent 'ado' default — an
+  // unresolved host is observable (no live check fires).
   const projectObjForChecks = reviewProject || shared.getProjects(config)[0];
-  const hostForChecks = projectObjForChecks?.repoHost || 'ado';
-  const checkFn = hostForChecks === 'github'
-    ? require('./github').checkLiveReviewStatus
-    : require('./ado').checkLiveReviewStatus;
+  const parsedCanonicalReviewId = shared.parseCanonicalPrId(reviewPr.id);
+  const hostFromCanonical = parsedCanonicalReviewId
+    ? parsedCanonicalReviewId.scope.split(':')[0]
+    : null;
+  const hostForChecks = hostFromCanonical || projectObjForChecks?.repoHost || null;
+  let checkFn = null;
+  if (hostForChecks === 'github') checkFn = require('./github').checkLiveReviewStatus;
+  else if (hostForChecks === 'ado') checkFn = require('./ado').checkLiveReviewStatus;
+  else log('warn', `Cannot resolve repoHost for review of ${reviewPr.id} (unparseable canonical id and no project config); skipping live review check.`);
   try {
-    if (projectObjForChecks) {
+    if (projectObjForChecks && checkFn) {
       liveStatus = await checkFn(reviewPr, projectObjForChecks);
     }
   } catch (e) { log('warn', `Post-review status check for ${reviewPr.id}: ${e.message}`); }
@@ -2025,7 +2045,9 @@ async function updatePrAfterReview(agentId, pr, project, config, resultSummary,
     try {
       const reconcileFn = hostForChecks === 'github'
         ? require('./github').dismissPriorViewerChangesRequestedReviews
-        : require('./ado').resetReviewerNegativeVote;
+        : hostForChecks === 'ado'
+          ? require('./ado').resetReviewerNegativeVote
+          : null;
       if (typeof reconcileFn === 'function') {
         const result = await reconcileFn(reviewPr, projectObjForChecks);
         const cleared = !!(result && (result.changed || result.dismissed > 0));
@@ -3395,85 +3417,6 @@ function parseAgentOutput(stdout, runtimeName) {
   return { resultSummary: text, taskUsage: usage, sessionId, model };
 }
 
-/**
- * Parse structured completion block from agent output.
- * Agents produce a ```completion fenced block with key: value pairs.
- * Returns parsed object or null if not found / malformed.
- * If multiple blocks exist, the last one wins (agent may retry).
- *
- * DEPRECATED — slated for removal once telemetry shows zero hits over a 14-day
- * window. Telemetry: see _engine.completionFallbacks in metrics.json (the JSON
- * sidecar at MINIONS_COMPLETION_REPORT is the documented contract; this fenced
- * fallback exists only to support runtimes/agents that have not yet adopted it).
- * Removal is tracked by the P-c8f5e1b3 follow-up plan.
- */
-function parseStructuredCompletion(stdout, runtimeName) {
-  if (!stdout || typeof stdout !== 'string') return null;
-
-  // Extract text from stream-json output if needed
-  const text = extractCompletionText(stdout, runtimeName);
-
-  // Find all ```completion blocks, take the last one
-  const blockPattern = /```completion\s*\n([\s\S]*?)```/g;
-  let lastMatch = null;
-  let m;
-  while ((m = blockPattern.exec(text)) !== null) {
-    lastMatch = m[1];
-  }
-  if (!lastMatch) {
-    const taskCompleteSummary = extractTaskCompleteSummary(stdout);
-    return taskCompleteSummary ? parseCompletionKeyValues(taskCompleteSummary) : null;
-  }
-
-  return parseCompletionKeyValues(lastMatch);
-}
-
-function extractCompletionText(stdout, runtimeName) {
-  let text = stdout;
-  if (typeof stdout === 'string' && stdout.includes('"type":')) {
-    try {
-      const parsed = shared.parseStreamJsonOutput(stdout, runtimeName);
-      if (parsed.text) text = parsed.text;
-    } catch {}
-  }
-  return text;
-}
-
-function hasCompletionFence(stdout, runtimeName) {
-  const text = extractCompletionText(stdout, runtimeName);
-  return /```completion\s*\n[\s\S]*?```/.test(text);
-}
-
-function extractTaskCompleteSummary(stdout) {
-  if (!stdout || typeof stdout !== 'string') return '';
-  let summary = '';
-  for (const rawLine of stdout.split('\n')) {
-    const line = rawLine.trim();
-    if (!line || !line.startsWith('{')) continue;
-    let obj;
-    try { obj = JSON.parse(line); } catch { continue; }
-    if (!obj || typeof obj !== 'object') continue;
-    if (obj.type === 'session.task_complete') {
-      const value = obj.data?.summary;
-      if (typeof value === 'string' && value.trim()) summary = value;
-      continue;
-    }
-    if (obj.type === 'tool.execution_start' && obj.data?.toolName === 'task_complete') {
-      const value = obj.data?.arguments?.summary;
-      if (typeof value === 'string' && value.trim()) summary = value;
-      continue;
-    }
-    if (obj.type === 'assistant.message' && Array.isArray(obj.data?.toolRequests)) {
-      for (const tr of obj.data.toolRequests) {
-        if (tr?.name !== 'task_complete') continue;
-        const value = tr.arguments?.summary || tr.intentionSummary;
-        if (typeof value === 'string' && value.trim()) summary = value;
-      }
-    }
-  }
-  return summary;
-}
-
 function hasActionableFailureClass(value) {
   const normalized = String(value || '').trim().toLowerCase();
   if (!normalized) return false;
@@ -3577,57 +3520,6 @@ function handleInjectionFlag(dispatchItem, agentId, structuredCompletion, config
   return { description, sources, at };
 }
 
-function parseCompletionKeyValues(text) {
-  if (!text || typeof text !== 'string') return null;
-  const result = {};
-  const allowedFields = new Set(shared.COMPLETION_FIELDS || []);
-  const lines = text.trim().split('\n');
-  for (const line of lines) {
-    const normalizedLine = line.trim().replace(/^[-*]\s+/, '');
-    const colonIdx = normalizedLine.indexOf(':');
-    if (colonIdx < 1) continue;
-    const key = normalizedLine.slice(0, colonIdx).trim().toLowerCase();
-    if (allowedFields.size > 0 && !allowedFields.has(key)) continue;
-    const value = normalizedLine.slice(colonIdx + 1).trim();
-    if (key && value) result[key] = value;
-  }
-
-  // Must have at least status, or an actionable failure_class that implies failure.
-  if (!result.status && hasActionableFailureClass(result.failure_class)) result.status = 'failed';
-  if (!result.status) return null;
-  return result;
-}
-
-/**
- * DEPRECATED — slated for removal once telemetry shows zero hits over a 14-day
- * window. Telemetry: see _engine.completionFallbacks in metrics.json (the JSON
- * sidecar at MINIONS_COMPLETION_REPORT is the documented contract; this prose
- * fallback only fires when both the sidecar AND the fenced ```completion block
- * are missing). Removal is tracked by the P-c8f5e1b3 follow-up plan.
- */
-function parseCompletionFieldSummary(text) {
-  if (!text || typeof text !== 'string') return null;
-
-  const allowedFields = new Set(shared.COMPLETION_FIELDS || []);
-  const result = {};
-  for (const rawLine of text.split(/\r?\n/)) {
-    const line = rawLine.trim().replace(/^[-*]\s+/, '');
-    const colonIdx = line.indexOf(':');
-    if (colonIdx < 1) continue;
-    const key = line.slice(0, colonIdx).trim().toLowerCase().replace(/[\s-]+/g, '_');
-    if (!allowedFields.has(key)) continue;
-    const value = line.slice(colonIdx + 1).trim().replace(/^["'`]+|["'`]+$/g, '');
-    if (value) result[key] = value;
-  }
-
-  if (!result.status) return null;
-  const fieldCount = Object.keys(result).length;
-  const status = normalizeCompletionStatus(result.status);
-  const explicitlyFailed = status.startsWith('fail') || status === 'error';
-  if (fieldCount < 2 && !explicitlyFailed) return null;
-  return result;
-}
-
 function parseCompletionReportFile(dispatchItem, opts = {}) {
   const reportPath = dispatchItem?.meta?.completionReportPath || shared.dispatchCompletionReportPath(dispatchItem?.id);
   if (!reportPath || !fs.existsSync(reportPath)) {
@@ -3820,29 +3712,6 @@ function promoteCompletionArtifacts(meta, agentId, dispatchId, structuredComplet
   return { artifacts, notes, agentId, dispatchId };
 }
 
-function persistCompletionReport(dispatchItem, completion, source = 'fallback') {
-  if (!dispatchItem?.id || !completion || typeof completion !== 'object') return completion;
-  const reportPath = dispatchItem?.meta?.completionReportPath || shared.dispatchCompletionReportPath(dispatchItem.id);
-  if (!reportPath) return completion;
-  const report = {
-    ...completion,
-    status: completion.status || completion.outcome || 'unknown',
-    _source: source,
-    _path: reportPath,
-    dispatchId: dispatchItem.id,
-    agent: dispatchItem.agent || null,
-    type: dispatchItem.type || null,
-    completedAt: ts(),
-  };
-  try {
-    safeWrite(reportPath, report);
-    log('info', `Persisted ${source} completion report for ${dispatchItem.id}: ${reportPath}`);
-  } catch (err) {
-    log('warn', `Persist fallback completion report for ${dispatchItem.id}: ${err.message}`);
-  }
-  return report;
-}
-
 function normalizeCompletionStatus(status) {
   return String(status || '').trim().toLowerCase().replace(/[\s_]+/g, '-');
 }
@@ -4487,6 +4356,12 @@ function handleHarnessIterationResult(stdout, structuredCompletion, meta, config
  *   - Returns silently when the PR is no longer active, or when its current
  *     reviewStatus is not in {changes-requested, waiting}. An already-approved
  *     PR doesn't need a re-review.
+ *   - P-e8b1c4d2: Returns silently when engine.autoReReviewPrs === false. This
+ *     mirrors the discovery-driven gate in engine.js:discoverFromPrs so the
+ *     toggle is a single source of truth across BOTH re-review paths
+ *     (open-loop / closure-loop). Without this gate the dashboard switch only
+ *     muted the discovery path, leaving the closure-loop free to keep
+ *     dispatching re-reviews — defeating the operator's intent.
  *   - Idempotent: getPrDispatchDedupeKey + addToDispatch dedup already skips a
  *     second review dispatch for the same (PR, type). No second WI ever lands.
  *   - Soft agent preference: agents whose charter advertises code-review or
@@ -4504,6 +4379,14 @@ function dispatchReReviewForFix(fixDispatchItem, meta, config) {
   if (!addressesReviewWi) return null;
   const pr = meta?.pr;
   if (!pr?.id) return null;
+  // P-e8b1c4d2 — honor the autoReReviewPrs kill-switch in the closure-loop too.
+  // The open-loop discovery path in engine.js gates on the same flag; without
+  // this guard the closure-loop silently bypassed the operator's toggle.
+  const autoReReviewPrs = config?.engine?.autoReReviewPrs ?? shared.ENGINE_DEFAULTS.autoReReviewPrs;
+  if (autoReReviewPrs === false) {
+    log('info', `Re-review skipped for ${pr.id}: engine.autoReReviewPrs is off (closure-loop kill-switch)`);
+    return null;
+  }
   // Re-read live PR state so we don't queue a re-review against an already
   // merged/abandoned PR. The post-completion fix-update may have just flipped
   // reviewStatus to 'waiting'; consult that fresh state via the central read.
@@ -4672,33 +4555,7 @@ async function runPostCompletionHooks(dispatchItem, agentId, code, stdout, confi
     reportCompletion = null;
   }
 
-  const fencedCompletion = (nonceMismatch || reportCompletion) ? null : parseStructuredCompletion(stdout, runtimeName);
-  const summaryCompletion = (nonceMismatch || reportCompletion || fencedCompletion) ? null : parseCompletionFieldSummary(resultSummary);
-  const fallbackCompletion = fencedCompletion || summaryCompletion;
-  const fallbackSource = fencedCompletion && hasCompletionFence(stdout, runtimeName) ? 'fenced-completion' : 'summary-completion';
-  // P-c8f5e1b3 — telemetry: completion-fallback. Emit a grep-able log + bump a
-  // counter in metrics.json whenever the fenced or summary fallback fires (i.e.
-  // the documented sidecar contract was missing). Used to confirm zero adoption
-  // gaps before removing parseStructuredCompletion / parseCompletionFieldSummary
-  // in a follow-up. Sidecar (happy) path is silent — no log, no increment.
-  if (!reportCompletion && fallbackCompletion) {
-    const counterKey = fallbackSource === 'fenced-completion' ? 'fenced' : 'summary';
-    const wiId = dispatchItem.meta?.item?.id || null;
-    log('info', `telemetry: completion-fallback agent=${agentId || 'unknown'} wi=${wiId || 'N/A'} runtime=${runtimeName} source=${fallbackSource}`);
-    try {
-      const metricsPath = path.join(ENGINE_DIR, 'metrics.json');
-      mutateJsonFileLocked(metricsPath, (metrics) => {
-        metrics = metrics || {};
-        if (!metrics._engine) metrics._engine = {};
-        if (!metrics._engine.completionFallbacks) metrics._engine.completionFallbacks = { fenced: 0, summary: 0 };
-        metrics._engine.completionFallbacks[counterKey] = (metrics._engine.completionFallbacks[counterKey] || 0) + 1;
-        return metrics;
-      });
-    } catch (err) {
-      log('warn', `telemetry: completion-fallback metrics write failed: ${err.message}`);
-    }
-  }
-  const structuredCompletion = reportCompletion || persistCompletionReport(dispatchItem, fallbackCompletion, fallbackSource);
+  const structuredCompletion = reportCompletion;
   if (structuredCompletion) {
     if (structuredCompletion.summary) resultSummary = String(structuredCompletion.summary);
     log('info', `Structured completion from ${agentId}: status=${structuredCompletion.status}, pr=${structuredCompletion.pr || 'N/A'}${structuredCompletion._source ? ` (${structuredCompletion._source})` : ''}`);
@@ -5638,8 +5495,6 @@ module.exports = {
   parseAgentOutput,
   parseReviewVerdict,
   isReviewBailout,
-  parseStructuredCompletion,
-  parseCompletionFieldSummary,
   parseCompletionNoop,
   detectNonTerminalResultSummary,
   deferNonTerminalCompletion,
@@ -5651,7 +5506,6 @@ module.exports = {
   completionArtifactToNoteEntry,
   mergeArtifactNotes,
   promoteCompletionArtifacts,
-  persistCompletionReport,
   runPostCompletionHooks,
   syncPrdFromPrs,
   resolveWorkItemPath,

package/engine/meeting.js

@@ -916,6 +916,36 @@ function checkMeetingTimeouts(config) {
     const elapsed = Date.now() - roundStartedMs;
     if (elapsed < timeout) continue;
 
+    // BUG-H11: when a hard timeout will fire, kill in-flight meeting
+    // dispatches BEFORE entering the meeting lock so they stop consuming
+    // worker slots / LLM tokens immediately rather than draining over the
+    // next tens of minutes. _killMeetingDispatches takes the dispatch.json
+    // lock and shells out to kill processes — per CLAUDE.md and the
+    // advanceMeetingRound/endMeeting/deleteMeeting pattern at L834, that
+    // MUST run outside the meeting lock. We pre-evaluate eligibility from
+    // the snapshot using the same predicate the mutate callback below
+    // re-checks under lock; if the timeout has already advanced/cleared,
+    // the kill is a no-op on dispatch.json (no matching meetingId entries).
+    const snapshotRoundName = snapshot.status === 'investigating'
+      ? 'investigate'
+      : snapshot.status === 'debating'
+        ? 'debate'
+        : snapshot.status === 'concluding'
+          ? 'conclude'
+          : null;
+    const snapshotHardTimeoutWillFire = elapsed >= hardTimeout && (
+      // Round-timeout branch: non-conclude round + not all participants done
+      (
+        (snapshotRoundName === 'investigate' || snapshotRoundName === 'debate')
+        && !allParticipantsFinishedRound(snapshot, snapshotRoundName, snapshot.round)
+      )
+      // Conclusion-timeout branch: concluding status
+      || snapshot.status === 'concluding'
+    );
+    if (snapshotHardTimeoutWillFire) {
+      _killMeetingDispatches(snapshot.id);
+    }
+
     // Re-evaluate the timeout transition under the file lock to avoid lost
     // updates if an agent finalised mid-tick. Helpers (advanceMeetingIfRoundComplete
     // etc.) operate on the locked-and-rehydrated meeting object.

package/engine/playbook.js

@@ -298,6 +298,11 @@ const PLAYBOOK_OPTIONAL_VARS = new Set([
   'existing_prd_json',    // only set when re-running plan-to-prd over an existing PRD
   'branch_strategy_hint', // only set for shared-branch plans
   'review_note',          // only set on fix/review tasks tied to a comment
+  // P-4d6e2af3 — comma-separated list of target projects for cross-repo
+  // plans. Only set in engine.js's WORK_TYPE.PLAN branch when the WI carries
+  // item._targetProjects (≥2 entries from dashboard.js#buildPlanWorkItem).
+  // Single-project plans legitimately resolve to ''.
+  'target_projects',
   // PR-context vars on non-PR tasks (implement/explore/etc.)
   'pr_id', 'pr_number', 'pr_title', 'pr_branch', 'pr_author', 'pr_url',
   'reviewer',
@@ -868,6 +873,16 @@ function renderPlaybook(type, vars) {
     return (val && String(val).trim()) ? block : '';
   });
 
+  // P-c1f87a92 — negative conditional blocks: {{^key}}...{{/key}} — include
+  // block only if key is FALSY / absent / whitespace-only. Mirror the
+  // positive-block trim() check above so single-value semantics line up
+  // (vars.target_projects = '' or undefined renders the {{^}} branch, the
+  // same way it omits the {{#}} branch).
+  content = content.replace(/\{\{\^(\w+)\}\}([\s\S]*?)\{\{\/\1\}\}/g, (_, key, block) => {
+    const val = allVars[key];
+    return (val && String(val).trim()) ? '' : block;
+  });
+
   // Substitute variables
   for (const [key, val] of Object.entries(allVars)) {
     content = content.replace(new RegExp(`\\{\\{${key}\\}\\}`, 'g'), String(val));

package/engine/queries.js

@@ -1521,6 +1521,21 @@ function _getPrdInputHash(projects) {
   }
   // Static pr-links.json overrides (affect shared.getPrLinks(); missing project mtimes otherwise)
   try { mtimes.push(fs.statSync(path.join(MINIONS_DIR, 'engine', 'pr-links.json')).mtimeMs); } catch { mtimes.push(0); }
+  // W-mqacrzis0003df4a — Source-plan markdown mtimes. Without this, the
+  // per-PRD planStale fresh-computation at lines ~1568-1576 is never reached
+  // after the user revises plans/<x>.md until the engine tick (~10s) flips
+  // the persisted plan.planStale flag. The cached `_prdResultCache` hits the
+  // early-return and serves the prior (stale) `planStale: false` to readers
+  // long enough for a fast user to Approve and silently bypass diff-aware
+  // regen. Push the PLANS_DIR directory mtime first (catches add/delete on
+  // POSIX) then every .md file's mtime in sorted order for determinism.
+  try { mtimes.push(fs.statSync(PLANS_DIR).mtimeMs); } catch { mtimes.push(0); }
+  try {
+    const planFiles = fs.readdirSync(PLANS_DIR).filter(f => f.endsWith('.md')).sort();
+    for (const f of planFiles) {
+      try { mtimes.push(fs.statSync(path.join(PLANS_DIR, f)).mtimeMs); } catch { mtimes.push(0); }
+    }
+  } catch { /* plans/ may not exist in some test/init states */ }
   return { hash: mtimes.join(','), prdDirMtime, archiveDirMtime };
 }
 
@@ -1770,7 +1785,17 @@ function getPrdInfo(config) {
     items: items.map(i => ({
       id: i.id, name: i.name || i.title, priority: i.priority,
       complexity: i.estimated_complexity || i.size, status: i.status || 'missing',
-      description: i.description || '', projects: i.projects || [],
+      description: i.description || '',
+      // P-e8d49105 — projects[] feeds the per-item badge in
+      // dashboard/js/render-prd.js:250-252 + the plan-group rollup at :243.
+      // Honor a pre-populated projects[] (forward-compat for any future
+      // multi-repo single item); otherwise derive a single-element array
+      // from i.project so cross-repo PRDs (every item.project may differ)
+      // light up the dormant badge code without changing single-project
+      // behavior — i.project keeps being emitted unchanged below.
+      projects: (Array.isArray(i.projects) && i.projects.length > 0)
+        ? i.projects
+        : (i.project ? [i.project] : []),
       prs: prdToPr[i.id] || [], depends_on: i.depends_on || [],
       project: i.project || '', source: i._source || '', planSummary: i._planSummary || '', planProject: i._planProject || '', planStatus: i._planStatus || 'active', _archived: i._archived || false, sourcePlan: i._sourcePlan || '',
       branchStrategy: i._branchStrategy || 'parallel',

package/engine/runtimes/copilot.js

@@ -444,6 +444,7 @@ function buildArgs(opts = {}) {
     disableBuiltinMcps,
     suppressAgentsMd,
     reasoningSummaries,
+    disabledMcpServers,
   } = opts;
 
   const args = [
@@ -478,6 +479,16 @@ function buildArgs(opts = {}) {
   if (suppressAgentsMd === true) args.push('--no-custom-instructions');
   if (reasoningSummaries === true) args.push('--enable-reasoning-summaries');
 
+  // P-mcp-storm — Disable named user-scope MCP servers per spawn. Copilot loads
+  // ~/.copilot/mcp-config.json unconditionally (not gated by --add-dir/cwd), so
+  // this --disable-mcp-server <name> (repeatable) is the only lever to keep an
+  // operator's interactive MCP servers out of autonomous agent dispatches.
+  if (Array.isArray(disabledMcpServers)) {
+    for (const name of disabledMcpServers) {
+      if (name) args.push('--disable-mcp-server', String(name));
+    }
+  }
+
   // --stream takes a value: 'on' or 'off'. Caller passes that exact value.
   if (stream === 'on' || stream === 'off') {
     args.push('--stream', stream);
@@ -504,6 +515,14 @@ function buildSpawnFlags(opts = {}) {
   if (opts.disableBuiltinMcps === true) flags.push('--disable-builtin-mcps');
   if (opts.suppressAgentsMd === true) flags.push('--no-custom-instructions');
   if (opts.reasoningSummaries === true) flags.push('--enable-reasoning-summaries');
+  // P-mcp-storm — forward each disabled user MCP server so spawn-agent.js can
+  // re-emit it on the copilot CLI (parseSpawnArgs accumulates these into
+  // opts.disabledMcpServers, which buildArgs turns back into --disable-mcp-server).
+  if (Array.isArray(opts.disabledMcpServers)) {
+    for (const name of opts.disabledMcpServers) {
+      if (name) flags.push('--disable-mcp-server', String(name));
+    }
+  }
   return flags;
 }