@yemi33/minions 0.1.2166 → 0.1.2168

package/docs/deprecated.json

@@ -37,11 +37,12 @@
     "symbols": ["parseStructuredCompletion", "parseCompletionFieldSummary"],
     "removalSites": [
       { "file": "engine/lifecycle.js", "line": 4675, "symbol": "parseStructuredCompletion", "reason": "Gated fallback at engine/lifecycle.js:4675-4700 — removed in the same follow-up PR that drops the parser definitions." },
-      { "file": "engine/lifecycle.js", "line": 4676, "symbol": "parseCompletionFieldSummary", "reason": "Gated fallback at engine/lifecycle.js:4675-4700 — removed in the same follow-up PR that drops the parser definitions." }
+      { "file": "engine/lifecycle.js", "line": 4676, "symbol": "parseCompletionFieldSummary", "reason": "Gated fallback at engine/lifecycle.js:4675-4700 — removed in the same follow-up PR that drops the parser definitions." },
+      { "file": "engine/timeout.js", "line": 646, "symbol": "parseStructuredCompletion", "reason": "Gated fallback inside detectNonTerminalResultSummary on the timeout/process-exit path. Already removed on yemi33/master in P-a7b2c1d9 (commit eb544aa80dbd64c87b78ad08a17ca3560e627094, merged 2026-06-10); tracked here so the static call-site audit still passes on opg-microsoft/minions where the P-a7b2c1d9 backport is pending. Stale entry once the opg sync lands and can be dropped together with the parser definitions." }
     ],
     "allowedCallers": [],
     "schemaRef": "docs/deprecated-process.md (see 'Static call-site audit fields')",
-    "notes": "Do NOT set removedAt until telemetry confirms zero usage across the sweepWindowDays from sweepStartDate. The follow-up code-removal PR (dropping parseStructuredCompletion at engine/lifecycle.js:3410, parseCompletionFieldSummary at :3608, and the gated fallback at :4675-4700) is dispatched separately once the window is observed clean. The symbols/removalSites/allowedCallers triple is enforced by test/unit/deprecated-call-site-audit.test.js — see docs/deprecated-process.md for the schema."
+    "notes": "Do NOT set removedAt until telemetry confirms zero usage across the sweepWindowDays from sweepStartDate. The follow-up code-removal PR (dropping parseStructuredCompletion at engine/lifecycle.js:3410, parseCompletionFieldSummary at :3608, the gated fallback at :4675-4700, and the opg-only timeout.js:646 caller after the P-a7b2c1d9 backport lands) is dispatched separately once the window is observed clean. The symbols/removalSites/allowedCallers triple is enforced by test/unit/deprecated-call-site-audit.test.js — see docs/deprecated-process.md for the schema."
   },
   {
     "id": "config-claude-binary-override",

package/engine/github.js

@@ -154,6 +154,7 @@ function _isNonActionableComment(c, config = {}) {
   const ignoredAuthors = new Set((config.engine?.ignoredCommentAuthors || []).map(a => String(a).toLowerCase()));
   const login = String(c?.user?.login || '').toLowerCase();
   if (ignoredAuthors.has(login)) return true;
+  if (_isGitHubBotComment(c)) return true;
   if (_isAgentComment(c)) return true;
   // P-f23classifier (F2): body-only preview/CI-report check is now host-
   // agnostic. The legacy `_isCiReportCommentBody` body match (Coverage /
@@ -167,6 +168,18 @@ function _isNonActionableComment(c, config = {}) {
   return false;
 }
 
+function _commentKey(c) {
+  if (!c || c.id == null) return '';
+  const type = c._type ? String(c._type) : '';
+  return type ? `${type}:${c.id}` : String(c.id);
+}
+
+function _entryCommentKey(entry) {
+  if (!entry || entry.commentId == null) return '';
+  const type = entry._type ? String(entry._type) : '';
+  return type ? `${type}:${entry.commentId}` : String(entry.commentId);
+}
+
 // W-mp3bp0ha000997ab-b — Structural classifier for Minions-authored PR comments.
 //
 // Replaces the body-shape classifier chain (PR #2431's _isAgentSelfReviewDeclinedComment,
@@ -1141,6 +1154,8 @@ async function pollPrHumanComments(config) {
     const allCommentEntries = [];
     const newComments = [];
     const seenInNewComments = new Set();
+    const nonActionableCommentKeys = new Set();
+    const nonActionableCommentIds = new Set();
 
     for (const c of allComments) {
       const date = c.created_at || c.updated_at || '';
@@ -1152,7 +1167,12 @@ async function pollPrHumanComments(config) {
       // with this PR.
       const isNonActionable = _isNonActionableComment(c, config);
       if (dateMs) allCommentDates.push(date);
-      if (isNonActionable) continue;
+      if (isNonActionable) {
+        const key = _commentKey(c);
+        if (key) nonActionableCommentKeys.add(key);
+        if (c.id != null) nonActionableCommentIds.add(String(c.id));
+        continue;
+      }
       const entry = {
         commentId: c.id,
         author: c.user?.login || 'Human',
@@ -1167,6 +1187,7 @@ async function pollPrHumanComments(config) {
         // same-head guard can dedup via a single comparable key.
         _type: c._type,
       };
+      entry.commentKey = _entryCommentKey(entry);
       allCommentEntries.push(entry);
 
       if (dateMs && dateMs > cutoffMs) {
@@ -1181,25 +1202,58 @@ async function pollPrHumanComments(config) {
       }
     }
 
+    // Sort all actionable comments chronologically before any state repair so
+    // stale bot/agent keys can be replaced with the newest actionable human key
+    // even when the cutoff already advanced past the human comments.
+    allCommentEntries.sort((a, b) => a.date.localeCompare(b.date));
+    newComments.sort((a, b) => a.date.localeCompare(b.date));
+    const latestActionableComment = allCommentEntries[allCommentEntries.length - 1] || null;
+    const currentFeedback = pr.humanFeedback || {};
+    const currentCommentKey = String(currentFeedback.lastProcessedCommentKey || '');
+    const currentCommentId = String(currentFeedback.lastProcessedCommentId || '');
+    const currentCauseIsNonActionable = !!(
+      (currentCommentKey && nonActionableCommentKeys.has(currentCommentKey))
+      || (!currentCommentKey && currentCommentId && nonActionableCommentIds.has(currentCommentId))
+    );
+
+    const repairNonActionableCause = (nextFeedback) => {
+      if (!currentCauseIsNonActionable) return false;
+      if (latestActionableComment) {
+        nextFeedback.lastProcessedCommentId = String(latestActionableComment.commentId);
+        nextFeedback.lastProcessedCommentKey = latestActionableComment.commentKey || _entryCommentKey(latestActionableComment);
+        nextFeedback.pendingFix = true;
+      } else {
+        nextFeedback.pendingFix = false;
+        delete nextFeedback.lastProcessedCommentId;
+        delete nextFeedback.lastProcessedCommentKey;
+        delete nextFeedback.feedbackContent;
+      }
+      return true;
+    };
+
     // Update cutoff even if only non-actionable comments are new.
     const allNewDates = allCommentDates.filter(date => (new Date(date).getTime() || 0) > cutoffMs);
     if (allNewDates.length > 0 && newComments.length === 0) {
-      pr.humanFeedback = { ...(pr.humanFeedback || {}), lastProcessedCommentDate: allNewDates.sort().pop() };
+      pr.humanFeedback = { ...currentFeedback, lastProcessedCommentDate: allNewDates.sort().pop() };
+      repairNonActionableCause(pr.humanFeedback);
       if (editsSeenChanged) pr.humanFeedback.editsSeen = editsSeen;
       return true; // non-actionable comments only — persist cutoff without triggering fix
     }
     if (newComments.length === 0) {
+      if (currentCauseIsNonActionable) {
+        pr.humanFeedback = { ...currentFeedback };
+        repairNonActionableCause(pr.humanFeedback);
+        if (editsSeenChanged) pr.humanFeedback.editsSeen = editsSeen;
+        return true;
+      }
       // F6: persist pruned/updated editsSeen map even when no dispatch is queued.
       if (editsSeenChanged) {
-        pr.humanFeedback = { ...(pr.humanFeedback || {}), editsSeen };
+        pr.humanFeedback = { ...currentFeedback, editsSeen };
         return true;
       }
       return false;
     }
 
-    // Sort all comments chronologically and build full context for the fix agent
-    allCommentEntries.sort((a, b) => a.date.localeCompare(b.date));
-    newComments.sort((a, b) => a.date.localeCompare(b.date));
     const latestDate = allNewDates.sort().pop() || newComments[newComments.length - 1].date;
 
     // Provide ALL comments as context — the agent needs full thread context to fix properly.
@@ -1230,7 +1284,7 @@ async function pollPrHumanComments(config) {
       // form. Falls back to the bare id when `_type` is absent (defensive;
       // every entry above sets it, but the pollPrHumanComments path in
       // engine/ado.js writes the legacy format too).
-      lastProcessedCommentKey: `${newComments[newComments.length - 1]._type || ''}:${newComments[newComments.length - 1].commentId}`,
+      lastProcessedCommentKey: newComments[newComments.length - 1].commentKey || _entryCommentKey(newComments[newComments.length - 1]),
       pendingFix: true,
       feedbackContent,
       editsSeen,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2166",
+  "version": "0.1.2168",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"