@yemi33/minions 0.1.2155 → 0.1.2156

package/engine/cli.js

@@ -580,6 +580,21 @@ const commands = {
       }
     } catch (err) { e.log('warn', `cc worker pool force-on migration failed: ${err.message}`); }
 
+    // Repair work-item note links that broke before the rewriter covered
+    // completion-report artifact links (W-mq1j85cj00055a8f). Notes the engine
+    // auto-archived back then left the WI pill pointing at the gone
+    // notes/inbox/<name> path; this repoints them to the archived/KB location.
+    // Idempotent (only touches provably-broken + resolvable links) and routed
+    // through mutateWorkItems so SQL + JSON mirror stay consistent — a no-op
+    // once healed, so it's safe to run on every boot.
+    try {
+      const res = require('./note-link-backfill').runNoteLinkBackfill({ config });
+      if (res.fixedLinks > 0) {
+        e.log('info', `Repointed ${res.fixedLinks} broken note link(s) across ${res.fixedItems} work item(s)`);
+        console.log(`  Repaired ${res.fixedLinks} broken note link(s) in ${res.fixedItems} work item(s).`);
+      }
+    } catch (err) { e.log('warn', `note-link backfill failed: ${err.message}`); }
+
     // Auto-heal projects missing workSources (cloned-repo / hand-rolled-config
     // footgun): without this block, discoverFromWorkItems / discoverFromPrs
     // bail silently and the engine looks healthy but never dispatches. The

package/engine/db/migrations/013-backfill-broken-note-links.js

@@ -1,31 +1,15 @@
 // engine/db/migrations/013-backfill-broken-note-links.js
 //
-// One-time data repair (not a schema change). Before the work-item rewriter
-// covered completion-report artifact links (W-mq1j85cj00055a8f, extended to
-// _artifacts.notes[] / artifacts[]), any inbox note the engine auto-archived
-// left the work item's note link pointing at the gone `notes/inbox/<name>` path
-// — a dangling pill. This migration runs the backfill exactly once on the next
-// engine start: it scans existing work_items, finds links whose inbox file is
-// missing, discovers where the note went (notes/archive/ or knowledge/<cat>/),
-// and repoints them. Best-effort and self-isolating — wrapped so a failure can
-// never wedge boot or roll back the migration batch.
+// No-op marker. The one-time repair of broken inbox note links was moved to an
+// idempotent engine-boot sweep (engine/cli.js → note-link-backfill.runNoteLink
+// Backfill) because it must go through shared.mutateWorkItems to keep the SQL
+// store and its JSON mirror consistent — a raw in-migration UPDATE left the
+// mirror diverged and could be reverted by the store's resync. This migration
+// stays so schema_version progression is identical across installs that already
+// recorded v13.
 
 module.exports = {
   version: 13,
-  description: 'one-time backfill: repoint broken inbox note links in existing work items',
-  up(db) {
-    try {
-      const { backfillBrokenNoteLinks } = require('../../note-link-backfill');
-      const res = backfillBrokenNoteLinks(db);
-      if (res && res.fixedLinks > 0) {
-        // eslint-disable-next-line no-console -- migrate.js logs progress to stdout
-        console.log(`[db-migrate] v13: repointed ${res.fixedLinks} broken note link(s) across ${res.fixedItems} work item(s) (${res.scanned} scanned)`);
-      }
-    } catch (e) {
-      // One-time cosmetic repair — never block boot. Record the version anyway
-      // so it doesn't retry forever against the same un-repairable state.
-      // eslint-disable-next-line no-console -- surface the skip without throwing
-      console.warn(`[db-migrate] v13: note-link backfill skipped: ${e && e.message ? e.message : e}`);
-    }
-  },
+  description: 'reserved (note-link backfill moved to an idempotent engine-boot sweep)',
+  up() { /* intentionally empty — see header */ },
 };

package/engine/note-link-backfill.js

@@ -18,11 +18,10 @@
 // notes.md) are left untouched. Idempotent: a second pass finds nothing because
 // the repaired links no longer reference `notes/inbox/`.
 //
-// Wired as a one-time SQL migration (db/migrations/013-*) so it runs exactly
-// once on the next engine start after an update. Updates the canonical SQL
-// `work_items` rows only; the JSON mirror self-heals on the next mutateWorkItems
-// write and SQL is what readers serve (work-items-store), so rewriting the
-// passive mirror here would only risk dropping rows for no benefit.
+// Wired as an idempotent engine-boot sweep (engine/cli.js, alongside the other
+// one-shot boot migrations). It runs through shared.mutateWorkItems — the same
+// write path the live rewriter uses — so the canonical SQL store and its JSON
+// mirror stay consistent, and it's a no-op once every link is healed.
 
 'use strict';
 
@@ -149,10 +148,13 @@ function repointItemNoteLinks(item, resolve) {
   return fixed;
 }
 
-// Scan the canonical SQL `work_items` table and repair broken note links in
-// place. db is a node:sqlite DatabaseSync (the migration's connection). Per-row
-// try/catch so one corrupt row can't abort the pass. Returns a summary.
-function backfillBrokenNoteLinks(db, opts = {}) {
+// Repair broken note links across every work-items file (each project's plus
+// the central one), routed through shared.mutateWorkItems so the canonical SQL
+// store AND its JSON mirror stay consistent — the same write path the live
+// rewriter uses. Idempotent: only touches links that are provably broken AND
+// resolvable, so once healed a re-run writes nothing (skipWriteIfUnchanged).
+// Safe to call on every engine boot. Per-file try/catch isolates a bad scope.
+function runNoteLinkBackfill(opts = {}) {
   const shared = require('./shared');
   const minionsDir = opts.minionsDir || shared.MINIONS_DIR;
   const resolve = buildNoteResolver({
@@ -162,33 +164,34 @@ function backfillBrokenNoteLinks(db, opts = {}) {
     kbCategories: shared.KB_CATEGORIES,
   });
 
-  let scopes;
-  try {
-    scopes = db.prepare('SELECT DISTINCT scope FROM work_items').all().map(r => r.scope);
-  } catch {
-    return { scanned: 0, fixedItems: 0, fixedLinks: 0 };
+  let config = opts.config;
+  if (!config) {
+    try { config = JSON.parse(fs.readFileSync(path.join(minionsDir, 'config.json'), 'utf8')); }
+    catch { config = {}; }
   }
+  const projects = Array.isArray(config.projects) ? config.projects : [];
+  const candidates = [];
+  for (const p of projects) {
+    if (p && p.name) candidates.push(path.join(minionsDir, 'projects', p.name, 'work-items.json'));
+  }
+  candidates.push(path.join(minionsDir, 'work-items.json'));
 
-  const now = opts.now || Date.now();
-  const upd = db.prepare('UPDATE work_items SET data = ?, updated_at = ? WHERE scope = ? AND id = ?');
   let scanned = 0, fixedItems = 0, fixedLinks = 0;
-
-  for (const scope of scopes) {
-    let rows;
-    try { rows = db.prepare('SELECT id, data FROM work_items WHERE scope = ?').all(scope); } catch { continue; }
-    for (const row of rows) {
-      let item;
-      try { item = JSON.parse(row.data); } catch { continue; }
-      scanned++;
-      try {
-        const n = repointItemNoteLinks(item, resolve);
-        if (n > 0) {
-          upd.run(JSON.stringify(item), now, scope, item.id);
-          fixedItems++;
-          fixedLinks += n;
+  for (const wiPath of candidates) {
+    try {
+      shared.mutateWorkItems(wiPath, (items) => {
+        if (!Array.isArray(items)) return items;
+        for (const item of items) {
+          if (!item) continue;
+          scanned++;
+          try {
+            const n = repointItemNoteLinks(item, resolve);
+            if (n > 0) { fixedItems++; fixedLinks += n; }
+          } catch { /* skip unfixable item */ }
         }
-      } catch { /* skip unfixable row */ }
-    }
+        return items;
+      });
+    } catch { /* per-file isolation — one bad scope can't block the others */ }
   }
 
   return { scanned, fixedItems, fixedLinks };
@@ -198,5 +201,5 @@ module.exports = {
   inboxNameFromRef,
   buildNoteResolver,
   repointItemNoteLinks,
-  backfillBrokenNoteLinks,
+  runNoteLinkBackfill,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2155",
+  "version": "0.1.2156",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"