@yemi33/minions 0.1.2151 → 0.1.2153

package/dashboard/js/refresh.js

@@ -214,6 +214,30 @@ function _changed(key, value, version) {
   return true;
 }
 
+// Conditional JSON fetch for the heavy per-page endpoints (browser-OOM fix).
+// /api/knowledge (~4.5MB) and /api/work-items (~4.2MB) were re-fetched AND
+// re-parsed on every 4s refresh tick — ~11MB of allocation churn per tick that
+// OOM-crashed the tab during active foreground use. These endpoints emit an
+// input-mtime ETag server-side (serveFreshJson + handleKnowledgeList), so send
+// If-None-Match off the last-seen ETag and resolve { notModified:true } on a
+// 304. Callers skip the parse + render entirely and keep their last-rendered
+// state, so an idle dashboard drops from ~11MB/tick to ~0. Routes through
+// safeFetch (like the /api/status poll it mirrors) for the 15s abort timeout +
+// X-Minions-Dashboard-* tab/visibility correlation headers. Per-URL ETag cache;
+// a non-304 error rejects so each call site's existing .catch arm still fires.
+var _condFetchEtags = {};
+function _condFetchJson(url) {
+  var headers = {};
+  if (_condFetchEtags[url]) headers['If-None-Match'] = _condFetchEtags[url];
+  return safeFetch(url, { headers }).then(function (r) {
+    if (r.status === 304) return { notModified: true, data: null };
+    if (!r.ok) return Promise.reject(new Error('HTTP ' + r.status));
+    var etag = r.headers && r.headers.get ? r.headers.get('etag') : null;
+    if (etag) _condFetchEtags[url] = etag;
+    return r.json().then(function (data) { return { notModified: false, data: data }; });
+  });
+}
+
 function _formatCcPowerLabel(autoMode) {
   var runtime = autoMode && autoMode.ccCli ? String(autoMode.ccCli) : 'claude';
   var runtimeLabel = runtime.charAt(0).toUpperCase() + runtime.slice(1);
@@ -518,7 +542,11 @@ function _processStatusUpdate(data, opts) {
     window._lastRequestedSeq = window._lastRequestedSeq || {};
     window._lastRequestedSeq.prd = seq;
     Promise.all([
-      fetch('/api/prd').then(function (r) { return r.ok ? r.json() : null; }),
+      // Conditional fetch (browser-OOM fix): flatten to null on a 304 or error,
+      // which the cached status/progress fallback below already handles. The
+      // .catch keeps a prd failure from rejecting the whole Promise.all and
+      // starving the verify-guides slice (matches the old `r.ok ? … : null`).
+      _condFetchJson('/api/prd').then(function (resp) { return resp.notModified ? null : resp.data; }).catch(function () { return null; }),
       fetch('/api/verify-guides').then(function (r) { return r.ok ? r.json() : null; }),
     ])
       .then(function (results) {
@@ -616,10 +644,12 @@ function _processStatusUpdate(data, opts) {
     const seq = (window._refreshSeq = (window._refreshSeq || 0) + 1);
     window._lastRequestedSeq = window._lastRequestedSeq || {};
     window._lastRequestedSeq.prs = seq;
-    fetch('/api/pull-requests')
-      .then(function (r) { return r.ok ? r.json() : Promise.reject(); })
-      .then(function (fresh) {
+    _condFetchJson('/api/pull-requests')
+      .then(function (resp) {
         if (seq < (window._lastRequestedSeq.prs || 0)) return;
+        // 304 → PR list unchanged; keep last-rendered state + cross-slice sigs.
+        if (resp.notModified) return;
+        const fresh = resp.data;
         const list = Array.isArray(fresh) ? fresh : (window._lastPullRequests || []);
         const wasFirstNonEmpty = !Array.isArray(window._lastPullRequests);
         window._lastPullRequests = list;
@@ -695,11 +725,12 @@ function _processStatusUpdate(data, opts) {
     const seq = (window._refreshSeq = (window._refreshSeq || 0) + 1);
     window._lastRequestedSeq = window._lastRequestedSeq || {};
     window._lastRequestedSeq.dispatch = seq;
-    fetch('/api/dispatch')
-      .then(function (r) { return r.ok ? r.json() : Promise.reject(); })
-      .then(function (fresh) {
+    _condFetchJson('/api/dispatch')
+      .then(function (resp) {
         if (seq < (window._lastRequestedSeq.dispatch || 0)) return;
-        const d = fresh || window._lastDispatch;
+        // 304 → dispatch queue unchanged; keep last-rendered panes + scroll.
+        if (resp.notModified) return;
+        const d = resp.data || window._lastDispatch;
         if (d) window._lastDispatch = d;
         _safeRender('dispatch', function() { renderDispatch(d, dispatchOpts); });
         // Dispatch is the third cross-slice edge: derivePlanStatus reads
@@ -785,10 +816,12 @@ function _processStatusUpdate(data, opts) {
     const seq = (window._refreshSeq = (window._refreshSeq || 0) + 1);
     window._lastRequestedSeq = window._lastRequestedSeq || {};
     window._lastRequestedSeq.workItems = seq;
-    fetch('/api/work-items')
-      .then(function (r) { return r.ok ? r.json() : Promise.reject(); })
-      .then(function (fresh) {
+    _condFetchJson('/api/work-items')
+      .then(function (resp) {
         if (seq < (window._lastRequestedSeq.workItems || 0)) return;
+        // 304 → list unchanged; keep the last-rendered rows + DOM untouched.
+        if (resp.notModified) return;
+        const fresh = resp.data;
         const list = Array.isArray(fresh) ? fresh : (window._lastWorkItems || []);
         window._lastWorkItems = list;
         _safeRender('workItems', function() { renderWorkItems(list); });

package/dashboard/js/render-kb.js

@@ -32,13 +32,18 @@ function _formatSweepElapsed(startedAt) {
 
 async function refreshKnowledgeBase() {
   try {
-    // Always update _kbData — cross-slice readers (e.g. command-center.js
-    // suggestion lookup) depend on it staying fresh even when the renderer is
-    // skipped (S1).
-    _kbData = await fetch('/api/knowledge').then(r => r.json());
-    // Skip the full kb-list/kb-tabs rewrite when /api/knowledge returned the
-    // same payload as last tick. Dedicated cache key 'kbPayload' avoids
-    // colliding with any other tracked slice (S1).
+    // Conditional fetch (browser-OOM fix): /api/knowledge is ~4.5MB and was
+    // re-fetched + re-parsed every 4s tick, the single biggest contributor to
+    // the heap churn that crashed the tab. On a 304 the payload is unchanged,
+    // so _kbData (which cross-slice readers like command-center.js depend on)
+    // is already current — skip the parse and the render entirely.
+    const resp = await _condFetchJson('/api/knowledge');
+    if (resp.notModified) return;
+    _kbData = resp.data;
+    // Second-level guard: an mtime-only ETag bust (e.g. a sweep touched a file)
+    // can arrive with byte-identical content — skip the full kb-list/kb-tabs
+    // rewrite when the payload matches last tick. Dedicated cache key
+    // 'kbPayload' avoids colliding with any other tracked slice (S1).
     if (typeof _changed !== 'function' || _changed('kbPayload', _kbData)) {
       renderKnowledgeBase();
     }

package/dashboard.js

@@ -6425,6 +6425,33 @@ const server = http.createServer(async (req, res) => {
 
   async function handleKnowledgeList(req, res) {
     const entries = await getKnowledgeBaseEntries();
+    // Content ETag (browser-OOM fix). /api/knowledge is ~4.5MB and the dashboard
+    // polls it every 4s per foregrounded tab; without a 304 path the browser
+    // re-downloaded + re-parsed the whole payload every tick, churning enough
+    // heap to OOM-crash the tab. Derive the signature from the already-cached
+    // entry metadata (count + per-file mtime/size) instead of stat-walking the
+    // knowledge tree — that tree is ~9k files and the walk measured ~185ms,
+    // which would block the event loop on every poll. getKnowledgeBaseEntries
+    // is O(1) on a cache hit (30s TTL + explicit invalidation on KB writes and
+    // sweeps), so this adds ~nothing on the hot path. Two small stats fold in
+    // the sweep-badge files so the in-flight indicator still busts the tag.
+    let h = 2166136261;
+    for (const e of entries) {
+      h = Math.imul(h ^ ((e.size || 0) >>> 0), 16777619);
+      h = Math.imul(h ^ Math.floor(e.sortTs || 0), 16777619);
+    }
+    const sweepMtime = _maxInputMtimeMs([
+      path.join(ENGINE_DIR, 'kb-swept.json'),
+      path.join(ENGINE_DIR, 'kb-sweep-state.json'),
+    ]);
+    const kbEtag = '"knowledge-' + entries.length + '-' + (h >>> 0).toString(36) + '-' + sweepMtime + '"';
+    res.setHeader('ETag', kbEtag);
+    res.setHeader('Cache-Control', 'private, max-age=0, must-revalidate');
+    if (req && req.headers && req.headers['if-none-match'] === kbEtag) {
+      res.statusCode = 304;
+      res.end();
+      return;
+    }
     const result = {};
     for (const cat of shared.KB_CATEGORIES) result[cat] = [];
     for (const e of entries) {

package/engine/lifecycle.js

@@ -546,6 +546,64 @@ function resolveWorkItemPath(meta) {
   return null;
 }
 
+function getWorkItemPaths(config) {
+  const paths = [path.join(MINIONS_DIR, 'work-items.json')];
+  for (const p of shared.getProjects(config || {})) {
+    if (p && p.name) paths.push(shared.projectWorkItemsPath(p));
+  }
+  return paths;
+}
+
+function findWorkItemRecord(itemId, config) {
+  if (!itemId) return null;
+  for (const wiPath of getWorkItemPaths(config)) {
+    try {
+      const items = readOptionalJsonStrict(wiPath, 'work-items', Array.isArray) || [];
+      const item = items.find(i => i && i.id === itemId);
+      if (item) return { item, path: wiPath };
+    } catch { /* best-effort lineage lookup */ }
+  }
+  return null;
+}
+
+function resolveWorkItemScheduleContext(item, config) {
+  if (!item || typeof item !== 'object') return {};
+  const seen = new Set();
+  let current = item;
+  let scheduleId = current._scheduleId || current._sourceScheduleId || '';
+  let scheduleWorkItemId = current._scheduleId ? current.id : (current._scheduleWorkItemId || '');
+  let projectName = current.project || '';
+  let parentItemId = current.parent_id || current.parentId || '';
+
+  while ((!scheduleId || !projectName) && parentItemId && !seen.has(parentItemId)) {
+    seen.add(parentItemId);
+    const found = findWorkItemRecord(parentItemId, config);
+    if (!found?.item) break;
+    current = found.item;
+    if (!scheduleId && (current._scheduleId || current._sourceScheduleId)) {
+      scheduleId = current._scheduleId || current._sourceScheduleId;
+      scheduleWorkItemId = current._scheduleId ? current.id : (current._scheduleWorkItemId || current.id);
+    }
+    if (!projectName && current.project) projectName = current.project;
+    parentItemId = current.parent_id || current.parentId || '';
+  }
+
+  return {
+    scheduleId: scheduleId || '',
+    scheduleWorkItemId: scheduleWorkItemId || '',
+    projectName: projectName || '',
+  };
+}
+
+function applyScheduleContextToPrEntry(entry, item, config) {
+  const ctx = resolveWorkItemScheduleContext(item, config);
+  if (ctx.scheduleId) {
+    entry._sourceScheduleId = ctx.scheduleId;
+    if (ctx.scheduleWorkItemId) entry._scheduleWorkItemId = ctx.scheduleWorkItemId;
+  }
+  return entry;
+}
+
 /** Check if a work item is in a terminal completed state. */
 function isItemCompleted(item) {
   if (!item || typeof item !== 'object') return false;
@@ -920,6 +978,7 @@ function syncPrsFromOutput(output, agentId, meta, config, opts = {}) {
       sourcePlan: meta?.item?.sourcePlan || '',
       itemType: meta?.item?.itemType || ''
     };
+    applyScheduleContextToPrEntry(entry, meta?.item, config);
     // Issue #1772: one-off dispatches (e.g. human-initiated "review this PR" via CC)
     // must not enroll the discovered PR into the auto eval loop. Tag _contextOnly so
     // discoverFromPrs skips it for review/fix dispatch (still polled for status/comments).
@@ -1318,6 +1377,11 @@ function resolvePrFallbackProject(meta, config) {
     const match = shared.resolveProjectSource(meta.item.project, projects, { allowCentral: false }).project;
     if (match) return match;
   }
+  const scheduleContext = resolveWorkItemScheduleContext(meta?.item, config);
+  if (scheduleContext.projectName) {
+    const match = shared.resolveProjectSource(scheduleContext.projectName, projects, { allowCentral: false }).project;
+    if (match) return match;
+  }
   return projects.length === 1 ? projects[0] : null;
 }
 
@@ -1488,6 +1552,7 @@ function _attachFoundPrToWi(found, meta, agentId, resultSummary, config) {
     sourcePlan: meta.item?.sourcePlan || '',
     itemType: meta.item?.itemType || '',
   };
+  applyScheduleContextToPrEntry(entry, meta?.item, config);
   shared.upsertPullRequestRecord(shared.projectPrPath(found.project), entry, {
     project: found.project,
     itemId: meta.item.id,
@@ -4184,6 +4249,9 @@ function processCompletionFollowups(completion, agentId, dispatchItem, config) {
   }
   if (raw.length === 0) return [];
   const wiId = dispatchItem?.meta?.item?.id || 'N/A';
+  const parentItem = dispatchItem?.meta?.item || null;
+  const parentProject = dispatchItem?.meta?.project?.name || parentItem?.project || '';
+  const parentSchedule = resolveWorkItemScheduleContext(parentItem, config);
   let existingIds = null;
   function loadExistingIds() {
     if (existingIds !== null) return existingIds;
@@ -4217,6 +4285,27 @@ function processCompletionFollowups(completion, agentId, dispatchItem, config) {
     if (allIds.size > 0 && !allIds.has(followupWiId)) {
       log('warn', `Followup audit (${agentId || 'unknown'} wi=${wiId}): claimed followup ${followupWiId} not found in any work-items.json — dispatch may have been deduped, reverted, or never landed`);
     }
+    if (parentItem && (parentSchedule.scheduleId || parentProject)) {
+      let stamped = false;
+      for (const wiPath of getWorkItemPaths(config)) {
+        mutateWorkItems(wiPath, items => {
+          const target = Array.isArray(items) ? items.find(i => i && i.id === followupWiId) : null;
+          if (!target) return items;
+          if (!target.parent_id && target.id !== wiId) target.parent_id = wiId;
+          if (!target.project && parentProject) target.project = parentProject;
+          if (parentSchedule.scheduleId) {
+            if (!target._sourceScheduleId) target._sourceScheduleId = parentSchedule.scheduleId;
+            if (!target._scheduleWorkItemId) target._scheduleWorkItemId = parentSchedule.scheduleWorkItemId || wiId;
+          }
+          stamped = true;
+          return items;
+        });
+        if (stamped) break;
+      }
+      if (stamped && parentSchedule.scheduleId) {
+        log('info', `Followup audit (${agentId || 'unknown'} wi=${wiId}): linked ${followupWiId} to schedule ${parentSchedule.scheduleId}`);
+      }
+    }
     accepted.push({
       wi_id: followupWiId,
       title,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2151",
+  "version": "0.1.2153",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"