@yemi33/minions 0.1.2146 → 0.1.2148

package/engine/playbook.js

@@ -301,6 +301,12 @@ const PLAYBOOK_OPTIONAL_VARS = new Set([
   // PR-context vars on non-PR tasks (implement/explore/etc.)
   'pr_id', 'pr_number', 'pr_title', 'pr_branch', 'pr_author', 'pr_url',
   'reviewer',
+  // W-mq16xtdx001a347e — review dispatches inject this block (or empty string
+  // when discovery finds no project-local review skills). Optional because
+  // non-review playbooks never reference it and review-against-skill-less
+  // projects legitimately resolve it to ''.
+  'project_review_skills_block',
+  'skip_project_review_skills',
   // P-e6b3c2d8 — QA Session template vars. session_id / target_kind /
   // flows_raw / managed_spawn_name are required (declared in
   // PLAYBOOK_REQUIRED_VARS['qa-session-setup']); these target_* sub-fields
@@ -333,6 +339,17 @@ const PLAYBOOK_OPTIONAL_VARS = new Set([
   'role',                  // 'primary' | 'co-service'
   'primary_project',       // canonical primary project name; empty on single-project sessions
   'co_services_json',      // JSON-encoded co-service project names (e.g. ["api","worker"]); empty when none
+  // W-mq16xtdx001a347e (PR-82) — project-local review-skill discovery vars.
+  // Always rendered (empty string when no discoveries); listed here so the
+  // unresolved-var check doesn't complain when discovery returns nothing or
+  // projects legitimately resolve it to ''.
+  'project_review_skills_block',
+  'skip_project_review_skills',
+  // W-mq1cczi90006b21f — generic, intent-filtered project skills block.
+  // Spliced by review/fix/implement/plan/etc. when discovery + intent map
+  // produce matches. Optional for the same reason as the review-only alias.
+  'project_skills_block',
+  'skip_project_skills',
 ]);
 
 const PLAYBOOK_REQUIRED_VARS = {
@@ -689,6 +706,58 @@ function renderPlaybook(type, vars) {
     } catch (e) { log('warn', `managed-spawn live-processes inject failed: ${e.message}`); }
   }
 
+  // W-mq16xtdx001a347e (PR #82) + W-mq1cczi90006b21f (generalization) —
+  // surface project-local skills relevant to the playbook being dispatched.
+  //
+  // PR-82 hard-scoped this to type === 'review'. This wiring generalizes it:
+  //   1. Discovery walks every project skill / command / documented slash-
+  //      command (engine/discover-project-skills.js).
+  //   2. engine/playbook-intents.js maps playbook → intent set.
+  //   3. Discovered entries are filtered to the playbook's intent set and
+  //      rendered into `project_skills_block`. Empty intent set or zero
+  //      matches → empty string (no stray header).
+  //
+  // Header copy: review dispatches keep PR-82's "## Project review skills"
+  // header (existing agents/tests grep for it). All other playbooks use the
+  // generalized "## Project skills" header.
+  //
+  // Backward-compat: `project_review_skills_block` and
+  // `vars.skip_project_review_skills` remain wired so external consumers of
+  // the PR-82 names keep working. They alias to the generic var/flag.
+  const skipProjectSkills = !!(vars.skip_project_skills || vars.skip_project_review_skills);
+  let projectSkillsBlock = '';
+  if (!skipProjectSkills) {
+    try {
+      const discover = require('./discover-project-skills');
+      const { intentsForPlaybook } = require('./playbook-intents');
+      const projectPath = matchedProject?.localPath || '';
+      if (projectPath) {
+        // Inherit intent set from parent dispatch type when the engine
+        // passes vars.parent_dispatch_type (followup-dispatch flow).
+        const effectiveType = vars.parent_dispatch_type || type;
+        const intents = intentsForPlaybook(effectiveType);
+        if (intents.length > 0) {
+          const entries = discover.discoverProjectSkills({ projectPath });
+          const filtered = discover.filterByIntents(entries, intents);
+          // type === 'review' keeps PR-82 header copy + meta.review.* outcome
+          // guidance; everything else uses the generic header that points at
+          // meta.skill.* in the completion report.
+          projectSkillsBlock = (type === 'review')
+            ? discover.renderReviewSkillsBlock(filtered)
+            : discover.renderProjectSkillsBlock(filtered);
+        }
+      }
+    } catch (e) {
+      log('warn', `discover-project-skills failed: ${e.message}`);
+    }
+  }
+  vars.project_skills_block = projectSkillsBlock;
+  // Backward-compat alias for any consumer that still references
+  // {{project_review_skills_block}} directly. Same content; cheaper than
+  // re-rendering. Non-review playbooks that don't reference the alias
+  // ignore it (it's in PLAYBOOK_OPTIONAL_VARS).
+  vars.project_review_skills_block = projectSkillsBlock;
+
   // W-mpeiwz6k0005bf34-c — opt-in qa-validate context block. Injected only
   // when the dispatcher set vars.qa_run_id (truthy) from the work item's
   // `meta.qaRunId`. Mirrors the managed_spawn hint pattern: the playbook is
@@ -1098,6 +1167,11 @@ function buildPrDispatch(agentId, config, project, pr, type, extraVars, taskLabe
   const vars = {
     ...buildBaseVars(agentId, config, project),
     branch_name: extraVars?.pr_branch || '',
+    // W-mq16xtdx001a347e + W-mq1cczi90006b21f — honor both meta flag names
+    // (skipProjectReviewSkills is the PR-82 alias). Default OFF: review/fix
+    // dispatches surface the project-local skills block.
+    skip_project_review_skills: !!(meta && meta.skipProjectReviewSkills),
+    skip_project_skills: !!(meta && (meta.skipProjectSkills || meta.skipProjectReviewSkills)),
     ...extraVars,
     task_id: dispatchId,
   };

package/engine/shared.js

@@ -5919,6 +5919,97 @@ function migratePrGateFlags(projectsRoot) {
   return summary;
 }
 
+// ─── PR Reference → URL Derivation ───────────────────────────────────────────
+//
+// W-mq5wfh1v000e0da9 — Given a PR ref (URL, canonical `host:scope#N` id, or
+// bare number / legacy `PR-N`), derive a usable URL. Used by the fix-WI auto-
+// enrollment helper below so untracked PRs can be linked without forcing the
+// caller to construct a URL themselves.
+//
+// Returns null when no URL can be derived (e.g. bare number with no
+// project.prUrlBase to anchor against).
+function deriveUrlForPrRef(prRef, project) {
+  const ref = String(prRef || '').trim();
+  if (!ref) return null;
+  if (/^https?:\/\//i.test(ref)) return ref;
+  const canonical = parseCanonicalPrId(ref);
+  if (canonical) {
+    if (canonical.scope.startsWith('github:')) {
+      const slug = canonical.scope.slice('github:'.length);
+      return `https://github.com/${slug}/pull/${canonical.prNumber}`;
+    }
+    if (canonical.scope.startsWith('ado:')) {
+      const parts = canonical.scope.slice('ado:'.length).split('/');
+      if (parts.length >= 3) {
+        return `https://dev.azure.com/${parts[0]}/${parts[1]}/_git/${parts[2]}/pullrequest/${canonical.prNumber}`;
+      }
+    }
+  }
+  // Bare number / PR-N — derive from project.prUrlBase if available.
+  const numMatch = ref.match(/^(?:PR-)?(\d+)$/i);
+  if (numMatch && project && project.prUrlBase) {
+    return `${project.prUrlBase}${numMatch[1]}`;
+  }
+  return null;
+}
+
+// W-mq5wfh1v000e0da9 — Auto-enroll a PR into pull-requests.json when a
+// `type: fix` work item is created with a structured PR pointer. Without
+// this, fix WIs against untracked PRs bypass the polling / review / build
+// pipelines (the engine `pr_not_found` gate blocks dispatch entirely, and
+// human PR comments / build failures never surface) until an operator hits
+// POST /api/pull-requests/link manually.
+//
+// Idempotent: no-ops if the PR is already enrolled. Concurrent calls are
+// safe because the underlying upsertPullRequestRecord serializes via
+// mutatePullRequests.
+//
+// Only inspects STRUCTURED refs (targetPr / pr_id / prId / sourcePr /
+// pullRequest / prUrl / prNumber / references[*].url / meta.pr_followup
+// .parent_pr_url). Description-only PR mentions are INTENTIONALLY skipped
+// per the "structured-vs-loose split" — enrollment must be intentional.
+//
+// Returns:
+//   { skipped: true, reason }            — not a fix / no ref / no URL / upsert error
+//   { alreadyEnrolled: true, id }        — PR already in pull-requests.json
+//   { enrolled: true, id, prPath }       — newly enrolled
+function autoEnrollPrFromFixWorkItem(item, project, minionsDir) {
+  if (!item || item.type !== WORK_TYPE.FIX) return { skipped: true, reason: 'not-fix' };
+  const prRef = extractStructuredWorkItemPrRef(item);
+  if (!prRef) return { skipped: true, reason: 'no-structured-ref' };
+  const url = deriveUrlForPrRef(prRef, project);
+  if (!url) return { skipped: true, reason: 'no-url' };
+  const prPath = project ? projectPrPath(project) : centralPullRequestsPath(minionsDir);
+  const existing = safeJsonArr(prPath);
+  if (findPrRecord(existing, prRef, project)) {
+    return { alreadyEnrolled: true, id: getCanonicalPrId(project, prRef, url) };
+  }
+  const parsedUrl = parsePrUrl(url);
+  const prNum = parsedUrl ? parsedUrl.prNumber : null;
+  const prId = getCanonicalPrId(project, prRef, url);
+  try {
+    const result = upsertPullRequestRecord(prPath, {
+      id: prId,
+      prNumber: prNum,
+      title: `PR #${prNum != null ? prNum : '?'} (polling...)`,
+      description: '',
+      agent: 'human',
+      branch: '',
+      reviewStatus: 'pending',
+      status: 'active',
+      created: new Date().toISOString(),
+      url,
+      contextOnly: false,
+    }, { project, itemId: item.id });
+    return result.created
+      ? { enrolled: true, id: result.id, prPath }
+      : { alreadyEnrolled: true, id: result.id };
+  } catch (e) {
+    log('warn', `autoEnrollPrFromFixWorkItem ${item.id}: ${e.message}`);
+    return { skipped: true, reason: 'upsert-error', error: e.message };
+  }
+}
+
 // ─── Cross-Platform Process Kill Helpers ─────────────────────────────────────
 
 function normalizeKillPid(proc) {
@@ -7091,6 +7182,8 @@ module.exports = {
   upsertPullRequestRecord,
   isAutoManagedPrRecord, // W-mq5s5ttx000j7ab8-a — exported for engine + watch-plugin gate consolidation
   migratePrGateFlags, // W-mq5s5ttx000j7ab8-a — boot migration wired from engine/cli.js
+  autoEnrollPrFromFixWorkItem,
+  deriveUrlForPrRef, // exported for testing
   nextWorkItemId,
   getProjectOrg,
   getAdoOrgBase,

package/engine.js

@@ -5885,6 +5885,12 @@ function renderProjectWorkItemPromptForAgent(item, workType, agentId, config, pr
     qa_artifacts_dir: item.meta && item.meta.qaRunId
       ? path.posix.join('engine', 'qa-artifacts', String(item.meta.qaRunId))
       : '',
+    // W-mq16xtdx001a347e — escape hatch for review dispatches that should NOT
+    // be steered toward project-local review skills (e.g. when the diff
+    // under review IS that skill, so a meta-review needs first-principles).
+    // Default OFF — the new "Project review skills" block is the whole point
+    // of W-mq16xtdx and should surface on every review by default.
+    skip_project_review_skills: !!(item.meta && item.meta.skipProjectReviewSkills),
     // P-e6b3c2d8 — QA Session template vars. The qa-sessions chain helpers
     // (engine/qa-sessions.js#_baseWorkItem) stamp meta.sessionId,
     // meta.sessionPhase, and meta.qaSession.{target,flowsRaw,mode,capture,runner}
@@ -5960,6 +5966,18 @@ function renderProjectWorkItemPromptForAgent(item, workType, agentId, config, pr
     // failure via the qa-session-draft-failed / qa-session-execute-failed
     // path. (See playbooks/qa-session-draft.md → "Failure path" section.)
     ..._buildRunnerBriefVars(item, project),
+    // W-mq16xtdx001a347e + W-mq1cczi90006b21f — escape hatches for dispatches
+    // that should NOT be steered toward project-local skills (e.g. when the
+    // diff under review IS that skill, so a meta-review needs first-principles).
+    // Default OFF — the project skills block is the whole point of these WIs
+    // and should surface on every applicable dispatch by default.
+    //
+    // Both meta names are honored:
+    //   - meta.skipProjectReviewSkills (PR-82 alias, review-only suppression)
+    //   - meta.skipProjectSkills       (W-mq1cczi90006b21f, generic suppression)
+    // Either flag suppresses both blocks on the dispatch.
+    skip_project_review_skills: !!(item.meta && item.meta.skipProjectReviewSkills),
+    skip_project_skills: !!(item.meta && (item.meta.skipProjectSkills || item.meta.skipProjectReviewSkills)),
   };
   const cpResult = buildWorkItemDispatchVars(item, vars, config, {
     worktreePath: vars.worktree_path || root,
@@ -6319,6 +6337,18 @@ function discoverFromWorkItems(config, project) {
       skipped.noAgent++; continue;
     }
 
+    // W-mq5wfh1v000e0da9 — defense-in-depth: auto-enroll the PR for fix WIs
+    // carrying a structured PR pointer. Primary enrollment runs in the
+    // dashboard `POST /api/work-items` handler, but WIs created via CLI / restored
+    // from disk / older code paths might land here without the PR record.
+    // No-op if the PR is already tracked. Failures swallowed — the gate below
+    // still trips on missing PR records and surfaces `pr_not_found`.
+    try {
+      if (item.type === WORK_TYPE.FIX) {
+        shared.autoEnrollPrFromFixWorkItem(item, project, MINIONS_DIR);
+      }
+    } catch (e) { log('warn', `auto-enroll PR for ${item.id}: ${e.message}`); }
+
     const linkedPr = resolveWorkItemPrRecord(item, project);
     const promptItem = linkedPr ? withWorkItemPrContext(item, linkedPr) : item;
     const prBranch = linkedPr?.branch || '';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2146",
+  "version": "0.1.2148",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/fix.md

@@ -44,6 +44,10 @@ Before editing, split the feedback into:
 
 ## Health Check
 
+{{#project_skills_block}}
+{{project_skills_block}}
+
+{{/project_skills_block}}
 Before starting work, run `git status` and verify the worktree is clean and on the expected branch (`{{pr_branch}}`). If the worktree is dirty or on the wrong branch, report the issue and stop.
 
 ### Branch-mismatch guard (issue #2999)

package/playbooks/implement-shared.md

@@ -45,6 +45,10 @@ Do ALL work in the worktree.
 
 ## Health Check
 
+{{#project_skills_block}}
+{{project_skills_block}}
+
+{{/project_skills_block}}
 Before starting work, run `git status` and verify the worktree is clean and on the expected branch (`{{branch_name}}`). If the worktree is dirty or on the wrong branch, report the issue and stop.
 
 ## Working Style

package/playbooks/implement.md

@@ -38,6 +38,10 @@ If this feature spans multiple projects, inspect the relevant repos, make change
 
 ## Health Check
 
+{{#project_skills_block}}
+{{project_skills_block}}
+
+{{/project_skills_block}}
 Before starting work, run `git status` and verify the worktree is clean and on the expected branch. If the worktree is dirty or on the wrong branch, report the issue and stop.
 
 ## Working Style

package/playbooks/plan-to-prd.md

@@ -17,6 +17,10 @@ A user has provided a plan. Analyze it against the codebase and produce a struct
 
 ## Instructions
 
+{{#project_skills_block}}
+{{project_skills_block}}
+
+{{/project_skills_block}}
 1. **Read the plan carefully** — understand the goals, scope, and requirements
    - If the plan declares `Project: <name>` (including `**Project:** <name>`), the engine has resolved `{{project_name}}` from that declaration. Preserve `{{project_name}}` for the top-level `project`, default item `project`, filename, and implementation framing; do not let contextual mentions of another product or repository override it.
 2. **Check for an existing PRD** — if the engine provides `existing_prd_json` below, a PRD already exists for this plan. See "Reusing an Existing PRD" section for how to preserve item IDs and done statuses. If no existing PRD is provided, this is a fresh run — all items start as `"missing"`.

package/playbooks/plan.md

@@ -27,6 +27,10 @@ A user has described a feature they want built. Your job is to create a detailed
 - Identify the core goal, constraints, and success criteria
 - Note any ambiguities that need to be called out
 
+{{#project_skills_block}}
+{{project_skills_block}}
+
+{{/project_skills_block}}
 ### 2. Explore the Codebase
 - Read `CLAUDE.md` at repo root and relevant directories
 - Map the areas of code that this feature will touch

package/playbooks/review.md

@@ -27,6 +27,10 @@ Use subagents only for genuinely parallel, independent tasks (e.g., reviewing un
    git diff {{main_branch}}...origin/{{pr_branch}}
    ```
 
+{{#project_skills_block}}
+{{project_skills_block}}
+
+{{/project_skills_block}}
 2. Think about deploy risk before commenting:
    - What user-visible behavior changed?
    - What dependencies, callers, or tests could be affected?

package/bin/minions.js.rej

@@ -1,16 +0,0 @@
-diff a/bin/minions.js b/bin/minions.js	(rejected hunks)
-@@ -852,6 +852,14 @@ if (!cmd || cmd === 'help' || cmd === '--help' || cmd === '-h') {
- 
-   Dashboard:
-     minions dash                     Start web dashboard (default :7331)
-+
-+  Watchdog (out-of-process recovery):
-+    minions watchdog install [--interval=5]
-+                                      Register OS scheduler task to probe + heal every N minutes
-+                                      (Windows Task Scheduler / macOS launchd / Linux systemd --user)
-+    minions watchdog uninstall       Remove the scheduled task (idempotent)
-+    minions watchdog status          Show registration + last-run details from the OS scheduler
-+    minions watchdog tick            One-shot probe + recovery (used by the scheduler; safe to run by hand)
- ${fs.existsSync(path.join(PKG_ROOT, '.git')) ? `
-   Dev mode (this checkout, contributors only):
-     minions --dev <cmd>              Run against this checkout instead of ~/.minions/

package/dashboard/slim/body.html.rej

@@ -1,11 +0,0 @@
-diff a/dashboard/slim/body.html b/dashboard/slim/body.html	(rejected hunks)
-@@ -8,7 +8,8 @@
-          silently break (handler attaches before crash, button still renders,
-          click fires but no global handler). addEventListener attaches inside
-          the same scope and is observable in DevTools when wiring fails. -->
--    <button id="slim-new-chat-btn" class="icon-btn" title="New chat (opens a new tab)">&#x270E;</button>
-+    <button id="slim-back-classic-btn" class="topbar-back-btn" title="Return to the classic dashboard">&#8592; Classic dashboard</button>
-+    <button id="slim-report-bug-btn" class="topbar-back-btn" title="Report a bug in Minions">Report Bug</button>
-     <button id="slim-settings-btn" class="icon-btn" title="Settings">&#9881;</button>
-   </div>
- </div>

package/dashboard/slim/js/command-send.js.rej

@@ -1,12 +0,0 @@
-diff a/dashboard/slim/js/command-send.js b/dashboard/slim/js/command-send.js	(rejected hunks)
-@@ -195,8 +195,8 @@
-   }
- 
-   // ── Wiring ──────────────────────────────────────────────────────
--  var newChatBtn = document.getElementById('slim-new-chat-btn');
--  if (newChatBtn) newChatBtn.addEventListener('click', function() { newTab(); });
-+  // (The header "new chat" button was replaced by "Report Bug"; new tabs are
-+  // created via the "+" affordance in the chat tab bar — see renderTabBar.)
-   sendBtn.addEventListener('click', sendMessage);
-   stopBtn.addEventListener('click', abortActive);
-   inputEl.addEventListener('keydown', function(ev) {

package/dashboard/slim/js/history.js.rej

@@ -1,26 +0,0 @@
-diff a/dashboard/slim/js/history.js b/dashboard/slim/js/history.js	(rejected hunks)
-@@ -96,7 +83,12 @@
-       chip.title = 'review';
-     } else {
-       chip.className = 'completions-card-type-chip';
--      chip.textContent = typeEmoji(c.type);
-+      // Known types → Fluent icon via CSS mask (data-type); unknown → "•" glyph.
-+      if (c.type && TYPE_ICON_SET[c.type]) {
-+        chip.setAttribute('data-type', c.type);
-+      } else {
-+        chip.textContent = '•';
-+      }
-       if (c.type) chip.title = c.type;
-     }
-     railTop.appendChild(chip);
-@@ -105,7 +97,9 @@
-     railBottom.className = 'completions-card-rail-bottom';
-     var icon = document.createElement('span');
-     icon.className = 'completions-card-status-icon ' + status;
--    icon.textContent = status === 'active' ? '●' : (status === 'ok' ? '✓' : (status === 'warn' ? '⚠' : '✕'));
-+    // ok/warn/fail render as Fluent icons via the status class (CSS mask in
-+    // styles.css); the live 'active' state keeps its pulsing dot.
-+    if (status === 'active') icon.textContent = '●';
-     icon.title = status === 'active' ? 'Running' : (status === 'ok' ? 'Success' : (status === 'warn' ? 'Partial' : 'Failure'));
-     var sep = document.createElement('span');
-     sep.className = 'completions-card-rail-sep';