@yemi33/minions 0.1.2139 → 0.1.2141

package/dashboard/js/confirm-dialog.js

@@ -0,0 +1,124 @@
+// confirm-dialog.js — Promise-based custom confirm dialog primitive.
+//
+// Replaces native window.confirm() for actions where the dashboard wants
+// a styled, accessible modal. The HTML scaffold lives in layout.html
+// (#confirm-dialog) and the styles live in styles.css (.confirm-card,
+// .confirm-actions). Both the trigger and the dialog buttons are wired
+// to the same Promise so callers can `await confirmDialog({...})`.
+//
+// Behavior contract (matches WI W-mq5dk1lq):
+//   - Escape closes (resolves false)
+//   - Backdrop click closes (resolves false)
+//   - Enter activates the focused button (default focus is the confirm
+//     button, so Enter == confirm in the common case)
+//   - Tab / Shift+Tab cycle between Cancel and Confirm (focus trap)
+//   - Focus returns to the element that opened the dialog on close
+//   - role="dialog", aria-modal="true", aria-labelledby points at the title
+//
+// API:
+//   confirmDialog({title, message, confirmLabel, cancelLabel, danger})
+//     -> Promise<boolean>  (true = confirmed, false = cancelled)
+
+(function() {
+  let _activeResolve = null;
+  let _previousFocus = null;
+  let _keyHandler = null;
+
+  function getEl() { return document.getElementById('confirm-dialog'); }
+
+  function getFocusable(scope) {
+    return Array.from(scope.querySelectorAll('button, [href], input, select, textarea, [tabindex]:not([tabindex="-1"])'))
+      .filter(el => !el.disabled && el.offsetParent !== null);
+  }
+
+  function closeDialog(result) {
+    const el = getEl();
+    if (!el) return;
+    el.classList.remove('open');
+    if (_keyHandler) {
+      document.removeEventListener('keydown', _keyHandler, true);
+      _keyHandler = null;
+    }
+    const resolver = _activeResolve;
+    _activeResolve = null;
+    // Restore focus to the trigger element (button/link/etc) on close.
+    const prev = _previousFocus;
+    _previousFocus = null;
+    if (prev && typeof prev.focus === 'function') {
+      try { prev.focus(); } catch { /* ignore — element may be gone */ }
+    }
+    if (resolver) resolver(!!result);
+  }
+
+  function confirmDialog(opts) {
+    opts = opts || {};
+    const el = getEl();
+    if (!el) {
+      // Defensive: if the HTML scaffold is missing, fall back to native
+      // confirm so the calling action still works (e.g. in a test harness
+      // that loads the JS without the layout).
+      return Promise.resolve(window.confirm(opts.message || opts.title || 'Confirm?'));
+    }
+    // If a prior dialog is somehow still open, cancel it before reusing
+    // the shared scaffold.
+    if (_activeResolve) closeDialog(false);
+
+    const titleEl = el.querySelector('#confirm-dialog-title');
+    const msgEl = el.querySelector('#confirm-dialog-message');
+    const confirmBtn = el.querySelector('#confirm-dialog-confirm');
+    const cancelBtn = el.querySelector('#confirm-dialog-cancel');
+
+    titleEl.textContent = opts.title || 'Confirm';
+    msgEl.textContent = opts.message || '';
+    confirmBtn.textContent = opts.confirmLabel || 'OK';
+    cancelBtn.textContent = opts.cancelLabel || 'Cancel';
+    // Style the confirm action: red border/text for destructive intent,
+    // solid blue for the default reversible/action case. Both reuse the
+    // existing .btn primitive in styles.css so the dialog inherits the
+    // app's button look.
+    confirmBtn.className = 'btn ' + (opts.danger ? 'btn-danger' : 'btn-primary');
+    cancelBtn.className = 'btn';
+
+    _previousFocus = document.activeElement;
+
+    return new Promise((resolve) => {
+      _activeResolve = resolve;
+
+      el.classList.add('open');
+      // Default-focus the confirm button so Enter activates it natively.
+      // (Spec: "Enter submits (confirm)".) Defer to next tick so the
+      // browser sees the dialog as visible before focus is moved.
+      setTimeout(() => { try { confirmBtn.focus(); } catch { /* ignore */ } }, 0);
+
+      _keyHandler = function(ev) {
+        if (!el.classList.contains('open')) return;
+        if (ev.key === 'Escape') {
+          ev.preventDefault();
+          closeDialog(false);
+          return;
+        }
+        if (ev.key === 'Tab') {
+          // Focus trap: keep tab cycling between the two buttons.
+          const focusable = getFocusable(el);
+          if (focusable.length === 0) return;
+          const first = focusable[0];
+          const last = focusable[focusable.length - 1];
+          if (ev.shiftKey && document.activeElement === first) {
+            ev.preventDefault();
+            last.focus();
+          } else if (!ev.shiftKey && document.activeElement === last) {
+            ev.preventDefault();
+            first.focus();
+          }
+        }
+        // Enter / Space are handled natively by whichever button has focus.
+      };
+      document.addEventListener('keydown', _keyHandler, true);
+    });
+  }
+
+  window.confirmDialog = confirmDialog;
+  // Exposed so the inline onclick handlers on the dialog backdrop /
+  // Cancel / Confirm buttons can resolve the promise.
+  window._confirmDialogResolve = closeDialog;
+})();

package/dashboard/js/render-pinned.js

@@ -77,10 +77,21 @@ async function submitPinnedNote(e) {
 }
 
 async function removePinnedNote(title) {
-  if (!confirm('Unpin "' + title + '"?')) return;
+  // Capture the trigger before awaiting so confirmDialog can restore focus
+  // to the actual Unpin button (window.event is cleared by the time the
+  // dialog resolves).
+  const btn = (window.event)?.target;
+  const ok = await confirmDialog({
+    title: 'Unpin context?',
+    message: 'This will remove "' + title + '" from your pinned context. You can re-pin it anytime.',
+    confirmLabel: 'Unpin',
+    cancelLabel: 'Cancel',
+    danger: false,
+  });
+  if (!ok) return;
   showToast('cmd-toast', 'Note unpinned', true);
   markDeleted('pin:' + title);
-  const btn = (window.event)?.target; if (btn) { const card = btn.closest('.pinned-card') || btn.parentElement?.parentElement; if (card) card.remove(); }
+  if (btn) { const card = btn.closest('.pinned-card') || btn.parentElement?.parentElement; if (card) card.remove(); }
   try {
     const res = await fetch('/api/pinned/remove', { method: 'POST', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({ title }) });
     if (!res.ok) { clearDeleted('pin:' + title); showToast('cmd-toast', 'Unpin failed', false); refresh(); }

package/dashboard/layout.html

@@ -159,6 +159,22 @@
 <!-- Floating "Ask about selection" button -->
 <div class="ask-selection-btn" id="ask-selection-btn" onclick="modalAskAboutSelection()">Ask about this</div>
 
+<!-- Custom confirm dialog — replaces native window.confirm() for actions
+     that want the dashboard's styled, accessible modal (W-mq5dk1lq).
+     The contents are filled in by confirmDialog() in confirm-dialog.js. -->
+<div class="modal-bg confirm-dialog-bg" id="confirm-dialog" role="dialog" aria-modal="true" aria-labelledby="confirm-dialog-title" onclick="if(event.target===this)_confirmDialogResolve(false)">
+  <div class="modal confirm-card">
+    <div class="modal-header">
+      <h3 id="confirm-dialog-title">Confirm</h3>
+    </div>
+    <div class="modal-body confirm-message" id="confirm-dialog-message"></div>
+    <div class="confirm-actions">
+      <button type="button" class="btn" id="confirm-dialog-cancel" onclick="_confirmDialogResolve(false)">Cancel</button>
+      <button type="button" class="btn btn-primary" id="confirm-dialog-confirm" onclick="_confirmDialogResolve(true)">OK</button>
+    </div>
+  </div>
+</div>
+
 <script>/* __JS__ */</script>
 </body>
 </html>

package/dashboard/styles.css

@@ -745,6 +745,18 @@
   .modal-copy.copied { color: var(--green); border-color: var(--green); }
   .modal-close { background: none; border: none; color: var(--muted); font-size: var(--text-2xl); cursor: pointer; padding: var(--space-2) var(--space-4); }
   .modal-close:hover { color: var(--text); }
+
+  /* Custom confirm dialog (W-mq5dk1lq) — promise-based replacement for
+     native window.confirm(). Scaffold in layout.html (#confirm-dialog),
+     behavior in dashboard/js/confirm-dialog.js. Reuses .modal-bg / .modal
+     for backdrop + card chrome; the rules below size the card down to a
+     compact "are you sure?" footprint and style the action row. */
+  .confirm-dialog-bg { z-index: 500; }
+  .modal.confirm-card { width: auto; max-width: 480px; min-width: 320px; }
+  .confirm-message { white-space: normal; font-family: 'Segoe UI', system-ui, sans-serif; font-size: var(--text-md); color: var(--text); line-height: 1.5; }
+  .confirm-actions { display: flex; justify-content: flex-end; gap: var(--space-4); padding: var(--space-5) var(--space-8) var(--space-7); }
+  .confirm-actions .btn { min-width: 80px; }
+  .confirm-actions .btn:focus-visible { outline: 2px solid var(--blue); outline-offset: 1px; }
   .notif-badge { position: absolute; top: -5px; right: -5px; pointer-events: none; }
   .notif-badge.done { width: 8px; height: 8px; background: var(--red); border-radius: 50%; animation: notifPulse 2s infinite; }
   .notif-badge.processing { display: flex; gap: 2px; align-items: center; }

package/dashboard-build.js

@@ -34,7 +34,7 @@ function buildDashboardHtml() {
     'render-prs', 'render-plans', 'render-inbox', 'render-kb', 'render-skills',
     'render-other', 'render-managed', 'render-schedules', 'render-watches', 'render-pipelines', 'render-meetings', 'render-pinned',
     'command-parser', 'command-input', 'command-center', 'command-history',
-    'modal', 'modal-qa', 'settings', 'qa', 'fre', 'refresh'
+    'confirm-dialog', 'modal', 'modal-qa', 'settings', 'qa', 'fre', 'refresh'
   ];
   let jsHtml = '';
   for (const f of jsFiles) {

package/dashboard.js

@@ -1098,7 +1098,7 @@ function buildDashboardHtml() {
     'render-prs', 'render-plans', 'render-inbox', 'render-kb', 'render-skills',
     'render-other', 'render-managed', 'render-schedules', 'render-watches', 'render-pipelines', 'render-meetings', 'render-pinned',
     'command-parser', 'command-input', 'command-center', 'command-history',
-    'modal', 'modal-qa', 'settings', 'qa', 'fre', 'refresh'
+    'confirm-dialog', 'modal', 'modal-qa', 'settings', 'qa', 'fre', 'refresh'
   ];
   let jsHtml = '';
   for (const f of jsFiles) {

package/engine/github.js

@@ -99,6 +99,20 @@ function getRepoSlug(project) {
   return `${org}/${repo}`;
 }
 
+function getConfiguredGitHubAuthorLogins(config = {}) {
+  const accounts = config?.engine?.ghAccounts;
+  if (!accounts || typeof accounts !== 'object') return new Set();
+  const logins = new Set();
+  for (const value of Object.values(accounts)) {
+    const values = Array.isArray(value) ? value : [value];
+    for (const login of values) {
+      const normalized = String(login || '').trim().toLowerCase();
+      if (normalized) logins.add(normalized);
+    }
+  }
+  return logins;
+}
+
 // P-f23classifier (F4): delegates to the host-agnostic VERDICT prefix check
 // in engine/comment-classifier.js. The literal regex used to live here;
 // extraction allowed F4 (Wave 3) to tighten the prefix in a single place.
@@ -1222,6 +1236,7 @@ async function pollPrHumanComments(config) {
 async function reconcilePrs(config) {
   const projects = getProjects(config).filter(isGitHub);
   const branchPatterns = [/^work\//i, /^feat\//i, /^fix\//i, /^e2e\//i, /^user\/yemishin\//i];
+  const configuredAuthorLogins = getConfiguredGitHubAuthorLogins(config);
   let totalAdded = 0;
 
   for (const project of projects) {
@@ -1322,11 +1337,11 @@ async function reconcilePrs(config) {
         continue;
       }
 
-      // E2E branches are always Minions-generated (verify tasks) — track even without a work item ID in the branch name
-      const isE2eBranch = /^e2e\//i.test(branch);
-
-      // Only auto-track PRs linked to a minions work item — skip human-authored PRs
-      if (!confirmedItemId && !isE2eBranch) continue;
+      // Auto-import only when local state proves this branch belongs to a
+      // Minions work item and the PR was opened by one of this client's
+      // configured GitHub accounts. Existing/manual records are handled above.
+      const authorLogin = String(ghPr.user?.login || '').trim().toLowerCase();
+      if (!confirmedItemId || !configuredAuthorLogins.has(authorLogin)) continue;
 
       const entry = {
         id: prId,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2139",
+  "version": "0.1.2141",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"