@yemi33/minions 0.1.2133 → 0.1.2135

package/engine/playbook.js

@@ -1032,10 +1032,21 @@ function formatPrContextSuffix(pr) {
 // ─── Work Discovery Helpers ──────────────────────────────────────────────────
 
 function buildBaseVars(agentId, config, project) {
+  // W-mq15r0cx — surface the LLM model id alongside the agent name so PR
+  // comment sign-offs can stamp `<agent> · <model>` and humans can tell
+  // which agent + which model authored the comment. Falls through to
+  // 'unknown' (defensive only) rather than crashing or omitting the
+  // field when neither agent.model nor engine.defaultModel resolves —
+  // omitting would leave a dangling `· ` in the rendered sign-off.
+  const resolvedModel = shared.resolveAgentModel(
+    config?.agents?.[agentId] || null,
+    config?.engine || null
+  );
   return {
     agent_id: agentId,
     agent_name: config.agents[agentId]?.name || agentId,
     agent_role: config.agents[agentId]?.role || 'Agent',
+    agent_model: resolvedModel || 'unknown',
     team_root: MINIONS_DIR,
     repo_id: project?.repositoryId || '',
     project_name: project?.name || 'Unknown Project',

package/engine.js

@@ -7700,33 +7700,11 @@ async function tickInner() {
     } catch (err) { log('warn', `Stall detection error: ${err?.message || err}`); }
   }
 
-  // 3. Discover new work from sources
-  // Cap temp-agent creation at (maxConcurrent - activeCount) for this tick so
-  // temps count against maxConcurrent like named agents. Without this, a mass
-  // discovery pass (e.g. 20 PR build failures) would stamp a fresh temp agent
-  // onto every pending item regardless of concurrency cap, and those temps
-  // would spawn over subsequent ticks — overwhelming the OS and mass-orphaning
-  // the dispatches (#1209).
-  {
-    const dispatchPre = getDispatch();
-    const activeCountPre = (dispatchPre.active || []).length;
-    const maxC = resolveMaxConcurrent(config);
-    setTempBudget(Math.max(0, maxC - activeCountPre));
-  }
   try { pruneStalePrDispatches(config); } catch (e) { log('warn', 'prune stale PR dispatches: ' + e.message); }
-  let discoveryOk = true;
-  try { await discoverWork(config); } catch (e) { log('warn', 'discoverWork: ' + e.message); discoveryOk = false; }
-  if (_isTickStale(myGeneration)) return;
-
-  // 4. Update snapshot
-  safe('updateSnapshot', () => updateSnapshot(config));
-
-  if (!discoveryOk) {
-    log('warn', 'Skipping dispatch — discovery failed, stale data risk');
-    return;
-  }
 
-  // 5. Process pending dispatches — auto-spawn agents
+  // 3. Process pending dispatches before discovery. discoverWork() runs
+  // pre-dispatch LLM validation for newly found work; a slow validator must not
+  // starve runnable entries that are already durable in dispatch.pending.
   const dispatch = getDispatch();
   const activeCount = (dispatch.active || []).length;
   const maxConcurrent = resolveMaxConcurrent(config);
@@ -8017,6 +7995,31 @@ async function tickInner() {
     if (_isTickStale(myGeneration)) return;
     mutateDispatch((dp) => { dp.pending = postDispatch.pending; return dp; });
   }
+
+  // 4. Discover new work from sources. Newly discovered dispatches are eligible
+  // for the next tick; existing pending work has already had its spawn chance.
+  // Cap temp-agent creation at (maxConcurrent - activeCount) for this tick so
+  // temps count against maxConcurrent like named agents. Without this, a mass
+  // discovery pass (e.g. 20 PR build failures) would stamp a fresh temp agent
+  // onto every pending item regardless of concurrency cap, and those temps
+  // would spawn over subsequent ticks — overwhelming the OS and mass-orphaning
+  // the dispatches (#1209).
+  {
+    const dispatchPre = getDispatch();
+    const activeCountPre = (dispatchPre.active || []).length;
+    const maxC = resolveMaxConcurrent(config);
+    setTempBudget(Math.max(0, maxC - activeCountPre));
+  }
+  let discoveryOk = true;
+  try { await discoverWork(config); } catch (e) { log('warn', 'discoverWork: ' + e.message); discoveryOk = false; }
+  if (_isTickStale(myGeneration)) return;
+
+  // 5. Update snapshot
+  safe('updateSnapshot', () => updateSnapshot(config));
+
+  if (!discoveryOk) {
+    log('warn', 'Discovery failed after pending dispatch pass — new work may be stale until next tick');
+  }
 }
 
 // ─── Exports (for engine/cli.js and other modules) ──────────────────────────

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2133",
+  "version": "0.1.2135",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/fix.md

@@ -93,7 +93,7 @@ Do NOT remove the worktree — the engine handles cleanup automatically.
 {{pr_comment_instructions}}
 - pullRequestId: `{{pr_number}}`
 - content: Explain what was fixed, reference each review finding, include build/test status
-- Sign: `Fixed by Minions ({{agent_name}} — {{agent_role}})`
+- Sign: `Fixed by Minions ({{agent_name}} — {{agent_role}} · {{agent_model}})`
 
 ## Resolve Review Comments
 

package/playbooks/review.md

@@ -77,7 +77,7 @@ Your review body **MUST** start with one of these verdict lines (exactly as show
 - `VERDICT: REQUEST_CHANGES` — if there are issues that must be fixed
 
 Follow the verdict line with your detailed review findings, then sign off:
-- Sign: `Review by Minions ({{agent_name}} — {{agent_role}})`
+- Sign: `Review by Minions ({{agent_name}} — {{agent_role}} · {{agent_model}})`
 
 Use this structure after the verdict:
 
@@ -95,7 +95,7 @@ Minimum diff to ship: <one-line description of the smallest change that would fl
 Non-blocking observations: None
 - (default to `None`; if you list any, each must be tied to an existing diff line in the form `path:line — observation`)
 
-Review by Minions ({{agent_name}} — {{agent_role}})
+Review by Minions ({{agent_name}} — {{agent_role}} · {{agent_model}})
 ```
 
 After running the command, confirm it succeeded (check the command output for errors). If it fails, retry once.
@@ -124,8 +124,8 @@ Key rules (full detail in the template):
 
 Your task is complete when your review comment has been posted successfully with BOTH:
 - `VERDICT: APPROVE` or `VERDICT: REQUEST_CHANGES` on the first line, AND
-- the `Review by Minions ({{agent_name}} — {{agent_role}})` sign-off on the last line of the body
+- the `Review by Minions ({{agent_name}} — {{agent_role}} · {{agent_model}})` sign-off on the last line of the body
 
-and the completion report has `verdict: "approved"` or `verdict: "changes-requested"`. The sign-off is what lets the engine distinguish agent reviews from human PR comments on ADO; without it the engine will queue a redundant fix-dispatch loop (W-mpbhnaim000q9ed3, Ripley on PR 5056697).
+and the completion report has `verdict: "approved"` or `verdict: "changes-requested"`. The sign-off is what lets the engine distinguish agent reviews from human PR comments on ADO; without it the engine will queue a redundant fix-dispatch loop (W-mpbhnaim000q9ed3, Ripley on PR 5056697). The `· {{agent_model}}` suffix is an addition inside the existing parens (W-mq15r0cx) so humans can tell which agent + which model authored the review — the legacy `Review by Minions (` prefix is preserved so the engine's `/\bMinions\s*\(/i` matcher still recognizes both new comments (with model id) and pre-W-mq15r0cx historical comments (without).
 
 Do NOT stop before posting the review. Do NOT continue reading unrelated files after posting.