@yemi33/minions 0.1.2129 → 0.1.2130

package/dashboard/js/refresh.js

@@ -150,7 +150,7 @@ const RENDER_VERSIONS = {
   skills: 1,
   mcpServers: 1,
   schedules: 1,
-  watches: 1,
+  watches: 2,
   meetings: 1,
   pipelines: 1,
   pinned: 1,

package/dashboard/js/render-watches.js

@@ -101,6 +101,36 @@ function _targetTypeLabel(type) {
   return _WATCH_TARGET_LABELS[type] || (type || '');
 }
 
+// W-mq1j5f9z00030b8f — `teams-channel` target is `{teamId, channelId}` (object);
+// other targetTypes use strings. Avoid `String(target)` → "[object Object]";
+// route all target rendering here so future object-target plugins inherit safety.
+function _formatWatchTarget(target, targetType) {
+  if (target == null || target === '') return '';
+  if (typeof target === 'string') return target;
+  if (typeof target !== 'object') return String(target);
+  if (targetType === 'teams-channel'
+      && typeof target.teamId === 'string' && target.teamId
+      && typeof target.channelId === 'string' && target.channelId) {
+    var team = target.teamId.slice(0, 8) + '…';
+    var chPart = target.channelId.split(':')[1] || target.channelId;
+    var ch = chPart.slice(0, 12) + '…';
+    return 'Team ' + team + ' > Channel ' + ch;
+  }
+  var json;
+  try { json = JSON.stringify(target); } catch (_) { return '[unserializable target]'; }
+  if (json == null) return '';
+  return json.length > 60 ? json.slice(0, 57) + '…' : json;
+}
+
+// W-mq1j5f9z00030b8f — title fallback chain: title → description → formatted target → "(no target)".
+function _watchTitleFallback(w) {
+  if (!w) return '(no target)';
+  if (w.title) return w.title;
+  if (w.description) return w.description;
+  var formatted = _formatWatchTarget(w.target, w.targetType);
+  return formatted || '(no target)';
+}
+
 function _intervalToHuman(ms) {
   if (!ms) return 'default';
   const sec = Math.floor(ms / 1000);
@@ -170,7 +200,7 @@ function renderWatches(watchesData, opts) {
 
     html += '<tr style="cursor:pointer" onclick="if(shouldIgnoreSelectionClick(event))return;openWatchDetail(\'' + escHtml(w.id) + '\')">' +
       '<td><span class="pr-id">' + escHtml(w.id) + '</span></td>' +
-      '<td style="max-width:180px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap" title="' + escHtml(w.description || w.target) + '">' + escHtml(w.target) + '</td>' +
+      '<td style="max-width:180px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap" title="' + escHtml(_watchTitleFallback(w)) + '">' + escHtml(_formatWatchTarget(w.target, w.targetType) || _watchTitleFallback(w)) + '</td>' +
       '<td><span class="dispatch-type explore">' + escHtml(targetLabel) + '</span></td>' +
       '<td><span style="font-size:var(--text-base);color:var(--blue)">' + escHtml(condLabel) + '</span></td>' +
       '<td><span style="font-size:var(--text-sm)">' + actionLabel + '</span></td>' +
@@ -250,7 +280,7 @@ function _renderWatchRequiresDetail(requires) {
   var rows = requires.map(function(r, i) {
     return '<div style="margin-top:4px;padding:6px 8px;background:var(--surface2);border-radius:4px;font-size:var(--text-base)">' +
       '<span style="color:var(--muted)">[' + (i + 1) + ']</span> ' +
-      escHtml(r && r.target ? r.target : '?') +
+      escHtml(r && r.target ? (_formatWatchTarget(r.target, r.targetType) || '?') : '?') +
       ' <span class="dispatch-type explore">' + escHtml(r && r.targetType ? r.targetType : '?') + '</span>' +
       ' <span style="color:var(--blue)">' + escHtml(_conditionLabel(r && r.condition ? r.condition : '?')) + '</span>' +
       '</div>';
@@ -300,7 +330,7 @@ function openWatchDetail(id) {
   var condLabel = _conditionLabel(w.condition);
 
   // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; all user data wrapped in escHtml() (fields: watch description/target/id)
-  document.getElementById('modal-title').innerHTML = escHtml(w.description || w.target) +
+  document.getElementById('modal-title').innerHTML = escHtml(_watchTitleFallback(w)) +
     ' <div style="display:flex;gap:4px;margin-top:4px">' +
       (w.status === 'active' ? '<button class="pr-pager-btn" style="font-size:var(--text-sm);padding:2px 10px;color:var(--yellow)" onclick="toggleWatchPause(\'' + escHtml(w.id) + '\',true);closeModal()">Pause</button>' : '') +
       (w.status === 'paused' ? '<button class="pr-pager-btn" style="font-size:var(--text-sm);padding:2px 10px;color:var(--green)" onclick="toggleWatchPause(\'' + escHtml(w.id) + '\',false);closeModal()">Resume</button>' : '') +
@@ -309,7 +339,7 @@ function openWatchDetail(id) {
 
   var body = '<div style="display:flex;flex-direction:column;gap:10px;font-size:var(--text-md);line-height:1.6">' +
     '<div><strong style="color:var(--muted)">ID:</strong> ' + escHtml(w.id) + '</div>' +
-    '<div><strong style="color:var(--muted)">Target:</strong> ' + escHtml(w.target) + '</div>' +
+    '<div><strong style="color:var(--muted)">Target:</strong> ' + escHtml(_formatWatchTarget(w.target, w.targetType)) + '</div>' +
     '<div><strong style="color:var(--muted)">Target Type:</strong> <span class="dispatch-type explore">' + escHtml(targetLabel) + '</span></div>' +
     '<div><strong style="color:var(--muted)">Condition:</strong> <span style="color:var(--blue)">' + escHtml(condLabel) + '</span></div>' +
     '<div><strong style="color:var(--muted)">Check Interval:</strong> ' + escHtml(_intervalToHuman(w.interval)) + '</div>' +
@@ -791,4 +821,7 @@ window.MinionsWatches = {
   _updateRequireConditionOptions: _updateRequireConditionOptions,
   // P-w15f1d4b — Phase 7.2: history table helper exposed for testability.
   _renderWatchHistoryDetail: _renderWatchHistoryDetail,
+  // W-mq1j5f9z00030b8f — target / title fallback helpers exposed for unit coverage.
+  _formatWatchTarget: _formatWatchTarget,
+  _watchTitleFallback: _watchTitleFallback,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2129",
+  "version": "0.1.2130",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"