@yemi33/minions 0.1.2118 → 0.1.2120

package/dashboard/js/utils.js

@@ -494,7 +494,7 @@ function openBugReport() {
   container.style.cssText = 'display:flex;flex-direction:column;gap:12px';
   var intro = document.createElement('p');
   intro.style.cssText = 'color:var(--muted);font-size:var(--text-md);margin:0';
-  intro.textContent = 'File a bug on the Minions repo (yemi33/minions).';
+  intro.textContent = 'File a bug on the public Minions repo (opg-microsoft/minions).';
 
   var titleLabel = document.createElement('label');
   titleLabel.style.cssText = 'color:var(--text);font-size:var(--text-md)';
@@ -577,7 +577,7 @@ async function submitBugReport() {
     } else {
       var msg = document.createElement('span');
       msg.style.cssText = 'color:var(--muted);font-size:var(--text-md)';
-      msg.textContent = 'Issue created on yemi33/minions';
+      msg.textContent = 'Issue created on opg-microsoft/minions';
       container.appendChild(msg);
     }
     var actions = document.createElement('div');

package/dashboard.js

@@ -39,6 +39,7 @@ const dispatchMod = require('./engine/dispatch');
 const dispatchEvents = require('./engine/dispatch-events');
 const { wrapUntrusted, buildSource } = require('./engine/untrusted-fence');
 const steering = require('./engine/steering');
+const steeringStore = require('./engine/steering-store');
 const projectDiscovery = require('./engine/project-discovery');
 const features = require('./engine/features');
 const ccWorkerPool = require('./engine/cc-worker-pool');
@@ -7795,7 +7796,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         title: body.title,
         description: body.description || '',
         labels: body.labels,
-        repo: 'yemi33/minions',
+        repo: 'opg-microsoft/minions',
         tmpDir: path.join(ENGINE_DIR, 'tmp'),
       });
       return jsonReply(res, 200, result);
@@ -9632,6 +9633,32 @@ What would you like to discuss or change? When you're happy, say "approve" and I
     } catch (e) { return jsonReply(res, e.statusCode || 500, { error: e.message }); }
   }
 
+  // W-mq03l6zh0006f0a1-d — read-only diagnostics surface for the per-org ADO
+  // throttle tracker. Returns { orgs: { [orgBase]: { throttled, retryAfter,
+  // consecutiveHits } } }. Prefers the per-org getter ado.getAdoThrottleStateAll
+  // when present (introduced by W-mq03l6zh0006f0a1-b). Falls back to the
+  // process-global ado.getAdoThrottleState() under the synthetic key `global`
+  // when the per-org getter is not present, so the endpoint stays live across
+  // the staged rollout of the per-org isolation work.
+  async function handleDiagnosticsAdoThrottle(req, res) {
+    try {
+      let orgs = {};
+      if (typeof ado.getAdoThrottleStateAll === 'function') {
+        const all = ado.getAdoThrottleStateAll() || {};
+        // Defensive copy — handler must never expose internal mutable state.
+        for (const [k, v] of Object.entries(all)) {
+          if (v && typeof v === 'object') {
+            orgs[k] = { throttled: !!v.throttled, retryAfter: Number(v.retryAfter) || 0, consecutiveHits: Number(v.consecutiveHits) || 0 };
+          }
+        }
+      } else if (typeof ado.getAdoThrottleState === 'function') {
+        const v = ado.getAdoThrottleState() || {};
+        orgs.global = { throttled: !!v.throttled, retryAfter: Number(v.retryAfter) || 0, consecutiveHits: Number(v.consecutiveHits) || 0 };
+      }
+      return jsonReply(res, 200, { orgs });
+    } catch (e) { return jsonReply(res, e.statusCode || 500, { error: e.message }); }
+  }
+
   // Slim UX surface for the experimental redesigned dashboard.
   // The markup/CSS/JS live as fragments under dashboard/slim/ (layout.html +
   // styles.css + body.html + js/*.js) and are assembled by buildSlimHtml() —
@@ -11468,14 +11495,46 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       const liveLogPath = path.join(agentDir, 'live-output.log');
       try { fs.appendFileSync(liveLogPath, '\n[human-steering] ' + text + '\n'); } catch { /* optional */ }
 
+      // W-mq066js7000fff1f-a (Gap D): surface the observable
+      // delivery-state row to the UI. steerId / status / deliveryUrl
+      // let the dashboard poll /api/steering/:id without re-listing.
+      // Existing fields (ok, message, file, inboxCount, ...delivery)
+      // are preserved for back-compat with the current chat panel.
+      const steerId = entry?.steerId || null;
       return jsonReply(res, 200, {
         ok: true,
         message: delivery.pendingDelivery ? 'Steering message pending delivery' : 'Steering message queued',
         ...delivery,
         file: entry?.file || null,
         inboxCount: steering.listUnreadSteeringMessages(agentId).length,
+        steerId,
+        status: steerId ? 'queued' : null,
+        deliveryUrl: steerId ? `/api/steering/${steerId}` : null,
       });
     }},
+    { method: 'GET', path: /^\/api\/agents\/([\w-]+)\/steering$/, template: '/api/agents/:agentId/steering', desc: 'List recent steering delivery-state rows for an agent (latest 50 by default)', params: 'limit? (default 50, max 200)', handler: (req, res, match) => {
+      const agentId = match && match[1];
+      if (!agentId) return jsonReply(res, 400, { error: 'agentId required' }, req);
+      let limit = 50;
+      try {
+        const raw = new URL(req.url, 'http://localhost').searchParams.get('limit');
+        if (raw != null) {
+          const n = parseInt(raw, 10);
+          if (Number.isFinite(n) && n > 0) limit = Math.min(n, 200);
+        }
+      } catch { /* default */ }
+      let rows = [];
+      try { rows = steeringStore.listForAgent(agentId, { limit }); } catch { rows = []; }
+      return jsonReply(res, 200, { agentId, deliveries: rows, count: rows.length }, req);
+    } },
+    { method: 'GET', path: /^\/api\/steering\/([\w-]+)$/, template: '/api/steering/:id', desc: 'Get a single steering delivery-state row by steerId', handler: (req, res, match) => {
+      const steerId = match && match[1];
+      if (!steerId) return jsonReply(res, 400, { error: 'steerId required' }, req);
+      let row = null;
+      try { row = steeringStore.getById(steerId); } catch { row = null; }
+      if (!row) return jsonReply(res, 404, { error: 'steering delivery not found' }, req);
+      return jsonReply(res, 200, row, req);
+    } },
     { method: 'POST', path: '/api/agents/cancel', desc: 'Cancel an active agent by ID or task substring', params: 'agent? or agentId?, task?', handler: handleAgentsCancel },
     { method: 'POST', path: /^\/api\/agent\/([\w-]+)\/kill$/, template: '/api/agent/:id/kill', desc: 'Kill a running agent: stop process, clear dispatch, reset work items to pending', handler: handleAgentKill },
     { method: 'GET', path: /^\/api\/agent\/([\w-]+)\/live-stream(?:\?.*)?$/, template: '/api/agent/:id/live-stream', desc: 'SSE real-time live output streaming', handler: handleAgentLiveStream },
@@ -11548,7 +11607,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
     { method: 'POST', path: '/api/projects/remove', desc: 'Unlink a project: cancels WIs, drains dispatch, kills agents, cleans worktrees, archives data dir', params: 'name or path, keepData?, purge?', handler: handleProjectsRemove },
 
     // Bug Filing
-    { method: 'POST', path: '/api/issues/create', desc: 'File a bug on the Minions repo (yemi33/minions)', params: 'title, description?, labels?', handler: handleFileBug },
+    { method: 'POST', path: '/api/issues/create', desc: 'File a bug on the public Minions repo (opg-microsoft/minions)', params: 'title, description?, labels?', handler: handleFileBug },
 
     // Command Center
     { method: 'POST', path: '/api/command-center/new-session', desc: 'Clear active CC session', handler: handleCommandCenterNewSession },
@@ -11837,6 +11896,8 @@ What would you like to discuss or change? When you're happy, say "approve" and I
 
     // Diagnostics — refresh ring buffer persistence (W-mphejzx100081972).
     { method: 'POST', path: '/api/diagnostics/refresh', desc: 'Append a dashboard refresh-diagnostic ring buffer batch to engine/dashboard-diagnostics.log (rotated at 1 MB)', params: 'entries[]', handler: handleDiagnosticsRefresh },
+    // Diagnostics — per-org ADO throttle state (W-mq03l6zh0006f0a1-d).
+    { method: 'GET', path: '/api/diagnostics/ado-throttle', desc: 'Snapshot of per-org ADO throttle tracker state — { orgs: { [orgBase]: { throttled, retryAfter, consecutiveHits } } }. Falls back to a single `global` key when running against pre-per-org engines.', handler: handleDiagnosticsAdoThrottle },
   ];
 
   // ── Route Dispatcher ────────────────────────────────────────────────────────

package/docs/deprecated.json

@@ -98,5 +98,16 @@
     "removalGate": "Telemetry: pruneDefaultClaudeConfig must return false (no mutation) for every call across all known engines for >=30 consecutive days (add an `_engine.pruneDefaultClaudeConfigStrips` counter if needed to observe this), AND the parent `config-claude-binary-override` entry must have already cleared its own gate. The dependency is strict: removing the prune while users still rely on the override branch would surface the `deprecated-config-claude` warning on every stale generated default. Once both conditions hold, removal is the function definition (engine/shared.js:3126), the export at :5673, all 5 call sites (dashboard.js:202, :9116, :9331, :9450; minions.js:385), and the tests at unit.test.js:2260-2303 + runtime-fleet-helpers.test.js:546.",
     "targetRemovalDate": null,
     "notes": "Do NOT set targetRemovalDate — gating is signal-based AND ordered. This entry MUST NOT be removed before `config-claude-binary-override` clears its gate, otherwise installs with stale defaults will flood the deprecation channel until their next config save. The 5 call sites form a complete coverage net: load (dashboard.js:202 + minions.js:385) + save (dashboard.js:9116/9331/9450), so any code path that touches config.json runs the sanitizer."
+  },
+  {
+    "id": "ado-throttle-arg-less-shim",
+    "description": "Arg-less form of isAdoThrottled() in engine/ado.js. Introduced by W-mq03l6zh0006f0a1-b as a back-compat shim during the per-org ADO throttle isolation rollout: pre-rollout, isAdoThrottled() collapsed the single process-global tracker to one boolean; post-rollout, the canonical form is isAdoThrottled(orgBase) against the per-org Map. The arg-less call site is preserved transiently so engine code (and any in-process callers) that haven't yet been threaded through with a per-org `orgBase` keep returning the safe global-OR (true if ANY org is currently throttled) — preventing a regression where new poll work bypasses a still-warm throttle backoff on an unrelated noisy org.",
+    "deprecated": "2026-06-04",
+    "code": [
+      { "file": "engine/ado.js", "note": "isAdoThrottled() arg-less branch and the global-OR fold over the per-org Map. Single call site to migrate: shared.getAdoOrgBase(project) is already in scope at every consumer." }
+    ],
+    "removalGate": "Two conditions must hold simultaneously: (a) grep `engine/ado.js` for `isAdoThrottled\\s*\\(\\s*\\)` and confirm zero arg-less call sites remain across the engine — every caller passes a concrete `orgBase` resolved via `shared.getAdoOrgBase(project)`; (b) `GET /api/diagnostics/ado-throttle` on a live engine has been observed for >=2 consecutive weeks reporting per-org keys (proves the per-org Map is populated under load and the global-OR isn't masking a regression). Once both hold, removal deletes the arg-less branch in isAdoThrottled and the global-OR fold; callers that still pass no argument become an immediate, surfaced bug rather than a silent over-throttle.",
+    "targetRemovalDate": "2026-08-03",
+    "notes": "Introduced by W-mq03l6zh0006f0a1 (Per-org ADO throttle isolation). 60-day window (2 release cycles + buffer) gives the in-flight per-org migration time to land + observe per-org keys on the diagnostics endpoint. Observable live at GET /api/diagnostics/ado-throttle — the endpoint reports a single `global` key while the arg-less shim is still load-bearing, and per-org `<orgBase>` keys once isolation is complete; that key shape is the human-readable signal for whether this shim can retire."
   }
 ]

package/docs/team-memory.md

@@ -98,6 +98,30 @@ If an agent thinks a `knowledge/` file is wrong, the correct response is to **no
 
 The same constraint applies to `knowledge/agents/<agentId>.md` — those are curated by the sweep and should not be hand-edited.
 
+## Session State vs. Persistent Memory
+
+The PRD that introduced sliding-window memory (W-mq07b8do000nc86a) referenced two distinct write paths — `update_session_state()` and `update_memory()` — borrowed from agent frameworks that model agents as long-lived in-process objects. Minions has neither method because it doesn't model agents that way; understanding the mapping prevents fruitless searches for non-existent APIs.
+
+**Session state** = the dispatch's worktree + child process. Each Minions agent runs as a fresh OS process spawned by `engine.js → engine/spawn-agent.js` inside a per-work-item git worktree (`work/<wi-id>` by default; see `shared.deriveWorkItemBranchName`). When the dispatch ends, the engine deletes the worktree and the child exits. There is no persistent "session" object to update — ephemeral state lives in process memory and disk paths under the worktree, both of which are reclaimed automatically. No code is needed to "clear" session state; it never persists in the first place.
+
+**Persistent memory** = `knowledge/agents/<agentId>.md`, the per-agent file appended to by `engine/consolidation.js` during the inbox sweep. This is the analog of `update_memory()` in PRD terms. It is written only by the consolidation sweep (the [sweep-write-only constraint](#sweep-write-only-constraint) applies), is injected into every subsequent dispatch's prompt for that same agent ID via `engine/playbook.js`, and is bounded by two complementary cuts plus an optional summary pass:
+
+| Tunable (under `engine.*` in `config.json`)             | Default | Behavior                                                                                                          |
+|---------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------------------|
+| `agentMemoryMaxEntries`                                 | `300`   | Sliding-window entry-count cap. Older non-summary sections evicted oldest-first when exceeded.                    |
+| (built-in) `AGENT_MEMORY_BUDGET_BYTES`                  | `25000` | Hard byte ceiling for prompt-injection safety. Always wins when both caps bind. Sticky summary sections obey it.  |
+| `agentMemorySummaryEnabled`                             | `false` | Master switch for the LLM-driven compression pass. Off by default to avoid surprise Haiku spend.                  |
+| `agentMemorySummaryThreshold`                           | `30`    | When the summary pass fires, fold this many oldest entries into one summary section.                              |
+| `agentMemorySummaryDays`                                | `30`    | Age trigger: if the oldest entry is older than this, fold even when under the entry cap.                          |
+
+The summary pass runs fire-and-forget after every successful `appendToAgentMemory` write inside `classifyToKnowledgeBase`. It re-reads outside the lock, calls Haiku, then re-acquires the lock and verifies the same oldest sections are still in place (stale-candidate guard) before swapping. Any failure — disabled, no trigger, LLM unavailable, race detected — is a silent no-op; the consolidation pipeline is never blocked on the LLM.
+
+The compressed summary is wrapped in an `<UNTRUSTED-INPUT source="agent-memory-summary:agent=...">` fence on disk. The source material was the inbox bodies of evicted entries, which are themselves untrusted; without the fence, any imperative laundered through summarization could later be executed by an agent reading its own memory.
+
+Summary sections are **sticky** under the entry-count cap — they represent compressed knowledge that should outlive ordinary inbox entries. They are detected by their title prefix `Earlier learnings summary` and only the byte budget can evict them.
+
+**Default-off rationale.** `agentMemorySummaryEnabled` defaults to `false` (intentional deviation from PRD wording that implies "always on"). Enabling it commits operators to per-agent Haiku spend on every consolidation cycle; the entry-count cap on its own already prevents unbounded growth. Operators who have weighed the cost set `engine.agentMemorySummaryEnabled: true` in `config.json` to opt in.
+
 ## Quick reference for agents
 
 ```

package/engine/cli.js

@@ -159,6 +159,21 @@ function handleCommand(cmd, args) {
   if (!cmd) {
     return commands.start();
   } else if (commands[cmd]) {
+    // W-mq07mjzi000s1cc9: Centralized help-flag interception.
+    //
+    // `minions work --help` was creating ghost work items with title='--help'
+    // because the bare-string `title` was truthy and bypassed the `!title`
+    // usage check. Same class of bug exists in `spawn`/`plan`/`complete` —
+    // every command that takes a positional arg and tests it with `if (!arg)`.
+    //
+    // Intercept here so a single guard covers the whole command set. `pr` and
+    // `bridge` already handle `help`/`--help`/`-h` inline (see their own
+    // first-arg branches), so let them route through unchanged.
+    if (cmd !== 'pr' && cmd !== 'bridge' && isHelpToken(args && args[0])) {
+      console.log('Commands:');
+      for (const line of formatCliCommandHelpLines()) console.log(line);
+      return;
+    }
     return commands[cmd](...args);
   } else {
     console.log(`Unknown command: ${cmd}`);
@@ -168,6 +183,26 @@ function handleCommand(cmd, args) {
   }
 }
 
+// W-mq07mjzi000s1cc9: Help-flag token recognition.
+//
+// Matches the exact tokens the user typed on the CLI (`--help`, `-h`, `help`).
+// Used by handleCommand's centralized guard and by per-command defensive
+// checks (work/spawn/plan/complete) for defense-in-depth.
+function isHelpToken(arg) {
+  return arg === '--help' || arg === '-h' || arg === 'help';
+}
+
+// W-mq07mjzi000s1cc9: Stricter guard for command first-positionals.
+//
+// Real work-item titles, agent ids, plan source paths, and dispatch ids never
+// start with `--`. Rejecting any leading-`--` token catches the exact bug
+// reported (`--help`) plus typos like `--hep`, `--h`, `-help` that would
+// otherwise still slip through as ghost-WI titles.
+function looksLikeFlagOrHelp(arg) {
+  if (isHelpToken(arg)) return true;
+  return typeof arg === 'string' && arg.startsWith('--');
+}
+
 // SoT for engine-CLI metadata: drives handleCommand's help text and the
 // CC preamble's CLI index in dashboard.js. Drift-checked against `commands`.
 const CLI_COMMAND_DOCS = Object.freeze({
@@ -1295,6 +1330,11 @@ const commands = {
       console.log('Usage: minions complete <dispatch-id>');
       return;
     }
+    // W-mq07mjzi000s1cc9 — defensive guard mirrors work/spawn/plan.
+    if (looksLikeFlagOrHelp(id)) {
+      console.log('Usage: minions complete <dispatch-id>');
+      process.exit(2);
+    }
     const dispatch = getDispatch();
     const item = (dispatch.active || []).find(d => d.id === id);
     if (!item) {
@@ -1333,6 +1373,11 @@ const commands = {
       console.log('Usage: node .minions/engine.js spawn <agent-id> "<prompt>"');
       return;
     }
+    // W-mq07mjzi000s1cc9 — defensive guard mirrors work/plan/complete.
+    if (looksLikeFlagOrHelp(agentId)) {
+      console.log('Usage: node .minions/engine.js spawn <agent-id> "<prompt>"');
+      process.exit(2);
+    }
 
     const config = getConfig();
     if (!config.agents[agentId]) {
@@ -1365,6 +1410,16 @@ const commands = {
       console.log('  id  Optional caller-supplied work item ID. Defaults to a cuid-style W-<id>.');
       return;
     }
+    // W-mq07mjzi000s1cc9 — Defense-in-depth: reject `--help`/`-h`/`help` or any
+    // leading-`--` title even if a future caller bypasses handleCommand. The
+    // original bug created ghost WIs with title='--help' because the truthy
+    // check above let the flag through.
+    if (looksLikeFlagOrHelp(title)) {
+      console.log('Usage: node .minions/engine.js work "<title>" [options-json]');
+      console.log('Options: {"id":"W-customid","type":"implement","priority":"high","agent":"dallas","description":"...","branch":"feature/...","project":"minions"}');
+      console.log('  id  Optional caller-supplied work item ID. Defaults to a cuid-style W-<id>.');
+      process.exit(2);
+    }
 
     let opts = {};
     const optStr = rest.join(' ');
@@ -1452,6 +1507,15 @@ const commands = {
       console.log('  node engine.js plan "Add auth middleware with JWT tokens and role-based access"');
       return;
     }
+    // W-mq07mjzi000s1cc9 — defensive guard mirrors work/spawn/complete.
+    if (looksLikeFlagOrHelp(source)) {
+      console.log('Usage: node .minions/engine.js plan <source> [project]');
+      console.log('');
+      console.log('Source can be:');
+      console.log('  - A file path (markdown, txt, or json)');
+      console.log('  - Inline text wrapped in quotes');
+      process.exit(2);
+    }
 
     const config = getConfig();
     const { getProjects, resolveProjectSource } = require('./shared');