@yemi33/minions 0.1.2091 → 0.1.2092

package/engine/runtimes/copilot.js

@@ -222,25 +222,39 @@ function _isCachedBinUsable(cached) {
 }
 
 /**
- * Probe `gh extension list` for the gh-copilot extension. Returns the absolute
- * path of the `gh` binary when found, null otherwise.
+ * Probe `gh` for Copilot support. Returns the absolute path of the `gh`
+ * binary when `gh copilot` is invokable, null otherwise.
  *
- * `gh extension list` exits 0 with a list of extensions on stdout. We grep for
- * `gh-copilot`, the extension's repository slug. If `gh` isn't on PATH the
- * outer try-catch swallows the ENOENT.
+ * Two install paths produce a working `gh copilot` subcommand and we accept
+ * both:
+ *   1. gh ≥ ~2.90 ships Copilot as a built-in preview command. `gh extension
+ *      list` does NOT list it (it's not an extension) — and attempting to
+ *      install the legacy `github/gh-copilot` extension is rejected because
+ *      gh already provides the command. Detecting via the extension list
+ *      would falsely report "copilot not installed" on every recent gh.
+ *   2. gh < ~2.90 with the legacy `gh-copilot` extension installed. The
+ *      extension also responds to `gh copilot --help` with exit 0.
+ *
+ * `gh copilot --help` exits 0 in both cases and non-zero ("unknown command")
+ * when neither path is available, so it's a clean unified signal. The probe
+ * runs with --no-update-notifier (silences gh's update banner so a slow
+ * network doesn't drag the probe over the timeout). If `gh` isn't on PATH
+ * the outer try-catch swallows the ENOENT.
  */
-function _findGhCopilotExtension(env) {
+function _findGhCopilotExtension(env, { execSyncCapture = _execSyncCapture } = {}) {
   let ghPath = null;
   try {
     const cmd = isWin ? 'where gh 2>NUL' : 'which gh 2>/dev/null';
-    const which = _execSyncCapture(cmd, env).trim().split('\n')[0].trim();
+    const which = execSyncCapture(cmd, env).trim().split('\n')[0].trim();
     if (!which) return null;
     ghPath = which;
   } catch { return null; }
   try {
-    const out = _execSyncCapture('gh extension list', env);
-    if (/gh-copilot/i.test(out)) return ghPath;
-  } catch { /* `gh` may have no extensions or be misconfigured */ }
+    // execSync throws on non-zero exit; reaching the return means `gh copilot`
+    // is a valid subcommand on this gh version (builtin or legacy extension).
+    execSyncCapture('gh copilot --help', env, 5000);
+    return ghPath;
+  } catch { /* gh present but no copilot subcommand */ }
   return null;
 }
 
@@ -1205,11 +1219,12 @@ const capabilities = {
 
 // Install hint surfaced when `resolveBinary()` returns null. Covers all
 // supported install paths so users on any platform see one actionable line.
-// Standalone Copilot CLI (preferred path) is available via:
-//   - WinGet:    winget install --id GitHub.cli && gh extension install github/gh-copilot
-//   - Homebrew:  brew install gh && gh extension install github/gh-copilot
-//   - Direct:    download from https://github.com/github/copilot-cli/releases
-const INSTALL_HINT = 'install via WinGet (winget install --id GitHub.cli && gh extension install github/gh-copilot), Homebrew (brew install gh && gh extension install github/gh-copilot), or download standalone copilot from https://github.com/github/copilot-cli/releases';
+//
+// gh ≥ ~2.90 ships `gh copilot` as a built-in preview command, so the legacy
+// `gh extension install github/gh-copilot` flow is no longer required (and is
+// in fact rejected by recent gh, since the command is already provided). The
+// hint reflects that: get a modern gh, OR install the standalone Copilot CLI.
+const INSTALL_HINT = 'install GitHub CLI 2.90+ which ships `gh copilot` built in (WinGet: `winget install --id GitHub.cli`, Homebrew: `brew install gh`, or download from https://cli.github.com), or install the standalone Copilot CLI via `npm i -g @github/copilot`';
 
 function getUserAssetDirs({ homeDir = os.homedir() } = {}) {
   return [
@@ -1286,6 +1301,7 @@ module.exports = {
   _pickStandaloneCopilotFromOutput,
   _resolveNpmCopilotJsEntry,
   _isCachedBinUsable,
+  _findGhCopilotExtension,
   // W-mpmwxni2000c25c7-a — invalid-model error-path helpers. `_warmModelCache`
   // populates the in-memory model catalog so parseError can enrich its
   // "Model X not available" message without a per-error HTTP round trip.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2091",
+  "version": "0.1.2092",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"