@yemi33/minions 0.1.2084 → 0.1.2085

package/dashboard/js/settings.js

@@ -393,8 +393,8 @@ async function openSettings() {
     '<h4>Inbox &amp; Status Retention</h4>' +
     '<div class="settings-grid-2">' +
       settingsField('Consolidation Threshold', 'set-inboxConsolidateThreshold', e.inboxConsolidateThreshold || 5, 'notes', 'Inbox notes before auto-consolidation') +
-      settingsField('Status WorkItems Retention', 'set-statusWorkItemsRetentionDays', e.statusWorkItemsRetentionDays ?? 7, 'days', 'Trim done/failed/cancelled work items older than N days from the /api/status workItems slice (active items are always shipped). Cuts SPA payload from ~3MB to <500KB. Set to 0 to disable trimming (full list shipped, restoring legacy behavior).') +
-      settingsField('Status Meetings Retention', 'set-statusMeetingsRetentionDays', e.statusMeetingsRetentionDays ?? 7, 'days', 'Trim completed/archived meetings older than N days from the /api/status meetings slice (active meetings are always shipped). Cuts SPA payload from ~4.3MB to <500KB. Detail modal still fetches full transcripts via /api/meetings/:id. Set to 0 to disable trimming (full list shipped, restoring legacy behavior).') +
+      settingsField('Status WorkItems Retention', 'set-statusWorkItemsRetentionDays', e.statusWorkItemsRetentionDays ?? 0, 'days', 'Optional age-based trim for done/failed/cancelled work items in the /api/status workItems slice (active items are always shipped). Default 0 = no trim — the slim projection that strips description/AC/references already cuts the payload by ~80%. Set to a positive integer to also drop terminal items older than N days.') +
+      settingsField('Status Meetings Retention', 'set-statusMeetingsRetentionDays', e.statusMeetingsRetentionDays ?? 0, 'days', 'Optional age-based trim for completed/archived meetings in the /api/status meetings slice (active meetings are always shipped). Default 0 = no trim — the slim projection that collapses findings/debate/transcript bodies to {agentId: true} sentinels already cuts the payload by ~80%. Set to a positive integer to also drop terminal meetings older than N days. Detail modal still fetches full bodies via /api/meetings/:id.') +
       settingsField('Version Check Interval', 'set-versionCheckInterval', e.versionCheckInterval || 3600000, 'ms', 'How often to check npm for updates (default: 1 hour)') +
     '</div>' +
     '<h4>Operator &amp; Comments</h4>' +

package/dashboard.js

@@ -73,6 +73,11 @@ const TITLE_SUFFIX = IS_DEV_MODE ? ' [DEV]' : '';
 
 const PORT = parseInt(process.env.PORT || process.argv[2]) || 7331;
 let CONFIG = queries.getConfig();
+// Mirror cli.js: clear persisted statusWorkItemsRetentionDays=7 + the matching
+// meetings field (prior default 7) so the new default (0, no trim) reaches the
+// /api/status slimmers without needing an engine bounce first.
+try { shared.applyStatusWorkItemsRetentionMigration(CONFIG); } catch { /* best-effort */ }
+try { shared.applyStatusMeetingsRetentionMigration(CONFIG); } catch { /* best-effort */ }
 let PROJECTS = _getProjects(CONFIG);
 const CONFIG_PATH = path.join(MINIONS_DIR, 'config.json');
 const PINNED_PATH = path.join(MINIONS_DIR, 'pinned.md');
@@ -95,6 +100,8 @@ function ensureConfiguredProjectStateFiles() {
 
 function reloadConfig() {
   CONFIG = queries.getConfig();
+  try { shared.applyStatusWorkItemsRetentionMigration(CONFIG); } catch { /* best-effort */ }
+  try { shared.applyStatusMeetingsRetentionMigration(CONFIG); } catch { /* best-effort */ }
   PROJECTS = _getProjects(CONFIG);
   ensureConfiguredProjectStateFiles();
 }
@@ -1832,19 +1839,19 @@ function _safeStatusSlice(name, fn, fallback) {
 }
 
 // ── /api/status workItems slimming (W-mphejzmj000718bf) ─────────────────────
-// Strip down the workItems slice shipped on /api/status to (a) drop terminal
-// (done/failed/cancelled) items older than engine.statusWorkItemsRetentionDays
-// and (b) project each surviving item onto a narrow shape that omits the
-// large free-text fields (description, full acceptanceCriteria, full
-// references). The dashboard never renders description/AC/references-detail
-// off the cached slice — `wiRow` only needs counts + status/badge fields,
-// and `openWorkItemDetail` fetches the full record on demand via
-// GET /api/work-items/<id>. Live measurement at task time: 796 items / ~3MB
-// → ~50–100 items / <500KB typical. Active items (pending/dispatched/queued)
-// are ALWAYS kept regardless of age.
+// Project each work item onto a narrow shape that omits the large free-text
+// fields (description, full acceptanceCriteria, full references) before
+// shipping on /api/status. The dashboard never renders description/AC/
+// references-detail off the cached slice — `wiRow` only needs counts +
+// status/badge fields, and `openWorkItemDetail` fetches the full record on
+// demand via GET /api/work-items/<id>. This slim projection is the bulk of
+// the payload savings (~3MB → <500KB typical) and runs unconditionally.
 //
-// Set engine.statusWorkItemsRetentionDays = 0 to disable trimming entirely
-// (returns the full list unchanged, restoring legacy behavior).
+// engine.statusWorkItemsRetentionDays is an optional second-tier filter that
+// drops terminal (done/failed/cancelled) items older than N days. Default 0
+// = no trim (legacy behavior, full list shipped). Set to a positive integer
+// to opt into the date-based trim. Active items (pending/dispatched/queued)
+// are ALWAYS kept regardless of age.
 const _ACTIVE_WI_STATUSES_FOR_STATUS = new Set(['pending', 'dispatched', 'queued', 'paused', 'decomposed']);
 const _TERMINAL_WI_STATUSES_FOR_STATUS = new Set(['done', 'failed', 'cancelled']);
 function _resolveStatusWorkItemsRetentionDays() {
@@ -1931,9 +1938,9 @@ function _slimWorkItemsForStatus(items) {
 }
 
 // ── /api/status meetings slimming (W-mphlrxx6000a8760) ──────────────────────
-// Mirrors the workItems trim above (PR #2816). Meetings are the second
-// largest /api/status slice after workItems — live measurement: 22 meetings
-// / 4.3MB (60% of the 7.2MB payload). The list renderer in
+// Mirrors the workItems slim above (PR #2816). Meetings were the second
+// largest /api/status slice — live measurement: 22 meetings / 4.3MB
+// (60% of the 7.2MB payload) before slimming. The list renderer in
 // dashboard/js/render-meetings.js:renderMeetings only needs:
 //   - id, title, status, round, participants, agenda(short), createdAt,
 //     completedAt
@@ -1941,13 +1948,13 @@ function _slimWorkItemsForStatus(items) {
 //     ✓/⏳/○ icon — `m.findings?.[p]` truthy check, line 48-50)
 // The detail modal calls `/api/meetings/:id` which serves the full record
 // (findings.content + debate.content + conclusion + transcript bodies), so
-// dropping those from the slice is safe.
+// dropping those bodies from the slice is safe. The slim projection alone
+// delivers the bulk of the payload savings and always runs.
 //
-// Active meetings (investigating/debating/concluding) are ALWAYS kept
-// regardless of age. Terminal meetings (completed/archived) only survive
-// if their completedAt/roundStartedAt/createdAt is within the window.
-// Set engine.statusMeetingsRetentionDays = 0 to disable trimming entirely
-// (returns the full list — but still slim-shaped — restoring legacy size).
+// engine.statusMeetingsRetentionDays is an optional second-tier filter that
+// drops terminal (completed/archived) meetings older than N days. Default 0
+// = no trim (legacy behavior, full list shipped — but still slim-shaped).
+// Active meetings (investigating/debating/concluding) are ALWAYS kept.
 const _ACTIVE_MEETING_STATUSES_FOR_STATUS = new Set(['investigating', 'debating', 'concluding']);
 const _TERMINAL_MEETING_STATUSES_FOR_STATUS = new Set(['completed', 'archived']);
 function _resolveStatusMeetingsRetentionDays() {

package/docs/deprecated.json

@@ -1,4 +1,17 @@
 [
+  {
+    "id": "status-retention-stale-default-migration",
+    "description": "applyStatusWorkItemsRetentionMigration + applyStatusMeetingsRetentionMigration: one-time migrations that drop engine.statusWorkItemsRetentionDays=7 and engine.statusMeetingsRetentionDays=7 from loaded config so the new defaults (0, no trim) reach installs whose config.json was persisted while 7 was the baked-in default. The 7-day cutoffs were added alongside the slim projections (W-mphejzmj000718bf for workItems, W-mphlrxx6000a8760 for meetings) but surfaced as data loss to users (completed rows disappearing from /api/status after a week). The slim projections (which deliver the bulk of the payload savings) still run unconditionally; only the date filters were demoted to opt-in. shared.js mutates the in-memory config; engine/cli.js follows up with guarded shared.mutateJsonFileLocked calls on config.json so the fields are also removed on disk — affected installs are permanently corrected the first time the engine boots after this ships.",
+    "code": [
+      { "file": "engine/shared.js", "note": "applyStatusWorkItemsRetentionMigration / applyStatusMeetingsRetentionMigration definitions + _resetStaleRetentionMigrationFlag / _resetStaleMeetingsRetentionMigrationFlag test helpers — pure, in-memory" },
+      { "file": "engine/cli.js", "note": "Two boot blocks inside start() — each applies the in-memory pass THEN mutateJsonFileLocked on config.json to delete the field with skipWriteIfUnchanged so non-7 installs don't churn the file" },
+      { "file": "dashboard.js", "note": "Initial CONFIG load + reloadConfig() both apply the in-memory migrations so the dashboard picks up the new defaults even if it boots before the engine writes config.json" }
+    ],
+    "deprecated": "2026-05-29",
+    "targetRemovalDate": "2026-06-01",
+    "cleanup": "On or after 2026-06-01 (3 days), delete both migration functions + their reset helpers from engine/shared.js (including the shared.js export lines), the boot calls + mutateJsonFileLocked blocks in engine/cli.js, the call sites in dashboard.js, the tests in test/unit/status-workitems-retention.test.js and test/unit/status-meetings-retention.test.js gated on the function names, and this entry. Three days is enough because the on-disk rewrite happens on first engine boot — any install whose engine has rebooted at least once since this shipped has already had its config.json corrected and is no longer dependent on the in-memory shim.",
+    "notes": "Persistent custom values (any non-7 integer) are preserved untouched. The only at-risk users are those who explicitly want a 7-day window — they can re-set via the Settings page after removal. If a user never restarts the engine in the 3-day window, the shim still strips the persisted 7 on dashboard-only boot via the in-memory pass; the on-disk write is a hardening pass for the common case, not a strict requirement."
+  },
   {
     "id": "config-poll-key-migration",
     "location": "engine/queries.js:126-163",

package/engine/cli.js

@@ -471,6 +471,41 @@ const commands = {
     try { shared.applyLegacyCcModelMigration(config, { logger: e.log }); }
     catch (err) { e.log('warn', `legacy ccModel migration failed: ${err.message}`); }
 
+    // Drop persisted statusWorkItemsRetentionDays=7 (the prior baked-in default)
+    // so the new default of 0 (no trim) reaches installs that opened Settings
+    // before the flip. Explicit non-7 values are preserved. We mutate in-memory
+    // AND rewrite config.json so the fix is permanent — the shim in shared.js
+    // can then retire on schedule without users regressing.
+    try {
+      const applied = shared.applyStatusWorkItemsRetentionMigration(config, { logger: e.log });
+      if (applied) {
+        const configPath = path.join(shared.MINIONS_DIR, 'config.json');
+        shared.mutateJsonFileLocked(configPath, (onDisk) => {
+          if (onDisk && onDisk.engine && onDisk.engine.statusWorkItemsRetentionDays === 7) {
+            delete onDisk.engine.statusWorkItemsRetentionDays;
+          }
+          return onDisk;
+        }, { defaultValue: {}, skipWriteIfUnchanged: true });
+      }
+    }
+    catch (err) { e.log('warn', `statusWorkItemsRetentionDays migration failed: ${err.message}`); }
+
+    // Same treatment for statusMeetingsRetentionDays — the meetings slice had
+    // the same 7-day baked-in default and the same data-loss UX.
+    try {
+      const applied = shared.applyStatusMeetingsRetentionMigration(config, { logger: e.log });
+      if (applied) {
+        const configPath = path.join(shared.MINIONS_DIR, 'config.json');
+        shared.mutateJsonFileLocked(configPath, (onDisk) => {
+          if (onDisk && onDisk.engine && onDisk.engine.statusMeetingsRetentionDays === 7) {
+            delete onDisk.engine.statusMeetingsRetentionDays;
+          }
+          return onDisk;
+        }, { defaultValue: {}, skipWriteIfUnchanged: true });
+      }
+    }
+    catch (err) { e.log('warn', `statusMeetingsRetentionDays migration failed: ${err.message}`); }
+
     // Auto-heal projects missing workSources (cloned-repo / hand-rolled-config
     // footgun): without this block, discoverFromWorkItems / discoverFromPrs
     // bail silently and the engine looks healthy but never dispatches. The

package/engine/shared.js

@@ -2184,27 +2184,32 @@ const ENGINE_DEFAULTS = {
   // the override and falls back to auto-resolution.
   operatorLogin: null,
   // ── /api/status workItems retention (W-mphejzmj000718bf) ────────────────────
-  // Trim done/failed/cancelled work items older than this many days from the
-  // /api/status workItems slice to cut the SPA payload (live: 796 items / 3MB
-  // → ~50–100 items / <500KB typical). Active items (pending/dispatched/queued)
-  // are ALWAYS shipped regardless of age — only terminal items past the
-  // window are dropped. The detail modal fetches the full record on demand
-  // via GET /api/work-items/<id> when description/references/AC are needed.
-  // 0 disables the trim (full list shipped, restoring legacy behavior).
-  statusWorkItemsRetentionDays: 7,
+  // Optional age-based trim for done/failed/cancelled work items in the
+  // /api/status workItems slice. Default 0 = no trim (full list shipped). The
+  // bulk of the payload savings (~3MB → ~500KB) comes from _slimWorkItemForStatus
+  // dropping description / full acceptanceCriteria / references — that slim
+  // projection runs unconditionally. The date filter on top was a second-tier
+  // optimization that surfaced as data loss to users (completed items vanishing
+  // from /api/status after 7 days) so it now opts in via a positive integer.
+  // Active items (pending/dispatched/queued) are ALWAYS shipped regardless of
+  // age. The detail modal fetches the full record on demand via
+  // GET /api/work-items/<id> when description/references/AC are needed.
+  statusWorkItemsRetentionDays: 0,
 
   // ── /api/status meetings retention (W-mphlrxx6000a8760) ─────────────────────
-  // Same shape as statusWorkItemsRetentionDays — mirrors the trim+slim pass
-  // for the meetings slice (live: 22 meetings / 4.3MB → ~5 meetings / <500KB
-  // typical). Active meetings (investigating/debating/concluding) are ALWAYS
-  // shipped regardless of age — only terminal meetings (completed/archived)
-  // past the window are dropped. The detail modal fetches the full record
-  // (findings, debate, conclusion, transcript bodies) on demand via
-  // GET /api/meetings/<id> when opened. A top-level meetingsTotal field is
-  // synthesized so the sidebar activity dot still fires when ANY meeting
-  // (including those dropped from the slim slice) gains a new round.
-  // 0 disables the trim (full list shipped, restoring legacy behavior).
-  statusMeetingsRetentionDays: 7,
+  // Same shape as statusWorkItemsRetentionDays — optional age-based trim for
+  // completed/archived meetings in the /api/status meetings slice. Default 0
+  // = no trim (full list shipped). The slim projection (which collapses
+  // ~95KB+ per-round findings/debate/transcript bodies down to {agentId: true}
+  // sentinels) delivers the bulk of the payload savings and always runs.
+  // The date filter on top was demoted to opt-in for the same reason as the
+  // workItems trim: vanishing completed meetings read as data loss. Active
+  // meetings (investigating/debating/concluding) are ALWAYS shipped regardless
+  // of age. The detail modal fetches the full record (findings, debate,
+  // conclusion, transcript bodies) on demand via GET /api/meetings/<id>.
+  // A top-level meetingsTotal field is synthesized so the sidebar activity
+  // dot still fires when ANY meeting gains a new round.
+  statusMeetingsRetentionDays: 0,
 };
 
 // ─── Runtime Fleet Resolution (P-3b8e5f1d) ──────────────────────────────────
@@ -2401,6 +2406,64 @@ function _resetLegacyCcModelMigrationFlag() {
   _legacyCcModelMigrationLogged = false;
 }
 
+// ─── Stale statusWorkItemsRetentionDays Default Migration ────────────────────
+//
+// The retention default was 7 from W-mphejzmj000718bf until users reported the
+// trim hid completed work items from /api/status, which read as data loss.
+// We flipped the baked-in default to 0 (no trim). Installs that opened the
+// Settings page while the default was 7 have `engine.statusWorkItemsRetentionDays: 7`
+// persisted in their config.json — the resolver would return 7 and they'd
+// still see the trim. This shim drops a literal `7` at load time so the new
+// default of 0 applies. Operators who explicitly set a non-7 value (e.g. 14
+// or 30) are left untouched. No on-disk rewrite.
+
+let _staleRetentionMigrationLogged = false;
+
+function applyStatusWorkItemsRetentionMigration(config, { logger = log } = {}) {
+  if (!config || !config.engine || typeof config.engine !== 'object') return false;
+  const e = config.engine;
+  if (e.statusWorkItemsRetentionDays !== 7) return false;
+  delete e.statusWorkItemsRetentionDays;
+  if (!_staleRetentionMigrationLogged) {
+    _staleRetentionMigrationLogged = true;
+    try {
+      logger('warn', 'statusWorkItemsRetentionDays=7 was the previous default — clearing in-memory so the new default (0, no trim) applies. Re-save Settings to persist or set a positive value to opt back in.');
+    } catch { /* logger may not be wired during tests — best-effort */ }
+  }
+  return true;
+}
+
+/** Test helper: reset the dedup flag so repeated tests can re-trigger the log. */
+function _resetStaleRetentionMigrationFlag() {
+  _staleRetentionMigrationLogged = false;
+}
+
+// Same shape as applyStatusWorkItemsRetentionMigration above, for the meetings
+// slice. The prior baked-in default of 7 caused completed/archived meetings to
+// vanish from /api/status after a week; we flipped the default to 0 and strip
+// the literal 7 from persisted configs so the new behavior applies.
+
+let _staleMeetingsRetentionMigrationLogged = false;
+
+function applyStatusMeetingsRetentionMigration(config, { logger = log } = {}) {
+  if (!config || !config.engine || typeof config.engine !== 'object') return false;
+  const e = config.engine;
+  if (e.statusMeetingsRetentionDays !== 7) return false;
+  delete e.statusMeetingsRetentionDays;
+  if (!_staleMeetingsRetentionMigrationLogged) {
+    _staleMeetingsRetentionMigrationLogged = true;
+    try {
+      logger('warn', 'statusMeetingsRetentionDays=7 was the previous default — clearing in-memory so the new default (0, no trim) applies. Re-save Settings to persist or set a positive value to opt back in.');
+    } catch { /* logger may not be wired during tests — best-effort */ }
+  }
+  return true;
+}
+
+/** Test helper: reset the dedup flag so repeated tests can re-trigger the log. */
+function _resetStaleMeetingsRetentionMigrationFlag() {
+  _staleMeetingsRetentionMigrationLogged = false;
+}
+
 // ─── Runtime Config Preflight Warnings ──────────────────────────────────────
 //
 // Emit non-fatal warnings about runtime/CLI configuration drift. Consumed by
@@ -5454,6 +5517,8 @@ module.exports = {
   resolveAgentCli, resolveCcCli, resolveCcUseWorkerPool, resolveAgentModel, resolveCcModel,
   resolveAgentMaxBudget, resolveAgentBareMode,
   applyLegacyCcModelMigration, _resetLegacyCcModelMigrationFlag,
+  applyStatusWorkItemsRetentionMigration, _resetStaleRetentionMigrationFlag,
+  applyStatusMeetingsRetentionMigration, _resetStaleMeetingsRetentionMigrationFlag,
   runtimeConfigWarnings,
   projectWorkSourceWarnings,
   backfillProjectWorkSourceDefaults,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2084",
+  "version": "0.1.2085",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"