@yemi33/minions 0.1.2080 → 0.1.2081

package/engine/pipeline.js

@@ -299,11 +299,19 @@ function evaluateCondition(condition, ctx) {
 
   switch (cond.check) {
     case 'runSucceeded': {
-      // True when the current/last run completed with all stages succeeded (none failed)
+      // P-bfa1e finding #21: tightened predicate.
+      // Previously this accepted PENDING as "succeeded" via `s.status === COMPLETED || s.status === PENDING`,
+      // which let `stopWhen`/`stop-pipeline` short-circuit fire while stages were still queued for the next
+      // dispatch cycle. A "succeeded" run is one where:
+      //   1. The run object exists (no run → nothing has succeeded).
+      //   2. At least one stage exists (vacuous-truth empty `.every()` would otherwise lie about success).
+      //   3. EVERY stage is COMPLETED — RUNNING/PENDING/WAITING_HUMAN/PAUSED/FAILED/STOPPED all fail the check.
+      // Any `stopWhen` or condition-stage `stop-pipeline` consumer wired to `runSucceeded` now sees `false`
+      // until the run is fully done, so it cannot prematurely terminate the pipeline.
       if (!run) return false;
-      return Object.values(run.stages || {}).every(
-        s => s.status === PIPELINE_STATUS.COMPLETED || s.status === PIPELINE_STATUS.PENDING
-      );
+      const stages = Object.values(run.stages || {});
+      if (stages.length === 0) return false;
+      return stages.every(s => s && s.status === PIPELINE_STATUS.COMPLETED);
     }
     case 'noFailedItems': {
       // True when all work items created by the pipeline are done (not failed)
@@ -1156,6 +1164,23 @@ async function discoverPipelineWork(config) {
           // Condition stage signaled pipeline stop — complete the run immediately
           if (result._stopPipeline) {
             completeRun(pipeline.id, activeRun.runId, PIPELINE_STATUS.STOPPED);
+            // P-bfa1e finding #24: the local `activeRun` reference still has
+            // `status === RUNNING` because we captured it at L980 before any
+            // completion writes. The post-loop `allComplete` block at L1138
+            // guards with `activeRun.status !== PIPELINE_STATUS.STOPPED`
+            // before re-calling `completeRun(..., COMPLETED)` — if we leave
+            // the stale RUNNING status in place that guard fails and we
+            // clobber the STOPPED status with COMPLETED. Refresh the local
+            // reference from disk so downstream reads in this same tick see
+            // STOPPED. `getActiveRun` excludes terminal runs, so fall back
+            // to a defensive in-place status patch when the refresh comes
+            // back empty.
+            const refreshed = getActiveRun(pipeline.id);
+            if (refreshed) {
+              activeRun = refreshed;
+            } else {
+              activeRun.status = PIPELINE_STATUS.STOPPED;
+            }
             allComplete = true;
             break;
           }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2080",
+  "version": "0.1.2081",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"