@yemi33/minions 0.1.2061 → 0.1.2063

package/dashboard/js/modal.js

@@ -4,11 +4,6 @@ function closeModal() {
   const modalEl = document.querySelector('#modal .modal');
   if (modalEl) modalEl.classList.remove('modal-wide');
   document.getElementById('modal').classList.remove('open');
-  // Clear the WI-detail auto-refresh tracker so renderWorkItems stops
-  // rewriting #modal-body each tick. Safe to do unconditionally — if the
-  // closed modal wasn't a WI detail, these vars were already null.
-  if (typeof _wiModalOpenId !== 'undefined') { _wiModalOpenId = null; }
-  if (typeof _wiModalHydratedFields !== 'undefined') { _wiModalHydratedFields = null; }
   clearModalBackStack();
   // Hide Q&A section (only shown for document modals)
   document.getElementById('modal-qa').style.display = 'none';

package/dashboard/js/render-agents.js

@@ -69,18 +69,24 @@ function renderAgents(agents) {
   `).join('');
 }
 
-// Re-render the detail-panel header (name + emoji + runtime/model chips +
-// status badge + lastAction + blocking-tool / resultSummary blocks) from a
-// slim agentData record. Extracted so renderAgents can call it every poll
-// tick to keep an open detail panel live without re-fetching the expensive
-// /api/agent/<id> charter/history/output payload. SEC-03 Phase A rules
-// still apply: emoji/name/role go through textContent.
-function _renderAgentDetailHeader(agent) {
+async function openAgentDetail(id) {
+  const agent = agentData.find(a => a.id === id);
+  if (!agent) return;
+  currentAgentId = id;
+  currentTab = (agent.status === 'working') ? 'live' : 'thought-process';
+
+  // SEC-03 Phase A: Build the detail header via DOM + textContent instead of innerHTML.
+  // Emoji, name and role are all user-controlled fields; routing them through textContent
+  // guarantees no HTML interpretation even if the escape function were ever bypassed.
   const nameEl = document.getElementById('detail-agent-name');
-  if (!nameEl) return;
   const emojiSpan = document.createElement('span');
   emojiSpan.style.fontSize = '22px';
   emojiSpan.textContent = agent.emoji || '';
+  // Runtime tag \u2014 uses the inline-SVG logo from the same RUNTIME_TAGS map the
+  // card uses, so the visual is consistent. The container's user-controlled
+  // text fields stay on the textContent path; the SVG is a hardcoded literal
+  // from RUNTIME_TAGS keyed by the runtime string (server-controlled, finite
+  // set), so injecting via innerHTML on the icon-only span is safe.
   const runtimeMeta = RUNTIME_TAGS[agent.runtime];
   const runtimeSpan = document.createElement('span');
   runtimeSpan.title = 'Runtime: ' + (runtimeMeta?.label || agent.runtime || 'unknown');
@@ -94,6 +100,9 @@ function _renderAgentDetailHeader(agent) {
     runtimeSpan.style.cssText += ';font-size:10px;font-weight:600;letter-spacing:0.4px;text-transform:uppercase;padding:2px 6px;border:1px solid var(--muted);border-radius:3px;color:var(--muted)';
     runtimeSpan.textContent = agent.runtime || 'unknown';
   }
+  // W-mpmwxk4y00053271 — mirror the model chip the card shows so the detail
+  // header stays in sync. textContent path keeps the model string from being
+  // interpreted as HTML.
   const modelSpan = (agent.model && typeof agent.model === 'string')
     ? (() => {
         const s = document.createElement('span');
@@ -112,27 +121,12 @@ function _renderAgentDetailHeader(agent) {
   nameEl.replaceChildren(...children);
 
   const badgeClass = agent.status;
-  const statusEl = document.getElementById('detail-status-line');
-  if (statusEl) {
-    // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; status is an internal bounded enum and all user data is wrapped in escapeHtml()/renderMd() (fields: lastAction, blocking tool, resultSummary)
-    statusEl.innerHTML =
-      '<span class="status-badge ' + badgeClass + '">' + agent.status.toUpperCase() + '</span> ' +
-      '<span style="color:var(--muted)">' + escapeHtml(agent.lastAction) + '</span>' +
-      (agent._blockingToolCall ? '<div style="margin-top:4px;padding:4px 8px;background:rgba(130,160,210,0.13);border:1px solid rgba(130,160,210,0.3);border-radius:4px;font-size:11px;color:var(--muted)">&#x23F3; Blocking tool call (' + escapeHtml(agent._blockingToolCall.tool) + ') &mdash; silent ' + Math.round(agent._blockingToolCall.silentMs/60000) + 'min, timeout in ' + Math.round(agent._blockingToolCall.remainingMs/60000) + 'min</div>' : '') +
-      (agent.resultSummary ? '<div style="margin-top:4px;font-size:11px;color:var(--text);line-height:1.4">' + renderMd(agent.resultSummary.slice(0, 300)) + '</div>' : '');
-  }
-}
-
-async function openAgentDetail(id) {
-  const agent = agentData.find(a => a.id === id);
-  if (!agent) return;
-  currentAgentId = id;
-  currentTab = (agent.status === 'working') ? 'live' : 'thought-process';
-
-  // SEC-03 Phase A: Build the detail header via DOM + textContent instead of innerHTML.
-  // Emoji, name and role are all user-controlled fields; routing them through textContent
-  // guarantees no HTML interpretation even if the escape function were ever bypassed.
-  _renderAgentDetailHeader(agent);
+  // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; status is an internal bounded enum and all user data is wrapped in escapeHtml()/renderMd() (fields: lastAction, blocking tool, resultSummary)
+  document.getElementById('detail-status-line').innerHTML =
+    '<span class="status-badge ' + badgeClass + '">' + agent.status.toUpperCase() + '</span> ' +
+    '<span style="color:var(--muted)">' + escapeHtml(agent.lastAction) + '</span>' +
+    (agent._blockingToolCall ? '<div style="margin-top:4px;padding:4px 8px;background:rgba(130,160,210,0.13);border:1px solid rgba(130,160,210,0.3);border-radius:4px;font-size:11px;color:var(--muted)">&#x23F3; Blocking tool call (' + escapeHtml(agent._blockingToolCall.tool) + ') &mdash; silent ' + Math.round(agent._blockingToolCall.silentMs/60000) + 'min, timeout in ' + Math.round(agent._blockingToolCall.remainingMs/60000) + 'min</div>' : '') +
+    (agent.resultSummary ? '<div style="margin-top:4px;font-size:11px;color:var(--text);line-height:1.4">' + renderMd(agent.resultSummary.slice(0, 300)) + '</div>' : '');
 
   // Show panel immediately with loading state — don't wait for API
   document.getElementById('detail-content').innerHTML = '<div style="padding:24px;text-align:center;color:var(--muted)">Loading...</div>';
@@ -167,12 +161,7 @@ function _tickAgentRuntimes() {
     el.textContent = 'Running: ' + (hr > 0 ? hr + 'h ' : '') + min + 'm ' + sec + 's';
   });
 }
-// Start ticker after each render if working agents exist, and refresh the
-// open agent-detail panel header so status / lastAction / blocking-tool /
-// resultSummary track the latest /api/status slice without re-fetching the
-// expensive /api/agent/<id> charter/history/output payload. The body tabs
-// (thought-process, live, output, etc.) are loaded once on open via
-// openAgentDetail's safeFetch — they stay as-is until the user reopens.
+// Start ticker after each render if working agents exist
 var _origRenderAgents = renderAgents;
 renderAgents = function(agents) {
   _origRenderAgents(agents);
@@ -181,10 +170,6 @@ renderAgents = function(agents) {
     _tickAgentRuntimes();
     _agentRuntimeTimer = setInterval(_tickAgentRuntimes, 1000);
   }
-  if (currentAgentId) {
-    var open = agents.find(function(a) { return a.id === currentAgentId; });
-    if (open) _renderAgentDetailHeader(open);
-  }
 };
 
 window.MinionsAgents = { renderAgents, openAgentDetail };

package/dashboard/js/render-work-items.js

@@ -4,18 +4,6 @@ let allWorkItems = [];
 let wiPage = 0;
 const WI_PER_PAGE = 20;
 
-// Track open WI detail modal so renderWorkItems can re-render its body
-// every poll tick. Without this the modal stays frozen on the snapshot
-// from the moment it was opened — status flips / agent assignments /
-// PR link arrival are invisible until the user closes + reopens or
-// hard-refreshes. Mirrors the same fix that drove the section-render
-// gate sweep (8ad48509 / W-mpn7keq9000302c9). `_wiModalHydratedFields`
-// caches the heavy free-text fields (description, acceptanceCriteria,
-// references) loaded once by openWorkItemDetail's GET /api/work-items/<id>
-// hydration call so per-tick re-renders don't lose them.
-let _wiModalOpenId = null;
-let _wiModalHydratedFields = null;
-
 // Track retry state per work item so loading/success/error survives re-renders
 const _wiRetryState = {}; // { [id]: { status: 'pending'|'done'|'error', message?, until? } }
 function setWiRetryState(id, state) { _wiRetryState[id] = state; }
@@ -167,27 +155,6 @@ function renderWorkItems(items) {
     const newWrap = el.querySelector('.pr-table-wrap');
     if (newWrap) newWrap.scrollLeft = savedScroll;
   }
-  // Refresh the open WI detail modal in-place so its status badge,
-  // agent assignment, PR link, etc. reflect the latest /api/status slice.
-  // The heavy free-text fields (description, AC, references) live in
-  // `_wiModalHydratedFields` from the one-time GET /api/work-items/<id>
-  // hydration and survive across these re-renders.
-  if (_wiModalOpenId) {
-    const slim = items.find(i => i.id === _wiModalOpenId);
-    if (slim) {
-      const merged = Object.assign({}, _wiModalHydratedFields || {}, slim);
-      const body = document.getElementById('modal-body');
-      if (body) {
-        // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; all user data wrapped in escapeHtml() or renderMd() by _wiRenderDetail()
-        body.innerHTML = _wiRenderDetail(merged);
-      }
-      const title = document.getElementById('modal-title');
-      if (title) title.textContent = slim.title || slim.id;
-    }
-    // If the WI dropped out of the slim slice (deleted/archived), leave
-    // the modal as-is — the user will close it normally; we don't want
-    // to auto-dismiss in case they're still reading.
-  }
 }
 
 async function editWorkItem(id, source) {
@@ -682,15 +649,6 @@ function openWorkItemDetail(id) {
     (cached.referencesCount > 0 && !Array.isArray(cached.references));
 
   const initial = needsHydration ? Object.assign({}, cached, { _descriptionLoading: true }) : cached;
-  // Track which WI's modal is open so renderWorkItems can re-render the
-  // modal body each poll tick. Reset the hydrated cache; openWorkItemDetail
-  // is the only authoritative source of the heavy free-text fields.
-  _wiModalOpenId = id;
-  _wiModalHydratedFields = needsHydration ? null : {
-    description: cached.description,
-    acceptanceCriteria: Array.isArray(cached.acceptanceCriteria) ? cached.acceptanceCriteria : undefined,
-    references: Array.isArray(cached.references) ? cached.references : undefined,
-  };
   document.getElementById('modal-title').textContent = initial.title || initial.id;
   // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; all user data wrapped in escapeHtml() or renderMd() by _wiRenderDetail() (fields: title, description, agent, source, reasons, references, artifacts, PR links)
   document.getElementById('modal-body').innerHTML = _wiRenderDetail(initial);
@@ -704,22 +662,18 @@ function openWorkItemDetail(id) {
     .then(function(r) { if (!r.ok) throw new Error('HTTP ' + r.status); return r.json(); })
     .then(function(data) {
       // Guard against modal navigation away from this WI during the fetch.
-      if (_wiModalOpenId !== id) return;
+      var title = document.getElementById('modal-title');
+      if (!title || title.textContent !== (initial.title || initial.id)) return;
       var full = data && data.item;
       if (!full) return;
-      // Cache the heavy free-text fields so per-tick re-renders preserve
-      // them. We keep them separate from the slim slice (which renderWorkItems
-      // refreshes on every tick).
-      _wiModalHydratedFields = {
-        description: full.description || cached.description || '',
-        acceptanceCriteria: Array.isArray(full.acceptanceCriteria) ? full.acceptanceCriteria : undefined,
-        references: Array.isArray(full.references) ? full.references : undefined,
-      };
       // Merge: cached cross-slice fields (_pr, _artifacts, etc.) WIN over
       // the on-disk record so we don't lose engine enrichment that lives
       // only on the in-memory pass. The full record contributes description,
       // acceptanceCriteria, and references back to the rendered shape.
-      var merged = Object.assign({}, full, cached, _wiModalHydratedFields);
+      var merged = Object.assign({}, full, cached);
+      merged.description = full.description || cached.description || '';
+      if (Array.isArray(full.acceptanceCriteria)) merged.acceptanceCriteria = full.acceptanceCriteria;
+      if (Array.isArray(full.references)) merged.references = full.references;
       // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; all user data wrapped in escapeHtml() or renderMd() by _wiRenderDetail() (fields: title, description, agent, source, reasons, references, artifacts, PR links)
       document.getElementById('modal-body').innerHTML = _wiRenderDetail(merged);
     })

package/engine/queries.js

@@ -789,12 +789,24 @@ let _skillsCacheKey = null;
 let _skillIndexCache = null;
 let _skillIndexCacheTs = 0;
 let _skillIndexCacheKey = null;
+// Top-level cache for getSkills (the read+parse + meta-build path layered on
+// top of collectSkillFiles). Without this, every /api/status slow-state
+// rebuild re-read and re-parsed all ~80 SKILL.md files (~29ms warm even
+// though collectSkillFiles itself was cached) because getSkills did the
+// I/O on the cached file list. Shares the same 30s TTL + cacheKey so an
+// invalidateSkillsCache() call still flushes everything.
+let _getSkillsResultCache = null;
+let _getSkillsResultCacheTs = 0;
+let _getSkillsResultCacheKey = null;
 const SKILLS_CACHE_TTL = 30000; // 30s — skill files change rarely (agent extraction, manual authoring)
 
 function invalidateSkillsCache() {
   _skillsCache = null;
   _skillsCacheTs = 0;
   _skillsCacheKey = null;
+  _getSkillsResultCache = null;
+  _getSkillsResultCacheTs = 0;
+  _getSkillsResultCacheKey = null;
   _skillIndexCache = null;
   _skillIndexCacheTs = 0;
   _skillIndexCacheKey = null;
@@ -906,6 +918,18 @@ const SKILL_SOURCE_BY_SCOPE = {
 };
 
 function getSkills(config) {
+  // Cache the entire read+parse round, not just the file list. /api/status
+  // slow-state calls getSkills on every rebuild and re-reading 80+ SKILL.md
+  // files + re-parsing their YAML frontmatter cost ~29ms each time (the
+  // single biggest hot-path offender after getPrdInfo cold). 30s TTL +
+  // shared cacheKey with collectSkillFiles so invalidateSkillsCache() still
+  // flushes everything in one shot.
+  const now = Date.now();
+  config = config || getConfig();
+  const cacheKey = _skillsCacheKeyFor(config, os.homedir());
+  if (_getSkillsResultCache && _getSkillsResultCacheKey === cacheKey && (now - _getSkillsResultCacheTs) < SKILLS_CACHE_TTL) {
+    return _getSkillsResultCache;
+  }
   const all = [];
   for (const { file: f, dir, scope, projectName, skillName } of collectSkillFiles(config)) {
     try {
@@ -923,6 +947,9 @@ function getSkills(config) {
       });
     } catch { /* optional */ }
   }
+  _getSkillsResultCache = all;
+  _getSkillsResultCacheTs = now;
+  _getSkillsResultCacheKey = cacheKey;
   return all;
 }
 
@@ -2143,8 +2170,34 @@ function resetProjectGitStatusCache() {
  * so a 5-project fleet runs 14 statSync calls per cache miss — bounded
  * and unmeasurable in benchmarks.
  */
+// Cache the slow-state path list: it only changes when projects are added/
+// removed or runtimes are registered/deregistered (essentially process-
+// lifetime stable in practice). Without it we walked runtime-registry +
+// projects + resolved per-project gitdir/commondir on every /api/status
+// rebuild — ~7.5ms per call. The fast-state list is cheaper (~2ms) but
+// we cache it too for symmetry. Cache key is keyed off the project list
+// shape so a new project (rare event, goes through configMutation +
+// invalidateStatusCache) invalidates correctly.
+let _fastMtimePathsCache = null;
+let _fastMtimePathsCacheKey = null;
+let _slowMtimePathsCache = null;
+let _slowMtimePathsCacheKey = null;
+function _mtimePathsCacheKey(config) {
+  const projects = getProjects(config).map(p => (p.name || '') + '|' + (p.localPath || ''));
+  return projects.join(';');
+}
+function _invalidateMtimePathsCache() {
+  _fastMtimePathsCache = null;
+  _fastMtimePathsCacheKey = null;
+  _slowMtimePathsCache = null;
+  _slowMtimePathsCacheKey = null;
+}
+
 function getStatusFastStateMtimePaths(config) {
-  const projects = getProjects(config || getConfig());
+  config = config || getConfig();
+  const cacheKey = _mtimePathsCacheKey(config);
+  if (_fastMtimePathsCache && _fastMtimePathsCacheKey === cacheKey) return _fastMtimePathsCache;
+  const projects = getProjects(config);
   const files = [
     // Engine-level state surfaced by getDispatchQueue. `control.json`,
     // `log.json`, and `metrics.json` are intentionally omitted — see the
@@ -2234,6 +2287,8 @@ function getStatusFastStateMtimePaths(config) {
       files.push(path.join(commonGitDir, 'FETCH_HEAD'));
     }
   }
+  _fastMtimePathsCache = files;
+  _fastMtimePathsCacheKey = cacheKey;
   return files;
 }
 
@@ -2307,6 +2362,8 @@ function getStatusFastStateMtimePaths(config) {
  */
 function getStatusSlowStateMtimePaths(config) {
   config = config || getConfig();
+  const cacheKey = _mtimePathsCacheKey(config);
+  if (_slowMtimePathsCache && _slowMtimePathsCacheKey === cacheKey) return _slowMtimePathsCache;
   const projects = getProjects(config);
   const homeDir = os.homedir();
   const files = [
@@ -2328,6 +2385,15 @@ function getStatusSlowStateMtimePaths(config) {
     // invalidateStatusCache({includeSlow:true}); tracker entry catches any
     // CLI/editor edit that bypasses the API.
     path.join(MINIONS_DIR, 'pinned.md'),
+    // work-items.json — central + per-project files (per-project pushed below
+    // alongside the PR paths). The PRD progress slice in slow-state is
+    // *derived* from work-item statuses via getPrdInfo's input-hash, so a
+    // WI flipping dispatched→done changes prdProgress without touching any
+    // file in this tracker. Without this entry the slow-state cache hangs
+    // on stale PRD progress for up to 60s after a WI completes (user
+    // report: visit /plans, see all items active; switch to /home + hard
+    // refresh; the WIs are done; return to /plans, now items show as done).
+    path.join(MINIONS_DIR, 'work-items.json'),
   ];
 
   // Skill discovery roots (surfaced by _buildStatusSlowState → getSkills).
@@ -2378,8 +2444,17 @@ function getStatusSlowStateMtimePaths(config) {
     const commonGitDir = _resolveCommonGitDir(gitDir);
     files.push(path.join(gitDir, 'logs', 'HEAD'));
     files.push(path.join(commonGitDir, 'FETCH_HEAD'));
+    // Per-project work-items.json + pull-requests.json — same reason as the
+    // central work-items.json above: the prdProgress slice is derived from
+    // their contents via getPrdInfo's input hash. A WI completion in a
+    // project that uses its own work-items.json file would otherwise hang
+    // slow-state until TTL.
+    try { files.push(projectWorkItemsPath(project)); } catch { /* path helper optional */ }
+    try { files.push(projectPrPath(project)); } catch { /* path helper optional */ }
   }
 
+  _slowMtimePathsCache = files;
+  _slowMtimePathsCacheKey = cacheKey;
   return files;
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2061",
+  "version": "0.1.2063",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"