@yemi33/minions 0.1.2058 → 0.1.2060

package/dashboard/js/modal.js

@@ -4,6 +4,11 @@ function closeModal() {
   const modalEl = document.querySelector('#modal .modal');
   if (modalEl) modalEl.classList.remove('modal-wide');
   document.getElementById('modal').classList.remove('open');
+  // Clear the WI-detail auto-refresh tracker so renderWorkItems stops
+  // rewriting #modal-body each tick. Safe to do unconditionally — if the
+  // closed modal wasn't a WI detail, these vars were already null.
+  if (typeof _wiModalOpenId !== 'undefined') { _wiModalOpenId = null; }
+  if (typeof _wiModalHydratedFields !== 'undefined') { _wiModalHydratedFields = null; }
   clearModalBackStack();
   // Hide Q&A section (only shown for document modals)
   document.getElementById('modal-qa').style.display = 'none';

package/dashboard/js/refresh.js

@@ -294,20 +294,38 @@ function _processStatusUpdate(data) {
   window._lastStatus = data;
 
 
-  // Render only changed sections
-  // Agents is exempt from the _changed gate: real-time status correctness on
-  // the Minions Members grid (status badge, running timer, Last-run line)
-  // beats the cost of re-rendering 5 cards every poll tick. The gate was
-  // causing visible staleness when the ref-eq / JSON-stringify short-circuit
-  // falsely matched across ticks (W-mpn7keq9000302c9). Still call _changed
-  // here so the _lastChangedFlags diag ring-buffer keeps recording whether
-  // the agents payload actually moved this tick.
+  // Render every section every tick (W-mpn7keq9000302c9 + this commit).
+  // Every `_changed(...)` GATE was producing the same class of bug —
+  // ref-equality or JSON.stringify short-circuit falsely matching across
+  // ticks, leaving the DOM frozen until the user did a hard refresh. The
+  // gates were a small CPU win at the cost of real-time correctness on
+  // every screen.
+  //
+  // We KEEP the `_changed(...)` CALLS (their side effect of populating
+  // `_lastChangedFlags` is still load-bearing for the diag ring-buffer
+  // and for the `_workItemsChanged` / `_prsChanged` cross-slice triggers
+  // below — F1 / F3 / W-mpgb0xbh000e3b86) but no longer use the return
+  // value to gate the render. Each renderer is a contained DOM rewrite
+  // (~ a few KB of HTML); ~10–20 of them per 4s tick is well under one
+  // frame's budget.
+  //
+  // Gates intentionally kept: none on the render path. The render-versions
+  // bump path (RENDER_VERSIONS map + _changed's stringify cache) is still
+  // useful for the diag flag, just not as a render skip.
   _changed('agents', data.agents);
   renderAgents(data.agents);
   cmdUpdateAgentList(data.agents);
-  if (_changed('prdProgress', data.prdProgress) || _changed('prdPrs', data.pullRequests?.length)) { renderPrdProgress(data.prdProgress); _cachePrdItems(data.prdProgress); }
-  if (_changed('inbox', data.inbox)) renderInbox(data.inbox || []);
-  if (_changed('projects', data.projects)) { cmdUpdateProjectList(data.projects || []); renderProjects(data.projects || []); }
+  // prdProgress + prdPrs are captured together so both flags publish to
+  // the diag buffer; the renderer + cachePrdItems run unconditionally.
+  _changed('prdProgress', data.prdProgress);
+  _changed('prdPrs', data.pullRequests?.length);
+  renderPrdProgress(data.prdProgress);
+  _cachePrdItems(data.prdProgress);
+  _changed('inbox', data.inbox);
+  renderInbox(data.inbox || []);
+  _changed('projects', data.projects);
+  cmdUpdateProjectList(data.projects || []);
+  renderProjects(data.projects || []);
   // FRE banner — safe to call every tick (idempotent + cheap). Pass the full
   // status payload so the runtime-CLI explainer reads autoMode.defaultCli from
   // THIS tick (window._lastStatus is hoisted above, but renderFre takes the
@@ -315,47 +333,55 @@ function _processStatusUpdate(data) {
   if (typeof renderFre === 'function') {
     try { renderFre(data); } catch { /* expected on first load */ }
   }
-  if (_changed('notes', data.notes)) renderNotes(data.notes);
-  if (_changed('prd', [data.prd, data.prdProgress])) renderPrd(data.prd, data.prdProgress);
+  _changed('notes', data.notes);
+  renderNotes(data.notes);
+  _changed('prd', [data.prd, data.prdProgress]);
+  renderPrd(data.prd, data.prdProgress);
   // Capture prs + workItems change signals once — also reused by the cross-slice
   // render triggers at the bottom of this function (F1/F3, W-mpgb0xbh000e3b86).
   // _changed mutates _sectionCache so it must be called exactly once per key.
   var _prsChanged = _changed('prs', data.pullRequests);
   var _workItemsChanged = _changed('workItems', data.workItems);
-  if (_prsChanged) renderPrs(data.pullRequests || []);
-  if (_changed('archivedPrds', data.archivedPrds)) renderArchiveButtons(data.archivedPrds || []);
-  if (_changed('engine', data.engine)) {
-    if (data.engine) renderEngineStatus(data.engine);
-    var qs = document.getElementById('engine-quick-stats');
-    if (qs && data.engine) {
-      var wt = data.engine.worktreeCount != null ? data.engine.worktreeCount : '-';
-      var pid = data.engine.pid || '-';
-      // W-mpnc4u8c001d9d6c — replace the dead "Tick: -" chip (control.json
-      // never carried a `tick` field) with a live "Next tick in Xs" countdown
-      // driven by engine.lastTickAt (stamped at the start of every tickInner)
-      // and engine.tickInterval (config, surfaced in the status payload).
-      // _updateNextTickChip below ticks the inner span every 1s without
-      // re-rendering this whole row.
-      _engineCountdown.lastTickAt = Number(data.engine.lastTickAt) || 0;
-      _engineCountdown.tickInterval = Number(data.engine.tickInterval) || 0;
-      _engineCountdown.engineState = data.engine.state || 'stopped';
-      // Feed the cadence ring buffer so the overshoot label can surface the
-      // observed tick-to-tick gap (W-mpodheao0006a37a).
-      _recordEngineTickObservation(_engineCountdown.lastTickAt);
-      // eslint-disable-next-line no-unsanitized/property -- reason: composed from internal engine metrics (pid, lastTickAt/tickInterval, worktreeCount) and a literal id; no user data flows in
-      qs.innerHTML = '<span>PID: <b>' + pid + '</b></span>' +
-        '<span>Next tick in: <b id="engine-next-tick">' + _formatNextTickText() + '</b></span>' +
-        '<span>Worktrees: <b>' + wt + '</b></span>';
-      _startNextTickTicker();
-    }
+  renderPrs(data.pullRequests || []);
+  _changed('archivedPrds', data.archivedPrds);
+  renderArchiveButtons(data.archivedPrds || []);
+  _changed('engine', data.engine);
+  if (data.engine) renderEngineStatus(data.engine);
+  var qs = document.getElementById('engine-quick-stats');
+  if (qs && data.engine) {
+    var wt = data.engine.worktreeCount != null ? data.engine.worktreeCount : '-';
+    var pid = data.engine.pid || '-';
+    // W-mpnc4u8c001d9d6c — replace the dead "Tick: -" chip (control.json
+    // never carried a `tick` field) with a live "Next tick in Xs" countdown
+    // driven by engine.lastTickAt (stamped at the start of every tickInner)
+    // and engine.tickInterval (config, surfaced in the status payload).
+    // _updateNextTickChip below ticks the inner span every 1s without
+    // re-rendering this whole row.
+    _engineCountdown.lastTickAt = Number(data.engine.lastTickAt) || 0;
+    _engineCountdown.tickInterval = Number(data.engine.tickInterval) || 0;
+    _engineCountdown.engineState = data.engine.state || 'stopped';
+    // Feed the cadence ring buffer so the overshoot label can surface the
+    // observed tick-to-tick gap (W-mpodheao0006a37a).
+    _recordEngineTickObservation(_engineCountdown.lastTickAt);
+    // eslint-disable-next-line no-unsanitized/property -- reason: composed from internal engine metrics (pid, lastTickAt/tickInterval, worktreeCount) and a literal id; no user data flows in
+    qs.innerHTML = '<span>PID: <b>' + pid + '</b></span>' +
+      '<span>Next tick in: <b id="engine-next-tick">' + _formatNextTickText() + '</b></span>' +
+      '<span>Worktrees: <b>' + wt + '</b></span>';
+    _startNextTickTicker();
   }
-  if (_changed('version', data.version)) renderVersionBanner(data.version);
-  if (_changed('adoThrottle', data.adoThrottle)) renderAdoThrottleAlert(data.adoThrottle);
-  if (_changed('ghThrottle', data.ghThrottle)) renderGhThrottleAlert(data.ghThrottle);
-  if (_changed('dispatch', data.dispatch)) renderDispatch(data.dispatch);
+  _changed('version', data.version);
+  renderVersionBanner(data.version);
+  _changed('adoThrottle', data.adoThrottle);
+  renderAdoThrottleAlert(data.adoThrottle);
+  _changed('ghThrottle', data.ghThrottle);
+  renderGhThrottleAlert(data.ghThrottle);
+  _changed('dispatch', data.dispatch);
+  renderDispatch(data.dispatch);
   prunePrdRequeueState(window._lastWorkItems);
-  if (_changed('engineLog', data.engineLog)) renderEngineLog(data.engineLog || []);
-  if (_changed('metrics', data.metrics)) renderMetrics(data.metrics || {});
+  _changed('engineLog', data.engineLog);
+  renderEngineLog(data.engineLog || []);
+  _changed('metrics', data.metrics);
+  renderMetrics(data.metrics || {});
   // managed-processes panel — ETag-gated so unchanged ticks return 304 with
   // no body (P-6e2a8b13). Sequenced BEFORE the keep-processes call below via
   // .then() so the keep renderer reads a populated managed-PID cache for
@@ -374,14 +400,21 @@ function _processStatusUpdate(data) {
       .catch(function () { /* keep render even if managed fetch failed — getLastItems() returns the last good cache (or []) */ })
       .then(function () { try { renderKeepProcesses(); } catch {} });
   }
-  if (_workItemsChanged) renderWorkItems(data.workItems || []);
-  if (_changed('skills', data.skills)) renderSkills(data.skills || []);
-  if (_changed('mcpServers', data.mcpServers)) renderMcpServers(data.mcpServers || []);
-  if (_changed('schedules', data.schedules)) renderSchedules(data.schedules || []);
-  if (_changed('watches', data.watches)) renderWatches(data.watches || []);
-  if (_changed('meetings', data.meetings)) renderMeetings(data.meetings || []);
-  if (_changed('pipelines', data.pipelines) && typeof renderPipelines === 'function') renderPipelines(data.pipelines || []);
-  if (_changed('pinned', data.pinned)) renderPinned(data.pinned || []);
+  renderWorkItems(data.workItems || []);
+  _changed('skills', data.skills);
+  renderSkills(data.skills || []);
+  _changed('mcpServers', data.mcpServers);
+  renderMcpServers(data.mcpServers || []);
+  _changed('schedules', data.schedules);
+  renderSchedules(data.schedules || []);
+  _changed('watches', data.watches);
+  renderWatches(data.watches || []);
+  _changed('meetings', data.meetings);
+  renderMeetings(data.meetings || []);
+  _changed('pipelines', data.pipelines);
+  if (typeof renderPipelines === 'function') renderPipelines(data.pipelines || []);
+  _changed('pinned', data.pinned);
+  renderPinned(data.pinned || []);
   // Sidebar counts (cheap)
   const swi = document.getElementById('sidebar-wi');
   if (swi) swi.textContent = (data.workItems || []).length || '';

package/dashboard/js/render-work-items.js

@@ -4,6 +4,18 @@ let allWorkItems = [];
 let wiPage = 0;
 const WI_PER_PAGE = 20;
 
+// Track open WI detail modal so renderWorkItems can re-render its body
+// every poll tick. Without this the modal stays frozen on the snapshot
+// from the moment it was opened — status flips / agent assignments /
+// PR link arrival are invisible until the user closes + reopens or
+// hard-refreshes. Mirrors the same fix that drove the section-render
+// gate sweep (8ad48509 / W-mpn7keq9000302c9). `_wiModalHydratedFields`
+// caches the heavy free-text fields (description, acceptanceCriteria,
+// references) loaded once by openWorkItemDetail's GET /api/work-items/<id>
+// hydration call so per-tick re-renders don't lose them.
+let _wiModalOpenId = null;
+let _wiModalHydratedFields = null;
+
 // Track retry state per work item so loading/success/error survives re-renders
 const _wiRetryState = {}; // { [id]: { status: 'pending'|'done'|'error', message?, until? } }
 function setWiRetryState(id, state) { _wiRetryState[id] = state; }
@@ -155,6 +167,27 @@ function renderWorkItems(items) {
     const newWrap = el.querySelector('.pr-table-wrap');
     if (newWrap) newWrap.scrollLeft = savedScroll;
   }
+  // Refresh the open WI detail modal in-place so its status badge,
+  // agent assignment, PR link, etc. reflect the latest /api/status slice.
+  // The heavy free-text fields (description, AC, references) live in
+  // `_wiModalHydratedFields` from the one-time GET /api/work-items/<id>
+  // hydration and survive across these re-renders.
+  if (_wiModalOpenId) {
+    const slim = items.find(i => i.id === _wiModalOpenId);
+    if (slim) {
+      const merged = Object.assign({}, _wiModalHydratedFields || {}, slim);
+      const body = document.getElementById('modal-body');
+      if (body) {
+        // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; all user data wrapped in escapeHtml() or renderMd() by _wiRenderDetail()
+        body.innerHTML = _wiRenderDetail(merged);
+      }
+      const title = document.getElementById('modal-title');
+      if (title) title.textContent = slim.title || slim.id;
+    }
+    // If the WI dropped out of the slim slice (deleted/archived), leave
+    // the modal as-is — the user will close it normally; we don't want
+    // to auto-dismiss in case they're still reading.
+  }
 }
 
 async function editWorkItem(id, source) {
@@ -649,6 +682,15 @@ function openWorkItemDetail(id) {
     (cached.referencesCount > 0 && !Array.isArray(cached.references));
 
   const initial = needsHydration ? Object.assign({}, cached, { _descriptionLoading: true }) : cached;
+  // Track which WI's modal is open so renderWorkItems can re-render the
+  // modal body each poll tick. Reset the hydrated cache; openWorkItemDetail
+  // is the only authoritative source of the heavy free-text fields.
+  _wiModalOpenId = id;
+  _wiModalHydratedFields = needsHydration ? null : {
+    description: cached.description,
+    acceptanceCriteria: Array.isArray(cached.acceptanceCriteria) ? cached.acceptanceCriteria : undefined,
+    references: Array.isArray(cached.references) ? cached.references : undefined,
+  };
   document.getElementById('modal-title').textContent = initial.title || initial.id;
   // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; all user data wrapped in escapeHtml() or renderMd() by _wiRenderDetail() (fields: title, description, agent, source, reasons, references, artifacts, PR links)
   document.getElementById('modal-body').innerHTML = _wiRenderDetail(initial);
@@ -662,18 +704,22 @@ function openWorkItemDetail(id) {
     .then(function(r) { if (!r.ok) throw new Error('HTTP ' + r.status); return r.json(); })
     .then(function(data) {
       // Guard against modal navigation away from this WI during the fetch.
-      var title = document.getElementById('modal-title');
-      if (!title || title.textContent !== (initial.title || initial.id)) return;
+      if (_wiModalOpenId !== id) return;
       var full = data && data.item;
       if (!full) return;
+      // Cache the heavy free-text fields so per-tick re-renders preserve
+      // them. We keep them separate from the slim slice (which renderWorkItems
+      // refreshes on every tick).
+      _wiModalHydratedFields = {
+        description: full.description || cached.description || '',
+        acceptanceCriteria: Array.isArray(full.acceptanceCriteria) ? full.acceptanceCriteria : undefined,
+        references: Array.isArray(full.references) ? full.references : undefined,
+      };
       // Merge: cached cross-slice fields (_pr, _artifacts, etc.) WIN over
       // the on-disk record so we don't lose engine enrichment that lives
       // only on the in-memory pass. The full record contributes description,
       // acceptanceCriteria, and references back to the rendered shape.
-      var merged = Object.assign({}, full, cached);
-      merged.description = full.description || cached.description || '';
-      if (Array.isArray(full.acceptanceCriteria)) merged.acceptanceCriteria = full.acceptanceCriteria;
-      if (Array.isArray(full.references)) merged.references = full.references;
+      var merged = Object.assign({}, full, cached, _wiModalHydratedFields);
       // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; all user data wrapped in escapeHtml() or renderMd() by _wiRenderDetail() (fields: title, description, agent, source, reasons, references, artifacts, PR links)
       document.getElementById('modal-body').innerHTML = _wiRenderDetail(merged);
     })

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2058",
+  "version": "0.1.2060",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"