@yemi33/minions 0.1.2054 → 0.1.2056

package/dashboard/js/refresh.js

@@ -73,7 +73,7 @@ const RENDER_VERSIONS = {
   prd: 1,
   prs: 2,
   archivedPrds: 1,
-  engine: 3,
+  engine: 4,
   version: 1,
   adoThrottle: 1,
   ghThrottle: 1,
@@ -147,18 +147,57 @@ function _formatCcDrawerLabel(autoMode) {
   return runtimeLabel + (model ? ' (' + model + ')' : '') + '-powered. Full minions context. Enter to send, Shift+Enter for newline.';
 }
 
-// W-mpnc4u8c001d9d6c — #engine-quick-stats "Next tick in Xs" countdown.
+// W-mpnc4u8c001d9d6c / W-mpodheao0006a37a — #engine-quick-stats "Next tick in"
+// countdown.
 //
 // Origin is engine.lastTickAt (stamped by tickInner at the start of every
 // tick, see engine.js) plus engine.tickInterval (server-side config, surfaced
 // via _buildStatusFastState). The chip updates every 1s without re-rendering
 // the surrounding row — mirrors the _tickAgentRuntimes pattern in
-// dashboard/js/render-agents.js. The countdown clamps at 0 and shows "due"
-// when the engine is mid-tick (PR polls etc. can push tick-to-tick wall time
-// past the nominal interval). When the engine isn't running, show "—" so a
-// stale lastTickAt doesn't render a ticking countdown the engine can't honor.
+// dashboard/js/render-agents.js.
+//
+// Cadence semantics (W-mpodheao0006a37a): tickInterval is the MINIMUM gap
+// between tick starts (engine.js#cli sets `setInterval(() => e.tick(), interval)`
+// and engine.tick() short-circuits if a previous tick is still running). Slow
+// ticks (PR polls, reconcilers) delay the next slot, so actual tick-to-tick
+// gaps can exceed tickInterval. Once the countdown crosses zero the chip
+// shows "running" (not "due" — the old label implied the engine was overdue,
+// which lies about the floor-not-ceiling semantics). When we have ≥3
+// observed deltas in _engineCadenceDeltas, the running label is augmented
+// with the observed median cadence: "running (~Ns cadence)".
+//
+// When the engine isn't running, show "—" so a stale lastTickAt doesn't
+// render a ticking countdown the engine can't honor.
 var _engineCountdown = { lastTickAt: 0, tickInterval: 0, engineState: 'stopped' };
 var _engineNextTickTimer = null;
+// Ring buffer of the most recent observed tick-to-tick deltas (ms). Updated
+// inside _processStatusUpdate whenever data.engine.lastTickAt advances. Used
+// by _formatNextTickText to surface an observed cadence in the overshoot
+// path. Capped at _engineCadenceMax entries (FIFO) so the median stays
+// representative of recent behavior.
+var _engineCadenceDeltas = [];
+var _engineCadenceMax = 5;
+var _engineCadenceLastSeenTickAt = 0;
+
+function _recordEngineTickObservation(lastTickAt) {
+  if (!lastTickAt) return;
+  if (!_engineCadenceLastSeenTickAt) {
+    _engineCadenceLastSeenTickAt = lastTickAt;
+    return;
+  }
+  if (lastTickAt <= _engineCadenceLastSeenTickAt) return;
+  var delta = lastTickAt - _engineCadenceLastSeenTickAt;
+  _engineCadenceLastSeenTickAt = lastTickAt;
+  _engineCadenceDeltas.push(delta);
+  if (_engineCadenceDeltas.length > _engineCadenceMax) _engineCadenceDeltas.shift();
+}
+
+function _medianCadenceMs() {
+  if (_engineCadenceDeltas.length < 3) return 0;
+  var sorted = _engineCadenceDeltas.slice().sort(function(a, b) { return a - b; });
+  var mid = Math.floor(sorted.length / 2);
+  return sorted.length % 2 ? sorted[mid] : Math.round((sorted[mid - 1] + sorted[mid]) / 2);
+}
 
 function _formatNextTickText() {
   var state = _engineCountdown.engineState;
@@ -167,8 +206,11 @@ function _formatNextTickText() {
   var interval = _engineCountdown.tickInterval;
   if (!last || !interval) return '—';
   var remainingMs = last + interval - Date.now();
-  if (remainingMs <= 0) return 'due';
-  return Math.ceil(remainingMs / 1000) + 's';
+  if (remainingMs > 0) return Math.ceil(remainingMs / 1000) + 's';
+  if (state !== 'running') return '—';
+  var medianMs = _medianCadenceMs();
+  if (medianMs > 0) return 'running (~' + Math.round(medianMs / 1000) + 's cadence)';
+  return 'running';
 }
 
 function _updateNextTickChip() {
@@ -297,6 +339,9 @@ function _processStatusUpdate(data) {
       _engineCountdown.lastTickAt = Number(data.engine.lastTickAt) || 0;
       _engineCountdown.tickInterval = Number(data.engine.tickInterval) || 0;
       _engineCountdown.engineState = data.engine.state || 'stopped';
+      // Feed the cadence ring buffer so the overshoot label can surface the
+      // observed tick-to-tick gap (W-mpodheao0006a37a).
+      _recordEngineTickObservation(_engineCountdown.lastTickAt);
       // eslint-disable-next-line no-unsanitized/property -- reason: composed from internal engine metrics (pid, lastTickAt/tickInterval, worktreeCount) and a literal id; no user data flows in
       qs.innerHTML = '<span>PID: <b>' + pid + '</b></span>' +
         '<span>Next tick in: <b id="engine-next-tick">' + _formatNextTickText() + '</b></span>' +
@@ -693,6 +738,21 @@ async function refresh() {
 
 refresh();
 _syncPinsFromServer(); // Load server-side pins on startup
+// W-mpmwxkrw000872ec — reconcile the font-size preference from the server
+// once on cold load. The inline bootstrap in layout.html has already applied
+// localStorage's value (if any) to avoid flash; this fetch promotes the
+// server value when it differs (e.g. fresh browser, different machine).
+(function _reconcileFontSizeFromServer() {
+  fetch('/api/settings').then(function(r) { return r.ok ? r.json() : null; }).then(function(data) {
+    if (!data || !data.engine) return;
+    var serverValue = data.engine.fontSize || 'small';
+    var localValue = 'small';
+    try { localValue = localStorage.getItem('minions:font-size') || 'small'; } catch (e) { /* private mode */ }
+    if (serverValue !== localValue && typeof window.applyFontSizePreference === 'function') {
+      window.applyFontSizePreference(serverValue);
+    }
+  }).catch(function() { /* offline / 4xx — keep localStorage value */ });
+})();
 
 // Poll for status updates (SSE caused HTTP/1.1 connection exhaustion — CC fetch would fail)
 setInterval(refresh, 4000);

package/dashboard/js/settings.js

@@ -1,5 +1,17 @@
 // settings.js — Settings panel functions extracted from dashboard.html
 
+// W-mpmwxkrw000872ec — single source of truth for applying the font-size
+// preference at runtime. Mirrors the inline bootstrap script in
+// layout.html (which runs before this file loads). Exposed on window so the
+// refresh.js reconciler can call it after the first /api/settings fetch.
+const FONT_SIZE_VALUES = ['small', 'medium', 'large', 'xlarge'];
+function applyFontSizePreference(value) {
+  const v = FONT_SIZE_VALUES.includes(value) ? value : 'small';
+  try { document.documentElement.setAttribute('data-font-size', v); } catch (e) { /* no DOM */ }
+  try { localStorage.setItem('minions:font-size', v); } catch (e) { /* private mode / disabled */ }
+}
+try { window.applyFontSizePreference = applyFontSizePreference; } catch (e) { /* non-browser */ }
+
 let _settingsData = null;
 // Async runtime/model discovery can resolve out of order when the operator
 // flips between runtimes quickly. Without a per-target token, a slower Copilot
@@ -166,6 +178,29 @@ async function openSettings() {
       settingsField('Eval Max Cost', 'set-evalMaxCost', e.evalMaxCost === null || e.evalMaxCost === undefined ? '' : e.evalMaxCost, '$', 'USD ceiling per work item across all eval iterations (blank = no limit)') +
     '</div>';
 
+  // W-mpmwxkrw000872ec — Appearance pane. Hosts dashboard-wide visual
+  // preferences (font-size scale today; reserved for future theme picks).
+  // Kept narrow + featured near the rail top so the setting is discoverable
+  // rather than buried under generic Engine headers.
+  const paneAppearance =
+    '<h3>Appearance</h3>' +
+    '<div class="settings-pane-sub">Dashboard-wide visual preferences. Persisted in browser localStorage + server-side settings so they survive a reload from a cold cache.</div>' +
+    '<div class="settings-grid-2">' +
+      '<div data-search="font size scale appearance dashboard">' +
+        '<label style="font-size:10px;color:var(--muted);display:block;margin-bottom:2px">Font Size</label>' +
+        '<select id="set-fontSize" style="width:100%;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--text);font-size:12px">' +
+          (function() {
+            var current = (e.fontSize || 'small');
+            var opts = [['small', 'Small (current default)'], ['medium', 'Medium'], ['large', 'Large'], ['xlarge', 'Extra Large']];
+            return opts.map(function(o) {
+              return '<option value="' + o[0] + '"' + (current === o[0] ? ' selected' : '') + '>' + o[1] + '</option>';
+            }).join('');
+          })() +
+        '</select>' +
+        '<div style="font-size:9px;color:var(--muted);margin-top:1px">Scales the whole dashboard. Persisted in browser + server.</div>' +
+      '</div>' +
+    '</div>';
+
   const projectsHtml = (data.projects || []).map(function(p) {
     // Cross-reference live /api/status to pull in the auto-detected
     // remoteDefaultBranch (read-only) — settings already has localPath +
@@ -230,7 +265,7 @@ async function openSettings() {
     '<div class="settings-pane-sub">How many agents run at once and how long they get before being killed for silence or runaway duration.</div>' +
     '<div class="settings-grid-2">' +
       settingsField('Max Concurrent Agents', 'set-maxConcurrent', e.maxConcurrent || 5, '', 'Max agents working simultaneously') +
-      settingsField('Tick Interval', 'set-tickInterval', e.tickInterval || 60000, 'ms', 'How often the engine runs discovery + dispatch') +
+      settingsField('Min Tick Interval', 'set-tickInterval', e.tickInterval || 60000, 'ms', 'Minimum gap between tick starts. Slow ticks (PR polls, reconcilers) may delay the next slot — see `running` indicator on /engine.') +
       settingsField('Agent Timeout', 'set-agentTimeout', e.agentTimeout || 18000000, 'ms', 'Kill agent after this duration') +
       settingsField('Heartbeat Timeout', 'set-heartbeatTimeout', e.heartbeatTimeout || 300000, 'ms', 'No output = dead after this') +
       settingsField('Idle Alert', 'set-idleAlertMinutes', e.idleAlertMinutes || 15, 'min', 'Alert after agent idle this long') +
@@ -378,6 +413,7 @@ async function openSettings() {
   const sections = [
     { id: 'runtime', label: 'Runtime & Models', featured: true, html: paneRuntime },
     { id: 'autofix', label: 'Auto-fix & Review Loop', featured: true, html: paneAutoFix },
+    { id: 'appearance', label: 'Appearance', html: paneAppearance },
     { id: 'projects', label: 'Projects', html: paneProjects },
     { id: 'polling', label: 'Polling', html: panePolling },
     { id: 'concurrency', label: 'Concurrency & Timeouts', html: paneConcurrency },
@@ -848,6 +884,9 @@ async function saveSettings() {
       copilotReasoningSummaries: !!document.getElementById('set-copilotReasoningSummaries')?.checked,
       maxBudgetUsd: (document.getElementById('set-maxBudgetUsd')?.value ?? '').trim(),
       disableModelDiscovery: !!document.getElementById('set-disableModelDiscovery')?.checked,
+      // W-mpmwxkrw000872ec — global font-size scale. Allowlist validation
+      // (and clamp messaging) lives server-side in handleSettingsUpdate.
+      fontSize: document.getElementById('set-fontSize')?.value || 'small',
       maxTurnsByType: (function() {
         var mbt = {};
         var types = ['explore', 'ask', 'review', 'implement', 'fix', 'test', 'verify', 'plan', 'decompose'];
@@ -912,6 +951,10 @@ async function saveSettings() {
       status.style.color = 'var(--green)';
       showToast('cmd-toast', 'Settings saved', true);
     }
+    // W-mpmwxkrw000872ec — apply font-size immediately + persist to
+    // localStorage so a hard reload still reflects the new pick (server is
+    // the cold-load authority; localStorage is the no-flash fast path).
+    try { applyFontSizePreference(enginePayload.fontSize); } catch (err) { /* tolerated — change shows on next reload */ }
     if (saveBtn) { saveBtn.innerHTML = '<svg width="12" height="12" viewBox="0 0 16 16" fill="currentColor"><path d="M13.78 4.22a.75.75 0 010 1.06l-7.25 7.25a.75.75 0 01-1.06 0L2.22 9.28a.75.75 0 011.06-1.06L6 10.94l6.72-6.72a.75.75 0 011.06 0z"/></svg> Saved'; saveBtn.style.color = 'var(--green)'; saveBtn.style.borderColor = 'var(--green)'; }
     setTimeout(function() {
       if (saveBtn) { saveBtn.disabled = false; saveBtn.style.opacity = ''; saveBtn.innerHTML = '<svg width="12" height="12" viewBox="0 0 16 16" fill="currentColor"><path d="M13.78 4.22a.75.75 0 010 1.06l-7.25 7.25a.75.75 0 01-1.06 0L2.22 9.28a.75.75 0 011.06-1.06L6 10.94l6.72-6.72a.75.75 0 011.06 0z"/></svg> Save'; }

package/dashboard/layout.html

@@ -5,6 +5,19 @@
 <meta name="viewport" content="width=device-width, initial-scale=1.0">
 <title>Minions Mission Control{{title_suffix}}</title>
 <link rel="icon" href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 100 100'><text y='.9em' font-size='90'>{{favicon_emoji}}</text></svg>">
+<script>
+  // W-mpmwxkrw000872ec — apply the saved font-size BEFORE the stylesheet
+  // parses so the first paint already reflects the user's preference (no
+  // flash of unstyled font size). localStorage is the fast path; the server
+  // value is reconciled later in refresh.js's first tick.
+  (function() {
+    try {
+      var v = localStorage.getItem('minions:font-size');
+      var valid = { small: 1, medium: 1, large: 1, xlarge: 1 };
+      document.documentElement.setAttribute('data-font-size', (v && valid[v]) ? v : 'small');
+    } catch (e) { /* private mode / disabled storage — fall through to default */ }
+  })();
+</script>
 <style>/* __CSS__ */</style>
 </head>
 <body>

package/dashboard/styles.css

@@ -1,4 +1,12 @@
   :root {
+    /* W-mpmwxkrw000872ec — global dashboard font-size scale. Driven by
+       [data-font-size] on <html>. 'small' is the historic default (1.0) so
+       existing users see no change. Body-level CSS `zoom` is the cheapest
+       way to scale every px/em/rem rule across the SPA (typography tokens
+       below, slim.html, and the many inline `font-size:11px` styles) without
+       rewriting every rule. Scales modals, drawers, and fixed-position
+       elements because they all live inside <body>. */
+    --minions-font-scale: 1;
     --bg: #0d1117; --surface: #161b22; --surface2: #21262d; --border: #30363d;
     --text: #e6edf3; --muted: #8b949e; --green: #3fb950; --yellow: #d29922;
     --blue: #58a6ff; --purple: #bc8cff; --red: #f85149; --orange: #e3b341;
@@ -23,9 +31,17 @@
     /* Transitions */
     --transition-fast: 0.15s; --transition-base: 0.2s; --transition-slow: 0.3s;
   }
+  /* W-mpmwxkrw000872ec — font-size scale overrides. Values picked so the
+     largest tier (~1.30) tops out near 18px effective for the default 14px
+     body without overflowing chips/badges/tables at /, /pull-requests, /qa,
+     /settings (spot-checked). */
+  :root[data-font-size="small"]  { --minions-font-scale: 1; }
+  :root[data-font-size="medium"] { --minions-font-scale: 1.08; }
+  :root[data-font-size="large"]  { --minions-font-scale: 1.18; }
+  :root[data-font-size="xlarge"] { --minions-font-scale: 1.30; }
   * { box-sizing: border-box; margin: 0; padding: 0; }
   html, body { height: 100%; margin: 0; overflow: hidden; }
-  body { background: var(--bg); color: var(--text); font-family: 'Segoe UI', system-ui, sans-serif; font-size: var(--text-xl); display: flex; flex-direction: column; }
+  body { background: var(--bg); color: var(--text); font-family: 'Segoe UI', system-ui, sans-serif; font-size: var(--text-xl); display: flex; flex-direction: column; zoom: var(--minions-font-scale, 1); }
 
   header {
     background: var(--surface); border-bottom: 1px solid var(--border);
@@ -730,8 +746,6 @@
   .settings-rail-btn { display: flex; align-items: center; justify-content: space-between; width: 100%; padding: var(--space-3) var(--space-6); background: transparent; border: none; border-left: 3px solid transparent; color: var(--muted); font-size: var(--text-md); font-weight: 400; font-family: inherit; cursor: pointer; text-align: left; transition: all var(--transition-fast); }
   .settings-rail-btn:hover { color: var(--text); background: var(--surface); }
   .settings-rail-btn.active { color: var(--blue); border-left-color: var(--blue); background: var(--surface); font-weight: 600; }
-  .settings-rail-btn.featured { color: var(--text); }
-  .settings-rail-btn.featured.active { color: var(--blue); }
   .settings-rail-btn.no-match { opacity: 0.3; }
   .settings-rail-btn .match-count { font-size: var(--text-xs); color: var(--blue); background: var(--bg); border-radius: var(--radius-xl); padding: 1px 6px; min-width: 18px; text-align: center; }
   .settings-content { flex: 1; overflow-y: auto; padding: var(--space-7) var(--space-8); min-width: 0; }

package/dashboard.js

@@ -9100,6 +9100,15 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           else if (valid.includes(e.copilotStreamMode)) _setEngineConfig('copilotStreamMode', e.copilotStreamMode);
           else _clamped.push(`copilotStreamMode: "${e.copilotStreamMode}" not in [on, off] (kept previous value)`);
         }
+        // W-mpmwxkrw000872ec — fontSize allowlist. Clamps invalid values
+        // (rather than silently failing) so the dashboard bootstrap never
+        // ends up with an unknown data-font-size attribute.
+        if (e.fontSize !== undefined) {
+          const valid = ['small', 'medium', 'large', 'xlarge'];
+          if (_isClear(e.fontSize)) _deleteEngineConfig('fontSize');
+          else if (valid.includes(e.fontSize)) _setEngineConfig('fontSize', e.fontSize);
+          else _clamped.push(`fontSize: "${e.fontSize}" not in [${valid.join(', ')}] (kept previous value)`);
+        }
         // maxBudgetUsd uses ?? semantics — 0 is a valid cap (read-only / dry-run agents).
         if (e.maxBudgetUsd !== undefined) {
           if (_isClear(e.maxBudgetUsd)) _deleteEngineConfig('maxBudgetUsd');

package/engine/lifecycle.js

@@ -2067,6 +2067,90 @@ function updatePrAfterFix(pr, project, source, options = {}, legacyDispatchId =
       delete next.fixedAt;
       target.minionsReview = next;
     };
+    // W-mpoeirqx0007712a — Build-fix push verification. The agent may report
+    // SUCCESS while the git push silently failed to advance the remote head
+    // (stale-worktree push rejected non-fast-forward, agent ignores non-zero
+    // `git push` exit, etc). detectPrFixBranchChange falls back to
+    // local-head / worktree-diff evidence in those scenarios and returns
+    // `changed: true` even though origin/<branch> never moved. Without a
+    // guard here, the optimistic stamp + 10-min buildFixGracePeriod
+    // suppresses re-dispatch against a still-failing build that was never
+    // actually fixed (live repro: opg-microsoft/minions PR #57).
+    //
+    // Only `evidence: 'remote-head'` proves the push landed. For
+    // BUILD_FAILURE with changed=true AND evidence explicitly set to one of
+    // the unverified types, increment `_buildFixPushFailedCount`, write an
+    // inbox alert, route through recordPrNoOpFixAttempt so the cause stays
+    // unhandled, and never write `_buildFixPushedAt`. When the counter
+    // reaches `engine.maxBuildFixRetries`, flip `_buildFixNeedsHumanRebase`
+    // so the engine stops retrying.
+    //
+    // Note: callers that omit `branchChange.evidence` (legacy / tests
+    // predating evidence plumbing) still hit the trusted-push path below to
+    // preserve backward compatibility — only the explicitly unverified
+    // evidence kinds trigger this guard.
+    const _unverifiedPushEvidence = new Set(['local-head', 'worktree-diff']);
+    if (cause === shared.PR_FIX_CAUSE.BUILD_FAILURE
+        && explicitlyChangedBranch
+        && options.branchChange?.changed === true
+        && _unverifiedPushEvidence.has(options.branchChange?.evidence)) {
+      const maxRetries = options.config?.engine?.maxBuildFixRetries
+        ?? ENGINE_DEFAULTS.maxBuildFixRetries;
+      target._buildFixPushFailedCount = (Number(target._buildFixPushFailedCount) || 0) + 1;
+      const reachedCap = target._buildFixPushFailedCount >= maxRetries;
+      if (reachedCap) {
+        target._buildFixNeedsHumanRebase = ts();
+      }
+      const beforeHeadStr = String(options.branchChange?.beforeHead || '').slice(0, 40);
+      const afterHeadStr = String(options.branchChange?.afterHead || '').slice(0, 40);
+      const evidenceStr = String(options.branchChange?.evidence || 'unknown');
+      try {
+        const wiId = options.dispatchItem?.meta?.item?.id || null;
+        const noteBody = `# Build-fix push not verified for ${pr.id}\n\n`
+          + `**PR:** ${pr.url || pr.id}\n`
+          + `**Branch:** ${pr.branch || '(unknown)'}\n`
+          + `**Cause:** build-failure\n`
+          + `**Pre-dispatch head:** ${beforeHeadStr || '(unknown)'}\n`
+          + `**Post-completion head (live):** ${afterHeadStr || '(unknown)'}\n`
+          + `**Branch-change evidence:** ${evidenceStr}\n`
+          + `**Attempt:** ${target._buildFixPushFailedCount}/${maxRetries}\n\n`
+          + (reachedCap
+              ? `⚠️ **Reached \`engine.maxBuildFixRetries\` (${maxRetries}).** PR flagged \`_buildFixNeedsHumanRebase\` — engine will stop auto-retrying. Likely root cause: worktree stale vs origin/master, push rejected non-fast-forward, or branch protection blocks the engine identity.\n`
+              : `_Engine will re-dispatch on the next \`discoverFromPrs\` pass (counter < cap)._\n`)
+          + `\nThe agent reported SUCCESS but the remote head did not advance — the optimistic \`_buildFixPushedAt\` stamp was suppressed to avoid the ${(ENGINE_DEFAULTS.buildFixGracePeriod / 60000) | 0}-minute grace-period blackout.\n`;
+        shared.writeToInbox(
+          'engine',
+          `build-fix-push-unverified-${pr.prNumber || pr.id}`,
+          noteBody,
+          null,
+          { wi: wiId, pr: pr.id, cause: shared.PR_FIX_CAUSE.BUILD_FAILURE }
+        );
+      } catch (err) {
+        log('warn', `build-fix push-verify inbox alert for ${pr.id}: ${err.message}`);
+      }
+      // Route through the noop path so the cause stays unhandled, the noop
+      // counter advances symmetrically with the genuine-noop case, and the
+      // existing `delete target._buildFixPushedAt` cleanup (line ~2016) runs.
+      const verifyBranchChange = {
+        changed: false,
+        beforeHead: options.branchChange?.beforeHead,
+        afterHead: options.branchChange?.afterHead,
+        evidence: 'push-unverified',
+      };
+      const noopReason = `build-fix push unverified (evidence: ${evidenceStr}); attempt ${target._buildFixPushFailedCount}/${maxRetries}${reachedCap ? ' — needs-human-rebase' : ''}`;
+      const record = recordPrNoOpFixAttempt(target, cause, source, options.dispatchItem, verifyBranchChange, options.config, noopReason);
+      result = {
+        noOp: true,
+        cause,
+        paused: !!record.paused,
+        count: record.count,
+        pushUnverified: true,
+        pushFailedCount: target._buildFixPushFailedCount,
+        needsHumanRebase: reachedCap,
+      };
+      log('warn', `Updated ${pr.id} → build-fix push unverified (${target._buildFixPushFailedCount}/${maxRetries}, evidence=${evidenceStr})${reachedCap ? ' [needs-human-rebase]' : ''}; remote head ${beforeHeadStr.slice(0, 8)} did not advance — inbox alert written, cause left unhandled for re-dispatch`);
+      return prs;
+    }
     if (explicitlyChangedBranch && options.branchChange?.changed === false) {
       const record = recordPrNoOpFixAttempt(target, cause, source, options.dispatchItem, options.branchChange, options.config, options.noopReason);
       result = { noOp: true, cause, paused: !!record.paused, count: record.count };
@@ -2086,6 +2170,19 @@ function updatePrAfterFix(pr, project, source, options = {}, legacyDispatchId =
       return prs;
     }
     clearPrNoOpFixAttempt(target, cause);
+    // W-mpoeirqx0007712a — verified-push stamping for BUILD_FAILURE. Reaching
+    // this point with explicitlyChangedBranch=true means the unverified-push
+    // guard above did NOT trigger, so either evidence === 'remote-head'
+    // (live remote refs prove the branch advanced) OR no branchChange info
+    // was supplied (legacy callers that didn't pass branchChange — keep
+    // existing behavior of trusting the agent's branchChanged claim).
+    // Clear the push-failure counter on confirmed success so future
+    // regressions start fresh.
+    if (cause === shared.PR_FIX_CAUSE.BUILD_FAILURE && explicitlyChangedBranch) {
+      target._buildFixPushedAt = ts();
+      delete target._buildFixPushFailedCount;
+      delete target._buildFixNeedsHumanRebase;
+    }
     if (source === 'pr-human-feedback') {
       const clearPendingFix = shouldClearHumanFeedbackPendingFix(target, pr, automationCauseKey);
       if (target.humanFeedback && clearPendingFix) target.humanFeedback.pendingFix = false;

package/engine/shared.js

@@ -1800,7 +1800,15 @@ const ENGINE_DEFAULTS = {
   logBufferSize: 50, // flush immediately when buffer exceeds this many entries
   lockRetries: 0, // no retries — single 5s timeout window with 25ms polling (200 attempts) is sufficient; stale lock recovery at 60s handles crashes
   lockRetryBackoffMs: 500, // base backoff between lock retries (doubles each attempt: 500ms, 1s, 2s, ...)
-  buildFixGracePeriod: 600000, // 10min — wait for CI to run after build fix before re-dispatching
+  buildFixGracePeriod: 600000, // 10min — wait for CI to run after a verified build-fix push before re-dispatching
+  // W-mpoeirqx0007712a: cap re-dispatch attempts when build-fix pushes
+  // silently fail to advance the remote head (stale-worktree push rejected,
+  // agent ignores non-zero git push exit and reports SUCCESS, etc).
+  // updatePrAfterFix increments `_buildFixPushFailedCount` whenever the
+  // post-completion branchChange has non-remote-head evidence; when the
+  // counter reaches this cap, the PR is flagged `_buildFixNeedsHumanRebase`
+  // so the dispatcher stops auto-retrying and a human can rescue the branch.
+  maxBuildFixRetries: 3,
   adoPollEnabled: true, // poll ADO PR status, comments, and reconciliation on each tick cycle
   ghPollEnabled: true, // poll GitHub PR status, comments, and reconciliation on each tick cycle
   prPollStatusEvery: 12,   // poll PR build/review/merge status every N ticks for both ADO and GitHub (~12 min at default interval)
@@ -1870,6 +1878,13 @@ const ENGINE_DEFAULTS = {
   ccUseWorkerPool: false,            // Sub-task C of W-mp2w003600196c51 (CC perf): when true AND CC runtime is copilot, _invokeCcStream routes through engine/cc-worker-pool.js (persistent `copilot --acp` per CC tab) instead of spawning a fresh CLI per turn. Off by default — opt-in feature flag. **Structurally copilot-only**: the pool spawns `copilot --acp` (Agent Client Protocol); Claude Code does not implement ACP, so resolveCcUseWorkerPool returns false on non-copilot CC runtimes even with explicit-true (W-mphlriic00095f69 — prevents silent runtime switch). Engine/agent dispatch path stays per-process regardless.
   maxBudgetUsd: undefined,       // fleet USD ceiling for --max-budget-usd (per-agent override: agents.<id>.maxBudgetUsd). Honors 0 via ?? so a literal cap of $0 works
   disableModelDiscovery: false,  // skip runtime.listModels() REST calls fleet-wide (settings UI falls back to free-text)
+  // W-mpmwxkrw000872ec — dashboard global font-size scale. Drives the
+  // [data-font-size] attribute on <html> via the inline bootstrap script in
+  // layout.html (localStorage fast path) and is reconciled from the server
+  // value on cold loads. Valid: 'small' (current default), 'medium', 'large',
+  // 'xlarge'. Allowlist validation lives in handleSettingsUpdate so invalid
+  // values are clamped rather than silently breaking the bootstrap.
+  fontSize: 'small',
   maxPendingContexts: 20, // cap pendingContexts arrays in cooldowns.json to prevent unbounded growth
   maxPendingContextEntryBytes: 256 * 1024, // 256 KB — cap each pendingContexts entry to prevent huge PR comments from bloating cooldowns.json
   maxDispatchPromptBytes: 1024 * 1024, // 1 MB — dispatch items with prompts larger than this sidecar to engine/contexts/ to prevent dispatch.json OOM (#1167)

package/engine.js

@@ -4929,15 +4929,16 @@ async function discoverFromPrs(config, project) {
       }, `Fix build failure on ${pr.id}: ${pr.title || ''}`, { dispatchKey: key, cooldownKey: key, automationCauseKey: buildCauseKey, source: 'pr', pr, branch: prBranch, project: projMeta });
       if (item) {
         newWork.push(item); fixDispatched = true;
-        try {
-          const prPath = projectPrPath(project);
-          mutatePullRequests(prPath, prs => {
-            const target = shared.findPrRecord(prs, pr, project);
-            if (target) {
-              target._buildFixPushedAt = ts();
-            }
-          });
-        } catch (e) { log('warn', 'mark build fix dispatched: ' + e.message); }
+        // W-mpoeirqx0007712a — DO NOT stamp `_buildFixPushedAt` at dispatch
+        // time. The optimistic stamp here used to suppress re-dispatch for
+        // the buildFixGracePeriod window even when the agent never pushed
+        // (stale-worktree push silently rejected, agent reported SUCCESS
+        // anyway). `_buildFixPushedAt` is now written only by
+        // lifecycle.updatePrAfterFix after the post-completion branchChange
+        // confirms the remote head actually advanced (evidence ===
+        // 'remote-head'). In-flight dispatches are already deduplicated by
+        // `isPrAutomationCausePending` + `isAlreadyDispatched` above, so no
+        // race window opens by removing the optimistic stamp.
       }
 
       if (pr.agent && !pr._buildFailNotified) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2054",
+  "version": "0.1.2056",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"