@yemi33/minions 0.1.2049 → 0.1.2051

package/dashboard/js/detail-panel.js

@@ -97,6 +97,7 @@ function renderDetailContent(detail, tab) {
     // eslint-disable-next-line no-unsanitized/property -- reason: composed from internal server timestamp and static live-chat controls (no user data flows in)
     el.innerHTML =
       '<div id="live-chat" style="display:flex;flex-direction:column;height:60vh">' +
+        '<div id="live-terminal-banner"></div>' +
         '<div id="live-messages" style="flex:1;overflow-y:auto;padding:8px;font-size:11px;line-height:1.6;display:flex;flex-direction:column"></div>' +
         '<div id="live-status-bar" style="padding:4px 8px;display:flex;align-items:center;gap:8px;border-top:1px solid var(--border)">' +
           '<span class="pulse"></span><span id="live-status-label" style="font-size:11px;color:var(--green)">Streaming live</span>' +

package/dashboard/js/live-stream.js

@@ -2,6 +2,7 @@
 
 let livePollingInterval = null;
 let liveEventSource = null;
+let liveTerminalSource = null;
 let _steerInFlight = false;
 let _lastRenderedText = '';
 let _runtimeTimer = null;
@@ -45,13 +46,54 @@ function startLiveStream(agentId) {
   if (msgEl) msgEl.innerHTML = '';
   _lastRenderedText = '';
 
+  // W-mpob4nyk0006580e — clear any stale banner from a previous agent.
+  const bannerEl = document.getElementById('live-terminal-banner');
+  if (bannerEl) bannerEl.innerHTML = '';
+
   // Start runtime counter
   _updateRuntimeCounter();
   _runtimeTimer = setInterval(_updateRuntimeCounter, 1000);
 
-  // Use polling instead of SSE to avoid HTTP/1.1 connection exhaustion
-  // (SSE holds a persistent connection, blocking CC and other API calls)
+  // Use polling for log content (avoids HTTP/1.1 connection exhaustion that
+  // a full SSE log stream would cause — see W-mpob4nyk0006580e note below).
   startLivePolling();
+
+  // W-mpob4nyk0006580e — terminal banner is driven by the engine's
+  // `dispatch.terminal` SSE event, NOT by parsing the JSONL log tail.
+  // The /live-stream endpoint multiplexes log frames (default `data:`
+  // messages) and terminal events (named `event: dispatch.terminal`); we
+  // open the SSE connection but only consume the terminal event. The
+  // stream stays mostly idle (one event per dispatch lifecycle), so this
+  // does not regress the connection-exhaustion fix that switched log
+  // tailing to polling.
+  startTerminalEventSource(agentId);
+}
+
+function startTerminalEventSource(agentId) {
+  if (typeof window.EventSource !== 'function') return;
+  try {
+    liveTerminalSource = new EventSource('/api/agent/' + encodeURIComponent(agentId) + '/live-stream?tail=0');
+  } catch (e) { console.error('terminal-event source open:', e.message); return; }
+  liveTerminalSource.addEventListener('dispatch.terminal', function(ev) {
+    let payload;
+    try { payload = JSON.parse(ev.data); } catch { return; }
+    renderTerminalBannerForAgent(agentId, payload);
+  });
+  // Ignore default `data:` log frames — log content arrives via polling.
+  liveTerminalSource.onerror = function() {
+    // EventSource auto-reconnects; nothing to do.
+  };
+}
+
+function renderTerminalBannerForAgent(agentId, payload) {
+  // Guard against late-arriving events for a previous agent (tab switch race).
+  if (typeof currentAgentId !== 'undefined' && currentAgentId !== agentId) return;
+  if (typeof currentTab !== 'undefined' && currentTab !== 'live') return;
+  const bannerEl = document.getElementById('live-terminal-banner');
+  if (!bannerEl) return;
+  const html = renderTerminalBanner(payload);
+  // eslint-disable-next-line no-unsanitized/property -- reason: renderTerminalBanner() escapes all user-controlled fields (summary, reason, prUrl) before assembling HTML (see dashboard/js/render-utils.js)
+  bannerEl.innerHTML = html;
 }
 
 function stopLiveStream() {
@@ -59,6 +101,10 @@ function stopLiveStream() {
     liveEventSource.close();
     liveEventSource = null;
   }
+  if (liveTerminalSource) {
+    try { liveTerminalSource.close(); } catch { /* optional */ }
+    liveTerminalSource = null;
+  }
   if (_runtimeTimer) { clearInterval(_runtimeTimer); _runtimeTimer = null; }
   stopLivePolling();
 }
@@ -169,4 +215,4 @@ async function sendSteering() {
   }
 }
 
-window.MinionsLive = { renderLiveChatMessage, startLiveStream, stopLiveStream, startLivePolling, stopLivePolling, refreshLiveOutput, sendSteering };
+window.MinionsLive = { renderLiveChatMessage, renderTerminalBannerForAgent, startLiveStream, stopLiveStream, startLivePolling, stopLivePolling, refreshLiveOutput, sendSteering };

package/dashboard/js/modal.js

@@ -7,6 +7,10 @@ function closeModal() {
   clearModalBackStack();
   // Hide Q&A section (only shown for document modals)
   document.getElementById('modal-qa').style.display = 'none';
+  // Remove settings-body marker so the next modal opens with the default
+  // monospace/pre-wrap modal-body styling rather than inheriting the Segoe-UI
+  // tabbed-settings overrides (W-mpmwxkcn000646cc).
+  document.getElementById('modal-body').classList.remove('settings-body');
   // Remove settings buttons if present
   const settingsBtn = document.getElementById('modal-settings-save');
   if (settingsBtn) settingsBtn.remove();

package/dashboard/js/refresh.js

@@ -89,6 +89,11 @@ const RENDER_VERSIONS = {
   pipelines: 1,
   pinned: 1,
   kbPayload: 2,
+  // settings is a modal-driven section, not a tick-driven render — but the
+  // cache-bust entry exists so future tick-driven code (or feature-flag-aware
+  // renderers) can call `_changed('settings', …)` and bump on visual revamps.
+  // Bumped to 2 by W-mpmwxkcn000646cc (left-rail tabbed Settings layout).
+  settings: 2,
 };
 const _sectionCache = {};
 const _lastValueByKey = {};

package/dashboard/js/render-utils.js

@@ -189,19 +189,15 @@ function _renderJsonObj(obj, state) {
   }
 
   if (obj.type === 'result') {
-    // Banner is gated on TWO conditions: (a) this is the LAST result line in the output,
-    // and (b) the [process-exit] sentinel has been seen. Intermediate result lines from
-    // ScheduleWakeup resume cycles fall through and render nothing.
-    if (state.isFinalResult) {
-      var subtype = typeof obj.subtype === 'string' ? obj.subtype : '';
-      var resultIsError = obj.is_error === true || subtype.startsWith('error');
-      var exitFailed = state.exitInfo && state.exitInfo.success === false;
-      if (resultIsError || exitFailed) {
-        parts.push('<div style="background:rgba(248,81,73,0.1);border:1px solid var(--red);padding:8px 12px;border-radius:8px;margin:8px 0;font-size:12px;color:var(--red)">\u2717 Task ended with error</div>');
-      } else {
-        parts.push('<div style="background:rgba(63,185,80,0.1);border:1px solid var(--green);padding:8px 12px;border-radius:8px;margin:8px 0;font-size:12px;color:var(--green)">\u2713 Task complete</div>');
-      }
-    }
+    // W-mpob4nyk0006580e — the terminal banner is no longer derived here.
+    // The engine's dispatch.result is the single source of truth and is
+    // pushed to the live view via the SSE `dispatch.terminal` channel
+    // (engine/dispatch-events.js → dashboard.js handleAgentLiveStream).
+    // `result` JSONL lines and the `[process-exit]` sentinel are still
+    // parsed for other purposes (e.g. tool deltas above), but they must
+    // NOT trigger any banner here — log heuristics can disagree with the
+    // engine verdict (CLI crash AFTER successful completion report, exit-0
+    // with no result line, timeout kill, …). See renderTerminalBanner().
   }
 
   return parts.join('');
@@ -237,46 +233,12 @@ function renderAgentOutput(text) {
     }
   }
 
-  // ── Pre-scan ──────────────────────────────────────────────────────────────
-  // ScheduleWakeup-based polling agents emit one `"type":"result"` JSONL line
-  // per resume cycle, followed by another resume — only the LAST result line
-  // before spawn-agent.js writes its `[process-exit]` sentinel is the true
-  // final result. Intermediate result lines must NOT trigger the banner.
-  //
-  // spawn-agent.js writes:
-  //   "\n[process-exit] code=N\n"        on normal close (engine/spawn-agent.js:202)
-  //   "\n[process-exit] spawn-failed\n"  on synchronous spawn() throw
-  //
-  // We pre-scan to find: (1) whether [process-exit] was emitted at all, (2) its
-  // exit code (success vs failure), and (3) the line index of the last result
-  // strictly before that sentinel.
-  var exitInfo = null; // null = process still running (no banner ever fires)
-  var exitLineIdx = -1;
-  var lastResultLineIdx = -1;
-  var exitRe = /^\[process-exit\]\s+(?:code=)?(-?\d+|spawn-failed)\s*$/;
-  for (var k = 0; k < lines.length; k++) {
-    var t = lines[k].trim();
-    if (!t) continue;
-    var em = exitRe.exec(t);
-    if (em) {
-      var token = em[1];
-      var code = token === 'spawn-failed' ? -1 : parseInt(token, 10);
-      exitInfo = { code: code, success: code === 0 };
-      exitLineIdx = k;
-    }
-  }
-
-  if (exitLineIdx !== -1) {
-    for (var r = 0; r < exitLineIdx; r++) {
-      var rt = lines[r].trim();
-      if (!rt || rt.charCodeAt(0) !== 123 /* '{' */) continue;
-      try {
-        var probe = JSON.parse(rt);
-        if (probe && probe.type === 'result') lastResultLineIdx = r;
-      } catch (e) { /* ignore parse errors during scan */ }
-    }
-  }
-  state.exitInfo = exitInfo;
+  // W-mpob4nyk0006580e — pre-scan removed. Previously we found the final
+  // `"type":"result"` line + `[process-exit]` sentinel to gate a terminal
+  // banner here, but the terminal banner is now pushed from the engine via
+  // the `dispatch.terminal` SSE channel (see renderTerminalBanner()). The
+  // log lines below are still parsed for tool calls / assistant text /
+  // reasoning deltas — only the banner-gating heuristic is gone.
 
   for (var i = 0; i < lines.length; i++) {
     var trimmed = lines[i].trim();
@@ -304,26 +266,24 @@ function renderAgentOutput(text) {
       continue;
     }
 
-    // JSON array line — never holds the canonical result, banner never fires here
+    // JSON array line
     if (trimmed.startsWith('[')) {
       try {
         var arr = JSON.parse(trimmed);
         if (Array.isArray(arr)) {
-          state.isFinalResult = false;
           for (var j = 0; j < arr.length; j++) fragments.push(_renderJsonObj(arr[j], state));
           continue;
         }
       } catch (e) { /* fall through */ }
     }
 
-    // JSON object line — banner fires only when this is the final result AND process exited
+    // JSON object line
     if (trimmed.startsWith('{')) {
       try {
         var obj = JSON.parse(trimmed);
         if (obj.type !== 'assistant.message_delta' && obj.type !== 'assistant.reasoning' && obj.type !== 'assistant.reasoning_delta' && obj.type !== 'assistant.message') {
           flushCopilotPending();
         }
-        state.isFinalResult = (i === lastResultLineIdx) && (exitInfo !== null);
         fragments.push(_renderJsonObj(obj, state));
         continue;
       } catch (e) { /* fall through */ }
@@ -342,16 +302,57 @@ function renderAgentOutput(text) {
 
   flushCopilotPending();
 
-  // Fallback error banner: process exited with non-zero code but never emitted
-  // a `"type":"result"` line (CLI crashed before producing one). Without this,
-  // the user would see only stderr noise with no terminal-state indicator.
-  if (exitInfo && !exitInfo.success && lastResultLineIdx === -1) {
-    fragments.push('<div style="background:rgba(248,81,73,0.1);border:1px solid var(--red);padding:8px 12px;border-radius:8px;margin:8px 0;font-size:12px;color:var(--red)">✗ Task ended with error</div>');
-  }
-
+  // W-mpob4nyk0006580e — no log-derived banner here either. The fallback
+  // "exit non-zero with no result line" branch used to render a red banner
+  // for crashes mid-write; that case is now covered by the engine's
+  // `dispatch.result` (set by completeDispatch and pushed via the SSE
+  // `dispatch.terminal` channel — see renderTerminalBanner()). Removing
+  // this branch is what makes the live view banner agree with the agent
+  // row's status in cases like exit-1 AFTER a success completion report.
   return fragments.join('');
 }
 
+/**
+ * W-mpob4nyk0006580e — render the terminal banner from an authoritative
+ * `dispatch.terminal` SSE event. The shape mirrors
+ * engine/dispatch-events.js buildTerminalEvent():
+ *   { type, ts, dispatchId, agentId, result, reason, failureClass, prUrl, summary }
+ *
+ * The banner state mirrors `dispatch.result` exactly — green for SUCCESS,
+ * red otherwise. Optional reason / failure class / PR link / summary first
+ * line are surfaced as secondary context.
+ *
+ * Returns HTML for a single banner div. Callers replace the banner
+ * container's innerHTML on each event.
+ */
+function renderTerminalBanner(event) {
+  if (!event || !event.result) return '';
+  var isSuccess = event.result === 'success';
+  var color = isSuccess ? 'var(--green)' : 'var(--red)';
+  var bg = isSuccess ? 'rgba(63,185,80,0.1)' : 'rgba(248,81,73,0.1)';
+  var glyph = isSuccess ? '\u2713' : '\u2717';
+  var headline;
+  if (isSuccess) {
+    headline = glyph + ' Task complete';
+  } else {
+    // 'error' / 'timeout' / anything-else → use reason word from the engine
+    var reasonWord = event.result === 'timeout' ? 'timeout' : (event.failureClass || 'error');
+    headline = glyph + ' Task ended with ' + escHtml(String(reasonWord));
+  }
+  var extra = '';
+  if (event.summary) extra += '<div style="font-size:11px;margin-top:4px;opacity:0.9">' + escHtml(event.summary) + '</div>';
+  if (event.reason && event.reason !== event.summary) {
+    extra += '<div style="font-size:10px;margin-top:2px;opacity:0.75">' + escHtml(event.reason) + '</div>';
+  }
+  if (event.prUrl) {
+    var safeUrl = encodeURI(String(event.prUrl));
+    extra += '<div style="font-size:11px;margin-top:4px"><a href="' + escHtml(safeUrl) + '" target="_blank" rel="noopener" style="color:' + color + '">' + escHtml(event.prUrl) + '</a></div>';
+  }
+  return '<div style="background:' + bg + ';border:1px solid ' + color + ';padding:8px 12px;border-radius:8px;margin:8px 0;font-size:12px;color:' + color + '">' +
+    headline + extra +
+    '</div>';
+}
+
 /**
  * Standard "Prev / Next" pager HTML for a paginated list. Used by inbox, KB,
  * completed dispatches, and engine log. The caller is responsible for the
@@ -404,4 +405,4 @@ function pinButton(pinKey, pinned, source, opts) {
     (pinned ? 'Unpin' : 'Pin') + '</button>';
 }
 
-window.MinionsRenderUtils = { formatToolSummary, renderAgentOutput, renderPager, pinButton };
+window.MinionsRenderUtils = { formatToolSummary, renderAgentOutput, renderTerminalBanner, renderPager, pinButton };