@yemi33/minions 0.1.2047 → 0.1.2049

package/engine/queries.js

@@ -531,6 +531,11 @@ function getAgents(config) {
     // → engine.defaultCli → 'copilot'. Surfaced so the dashboard can show a
     // runtime tag next to the agent name.
     const runtime = shared.resolveAgentCli(a, config.engine || {});
+    // Resolve the model alongside the runtime so the dashboard can render a
+    // sibling chip (W-mpmwxk4y00053271). `resolveAgentModel` returns
+    // `undefined` when neither the per-agent override nor `engine.defaultModel`
+    // is set, which the renderer treats as "runtime default" and omits.
+    const model = shared.resolveAgentModel(a, config.engine || {}) || null;
     const inboxFiles = allInboxFiles.filter(f => f.includes(a.id));
     let steeringInboxFiles = [];
     try { steeringInboxFiles = steering.listUnreadSteeringMessages(a.id); } catch { steeringInboxFiles = []; }
@@ -552,7 +557,7 @@ function getAgents(config) {
     const chartered = fs.existsSync(path.join(AGENTS_DIR, a.id, 'charter.md'));
     if (lastAction.length > 120) lastAction = lastAction.slice(0, 120) + '...';
     return {
-      ...a, runtime, status: s.status, lastAction,
+      ...a, runtime, model, status: s.status, lastAction,
       currentTask: (s.task || '').slice(0, 200),
       // P-w2c8d1e7 — Phase 1.2: surface the active dispatch id so watch
       // captureState can snapshot it for currentDispatchId-aware predicates.
@@ -1236,8 +1241,16 @@ function getWorkItems(config) {
       }
     }
     if (!item._pr) {
-      // Derive from PR.prdItems (single source of truth)
-      const linkedPr = allPrs.find(p => (p.prdItems || []).includes(item.id));
+      // Derive from PR.prdItems (single source of truth), then fall back to
+      // branch identity. The branch fallback heals decomposed-child WIs whose
+      // PR-opening agent only stamped the parent id into prdItems — branch
+      // names (`work/<wi-id>`) are unique per WI within a project, so a
+      // branch hit is as authoritative as a prdItems hit. Scoped to the same
+      // project so cross-repo branch collisions don't false-link.
+      // (W-mpn0b76200044eed)
+      const itemProject = item.project || item._source;
+      const linkedPr = allPrs.find(p => (p.prdItems || []).includes(item.id))
+        || (item.branch && allPrs.find(p => p.branch === item.branch && p._project === itemProject));
       if (linkedPr) {
         item._pr = linkedPr.id;
         item._prUrl = linkedPr.url;
@@ -1925,6 +1938,10 @@ function getProjectGitStatus(localPath, configuredMainBranch = null) {
   const key = _projectGitStatusCacheKey(localPath, configuredMainBranch);
   const now = Date.now();
   const cached = _projectGitStatusCache.get(key);
+  // Compute ref-mtime freshness once. Used twice below: to gate the TTL
+  // fast-path AND to decide whether the stale-while-revalidate return
+  // should null out the known-stale ahead/behind counters (#2848).
+  const refsAdvanced = !!(cached && _projectGitRefsAdvancedSince(localPath, configuredMainBranch, cached.refMtimes));
   // Within TTL: short-circuit ONLY when no tracked git ref has advanced
   // past cached.ts. Without the mtime gate, a freshly-pulled repo serves
   // the pre-pull ahead/behind counts for up to 15s + one SPA poll (~19s
@@ -1939,7 +1956,7 @@ function getProjectGitStatus(localPath, configuredMainBranch = null) {
   if (cachedIsMissing && fs.existsSync(localPath)) {
     // Path came back — fall through to schedule a fresh probe.
   } else if (cached && cached.ts && (now - cached.ts) < PROJECT_GIT_STATUS_TTL
-      && !_projectGitRefsAdvancedSince(localPath, configuredMainBranch, cached.refMtimes)) {
+      && !refsAdvanced) {
     return cached.value;
   }
   // Cheap synchronous existsSync — short-circuits a path that just disappeared
@@ -1955,7 +1972,22 @@ function getProjectGitStatus(localPath, configuredMainBranch = null) {
   // previous value (or pending placeholder on the very first call). The next
   // /api/status response after the refresh settles will have fresh data.
   _scheduleProjectGitStatusRefresh(localPath, key, configuredMainBranch);
-  return cached ? cached.value : PROJECT_GIT_STATUS_PENDING;
+  if (!cached) return PROJECT_GIT_STATUS_PENDING;
+  // When tracked git refs have advanced past the cached snapshot, the
+  // cached ahead/behind counts are known to be stale (e.g. user just ran
+  // `git pull` / `git fetch` and the local checkout is now current).
+  // Returning the cached value as-is would briefly display a misleading
+  // "behind: 8" after the user has already pulled to current — see
+  // yemi33/minions#2848. Null those specific counters so the dashboard
+  // shows a pending state for ahead/behind until the background probe
+  // settles; branch and dirty flags stay valid enough on the cached
+  // value (and update on the next poll once the probe lands). TTL-expiry
+  // fall-throughs (refsAdvanced=false) still return the prior counters
+  // because nothing local has actually changed there.
+  if (refsAdvanced) {
+    return { ...cached.value, ahead: null, behind: null };
+  }
+  return cached.value;
 }
 
 // Force a refresh now and wait for completion. Called from dashboard boot

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2047",
+  "version": "0.1.2049",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"
@@ -23,7 +23,8 @@
     "test:perf": "node test/perf/managed-spawn-load.test.js",
     "test:e2e:accept": "node test/playwright/accept-baseline.js",
     "test:e2e:accept-force": "node test/playwright/accept-baseline.js --force",
-    "test:setup": "npx playwright install chromium"
+    "test:setup": "npx playwright install chromium",
+    "lint": "eslint dashboard/"
   },
   "keywords": [
     "ai",
@@ -65,7 +66,9 @@
     "@azure-devops/mcp": "2.7.0"
   },
   "devDependencies": {
-    "@playwright/test": "^1.58.2"
+    "@playwright/test": "^1.58.2",
+    "eslint": "^9.39.4",
+    "eslint-plugin-no-unsanitized": "^4.1.5"
   },
   "publishConfig": {
     "access": "public"

package/playbooks/fix.md

@@ -93,11 +93,21 @@ Do NOT remove the worktree — the engine handles cleanup automatically.
 
 ## Resolve Review Comments
 
-After pushing, respond to each review comment/thread:
-- **If you fixed it**: Reply confirming the fix, then resolve the thread
-- **If the comment was invalid, stale, already addressed, out of scope, or harmful**: Reply with the evidence-backed rationale explaining why no code change was made — leave the thread open for the reviewer to decide
-- **GitHub**: Reply to each review comment, resolve conversations you've fixed
-- **ADO**: Use `az` CLI first to reply to each thread and update status when supported; use ADO MCP only as a fallback when `az` is unavailable or insufficient. Set status to `fixed` or `closed` for fixes; leave `active` for rationale replies
+After pushing, respond to each review comment/thread. **Every disposition requires a reply before you resolve, close, or mark-fixed the thread — no exceptions.** Resolving a thread silently is a process violation (see "Resolving Review Threads — No Silent Closures" in `shared-rules.md`).
+
+Pick the disposition that matches the finding and post the matching reply, then act on the thread:
+
+- **Fixed** → Reply confirming the fix with commit SHA or `file:line` of the change, then resolve the thread.
+- **Satisfied elsewhere** (addressed by another chunk / sibling PR / existing wiring the reviewer missed) → Reply citing the exact PR number, commit SHA, or `file:line` that satisfies it, then resolve. Example: `Satisfied by chunk 6 (PR 5216079) — ArtifactsMainScreen.kt:305 re-fires start() via LaunchedEffect on every screen enter.`
+- **Deferred** (non-blocking nit you accept but choose not to act on now) → Reply starting with `Deferred:` and a one-line reason, then resolve. Example: `Deferred: default-off rollout switch makes this acceptable for v1; revisit if telemetry shows otherwise.`
+- **Tracked as follow-up** → Reply with `Tracked as follow-up: W-…` and the WI link, then resolve (see `## Follow-up Dispatch` below).
+- **Won't fix / disagree** (comment is invalid, stale, already addressed, out of scope, or harmful) → Reply with the evidence-backed rationale explaining why no code change was made. Leave the thread **active** for the reviewer to decide; do NOT resolve unilaterally.
+
+Host-specific mechanics:
+- **GitHub**: Reply to each review comment, then resolve the conversation for the four resolve-eligible dispositions above. Leave Won't-fix threads unresolved.
+- **ADO**: Use `az` CLI first to reply to each thread and update status when supported; use ADO MCP only as a fallback when `az` is unavailable or insufficient. Set status to `fixed` for Fixed/Satisfied-elsewhere/Tracked-as-follow-up and `closed` for Deferred; leave `active` for Won't-fix rationale replies.
+
+Hard rule: never resolve, close, or mark-fixed a thread without first posting a reply that explains the disposition. The chunk-5 / Caleb-Tseng / MaiLibraryViewModel thread (ADO 5215549 thread 65692221) is the canonical bad example — closed silently with no audit trail.
 
 ## Follow-up Dispatch
 

package/playbooks/shared-rules.md

@@ -140,6 +140,35 @@ Concretely:
 - If you skipped local validation, say so in the completion JSON (e.g. `tests: skipped — relying on PR pipeline`) and still exit.
 - Holding a slot to watch a pipeline is wasted capacity; the engine has its own pipeline-monitoring path.
 
+## Resolving Review Threads — No Silent Closures
+
+Whenever you resolve, close, or mark-fixed any PR review thread (GitHub
+conversation or ADO thread), you MUST first post a reply on that thread
+explaining the disposition. This is non-negotiable across every playbook
+(`fix`, `review`, `implement`, follow-up dispatch, anything that touches
+a review thread).
+
+Allowed dispositions and what the reply MUST contain:
+- **Fixed** → reply with commit SHA or file:line of the change, then resolve.
+- **Satisfied elsewhere** (addressed by another chunk / sibling PR / existing
+  wiring the reviewer missed) → reply citing the exact PR number, commit
+  SHA, or `file:line` that satisfies it, then resolve. Example:
+  `Satisfied by chunk 6 (PR 5216079) — ArtifactsMainScreen.kt:305
+  re-fires start() via LaunchedEffect on every screen enter.`
+- **Deferred** (non-blocking nit you accept but choose not to act on now)
+  → reply starting with `Deferred:` and a one-line reason, then resolve.
+  Example: `Deferred: default-off rollout switch makes this acceptable
+  for v1; revisit if telemetry shows otherwise.`
+- **Tracked as follow-up** → reply with `Tracked as follow-up: W-…` and
+  the WI link, then resolve (see follow-up dispatch template).
+- **Won't fix / disagree** → reply with the evidence-backed rationale;
+  leave the thread **active** for the reviewer to decide. Do NOT resolve
+  unilaterally.
+
+Hard rule: resolving a thread with no reply comment is a process violation.
+The chunk-5 / Caleb-Tseng / MaiLibraryViewModel thread (ADO 5215549 thread
+65692221) is the canonical bad example — closed silently with no audit trail.
+
 {{#github_shared_rules}}
 ## Checking PR and Build Status