@yemi33/minions 0.1.2039 → 0.1.2040

package/dashboard/js/settings.js

@@ -98,7 +98,7 @@ async function openSettings() {
       settingsToggle('Allow Temp Agents', 'set-allowTempAgents', !!e.allowTempAgents, 'Spawn ephemeral agents when all permanent agents are busy') +
       settingsToggle('Auto-archive Plans', 'set-autoArchive', !!e.autoArchive, 'Automatically archive plans after verify completes (off = manual archive via dashboard)') +
       settingsToggle('Auto-complete PRs', 'set-autoCompletePrs', !!e.autoCompletePrs, 'Auto-merge PRs when builds pass and review is approved (opt-in)') +
-      settingsToggle('CC Worker Pool', 'set-ccUseWorkerPool', (e.ccUseWorkerPool === undefined ? ((e.ccCli || e.defaultCli) === 'copilot') : !!e.ccUseWorkerPool), 'Route Command Center / doc-chat through a persistent copilot --acp worker per tab instead of spawning a fresh CLI per turn. Default ON for copilot runtime (cold-spawn is ~20s on Windows); default OFF for claude.') +
+      settingsToggle('CC Worker Pool', 'set-ccUseWorkerPool', (e.ccUseWorkerPool === undefined ? ((e.ccCli || e.defaultCli) === 'copilot') : !!e.ccUseWorkerPool), 'Route Command Center / doc-chat through a persistent copilot --acp worker per tab instead of spawning a fresh CLI per turn. Copilot-only (Agent Client Protocol transport); Claude does not implement ACP, so this toggle has no effect when CC runtime is Claude. Default ON for copilot (cold-spawn ~20s on Windows); forced OFF for non-copilot CC runtimes regardless of this toggle.') +
     '</div>' +
 
     '<h3 style="font-size:13px;color:var(--blue);margin-bottom:8px">PR Polling &amp; Dispatch Gates</h3>' +

package/engine/features.js

@@ -35,14 +35,23 @@ const FEATURES = {
   // ccUseWorkerPool — sub-tasks B/C/D of W-mp2w003600196c51 (CC perf).
   // Routes Command Center / doc-chat through engine/cc-worker-pool.js
   // (persistent `copilot --acp` per CC tab) instead of spawning a fresh CLI
-  // per turn. Saves ~14 s of cold-start cost. Copilot-only — the pool drives
-  // ACP which Claude does not implement.
+  // per turn. Saves ~14 s of cold-start cost.
+  //
+  // **Copilot-only — structural, not just a UX preference.** The pool's
+  // transport is Agent Client Protocol (JSON-RPC over stdin/stdout, framed
+  // initialize → session/new → session/prompt → session/update). Claude Code
+  // has no equivalent `--acp` mode; its only session-reuse path is
+  // per-invocation `--resume <id>` against `~/.claude/projects/<dir>/<id>.jsonl`.
+  // Honoring this flag on a Claude CC runtime would silently switch the
+  // operator's CC turns to copilot — see `shared.resolveCcUseWorkerPool`
+  // which now refuses the override when CC runtime is not copilot
+  // (W-mphlriic00095f69).
   //
   // Resolution: `shared.resolveCcUseWorkerPool(engine)` (engine/shared.js)
   // is the canonical predicate every dashboard.js call site uses. Explicit
-  // `engine.ccUseWorkerPool` true/false in config wins; otherwise the helper
-  // defaults ON for `copilot` and OFF for `claude`. PR #2492 flipped the
-  // default ON for copilot; see that PR for the cold-spawn measurements.
+  // `engine.ccUseWorkerPool` true/false in config wins ONLY when CC runtime
+  // is copilot; otherwise the helper forces `false`. PR #2492 flipped the
+  // copilot default ON; see that PR for the cold-spawn measurements.
   //
   // `requiredCcRuntime: 'copilot'` here is a UX hint — the Settings panel
   // greys out the toggle when the resolved CC runtime mismatches so users

package/engine/shared.js

@@ -1865,7 +1865,7 @@ const ENGINE_DEFAULTS = {
   copilotSuppressAgentsMd: true,     // Copilot --no-custom-instructions: stop AGENTS.md auto-load from fighting Minions playbook prompts
   copilotStreamMode: 'on',           // Copilot --stream <on|off>: 'on' streams assistant.message_delta events live; 'off' batches them
   copilotReasoningSummaries: false,  // Copilot --enable-reasoning-summaries (Anthropic-family models only)
-  ccUseWorkerPool: false,            // Sub-task C of W-mp2w003600196c51 (CC perf): when true, _invokeCcStream routes through engine/cc-worker-pool.js (persistent `copilot --acp` per CC tab) instead of spawning a fresh CLI per turn. Off by default — opt-in feature flag. Engine/agent dispatch path stays per-process regardless.
+  ccUseWorkerPool: false,            // Sub-task C of W-mp2w003600196c51 (CC perf): when true AND CC runtime is copilot, _invokeCcStream routes through engine/cc-worker-pool.js (persistent `copilot --acp` per CC tab) instead of spawning a fresh CLI per turn. Off by default — opt-in feature flag. **Structurally copilot-only**: the pool spawns `copilot --acp` (Agent Client Protocol); Claude Code does not implement ACP, so resolveCcUseWorkerPool returns false on non-copilot CC runtimes even with explicit-true (W-mphlriic00095f69 — prevents silent runtime switch). Engine/agent dispatch path stays per-process regardless.
   maxBudgetUsd: undefined,       // fleet USD ceiling for --max-budget-usd (per-agent override: agents.<id>.maxBudgetUsd). Honors 0 via ?? so a literal cap of $0 works
   disableModelDiscovery: false,  // skip runtime.listModels() REST calls fleet-wide (settings UI falls back to free-text)
   maxPendingContexts: 20, // cap pendingContexts arrays in cooldowns.json to prevent unbounded growth
@@ -2097,22 +2097,31 @@ function resolveCcCli(engine) {
 /**
  * Resolve whether the Command Center / doc-chat path should route through the
  * persistent ACP worker pool. Priority:
- *   1. `engine.ccUseWorkerPool` explicit true/false — operator override always wins
- *   2. Runtime-aware default: ON when CC runtime resolves to `copilot`
+ *   1. CC runtime guard — pool spawns `copilot --acp` (Agent Client Protocol).
+ *      Claude Code does not implement ACP, and `_invokeCcStream` would silently
+ *      switch a Claude operator's CC turns to copilot if the pool ran for them.
+ *      Refuse the pool when CC runtime is not copilot, even if explicit-true is
+ *      set. Future runtimes that don't implement ACP fall into the same bucket.
+ *      (W-mphlriic00095f69)
+ *   2. `engine.ccUseWorkerPool` explicit true/false — operator override wins
+ *      *within* the copilot runtime
+ *   3. Runtime-aware default: ON when CC runtime resolves to `copilot`
  *      (Copilot's cold-spawn is 18-21s on Windows — pool turns subsequent turns
- *      from 47-140s back into a few seconds). Claude's cold-spawn is much
- *      cheaper and the ACP pool wasn't designed for it, so it stays OFF there.
- *   3. ENGINE_DEFAULTS.ccUseWorkerPool — final fallback
+ *      from 47-140s back into a few seconds).
+ *   4. ENGINE_DEFAULTS.ccUseWorkerPool — final fallback
  *
  * Strict boolean check on the override so a literal `false` opts out even on
  * Copilot, matching `_isMeaningful` semantics for boolean flags.
  */
 function resolveCcUseWorkerPool(engine) {
+  // Guard 1 (W-mphlriic00095f69): pool transport is ACP-only. If CC runtime
+  // isn't copilot, the pool cannot run regardless of operator opt-in — don't
+  // silently switch their runtime to copilot.
+  if (resolveCcCli(engine) !== 'copilot') return false;
   if (engine && (engine.ccUseWorkerPool === true || engine.ccUseWorkerPool === false)) {
     return engine.ccUseWorkerPool;
   }
-  if (resolveCcCli(engine) === 'copilot') return true;
-  return !!ENGINE_DEFAULTS.ccUseWorkerPool;
+  return true; // CC runtime is copilot — default ON (cold-start savings)
 }
 
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2039",
+  "version": "0.1.2040",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"