@yemi33/minions 0.1.2030 → 0.1.2032

package/dashboard/js/refresh.js

@@ -36,13 +36,21 @@ function _detectPageChanges(data) {
 
 // Change detection — skip renders for sections that haven't changed since last refresh.
 //
-// RENDER_VERSIONS is the in-process cache-bust knob (R3, W-mpgb0xgc000hf1d3).
-// _changed() caches JSON.stringify(value) per key, so when the input data is
-// byte-identical between ticks the render is skipped. That's the right call
-// 99% of the time, but it has a sharp edge: when a renderer body itself is
-// edited (hot-reloaded via dashboard-build.js or a freshly shipped bundle)
-// and the input stays the same, the stale render persists forever because
-// the cache key still matches. F8 / "projects chip" class of bug.
+// Two-layer cache:
+//   1. `_lastValueByKey` is an O(1) reference-equality precheck: when the server
+//      returns 304 Not Modified (refresh.js ~173) we reuse the same `_lastStatusData`
+//      reference tick after tick, so every `_changed(key, data.<slice>)` call below
+//      would otherwise re-stringify multi-MB slices for nothing. The JSON.stringify
+//      path stays as the fallback for the "fresh object, equal contents" case
+//      (S3, W-mpgcikfg000g8dc7).
+//   2. RENDER_VERSIONS is the in-process cache-bust knob (R3, W-mpgb0xgc000hf1d3).
+//      _changed() caches JSON.stringify(value) per (key, version), so when the
+//      input data is byte-identical between ticks the render is skipped. That's
+//      the right call 99% of the time, but it has a sharp edge: when a renderer
+//      body itself is edited (hot-reloaded via dashboard-build.js or a freshly
+//      shipped bundle) and the input stays the same, the stale render persists
+//      forever because the cache key still matches. F8 / "projects chip" class
+//      of bug.
 //
 // Bump the matching entry below whenever a renderer's *output* may change
 // for the same input. Cross-restart safety lives in the dashboardBuildId
@@ -74,15 +82,24 @@ const RENDER_VERSIONS = {
   pinned: 1,
 };
 const _sectionCache = {};
+const _lastValueByKey = {};
 const _sectionCacheVersions = {};
 function _changed(key, value, version) {
   var v = version == null ? (RENDER_VERSIONS[key] || 0) : version;
   // Drop the stale-version entry so the cache doesn't grow unbounded across bumps.
+  // A version bump must also reset the ref-eq sentinel — otherwise the S3
+  // short-circuit below would defeat the R3 cache-bust contract when the
+  // caller passes the SAME object reference across a version bump.
   if (_sectionCacheVersions[key] !== undefined && _sectionCacheVersions[key] !== v) {
     delete _sectionCache[key + ':v' + _sectionCacheVersions[key]];
+    _lastValueByKey[key] = undefined;
   }
   _sectionCacheVersions[key] = v;
   var cacheKey = key + ':v' + v;
+  // Reference-equality short-circuit: skip the stringify entirely when the
+  // server returned 304 and the same object reference is being re-checked.
+  if (_lastValueByKey[key] === value) return false;
+  _lastValueByKey[key] = value;
   var json = JSON.stringify(value);
   if (_sectionCache[cacheKey] === json) return false;
   _sectionCache[cacheKey] = json;
@@ -128,17 +145,35 @@ function _processStatusUpdate(data) {
   const threshEl = document.getElementById('inbox-threshold');
   if (threshEl && data.autoMode?.inboxThreshold) threshEl.textContent = data.autoMode.inboxThreshold;
 
-  // Publish window._last* snapshots BEFORE any renderer runs. Several renderers
-  // (renderProjects, renderPrd, renderPrs, refreshPlans, and others) read
-  // window._lastStatus / window._lastWorkItems / window._lastDispatch during
-  // their render path. If we assign these after the renderer calls, every tick
-  // consumes the PREVIOUS tick's globals — a one-tick (~4 s) staleness lag
-  // baked into the polling loop (W-mpgb0x81000cf8df, audit F4). No renderer in
-  // this function mutates `data`, so hoisting is safe.
+  // Publish window._last* snapshots BEFORE any renderer runs. Several
+  // renderers (renderPrd, renderPrs, derivePlanStatus inside refreshPlans,
+  // and the projectChipRemove/optimisticallyAddProject paths off
+  // renderProjects) read window._lastStatus / window._lastWorkItems /
+  // window._lastDispatch synchronously during their render path. When the
+  // assignments lived AFTER the renderer calls (the pre-fix layout in
+  // refresh.js:106-108), every tick consumed the PREVIOUS tick's globals —
+  // a one-tick (~4 s) staleness lag baked into the polling loop on top of
+  // the natural poll interval.
+  //
+  // See dashboard-refresh-audit.md finding F4 (W-mpgb0x81000cf8df / PR #2753
+  // landed the initial hoist; W-mpgbzpn9000390ae extends it with the
+  // render-agents / render-work-items invariants below). No renderer below
+  // mutates `data`, so hoisting the publish is safe; the renderers
+  // themselves still take their slice as a direct argument.
+  //
+  // Locking-in note (W-mpgbzpn9000390ae): renderAgents
+  // (render-agents.js:38) and renderWorkItems (render-work-items.js:98) —
+  // the two surfaces the user explicitly called out on /home and /work —
+  // take their data slice via argument and DO NOT read window._last*.
+  // Hoisting the publish here additionally guarantees that any future
+  // refactor that adds a window._last* read to those renderers will see
+  // fresh data on the same tick, not the previous one. Covered by
+  // dashboard-resilience.test.js source-inspection assertions.
   window._lastDispatch = data.dispatch;
   window._lastWorkItems = data.workItems || [];
   window._lastStatus = data;
 
+
   // Render only changed sections
   if (_changed('agents', data.agents)) { renderAgents(data.agents); cmdUpdateAgentList(data.agents); }
   if (_changed('prdProgress', data.prdProgress) || _changed('prdPrs', data.pullRequests?.length)) { renderPrdProgress(data.prdProgress); _cachePrdItems(data.prdProgress); }

package/dashboard/js/render-pipelines.js

@@ -491,7 +491,7 @@ function openPipelineDetail(id) {
         var fresh = list.find(function(x) { return x.id === id; });
         if (fresh) {
           // Only re-render if data changed
-          var newHash = JSON.stringify({ runs: fresh.runs || [], enabled: fresh.enabled, _stoppedBy: fresh._stoppedBy, _stopReason: fresh._stopReason });
+          var newHash = _computePipelineDetailHash(fresh);
           if (newHash !== _pipelinePollHash) {
             _pipelinePollHash = newHash;
             _pipelinesData = _pipelinesData.map(function(x) { return x.id === id ? fresh : x; });
@@ -504,6 +504,24 @@ function openPipelineDetail(id) {
 }
 var _pipelinePollHash = '';
 
+// F10: hash all pipeline fields the detail modal renders so stages/cron/monitoredResources/stopWhen
+// edits in another tab trigger re-render. Previously only {runs, enabled, _stoppedBy, _stopReason}.
+function _computePipelineDetailHash(p) {
+  if (!p) return '';
+  return JSON.stringify({
+    runs: p.runs || [],
+    enabled: p.enabled,
+    _stoppedBy: p._stoppedBy,
+    _stopReason: p._stopReason,
+    stages: p.stages,
+    monitoredResources: p.monitoredResources,
+    stopWhen: p.stopWhen,
+    trigger: p.trigger,
+    name: p.name,
+    description: p.description
+  });
+}
+
 /**
  * Fetch fresh pipeline data and re-render the detail modal immediately.
  * Used after actions (continue, trigger, abort) to avoid waiting for the 4s poll.
@@ -516,7 +534,7 @@ async function _refreshPipelineDetail(id) {
     var fresh = list.find(function(x) { return x.id === id; });
     if (fresh) {
       _pipelinesData = _pipelinesData.map(function(x) { return x.id === id ? fresh : x; });
-      _pipelinePollHash = JSON.stringify({ runs: fresh.runs || [], enabled: fresh.enabled, _stoppedBy: fresh._stoppedBy, _stopReason: fresh._stopReason });
+      _pipelinePollHash = _computePipelineDetailHash(fresh);
       renderPipelines(_pipelinesData);
       openPipelineDetail(id);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2030",
+  "version": "0.1.2032",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"