@yemi33/minions 0.1.2010 → 0.1.2012

package/dashboard.js

@@ -1919,7 +1919,7 @@ async function _handleStatusRequest(req, res) {
   }
 }
 
-// Periodic push for engine-driven changes (dispatch.json, control.json) that bypass invalidateStatusCache
+// Periodic push for engine-driven changes (dispatch.json, work-items.json, pull-requests.json) that bypass invalidateStatusCache
 setInterval(() => {
   if (_statusStreamClients.size === 0) return;
   const data = getStatusJson();
@@ -8098,6 +8098,11 @@ What would you like to discuss or change? When you're happy, say "approve" and I
   async function handleEngineRestart(req, res) {
     try {
       const newPid = restartEngine();
+      // control.json is no longer in the mtime-tracked list (W-mpg8aapw001d7e0c)
+      // because heartbeat noise dominated legitimate state changes and defeated
+      // the /api/status ETag short-circuit. Explicit invalidation here keeps the
+      // restart visible on the next poll without re-tracking control.json.
+      invalidateStatusCache();
       return jsonReply(res, 200, { ok: true, pid: newPid });
     } catch (e) { return jsonReply(res, e.statusCode || 500, { error: e.message }); }
   }

package/engine/lifecycle.js

@@ -1963,8 +1963,19 @@ function recordPrNoOpFixAttempt(target, cause, source, dispatchItem, branchChang
   ).slice(0, 500);
   target._lastDispatchByCause = target._lastDispatchByCause
     && typeof target._lastDispatchByCause === 'object' ? target._lastDispatchByCause : {};
+  // W-mpg6wptq0011cc68: distinguish indeterminate noops (detection could not
+  // prove the branch advanced — fetch failed, worktree gone, missing baseline)
+  // from confirmed noops (remote head was verified to equal beforeHead). The
+  // same-head guard in engine.js MUST NOT permanently suppress on indeterminate
+  // records, otherwise a single failed detection locks out future fix
+  // dispatches on that head+comment until the SHA moves — and the SHA cannot
+  // move unless the suppressed fix runs. The `_noOpFixes[cause].count` +
+  // `prNoOpFixPauseAttempts` (default 3) safety valve still applies; only the
+  // same-head guard is relaxed.
+  const indeterminate = !!branchChange && branchChange.changed === null;
   target._lastDispatchByCause[cause] = {
     outcome: 'noop',
+    indeterminate,
     headSha,
     reason: reasonText,
     dispatchedAt: now,

package/engine/playbook.js

@@ -1032,7 +1032,17 @@ function selectPlaybook(workType, item) {
 
 function buildPrDispatch(agentId, config, project, pr, type, extraVars, taskLabel, meta) {
   const dispatchId = `${agentId || 'unassigned'}-${type}-${shared.uid()}`;
-  const vars = { ...buildBaseVars(agentId, config, project), ...extraVars, task_id: dispatchId };
+  // W-mpg6wptq0011cc68: PR-context dispatches (review/fix/build-and-test) all
+  // operate on the PR's branch, so default `branch_name` to `pr_branch` here
+  // so shared-rules.md's `{{branch_name}}` reference resolves. Without this,
+  // every PR fix/review render emits a recurring `unresolved template
+  // variables: branch_name` warn. Callers may still override explicitly.
+  const vars = {
+    ...buildBaseVars(agentId, config, project),
+    branch_name: extraVars?.pr_branch || '',
+    ...extraVars,
+    task_id: dispatchId,
+  };
   const playbookName = type === 'test' ? 'build-and-test' : (type === 'review' ? 'review' : 'fix');
   const prompt = renderPlaybook(playbookName, vars);
   if (!prompt) return null;

package/engine/queries.js

@@ -1822,6 +1822,19 @@ function resetProjectGitStatusCache() {
  *      automatically.
  *
  * Files intentionally NOT tracked:
+ *   - `engine/log.json` — append-only log written many times per tick
+ *     (PR polls, dispatch transitions, heartbeat). Its mtime advances
+ *     every few seconds in steady state, which by itself was enough to
+ *     bust the ETag cache on every poll and reduce the /api/status 304
+ *     short-circuit to 0% hit rate (W-mpg8aapw001d7e0c). Log tail is
+ *     surfaced by `getEngineLog()` and accepts the 10 s `FAST_STATE_TTL`
+ *     backstop — log entries are not UX-blocking.
+ *   - `engine/control.json` — heartbeat writes advance mtime every tick
+ *     (~60 s) plus on any control-side mutation, dominating legitimate
+ *     state changes. Engine state (running/paused/stopped) is surfaced
+ *     by `getEngineState()`; the dashboard-side mutating handlers
+ *     (`handleEngineRestart` etc.) call `invalidateStatusCache()`
+ *     directly, and the 10 s TTL covers CLI-driven control-file edits.
  *   - `engine/state.json` — surfaced via `getEngineState()` but changes
  *     only on engine startup / reconcile. Negligible benefit.
  *   - `engine/cooldowns.json`, `engine/pr-links.json`, `engine/pending-
@@ -1841,11 +1854,10 @@ function resetProjectGitStatusCache() {
 function getStatusFastStateMtimePaths(config) {
   const projects = getProjects(config || getConfig());
   const files = [
-    // Engine-level state surfaced by getDispatchQueue / inline engine block /
-    // getEngineLog / getMetrics.
+    // Engine-level state surfaced by getDispatchQueue / getMetrics.
+    // `control.json` and `log.json` are intentionally omitted — see the
+    // "Files intentionally NOT tracked" section above (W-mpg8aapw001d7e0c).
     DISPATCH_PATH,
-    CONTROL_PATH,
-    LOG_PATH,
     path.join(ENGINE_DIR, 'metrics.json'),
     // Watches surfaced by watchesMod.getWatches() (W-mpftp7na000td0f4 fix).
     path.join(ENGINE_DIR, 'watches.json'),

package/engine.js

@@ -4252,6 +4252,13 @@ async function discoverFromPrs(config, project) {
       // queued). Skip only the human-feedback dispatch path; leave
       // `fixDispatched=false` so downstream causes are still evaluated.
       const skipHumanFeedback = !!(lastHumanDispatch?.outcome === 'noop'
+        // W-mpg6wptq0011cc68: indeterminate noops (detection could not verify
+        // branch advance — fetch failed, worktree gone) must NOT permanently
+        // suppress re-dispatch. lifecycle.js:2043-2048 explicitly comments
+        // that a future tick with working detection must be free to re-fire.
+        // The `_noOpFixes` count + `prNoOpFixPauseAttempts` (default 3) safety
+        // valve still triggers pause if detection keeps failing.
+        && !lastHumanDispatch.indeterminate
         && lastHumanDispatch.headSha
         && currentHeadSha
         && lastHumanDispatch.headSha === currentHeadSha
@@ -4436,6 +4443,12 @@ async function discoverFromPrs(config, project) {
       // below — symmetric to the human-feedback bug. Skip only the build-fix
       // dispatch path; downstream merge-conflict resolution must still run.
       const skipBuildFix = !!(lastBuildDispatch?.outcome === 'noop'
+        // W-mpg6wptq0011cc68: symmetric protection — indeterminate noops here
+        // (detection couldn't verify branch advance) must NOT permanently
+        // suppress build-fix either. Same rationale as the human-feedback
+        // guard above; the per-cause `_noOpFixes` count + pause-after-N valve
+        // still applies.
+        && !lastBuildDispatch.indeterminate
         && lastBuildDispatch.headSha
         && currentHeadSha
         && lastBuildDispatch.headSha === currentHeadSha);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2010",
+  "version": "0.1.2012",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"