@yemi33/minions 0.1.1994 → 0.1.1995

package/engine/ado.js

@@ -378,6 +378,15 @@ function applyAdoPrMetadata(pr, prData) {
     updated = true;
   }
 
+  // W-mpej044m00076d63: backfill `pr.created` from ADO's real creation
+  // timestamp. lifecycle.js attach paths omit `created` so this poll is the
+  // single source of truth for fresh records, and historical records missing
+  // `created` get backfilled the next time they're polled. Idempotent.
+  if (!pr.created && prData.creationDate) {
+    pr.created = prData.creationDate;
+    updated = true;
+  }
+
   return updated;
 }
 
@@ -720,6 +729,18 @@ async function pollPrStatus(config) {
       pr.status = newStatus;
       updated = true;
 
+      // W-mpej044m00076d63: persist platform close/merge timestamps on the
+      // normal-poll status flip. ADO does not split mergedAt vs closedAt at
+      // the API level — `closedDate` is set whenever a PR moves out of
+      // `active` (whether via merge or abandon). Mirror that into our own
+      // fields with the standard idempotency guard.
+      if (newStatus === PR_STATUS.MERGED && !pr.mergedAt) {
+        pr.mergedAt = prData.closedDate || ts();
+      }
+      if ((newStatus === PR_STATUS.ABANDONED || newStatus === PR_STATUS.CLOSED) && !pr.closedAt) {
+        pr.closedAt = prData.closedDate || ts();
+      }
+
       if (newStatus === PR_STATUS.MERGED || newStatus === PR_STATUS.ABANDONED) {
         if (pr.reviewStatus === 'waiting') {
           pr.reviewStatus = newStatus === PR_STATUS.MERGED ? 'approved' : 'pending';
@@ -1070,7 +1091,7 @@ async function pollPrHumanComments(config) {
     const threadsData = await adoFetch(threadsUrl, token);
     const threads = threadsData.value || [];
 
-    const cutoffStr = pr.humanFeedback?.lastProcessedCommentDate || pr.created || '1970-01-01';
+    const cutoffStr = pr.humanFeedback?.lastProcessedCommentDate || pr.created || pr._attachedAt || '1970-01-01';
     const cutoffMs = new Date(cutoffStr).getTime() || 0;
 
     // Collect ALL human comments on the PR for full context. `allCommentDates`

package/engine/github.js

@@ -661,6 +661,16 @@ async function pollPrStatus(config) {
     else if (prData.state === 'closed') newStatus = PR_STATUS.ABANDONED;
     else if (prData.state === 'open') newStatus = PR_STATUS.ACTIVE;
 
+    // W-mpej044m00076d63: backfill `pr.created` from the platform's real
+    // creation timestamp. lifecycle.js attach paths deliberately omit
+    // `created` so this poll is the single source of truth — and historical
+    // records that pre-date the fix get backfilled the next time they're
+    // polled. Idempotent: only writes when missing.
+    if (!pr.created && prData.created_at) {
+      pr.created = prData.created_at;
+      updated = true;
+    }
+
     // Track head SHA changes to detect new pushes (used for review re-dispatch gating)
     if (prData.head?.sha && pr.headSha !== prData.head.sha) {
       pr.headSha = prData.head.sha;
@@ -745,6 +755,17 @@ async function pollPrStatus(config) {
       pr.status = newStatus;
       updated = true;
 
+      // W-mpej044m00076d63: persist platform close/merge timestamps on the
+      // normal-poll status flip (previously only the abandoned-reconciliation
+      // path at ~line 1489 set mergedAt). Idempotency guard prevents a later
+      // reconciliation pass from overwriting an earlier-known value.
+      if (newStatus === PR_STATUS.MERGED && !pr.mergedAt) {
+        pr.mergedAt = prData.merged_at || prData.closed_at || ts();
+      }
+      if ((newStatus === PR_STATUS.ABANDONED || newStatus === PR_STATUS.CLOSED) && !pr.closedAt) {
+        pr.closedAt = prData.closed_at || ts();
+      }
+
       if (newStatus === PR_STATUS.MERGED || newStatus === PR_STATUS.ABANDONED) {
         // Resolve stale 'waiting' review status — won't be polled again after this
         if (pr.reviewStatus === 'waiting') {
@@ -961,7 +982,7 @@ async function pollPrHumanComments(config) {
     // fixture already populated the field.
     _backfillViewerDidAuthor(allComments, viewerLogin);
 
-    const cutoffStr = pr.humanFeedback?.lastProcessedCommentDate || pr.created || '1970-01-01';
+    const cutoffStr = pr.humanFeedback?.lastProcessedCommentDate || pr.created || pr._attachedAt || '1970-01-01';
     const cutoffMs = new Date(cutoffStr).getTime() || 0;
 
     // Collect comments that should advance the cutoff separately from comments

package/engine/lifecycle.js

@@ -907,7 +907,11 @@ function syncPrsFromOutput(output, agentId, meta, config, opts = {}) {
       branch: meta?.branch || '',
       reviewStatus: 'pending',
       status: PR_STATUS.ACTIVE,
-      created: ts(),
+      // W-mpej044m00076d63: do NOT seed `created` with ts() (engine discovery time).
+      // The next GitHub/ADO poll backfills `pr.created` from the platform's real
+      // creation timestamp; `_attachedAt` is preserved as a fallback for downstream
+      // cutoffs (e.g. comment-poll cutoffStr) that need any timestamp at all.
+      _attachedAt: ts(),
       url: prUrl,
       prdItems: meta?.item?.id ? [meta.item.id] : [],
       sourcePlan: meta?.item?.sourcePlan || '',
@@ -1221,7 +1225,9 @@ function _attachFoundPrToWi(found, meta, agentId, resultSummary, config) {
     branch: meta.branch || '',
     reviewStatus: 'pending',
     status: PR_STATUS.ACTIVE,
-    created: ts(),
+    // W-mpej044m00076d63: omit `created` — the next poll backfills from the
+    // platform's real createdAt. `_attachedAt` is the discovery-time fallback.
+    _attachedAt: ts(),
     url: found.url,
     prdItems: [meta.item.id],
     sourcePlan: meta.item?.sourcePlan || '',

package/engine/queries.js

@@ -673,12 +673,22 @@ function getPullRequests(config) {
     }
   }
   allPrs.sort((a, b) => {
-    // Normalize to YYYY-MM-DD for date comparison (some have full ISO, some date-only)
-    const aDate = (a.created || '').slice(0, 10);
-    const bDate = (b.created || '').slice(0, 10);
-    const dateComp = bDate.localeCompare(aDate);
-    if (dateComp !== 0) return dateComp;
-    // Same date — sort by PR number descending (newest first)
+    // W-mpej044m00076d63: sort by the full ISO `created` timestamp DESC so
+    // same-day PRs preserve creation order (previously the slice-to-date
+    // collapsed every PR opened on the same day into one bucket, then tied
+    // on a noisy PR-number-derived integer that ignored owner/repo digits).
+    // The PR-number tiebreaker survives only as a guard for records that
+    // legitimately lack `created` (e.g. mid-poll backfill window).
+    const aCreated = a.created || '';
+    const bCreated = b.created || '';
+    if (aCreated && bCreated) {
+      const cmp = bCreated.localeCompare(aCreated);
+      if (cmp !== 0) return cmp;
+    } else if (aCreated || bCreated) {
+      // One missing — surface the one with a timestamp first (newer signal).
+      return bCreated ? 1 : -1;
+    }
+    // Final guard for missing-data records: keep PR-number desc (newer first).
     const aNum = parseInt((a.id || '').replace(/\D/g, '')) || 0;
     const bNum = parseInt((b.id || '').replace(/\D/g, '')) || 0;
     return bNum - aNum;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1994",
+  "version": "0.1.1995",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"