@yemi33/minions 0.1.1990 → 0.1.1991

package/dashboard.js

@@ -34,7 +34,7 @@ const features = require('./engine/features');
 const ccWorkerPool = require('./engine/cc-worker-pool');
 const os = require('os');
 
-const { safeRead, safeReadDir, safeWrite, safeJson, safeJsonObj, safeJsonArr, safeJsonNoRestore, safeUnlink, mutateJsonFileLocked, mutateTextFileLocked, mutateControl, mutateCooldowns, mutateWorkItems, getProjects: _getProjects, DONE_STATUSES, WI_STATUS, WORK_TYPE, WORKTREE_REQUIRING_TYPES, reopenWorkItem } = shared;
+const { safeRead, safeReadOrNull, safeReadDir, safeWrite, safeJson, safeJsonObj, safeJsonArr, safeJsonNoRestore, safeUnlink, mutateJsonFileLocked, mutateTextFileLocked, mutateControl, mutateCooldowns, mutateWorkItems, getProjects: _getProjects, DONE_STATUSES, WI_STATUS, WORK_TYPE, WORKTREE_REQUIRING_TYPES, reopenWorkItem } = shared;
 const { getAgents, getAgentDetail, getPrdInfo, getWorkItems, getDispatchQueue,
   getSkills, getInbox, getNotesWithMeta, getPullRequests,
   getEngineLog, getMetrics, getKnowledgeBaseEntries, getProjectGitStatus, timeSince,
@@ -2640,11 +2640,31 @@ async function _preflightModelCheck({ runtime: cliOverride, model: modelOverride
  * document body. Always re-sending extraContext is correctness-safe; the
  * pool's warm-process saving is preserved regardless.
  */
+/**
+ * Build the persistent doc-chat pool tabKey from a session key (filePath or
+ * title). Single source of truth shared by _invokeDocChatViaPool (the
+ * streaming path) and handleDocChatWarm (the pre-warm endpoint). Both call
+ * sites MUST resolve to the same key, otherwise warm spawns an orphan worker
+ * the streaming call ignores — silently breaking the skip-18-21s Copilot
+ * cold-spawn optimization documented at modal-qa.js:506-516.
+ *
+ * The `default` fallback mirrors the legacy inline behavior for empty input
+ * so older callers (and the dashboard test fixtures that omit sessionKey)
+ * still land on a stable, predictable key.
+ *
+ * The freshSession one-shot branch in _invokeDocChatViaPool intentionally
+ * bypasses this helper — those callers want a unique short-lived key under
+ * `doc-chat:fresh:<uid>`, not the persistent namespace.
+ */
+function _buildDocChatTabKey(sessionKey) {
+  return 'doc-chat:' + (sessionKey || 'default');
+}
+
 function _invokeDocChatViaPool({ prompt, model, effort, engineConfig, systemPrompt, sessionKey, freshSession, timeoutMs, onChunk, onToolUse, onToolUpdate }) {
   const oneShot = !!freshSession;
   const tabKey = oneShot
     ? 'doc-chat:fresh:' + shared.uid()
-    : 'doc-chat:' + (sessionKey || 'default');
+    : _buildDocChatTabKey(sessionKey);
   let cancelled = false;
   let settled = false;
   let accumulated = '';
@@ -5905,7 +5925,10 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       if (canEdit) {
         try { shared.sanitizePath(body.filePath, MINIONS_DIR); } catch { return jsonReply(res, 400, { error: 'path must be under minions directory' }); }
         fullPath = path.resolve(MINIONS_DIR, body.filePath);
-        const diskContent = safeRead(fullPath);
+        // safeReadOrNull returns null when the file is missing/inaccessible.
+        // If absent, keep body.document (the client-sent panel content) — do
+        // NOT overwrite currentContent with '' (W-mpede4j7000ab7e4).
+        const diskContent = safeReadOrNull(fullPath);
         if (diskContent !== null) {
           // If client sent a contentHash and it matches disk, skip replacement — client copy is fresh
           if (body.contentHash && contentFingerprint(diskContent) === body.contentHash) {
@@ -5992,7 +6015,10 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         try { shared.sanitizePath(body.filePath, MINIONS_DIR); }
         catch { docChatInFlight.delete(docKey); res.statusCode = 400; res.setHeader('Content-Type', 'application/json'); res.end(JSON.stringify({ error: 'path must be under minions directory' })); return; }
         fullPath = path.resolve(MINIONS_DIR, body.filePath);
-        const diskContent = safeRead(fullPath);
+        // safeReadOrNull returns null when the file is missing/inaccessible.
+        // If absent, keep body.document (the client-sent panel content) — do
+        // NOT overwrite currentContent with '' (W-mpede4j7000ab7e4).
+        const diskContent = safeReadOrNull(fullPath);
         if (diskContent !== null) {
           if (!(body.contentHash && contentFingerprint(diskContent) === body.contentHash)) {
             currentContent = diskContent;
@@ -6595,7 +6621,10 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       const body = await readBody(req);
       const sessionKey = body && (body.filePath || body.title);
       if (!sessionKey) return jsonReply(res, 400, { error: 'filePath or title required' });
-      const result = await _warmCcPool(sessionKey, _docChatPromptHash);
+      // Must match the persistent tabKey _invokeDocChatViaPool hands to
+      // ccWorkerPool.getSession at first-message time, or this warm spawns
+      // an orphan worker (regression W-mpede4bf000957b5).
+      const result = await _warmCcPool(_buildDocChatTabKey(sessionKey), _docChatPromptHash);
       return jsonReply(res, 200, result);
     } catch (e) { return jsonReply(res, e.statusCode || 500, { error: e.message }); }
   }
@@ -9261,6 +9290,7 @@ module.exports = {
   parsePinnedEntries,
   _formatDocChatContext,
   _buildDocChatPass,
+  _buildDocChatTabKey,
   _docSessionsForTesting: docSessions,
   _docChatPromptHashForTesting: _docChatPromptHash,
   _isCompletedMeetingJson,

package/engine/shared.js

@@ -323,6 +323,15 @@ function safeRead(p) {
   try { return fs.readFileSync(p, 'utf8'); } catch { return ''; }
 }
 
+// Like safeRead, but returns null when the file is missing/inaccessible so
+// callers can distinguish "file absent" from "file present but empty".
+// Used by doc-chat handlers (W-mpede4j7000ab7e4) to avoid silently overwriting
+// the client-sent document body with '' when the file was deleted/moved
+// between panel open and send.
+function safeReadOrNull(p) {
+  try { return fs.readFileSync(p, 'utf8'); } catch { return null; }
+}
+
 function safeReadDir(dir) {
   try { return fs.readdirSync(dir); } catch { return []; }
 }
@@ -4680,6 +4689,7 @@ module.exports = {
   dateStamp,
   log,
   safeRead,
+  safeReadOrNull,
   safeReadDir,
   safeJson, safeJsonObj, safeJsonArr, safeJsonNoRestore,
   safeWrite,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1990",
+  "version": "0.1.1991",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"