@yemi33/minions 0.1.1987 → 0.1.1988

package/dashboard/js/qa.js

@@ -1,41 +1,19 @@
 // dashboard/js/qa.js — QA tab wiring (W-mpd5ewhj000oc5c5).
 //
-// The QA tab is the canonical home for long-running test/validation surfaces.
-// Phase 1 (this WI) mounts the managed-spawn + keep-processes panels into the
-// QA page using the shared mount API on render-managed.js + render-other.js.
-// The Engine page keeps its own mount registered eagerly inside those modules
-// so dual-render works (engine.html and qa.html show the same data, fed by
-// the same poll loop in refresh.js — no extra fetches, no extra SSE streams).
+// The QA tab hosts validation runbooks (human-driven and agent-driven) against
+// running managed instances. It does NOT mirror the live-process inventory —
+// that lives on /engine (Managed Processes + Keep-Processes panels). Runbook
+// rows in the next WI will link to their targets by name rather than duplicate
+// the inventory tables (W-mpdad3mq000m53bb).
 //
-// SSE log streaming is lazy: openManagedLog() opens a single EventSource on
-// user click and closeManagedLog() aborts it. The modal is a singleton, so
-// opening from either tab doesn't multiply connections (cf. render-managed.js
-// "single-stream invariant").
-//
-// Out of scope: actual runbook dispatch wiring. The placeholder card with the
-// disabled "+ New runbook" button is the only UX hook for the next phase.
+// The only wiring this file owns is the switchPage SSE-close hook: if the
+// user has the managed-log modal (defined in render-managed.js) open on the
+// engine page and navigates away, we close the EventSource so it doesn't
+// keep streaming behind the new page. The hook is harmless when the QA page
+// never opens the modal itself, and matches the broader page-navigation
+// contract for SSE cleanup.
 
 (function () {
-  function _registerQaMounts() {
-    if (typeof mountManagedProcessesPanel === 'function') {
-      mountManagedProcessesPanel({
-        contentId: 'qa-managed-processes-content',
-        countId: 'qa-managed-processes-count',
-      });
-    }
-    if (typeof mountKeepProcessesPanel === 'function') {
-      mountKeepProcessesPanel({
-        contentId: 'qa-keep-processes-content',
-        countId: 'qa-keep-processes-count',
-      });
-    }
-  }
-
-  // The page fragment is in the DOM at script-load time (all .page divs are
-  // assembled into layout.html at build), so registering immediately is safe.
-  // The mount API is no-op when the QA fragment is missing (defensive).
-  _registerQaMounts();
-
   // Close any open managed-log SSE stream when the user navigates away from a
   // page that triggered it — the modal otherwise floats over the new page and
   // the EventSource keeps streaming. Hooks into the existing switchPage()
@@ -48,6 +26,4 @@
     };
     window.switchPage.__qaWrapped = true;
   }
-
-  window.MinionsQA = { _registerQaMounts };
 })();

package/dashboard/js/refresh.js

@@ -103,16 +103,23 @@ function _processStatusUpdate(data) {
   prunePrdRequeueState(window._lastWorkItems);
   if (_changed('engineLog', data.engineLog)) renderEngineLog(data.engineLog || []);
   if (_changed('metrics', data.metrics)) renderMetrics(data.metrics || {});
-  // keep_processes panel renders on every page where its mount is in the DOM
-  // (Engine page + QA page — W-mpd5ewhj000oc5c5). Cheap call (one fetch); the
-  // renderer iterates all registered mounts and skips when none are present.
-  if (typeof renderKeepProcesses === 'function') {
-    try { renderKeepProcesses(); } catch {}
-  }
-  // managed-processes panel — same mount-point pattern, ETag-gated so
-  // unchanged ticks return 304 with no body (P-6e2a8b13).
+  // managed-processes panel — ETag-gated so unchanged ticks return 304 with
+  // no body (P-6e2a8b13). Sequenced BEFORE the keep-processes call below via
+  // .then() so the keep renderer reads a populated managed-PID cache for
+  // dedup (W-mpdad3mq000m53bb). _processStatusUpdate isn't async, so we
+  // chain on the returned Promise instead of awaiting.
+  let _managedRender = Promise.resolve();
   if (typeof renderManagedProcesses === 'function') {
-    try { renderManagedProcesses(); } catch {}
+    try { _managedRender = Promise.resolve(renderManagedProcesses()); } catch {}
+  }
+  // keep_processes panel renders on every page where its mount is in the DOM.
+  // Cheap call (one fetch); the renderer iterates all registered mounts, skips
+  // when none are present, and suppresses any PID already tracked as a managed
+  // process via MinionsManagedProcesses.getLastItems().
+  if (typeof renderKeepProcesses === 'function') {
+    _managedRender
+      .catch(function () { /* keep render even if managed fetch failed — getLastItems() returns the last good cache (or []) */ })
+      .then(function () { try { renderKeepProcesses(); } catch {} });
   }
   if (_changed('workItems', data.workItems)) renderWorkItems(data.workItems || []);
   if (_changed('skills', data.skills)) renderSkills(data.skills || []);

package/dashboard/js/render-managed.js

@@ -45,6 +45,12 @@ function unmountManagedProcessesPanel(contentId) {
   }
 }
 
+// Read-only accessor for the last successfully-fetched managed-process items.
+// Used by render-other.js renderKeepProcesses() to suppress PIDs that are
+// already tracked as managed processes (W-mpdad3mq000m53bb dedup). Returns
+// the live cache reference — callers must not mutate it.
+function getLastItems() { return _managedProcessesLastItems || []; }
+
 function _fmtAgo(ms) {
   if (!ms || ms < 0) return '0s';
   const s = Math.floor(ms / 1000);
@@ -302,4 +308,5 @@ window.MinionsManagedProcesses = {
   closeManagedLog,
   mountManagedProcessesPanel,
   unmountManagedProcessesPanel,
+  getLastItems,
 };

package/dashboard/js/render-other.js

@@ -529,15 +529,45 @@ async function renderKeepProcesses() {
   } catch (e) {
     fetchErr = e;
   }
+  // Dedup against managed-processes: agents that declare a process via
+  // managed-spawn.json AND leave it running via keep_processes show up in
+  // both panels. Managed is canonical (engine owns the lifecycle), so we
+  // suppress any PID already tracked there from the keep-processes table
+  // (W-mpdad3mq000m53bb).
+  const managed = (window.MinionsManagedProcesses && typeof window.MinionsManagedProcesses.getLastItems === 'function')
+    ? window.MinionsManagedProcesses.getLastItems()
+    : [];
+  const managedPidSet = new Set(
+    (Array.isArray(managed) ? managed : [])
+      .map(m => Number(m && m.pid))
+      .filter(n => Number.isFinite(n))
+  );
+  let rawCount = 0;
+  let filtered = items;
+  if (!fetchErr && items) {
+    rawCount = items.length;
+    filtered = [];
+    for (const it of items) {
+      if (!it.valid) { filtered.push(it); continue; }
+      // Shallow clone so we don't mutate the fetched array — caller may
+      // re-render the same payload on a 304 tick.
+      const pids = Array.isArray(it.pids) ? it.pids.filter(p => !managedPidSet.has(Number(p && p.pid))) : [];
+      if (!pids.length) continue;
+      filtered.push({ ...it, pids });
+    }
+  }
   if (fetchErr) {
     countText = '?';
     html = '<span style="color:var(--red)">Failed to load: ' + escHtml(fetchErr.message) + '</span>';
-  } else if (!items.length) {
+  } else if (!filtered.length) {
     countText = '0';
-    html = '<p class="empty">No agents have left processes running. Set <code>meta.keep_processes: true</code> on a work item to enable.</p>';
+    const baseEmpty = '<p class="empty">No agents have left processes running. Set <code>meta.keep_processes: true</code> on a work item to enable.</p>';
+    html = (rawCount > 0)
+      ? baseEmpty.replace('</p>', ' <span style="color:var(--muted)">(all PIDs are tracked as managed processes above)</span></p>')
+      : baseEmpty;
   } else {
-    countText = String(items.length);
-    html = items.map(function (it) {
+    countText = String(filtered.length);
+    html = filtered.map(function (it) {
       if (!it.valid) {
         return '<div style="border:1px solid var(--border);border-radius:4px;padding:8px;margin-bottom:8px;background:var(--surface2)">' +
           '<div style="color:var(--red);font-weight:600">' + escHtml(it.agentId) + ' INVALID</div>' +

package/dashboard/pages/engine.html

@@ -21,13 +21,13 @@
       </section>
       <section id="keep-processes-section">
         <h2>Keep-Processes <span class="count" id="keep-processes-count">0</span>
-          <span style="font-size:10px;color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">processes left running by agents (W-mp68q6ke0010de68 — opt-in keep_processes flag)</span>
+          <span style="font-size:10px;color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">processes left running by agents</span>
         </h2>
         <div id="keep-processes-content"><p class="empty">No agents have left processes running. Set <code>meta.keep_processes: true</code> on a work item to enable.</p></div>
       </section>
       <section id="managed-processes-section">
         <h2>Managed Processes <span class="count" id="managed-processes-count">0</span>
-          <span style="font-size:10px;color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">engine-managed long-running services (P-6e2a8b13 — managed-spawn primitive)</span>
+          <span style="font-size:10px;color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">engine-managed long-running services</span>
         </h2>
         <div id="managed-processes-content"><p class="empty">No managed processes. Agents declare them via <code>agents/&lt;id&gt;/managed-spawn.json</code>.</p></div>
       </section>

package/dashboard/pages/qa.html

@@ -1,18 +1,6 @@
       <section>
-        <h2>Live Processes <span style="font-size:10px;color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">canonical home for managed instances + agent-left processes (W-mpd5ewhj000oc5c5)</span></h2>
-        <p class="empty" style="margin:4px 0 12px 0">The QA tab is the foundation for human-driven and agent-driven validation against running managed instances. Phase 1 surfaces the live process inventory; runbook dispatch lands in a follow-up WI.</p>
-      </section>
-      <section id="qa-managed-processes-section">
-        <h2>Managed Processes <span class="count" id="qa-managed-processes-count">0</span>
-          <span style="font-size:10px;color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">engine-managed long-running services (P-6e2a8b13 — managed-spawn primitive)</span>
-        </h2>
-        <div id="qa-managed-processes-content"><p class="empty">No managed processes. Agents declare them via <code>agents/&lt;id&gt;/managed-spawn.json</code>.</p></div>
-      </section>
-      <section id="qa-keep-processes-section">
-        <h2>Keep-Processes <span class="count" id="qa-keep-processes-count">0</span>
-          <span style="font-size:10px;color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">processes left running by agents (W-mp68q6ke0010de68 — opt-in keep_processes flag)</span>
-        </h2>
-        <div id="qa-keep-processes-content"><p class="empty">No agents have left processes running. Set <code>meta.keep_processes: true</code> on a work item to enable.</p></div>
+        <h2>QA</h2>
+        <p class="empty" style="margin:4px 0 12px 0">Canonical home for human-driven and agent-driven validation against running managed instances. Runbook dispatch lands in a follow-up WI.</p>
       </section>
       <section id="qa-runbooks-section">
         <h2>Validation Runbooks <span style="font-size:10px;color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">human or agent-driven smoke / E2E flows against the live instances above</span></h2>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1987",
+  "version": "0.1.1988",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"