@yemi33/minions 0.1.1970 → 0.1.1971

package/engine/ado.js

@@ -1103,8 +1103,21 @@ async function pollPrHumanComments(config) {
         const authorName = (comment.author?.displayName || '').toLowerCase();
         if (ignoredAuthors.some(a => authorName.includes(a))) continue;
         if (/^#{1,3}\s*(Coverage|Build|Test|Deploy|Pipeline)\s*(Report|Status|Result|Summary)/i.test(content)) continue;
-        // Detect agent comments (included in context, but don't trigger fix)
-        const isAgent = /\bMinions\s*\(/i.test(content) || /\bby\s+Minions\b/i.test(content) || /\[minions\]/i.test(content);
+        // Detect agent comments (included in context, but don't trigger fix).
+        // W-mpbhnaim000q9ed3: also match the VERDICT-prefixed review body. The
+        // `Review by Minions (...)` sign-off can be skipped by a review agent
+        // (Ripley on PR ado:office/iss/constellation#5056697, 2026-05-18: posted
+        // a 1100-char APPROVE body with no sign-off → engine treated it as
+        // human feedback → fix-dispatch loop spammed "Skipping human-feedback
+        // fix ... noop on the same head" once a minute for 9+ hours). The
+        // VERDICT prefix is itself an engine-owned structured-output contract
+        // (parseReviewVerdict, playbooks/review.md:69-72) — humans don't write
+        // it as the first line of a comment. The `^` + /m anchor keeps quoted
+        // verdict text inside a human reply from matching.
+        const isAgent = /\bMinions\s*\(/i.test(content)
+          || /\bby\s+Minions\b/i.test(content)
+          || /\[minions\]/i.test(content)
+          || /^\s*VERDICT:\s*(APPROVE|REQUEST_CHANGES)\b/im.test(content);
 
         const entry = {
           threadId: thread.id,
@@ -1369,11 +1382,24 @@ async function checkLiveReviewStatus(pr, project) {
 
 /**
  * W-mp7b1g8q000fea45 — Reviewer vote reconciliation on verdict flip.
+ * W-mpbhnaim000q9ed3 — Bug A: also cast +10 when current vote is 0 (not just <0).
  *
- * Resets the *authenticated reviewer's own* prior negative vote (-5 wait-for-author
- * or -10 rejected) to +10 (approved) when an agent flips their verdict from
- * request_changes → approved on a re-review. Mirrors the existing target-branch
- * re-approval pattern at engine/ado.js:837-852 (PUT reviewers/{myId} {vote:10}).
+ * Ensures the *authenticated reviewer's own* vote is positive (+10) when an agent
+ * flips their verdict from request_changes → approved on a re-review. Mirrors the
+ * existing target-branch re-approval pattern at engine/ado.js:837-852 (PUT
+ * reviewers/{myId} {vote:10}). Covers both:
+ *   - prior negative vote (-5 wait-for-author, -10 rejected) → cleared to +10, and
+ *   - prior neutral vote (0 — never cast, or reset by another path and never
+ *     re-cast) → upgraded to +10 so the platform reflects the approved verdict.
+ *
+ * Without the neutral-vote upgrade, an agent flip to approved leaves the engine's
+ * `reviewStatus` stuck at `changes-requested` because checkLiveReviewStatus keeps
+ * seeing votes that don't carry an approval, and the next tick's reconciler
+ * dispatches a redundant human-feedback fix (Ripley on PR 5056697, 2026-05-18:
+ * `"Skipping human-feedback fix ... noop on the same head"` once a minute for 9+ hours).
+ *
+ * The function name remains `resetReviewerNegativeVote` for export-stability —
+ * it is referenced in playbooks/review.md and called from lifecycle.js.
  *
  * IMPORTANT: only operates on the authenticated reviewer's own vote. Other
  * reviewers' negative votes (humans, other minions on a different account) are
@@ -1385,7 +1411,7 @@ async function checkLiveReviewStatus(pr, project) {
  * Otherwise returns:
  *   {
  *     attempted: boolean,    // true if we found our reviewer entry and tried to PUT
- *     changed:   boolean,    // true if the reviewer's vote was actually flipped from <0 → 10
+ *     changed:   boolean,    // true if the reviewer's vote was actually flipped to +10
  *     fromVote:  number|null,// the reviewer's prior vote (null if not a reviewer on the PR)
  *     toVote:    number|null,// the vote after PUT (10 if changed, prior value otherwise)
  *   }
@@ -1421,16 +1447,19 @@ async function resetReviewerNegativeVote(pr, project) {
       // is the normal GH path; on ADO we generally do vote, so this is rare.)
       return { attempted: false, changed: false, fromVote: null, toVote: null };
     }
-    if (myVote >= 0) {
-      // Already neutral or positive — nothing to reset.
+    if (myVote > 0) {
+      // Already positive — platform already matches the approved verdict.
       return { attempted: false, changed: false, fromVote: myVote, toVote: myVote };
     }
+    // W-mpbhnaim000q9ed3: cover myVote === 0 too. A neutral vote on verdict flip
+    // means the agent never cast (or someone reset to 0), so the platform doesn't
+    // reflect approval yet; PUT +10 so reviewStatus reconciler stops looping.
     await adoFetch(`${repoBase}/pullrequests/${prNum}/reviewers/${myId}?api-version=7.1`, token, {
       method: 'PUT',
       body: JSON.stringify({ vote: 10 }),
       timeout: 4000,
     });
-    log('info', `PR ${pr.id}: reset reviewer vote ${myVote} → 10 (verdict flipped to approved)`);
+    log('info', `PR ${pr.id}: reset reviewer vote ${myVote} → 10 on verdict flip`);
     return { attempted: true, changed: true, fromVote: myVote, toVote: 10 };
   } catch (e) {
     log('warn', `Reviewer vote reset for ${pr?.id || 'unknown PR'}: ${e.message}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1970",
+  "version": "0.1.1971",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/review.md

@@ -88,6 +88,8 @@ Minimum diff to ship: <one-line description of the smallest change that would fl
 
 Non-blocking observations: None
 - (default to `None`; if you list any, each must be tied to an existing diff line in the form `path:line — observation`)
+
+Review by Minions ({{agent_name}} — {{agent_role}})
 ```
 
 After running the command, confirm it succeeded (check the command output for errors). If it fails, retry once.
@@ -100,6 +102,10 @@ If you encounter merge conflicts (e.g., the PR shows conflicts):
 
 ## When to Stop
 
-Your task is complete when your review comment (with `VERDICT: APPROVE` or `VERDICT: REQUEST_CHANGES` on the first line) has been posted successfully and the completion report has `verdict: "approved"` or `verdict: "changes-requested"`.
+Your task is complete when your review comment has been posted successfully with BOTH:
+- `VERDICT: APPROVE` or `VERDICT: REQUEST_CHANGES` on the first line, AND
+- the `Review by Minions ({{agent_name}} — {{agent_role}})` sign-off on the last line of the body
+
+and the completion report has `verdict: "approved"` or `verdict: "changes-requested"`. The sign-off is what lets the engine distinguish agent reviews from human PR comments on ADO; without it the engine will queue a redundant fix-dispatch loop (W-mpbhnaim000q9ed3, Ripley on PR 5056697).
 
 Do NOT stop before posting the review. Do NOT continue reading unrelated files after posting.