@yemi33/minions 0.1.1969 → 0.1.1971

package/engine/ado.js

@@ -1103,8 +1103,21 @@ async function pollPrHumanComments(config) {
         const authorName = (comment.author?.displayName || '').toLowerCase();
         if (ignoredAuthors.some(a => authorName.includes(a))) continue;
         if (/^#{1,3}\s*(Coverage|Build|Test|Deploy|Pipeline)\s*(Report|Status|Result|Summary)/i.test(content)) continue;
-        // Detect agent comments (included in context, but don't trigger fix)
-        const isAgent = /\bMinions\s*\(/i.test(content) || /\bby\s+Minions\b/i.test(content) || /\[minions\]/i.test(content);
+        // Detect agent comments (included in context, but don't trigger fix).
+        // W-mpbhnaim000q9ed3: also match the VERDICT-prefixed review body. The
+        // `Review by Minions (...)` sign-off can be skipped by a review agent
+        // (Ripley on PR ado:office/iss/constellation#5056697, 2026-05-18: posted
+        // a 1100-char APPROVE body with no sign-off → engine treated it as
+        // human feedback → fix-dispatch loop spammed "Skipping human-feedback
+        // fix ... noop on the same head" once a minute for 9+ hours). The
+        // VERDICT prefix is itself an engine-owned structured-output contract
+        // (parseReviewVerdict, playbooks/review.md:69-72) — humans don't write
+        // it as the first line of a comment. The `^` + /m anchor keeps quoted
+        // verdict text inside a human reply from matching.
+        const isAgent = /\bMinions\s*\(/i.test(content)
+          || /\bby\s+Minions\b/i.test(content)
+          || /\[minions\]/i.test(content)
+          || /^\s*VERDICT:\s*(APPROVE|REQUEST_CHANGES)\b/im.test(content);
 
         const entry = {
           threadId: thread.id,
@@ -1369,11 +1382,24 @@ async function checkLiveReviewStatus(pr, project) {
 
 /**
  * W-mp7b1g8q000fea45 — Reviewer vote reconciliation on verdict flip.
+ * W-mpbhnaim000q9ed3 — Bug A: also cast +10 when current vote is 0 (not just <0).
  *
- * Resets the *authenticated reviewer's own* prior negative vote (-5 wait-for-author
- * or -10 rejected) to +10 (approved) when an agent flips their verdict from
- * request_changes → approved on a re-review. Mirrors the existing target-branch
- * re-approval pattern at engine/ado.js:837-852 (PUT reviewers/{myId} {vote:10}).
+ * Ensures the *authenticated reviewer's own* vote is positive (+10) when an agent
+ * flips their verdict from request_changes → approved on a re-review. Mirrors the
+ * existing target-branch re-approval pattern at engine/ado.js:837-852 (PUT
+ * reviewers/{myId} {vote:10}). Covers both:
+ *   - prior negative vote (-5 wait-for-author, -10 rejected) → cleared to +10, and
+ *   - prior neutral vote (0 — never cast, or reset by another path and never
+ *     re-cast) → upgraded to +10 so the platform reflects the approved verdict.
+ *
+ * Without the neutral-vote upgrade, an agent flip to approved leaves the engine's
+ * `reviewStatus` stuck at `changes-requested` because checkLiveReviewStatus keeps
+ * seeing votes that don't carry an approval, and the next tick's reconciler
+ * dispatches a redundant human-feedback fix (Ripley on PR 5056697, 2026-05-18:
+ * `"Skipping human-feedback fix ... noop on the same head"` once a minute for 9+ hours).
+ *
+ * The function name remains `resetReviewerNegativeVote` for export-stability —
+ * it is referenced in playbooks/review.md and called from lifecycle.js.
  *
  * IMPORTANT: only operates on the authenticated reviewer's own vote. Other
  * reviewers' negative votes (humans, other minions on a different account) are
@@ -1385,7 +1411,7 @@ async function checkLiveReviewStatus(pr, project) {
  * Otherwise returns:
  *   {
  *     attempted: boolean,    // true if we found our reviewer entry and tried to PUT
- *     changed:   boolean,    // true if the reviewer's vote was actually flipped from <0 → 10
+ *     changed:   boolean,    // true if the reviewer's vote was actually flipped to +10
  *     fromVote:  number|null,// the reviewer's prior vote (null if not a reviewer on the PR)
  *     toVote:    number|null,// the vote after PUT (10 if changed, prior value otherwise)
  *   }
@@ -1421,16 +1447,19 @@ async function resetReviewerNegativeVote(pr, project) {
       // is the normal GH path; on ADO we generally do vote, so this is rare.)
       return { attempted: false, changed: false, fromVote: null, toVote: null };
     }
-    if (myVote >= 0) {
-      // Already neutral or positive — nothing to reset.
+    if (myVote > 0) {
+      // Already positive — platform already matches the approved verdict.
       return { attempted: false, changed: false, fromVote: myVote, toVote: myVote };
     }
+    // W-mpbhnaim000q9ed3: cover myVote === 0 too. A neutral vote on verdict flip
+    // means the agent never cast (or someone reset to 0), so the platform doesn't
+    // reflect approval yet; PUT +10 so reviewStatus reconciler stops looping.
     await adoFetch(`${repoBase}/pullrequests/${prNum}/reviewers/${myId}?api-version=7.1`, token, {
       method: 'PUT',
       body: JSON.stringify({ vote: 10 }),
       timeout: 4000,
     });
-    log('info', `PR ${pr.id}: reset reviewer vote ${myVote} → 10 (verdict flipped to approved)`);
+    log('info', `PR ${pr.id}: reset reviewer vote ${myVote} → 10 on verdict flip`);
     return { attempted: true, changed: true, fromVote: myVote, toVote: 10 };
   } catch (e) {
     log('warn', `Reviewer vote reset for ${pr?.id || 'unknown PR'}: ${e.message}`);

package/engine/shared.js

@@ -1959,9 +1959,15 @@ const WORK_TYPE = {
 // and /api/work-items/retry) refuses to create or re-spawn a project-less WI
 // of any type in this set when PROJECTS.length !== 1.
 //
-// Complement of engine.js READ_ONLY_ROOT_TASK_TYPES; `docs` is intentionally
-// also exempt because docs edits run at the Minions root, not in a project
-// worktree.
+// Complement of engine.js READ_ONLY_ROOT_TASK_TYPES. `docs` is included
+// (W-mpbgo1wv000gf75b): docs edits run as worktree-requiring dispatches
+// against the minions repo, so without a project the engine's
+// resolveProjectRootDir falls back to MINIONS_DIR's parent and can collapse
+// to a drive root on installs where MINIONS_DIR sits one level below the
+// filesystem root (e.g. `D:\squad` → `D:\`). Failing fast at HTTP-validate
+// time is preferable to letting a project-less docs WI land and loop on
+// WORKTREE_PREFLIGHT. Callers doing minions-repo docs work must pass
+// `project: "minions"` explicitly.
 const WORKTREE_REQUIRING_TYPES = new Set([
   WORK_TYPE.FIX,
   WORK_TYPE.IMPLEMENT,
@@ -1970,6 +1976,7 @@ const WORKTREE_REQUIRING_TYPES = new Set([
   WORK_TYPE.VERIFY,
   WORK_TYPE.REVIEW,
   WORK_TYPE.DECOMPOSE,
+  WORK_TYPE.DOCS,
 ]);
 
 const PLAN_STATUS = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1969",
+  "version": "0.1.1971",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/review.md

@@ -88,6 +88,8 @@ Minimum diff to ship: <one-line description of the smallest change that would fl
 
 Non-blocking observations: None
 - (default to `None`; if you list any, each must be tied to an existing diff line in the form `path:line — observation`)
+
+Review by Minions ({{agent_name}} — {{agent_role}})
 ```
 
 After running the command, confirm it succeeded (check the command output for errors). If it fails, retry once.
@@ -100,6 +102,10 @@ If you encounter merge conflicts (e.g., the PR shows conflicts):
 
 ## When to Stop
 
-Your task is complete when your review comment (with `VERDICT: APPROVE` or `VERDICT: REQUEST_CHANGES` on the first line) has been posted successfully and the completion report has `verdict: "approved"` or `verdict: "changes-requested"`.
+Your task is complete when your review comment has been posted successfully with BOTH:
+- `VERDICT: APPROVE` or `VERDICT: REQUEST_CHANGES` on the first line, AND
+- the `Review by Minions ({{agent_name}} — {{agent_role}})` sign-off on the last line of the body
+
+and the completion report has `verdict: "approved"` or `verdict: "changes-requested"`. The sign-off is what lets the engine distinguish agent reviews from human PR comments on ADO; without it the engine will queue a redundant fix-dispatch loop (W-mpbhnaim000q9ed3, Ripley on PR 5056697).
 
 Do NOT stop before posting the review. Do NOT continue reading unrelated files after posting.

package/prompts/cc-system.md

@@ -146,7 +146,7 @@ curl -s http://localhost:{{dashboard_port}}/api/status
 
 **Required fields per endpoint** — the server returns `{ error: "..." }` if missing. Common cases:
 - `POST /api/work-items`: `title` REQUIRED. `description` recommended. `project` REQUIRED when multiple projects are configured (server returns the list of known names if you guess wrong). `type` defaults to `implement`; valid values: `fix`, `implement`, `implement:large`, `explore`, `ask`, `review`, `test`, `verify`. Agent hint via `agent` (string) or `agents` (array).
-  - Exempt from the `project` requirement (these run rootless or via central paths): `ask`, `explore`, `plan`, `plan-to-prd`, `meeting`, `docs`. Every other type needs a project worktree, so the server rejects project-less creates with `400 { error, knownProjects }` when ≠1 project is configured.
+  - Exempt from the `project` requirement (these run rootless or via central paths): `ask`, `explore`, `plan`, `plan-to-prd`, `meeting`. (`docs` is intentionally NOT exempt — it's write-capable and lands in `WORKTREE_REQUIRING_TYPES`, so it needs a real project worktree. For minions-repo docs work, pass `project: "minions"` explicitly.) Every other type needs a project worktree, so the server rejects project-less creates with `400 { error, knownProjects }` when ≠1 project is configured.
   - **`meta.keep_processes: true`** — opt-in flag that lets the agent leave specific descendant PIDs running after it exits (default: engine reaps EVERYTHING the agent spawned). **Set this whenever the user's intent is to leave a process alive after the agent finishes** — e.g. "spin up the dev server and exit", "start the watcher and leave it running", "set up my dev env", "keep the emulator open", "launch the daemon for me", "boot the constellation host and disconnect". Don't set it for normal build/test/run-once tasks (`npm test`, `npm run build`, one-shot scripts) — those should be reaped. Also accepts optional `meta.keep_processes_ttl_minutes` (default 60, hard-cap 1440 = 24h). When you set this flag, also make the WI title/description say something like "leave the dev server running" so the agent knows to write `agents/<id>/keep-pids.json` before exiting (the playbook injects the contract automatically when the flag is on). Example: `-d '{"title":"Spin up Constellation dev env and leave server running","type":"implement","project":"constellation","description":"Run bun install + bun run dev. Leave the dev server (port 5173) and Constellation host (port 3001) running after you exit so the user can iterate.","meta":{"keep_processes":true,"keep_processes_ttl_minutes":240}}'`. Inspect / kill kept PIDs anytime via `GET /api/keep-processes` and `POST /api/keep-processes/kill`.
   - **`skipPr: true`** — opt-in flag that tells the engine NOT to enforce the PR-attachment contract for this work item, so the WI can complete `done` without the missing-PR hard-fail. **Set this when the dispatch mutates state OUTSIDE any tracked git repo and therefore cannot produce a PR** — e.g. cleaning `~/.claude/skills/`, editing runtime config under `~/.config/`, resetting the dashboard cache, mutating engine JSON state files (`engine/*.json`) the engine itself owns, or local tooling installs. **Do NOT set it for any task that touches a tracked repo's source** — even one-line diffs in a real repo should produce a PR. Type-selection rule of thumb: prefer `type: "explore"` for genuinely read-only tasks (rootless, no worktree, no PR contract); use `skipPr: true` when the task is write-side mutation but the writes don't land in a git repo. Example: `-d '{"title":"Clean up duplicate skills in ~/.claude/skills","type":"implement","description":"Audit ~/.claude/skills/ and delete the 3 obsolete entries identified in NOTE-mp7gt4iw0004b879. Pure user-machine state outside any git repo, so no PR will be produced.","skipPr":true}'`.
   - **`oneShot: true`** — opt-in flag for one-off human-initiated dispatches that should NOT enroll the discovered PR into the engine's automatic review/fix loop. The PR is still tracked (status + comments are polled normally) but `discoverFromPrs` skips it for review/fix dispatch. **Set this when the user's intent is "do this single action against an existing PR, then stop"** — e.g. "review PR #2533 once", "rebase PR #2540 once and exit", "post a fix-summary comment on PR #2519". Don't set it for normal feature/fix work where the PR should keep cycling through review/fix until merged. Example: `-d '{"title":"One-off review of PR #2533","type":"review","project":"minions","description":"Single review pass on github:yemi33/minions#2533. Do not re-dispatch on subsequent comments.","oneShot":true}'`.