@yemi33/minions 0.1.1961 → 0.1.1962

package/engine/pipeline.js

@@ -8,7 +8,7 @@ const fs = require('fs');
 const path = require('path');
 const shared = require('./shared');
 const queries = require('./queries');
-const { safeJson, safeJsonNoRestore, safeWrite, safeRead, safeReadDir, uid, log, ts, dateStamp, mutateJsonFileLocked, mutateWorkItems, slugify, formatTranscriptEntry, WI_STATUS, WORK_TYPE, PLAN_STATUS, PR_STATUS, PIPELINE_STATUS, STAGE_TYPE, MEETING_STATUS, ENGINE_DEFAULTS, MINIONS_DIR } = shared;
+const { safeJson, safeJsonNoRestore, safeWrite, safeRead, safeReadDir, uid, log, ts, dateStamp, mutateJsonFileLocked, mutateWorkItems, slugify, formatTranscriptEntry, WI_STATUS, WORK_TYPE, PLAN_STATUS, PR_STATUS, PIPELINE_STATUS, STAGE_TYPE, MEETING_STATUS, READ_ONLY_ROOT_TASK_TYPES, ENGINE_DEFAULTS, MINIONS_DIR } = shared;
 const routing = require('./routing');
 const http = require('http');
 const { parseCronExpr, shouldRunNow } = require('./scheduler');
@@ -388,13 +388,20 @@ function executeTaskStage(stage, stageState, run, config, pipeline = {}) {
       const projectSlug = _pipelineProjectSlug(project);
       const id = `PL-${run.runId.slice(4, 12)}-${stage.id}-${i}${projectResolution.projects.length > 1 || project ? '-' + projectSlug : ''}`;
       const wiPath = _pipelineWorkItemsPath(project);
+      const wiType = routing.normalizeWorkType(item.type || stage.taskType, WORK_TYPE.EXPLORE);
+      // W-mp8ho6w500034a58: read-only stages don't commit, so a pipeline
+      // branch label is meaningless to them — omit it entirely so the
+      // dispatcher's read-only fast-path runs without ceremony.
+      const wiBranch = READ_ONLY_ROOT_TASK_TYPES.has(wiType)
+        ? null
+        : `pipeline/${run.pipelineId}/${stage.id}`;
       mutateWorkItems(wiPath, workItems => {
         if (workItems.some(w => w.id === id)) { createdIds.push(id); return workItems; }
         workItems.push({
           id,
           title: item.title || stage.title,
           description: item.description || stage.description || '',
-          type: routing.normalizeWorkType(item.type || stage.taskType, WORK_TYPE.EXPLORE),
+          type: wiType,
           priority: item.priority || stage.priority || 'medium',
           // Agent is a soft routing hint unless agentLock/hardAgent is set.
           ...(item.agent || stage.agent ? { agent: item.agent || stage.agent } : {}),
@@ -403,7 +410,7 @@ function executeTaskStage(stage, stageState, run, config, pipeline = {}) {
           status: WI_STATUS.PENDING,
           created: ts(),
           createdBy: 'pipeline:' + run.pipelineId,
-          branch: `pipeline/${run.pipelineId}/${stage.id}`,
+          ...(wiBranch ? { branch: wiBranch } : {}),
           _pipelineRun: run.runId,
           _pipelineStage: stage.id,
         });
@@ -430,11 +437,18 @@ function executeTaskStageLegacy(stage, stageState, run, config) {
       const item = items[i % items.length];
       const id = `PL-${run.runId.slice(4, 12)}-${stage.id}-${i}`;
       if (workItems.some(w => w.id === id)) { createdIds.push(id); continue; }
+      const wiType = routing.normalizeWorkType(item.type || stage.taskType, WORK_TYPE.EXPLORE);
+      // W-mp8ho6w500034a58: read-only stages don't commit, so the branch
+      // label is meaningless — omit it so dispatch takes the read-only path
+      // without recomputing a worktree placement that will never be used.
+      const wiBranch = READ_ONLY_ROOT_TASK_TYPES.has(wiType)
+        ? null
+        : `pipeline/${run.pipelineId}/${stage.id}`;
       workItems.push({
         id,
         title: item.title || stage.title,
         description: item.description || stage.description || '',
-        type: routing.normalizeWorkType(item.type || stage.taskType, WORK_TYPE.EXPLORE),
+        type: wiType,
         priority: item.priority || stage.priority || 'medium',
         // Agent is a soft routing hint unless agentLock/hardAgent is set.
         ...(item.agent || stage.agent ? { agent: item.agent || stage.agent } : {}),
@@ -442,7 +456,7 @@ function executeTaskStageLegacy(stage, stageState, run, config) {
         status: WI_STATUS.PENDING,
         created: ts(),
         createdBy: 'pipeline:' + run.pipelineId,
-        branch: `pipeline/${run.pipelineId}/${stage.id}`,
+        ...(wiBranch ? { branch: wiBranch } : {}),
         _pipelineRun: run.runId,
         _pipelineStage: stage.id,
       });
@@ -571,7 +585,8 @@ async function executePlanStage(stage, stageState, run, config, pipeline = {}) {
               id: wiId, title: `Convert plan to PRD: ${existingPlanFile}`,
               type: WORK_TYPE.PLAN_TO_PRD, priority: 'high', status: WI_STATUS.PENDING,
               planFile: existingPlanFile, created: ts(), createdBy: 'pipeline:' + run.pipelineId,
-              branch: `pipeline/${run.pipelineId}/${stage.id}`, _pipelineRun: run.runId, _pipelineStage: stage.id,
+              // W-mp8ho6w500034a58: PLAN_TO_PRD is read-only — no branch needed.
+              _pipelineRun: run.runId, _pipelineStage: stage.id,
               ...(project ? { project: project.name } : {}),
             });
           }
@@ -665,7 +680,7 @@ async function executePlanStage(stage, stageState, run, config, pipeline = {}) {
           planFile: path.basename(filePath),
           created: ts(),
           createdBy: 'pipeline:' + run.pipelineId,
-          branch: `pipeline/${run.pipelineId}/${stage.id}`,
+          // W-mp8ho6w500034a58: PLAN_TO_PRD is read-only — no branch needed.
           _pipelineRun: run.runId,
           _pipelineStage: stage.id,
           ...(project ? { project: project.name } : {}),

package/engine/shared.js

@@ -2883,10 +2883,12 @@ const READ_ONLY_ROOT_TASK_TYPES = new Set(['meeting', 'ask', 'explore', 'plan-to
  *      the drive-root preflight that fires when MINIONS_DIR sits one level
  *      below a filesystem root (resolveProjectRootDir's collapse case).
  *
- * NOTE: Pipeline branches (engine.js `isPipelineBranchName`) override this —
- * they always need a worktree even for read-only types because the worktree
- * IS the pipeline's isolated workspace. The caller must detect the pipeline
- * branch case and recompute worktreeRootDir via `resolveProjectRootDir`.
+ * NOTE (W-mp8ho6w500034a58): Pipeline branches no longer override this.
+ * Read-only pipeline stages don't commit, so a `pipeline/...` branch is a
+ * meaningless label for them — the dispatcher short-circuits read-only WIs
+ * regardless of branch name, and `engine/pipeline.js` now omits the branch
+ * field for read-only stages. Only code-mutating pipeline stages need a
+ * worktree, and they take the normal code-mutating path below.
  *
  * @param {{ localPath?: string|null }|null|undefined} project
  * @param {string} type — work type (e.g. 'fix', 'explore', 'meeting')

package/engine.js

@@ -108,10 +108,6 @@ const CHECKPOINT_CAP_FAIL_REASON = 'Exceeded 3 checkpoint-resumes; manual interv
 // re-aliased here for the existing call sites in this file.
 const READ_ONLY_ROOT_TASK_TYPES = shared.READ_ONLY_ROOT_TASK_TYPES;
 
-function isPipelineBranchName(branchName) {
-  return typeof branchName === 'string' && branchName.startsWith('pipeline/');
-}
-
 // ─── Dispatch Management (extracted to engine/dispatch.js) ───────────────────
 
 const { mutateDispatch, addToDispatch, addToDispatchWithValidation, isRetryableFailureReason, completeDispatch,
@@ -777,8 +773,13 @@ async function spawnAgent(dispatchItem, config) {
   //     (caller defaults cwd to worktreeRootDir; drive-root collapse throws
   //     WORKTREE_ROOTDIR_COLLAPSED_TO_DRIVE_ROOT — same fail-fast behavior as
   //     the legacy resolveProjectRootDir call this replaced).
-  // Pipeline branches force a worktree even for read-only types — handled
-  // immediately after the resolver call below.
+  // W-mp8ho6w500034a58: read-only task types (meeting/ask/explore/plan/plan-to-prd)
+  // never need a worktree — even when carrying a pipeline branch. Pipeline branches
+  // on read-only stages are a no-op label; the stage doesn't commit anything, so
+  // the worktree had no functional purpose and was only there to absorb a drive-
+  // root preflight that fired against MINIONS_DIR's parent. Read-only pipeline
+  // stages now short-circuit alongside any other read-only WI (see the gate at
+  // `if (branchName && READ_ONLY_ROOT_TASK_TYPES.has(type))` below).
   const _preBranchName = meta?.branch ? sanitizeBranch(meta.branch) : null;
   let cwd, worktreeRootDir;
   try {
@@ -799,29 +800,6 @@ async function spawnAgent(dispatchItem, config) {
     }
     throw rootErr;
   }
-  // Pipeline branches need a worktree even for read-only types (the worktree
-  // IS the pipeline's isolated workspace). When we detect a pipeline branch
-  // on a read-only type, recompute worktreeRootDir so the worktree creation
-  // block has a placement parent — and so the drive-root preflight still fires.
-  if (worktreeRootDir === null && isPipelineBranchName(_preBranchName)) {
-    try {
-      worktreeRootDir = shared.resolveProjectRootDir(project.localPath, MINIONS_DIR);
-    } catch (rootErr) {
-      if (rootErr?.code === 'WORKTREE_ROOTDIR_COLLAPSED_TO_DRIVE_ROOT' || rootErr?.code === 'WORKTREE_ROOTDIR_MISSING_BASE') {
-        log('error', `spawnAgent: pipeline-branch rootDir resolution failed for ${id}: ${rootErr.message}`);
-        completeDispatch(
-          id,
-          DISPATCH_RESULT.ERROR,
-          rootErr.message.slice(0, 800),
-          'Pre-spawn worktree preflight rejected — see failure_class for the specific cause.',
-          { failureClass: FAILURE_CLASS.WORKTREE_PREFLIGHT, agentRetryable: false },
-        );
-        cleanupTempAgent(agentId);
-        return null;
-      }
-      throw rootErr;
-    }
-  }
   // Legacy local alias: downstream git ops (worktree add, prune, fetch) and
   // the `cwd === rootDir` safety warn at line ~1387 reference `rootDir`. For
   // read-only rootless tasks (no worktree, no branch) this is null — the
@@ -910,14 +888,15 @@ async function spawnAgent(dispatchItem, config) {
   };
   _phaseT.afterPrompt = Date.now();
 
-  if (branchName && READ_ONLY_ROOT_TASK_TYPES.has(type) && !isPipelineBranchName(branchName)) {
+  if (branchName && READ_ONLY_ROOT_TASK_TYPES.has(type)) {
     // W-mp7havqf0007ce6b: read-only types (meeting/ask/explore/plan/plan-to-prd)
     // short-circuit BEFORE the worktree-creation block. resolveSpawnPaths returns
     // worktreeRootDir=null for read-only types, and path.resolve(null, ...) throws
-    // ("paths[0] must be of type string. Received null"). Pipeline branches are
-    // exempt — they always need a worktree (the worktree IS the pipeline workspace),
-    // and the recompute at lines ~806-824 ensures worktreeRootDir is non-null
-    // before the worktree-creation block runs for them.
+    // ("paths[0] must be of type string. Received null"). Pipeline branches used
+    // to be exempt — they don't need to be (W-mp8ho6w500034a58): read-only stages
+    // never commit, so a pipeline-branch label is meaningless for them and the
+    // forced worktree only existed to feed the drive-root preflight that this
+    // short-circuit now correctly avoids.
     log('info', `${type}: read-only task with branch ${branchName} — skipping worktree, running in cwd ${cwd}`);
     branchName = null;
     worktreePath = null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1961",
+  "version": "0.1.1962",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"