@yemi33/minions 0.1.1927 → 0.1.1929

package/engine/cc-worker-pool.js

@@ -98,6 +98,19 @@ function _hashMcpServers(mcpServers) {
   return crypto.createHash('sha256').update(json).digest('hex');
 }
 
+// Bug B (issue #2479): `model` and `effort` were stored on the Worker but
+// never forwarded to ACP `session/new`, so any `ccModel` override was silently
+// dropped on the pool path. Build the params object here and only include
+// fields that are defined — sending `model: undefined` would force the daemon
+// onto its built-in default instead of letting it pick whatever the user has
+// configured globally.
+function _buildSessionNewParams({ cwd, mcpServers, model, effort }) {
+  const params = { cwd, mcpServers: mcpServers || [] };
+  if (model !== undefined && model !== null && model !== '') params.model = model;
+  if (effort !== undefined && effort !== null && effort !== '') params.effort = effort;
+  return params;
+}
+
 class Worker {
   constructor({ tabId, model, effort, mcpServers, mcpServersHash, systemPromptHash, cwd }) {
     this.tabId = tabId;
@@ -170,7 +183,9 @@ class Worker {
         earlyExitPromise,
       ]);
       const result = await Promise.race([
-        this._call('session/new', { cwd: this.cwd, mcpServers: this.mcpServers }),
+        this._call('session/new', _buildSessionNewParams({
+          cwd: this.cwd, mcpServers: this.mcpServers, model: this.model, effort: this.effort,
+        })),
         earlyExitPromise,
       ]);
       this.sessionId = result && result.sessionId;
@@ -344,7 +359,7 @@ class Worker {
     this._notify('session/cancel', { sessionId: this.inflight.sessionId });
   }
 
-  async newSession({ mcpServers, systemPromptHash }) {
+  async newSession({ mcpServers, systemPromptHash, model, effort }) {
     // Cancel any inflight before swapping the underlying session.
     if (this.inflight) {
       this.cancel();
@@ -360,10 +375,15 @@ class Worker {
         wait();
       });
     }
-    const result = await this._call('session/new', {
-      cwd: this.cwd,
-      mcpServers: mcpServers || [],
-    });
+    // Bug B (issue #2479): if the caller is rotating the session because the
+    // system prompt changed, they may also be passing a fresh model/effort —
+    // update bookkeeping BEFORE session/new so the new fields land on the
+    // daemon. Falls through to whatever we already had when callers omit them.
+    if (model !== undefined) this.model = model;
+    if (effort !== undefined) this.effort = effort;
+    const result = await this._call('session/new', _buildSessionNewParams({
+      cwd: this.cwd, mcpServers: mcpServers || [], model: this.model, effort: this.effort,
+    }));
     this.sessionId = result && result.sessionId;
     this.systemPromptHash = systemPromptHash;
     this.firstSystemPromptSent = false;
@@ -425,9 +445,9 @@ async function getSession({ tabId, model, effort, mcpServers, systemPromptHash,
     } else if (worker.systemPromptHash !== systemPromptHash) {
       // System prompt changed → keep the warm process, drop the session
       // and create a fresh one. Saves the ~2.1 s initialize handshake.
-      await worker.newSession({ mcpServers, systemPromptHash });
-      worker.model = model;
-      worker.effort = effort;
+      // Pass model/effort so the NEW session picks up any override the
+      // caller has rotated in (Bug B / issue #2479).
+      await worker.newSession({ mcpServers, systemPromptHash, model, effort });
       worker.lastUsedAt = _internals.now();
     } else {
       // Warm reuse — only update bookkeeping. model/effort changes on a
@@ -507,6 +527,7 @@ module.exports = {
   _internals,
   _tabs,
   _reapIdleTabs,
+  _buildSessionNewParams,
   IDLE_REAPER_MS,
   REAPER_INTERVAL_MS,
 };

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-14T02:06:41.197Z"
+  "cachedAt": "2026-05-14T02:50:03.274Z"
 }

package/engine/features.js

@@ -2,27 +2,51 @@
  * engine/features.js — Feature flag registry. Recipe in CLAUDE.md → "Feature Flags".
  */
 
-// Entry shape: id → { description, default: bool, addedIn?: version, expires?: ISO-date }
+// Entry shape: id → { description, default: bool, addedIn?: version, expires?: ISO-date, requiredCcRuntime?: string }
 //
-// INTENTIONAL EMPTY REGISTRY — DO NOT DELETE.
+// Optional fields:
+//   `requiredCcRuntime` (e.g. 'copilot') signals that the flag only takes
+//   effect when `resolveCcCli(engine)` matches. The dashboard uses this to
+//   render the toggle as disabled with a tooltip when the configured CC
+//   runtime is incompatible. Engine code still has to gate explicitly via
+//   `isFeatureOn` + a runtime check — `requiredCcRuntime` is a UX hint only.
+//
+// REGISTRY GROWTH POLICY — DO NOT DELETE THE FRAMEWORK.
 //
-// The `FEATURES = {}` literal below is intentional scaffolding, not dead code.
 // The surrounding framework (isFeatureOn, listFeatures, hasFeature, env-var
 // override resolver, expiration timestamps) is load-bearing: dashboard.js
 // boot wires it into /api/features (list), /api/features/toggle, and the
 // `window.MINIONS_FEATURES` client bootstrap. Deleting the registry — even
-// while empty — would break dashboard startup and the experimental-flags UI.
+// if it became empty — would break dashboard startup and the experimental-flags UI.
 //
 // New flags belong here. Register them in this object instead of removing
-// the empty literal. The first real entry will replace the example below;
-// until then the empty object is the correct, expected shape.
+// entries. Keep at least one entry so the framework remains demonstrably wired.
 //
 // Decision logged in the 2026-05-13 daily architecture & bug review meeting
 // (knowledge/architecture/2026-05-13-ripley-meeting-conclusion-daily-architecture-bug-review-2.md,
-// PR-C, Option B — keep framework, document the empty registry).
+// PR-C, Option B — keep framework, document the registry).
 const FEATURES = {
-  // Example:
-  // 'ux-sidebar-v2': { description: '…', default: false, addedIn: '0.1.1738', expires: '2026-06-01' },
+  // ccUseWorkerPool — sub-tasks B/C/D of W-mp2w003600196c51 (CC perf).
+  // Routes Command Center / doc-chat through engine/cc-worker-pool.js
+  // (persistent `copilot --acp` per CC tab) instead of spawning a fresh CLI
+  // per turn. Saves ~14 s of cold-start cost. Copilot-only — the pool drives
+  // ACP which Claude does not implement.
+  //
+  // Resolution: `shared.resolveCcUseWorkerPool(engine)` (engine/shared.js)
+  // is the canonical predicate every dashboard.js call site uses. Explicit
+  // `engine.ccUseWorkerPool` true/false in config wins; otherwise the helper
+  // defaults ON for `copilot` and OFF for `claude`. PR #2492 flipped the
+  // default ON for copilot; see that PR for the cold-spawn measurements.
+  //
+  // `requiredCcRuntime: 'copilot'` here is a UX hint — the Settings panel
+  // greys out the toggle when the resolved CC runtime mismatches so users
+  // see the constraint instead of toggling a no-op.
+  'ccUseWorkerPool': {
+    description: 'Route Command Center / doc-chat through a persistent `copilot --acp` worker per tab instead of spawning a fresh CLI per turn (~14s cold-start savings). Copilot-only — has no effect when the CC runtime is Claude.',
+    default: false,
+    addedIn: '0.1.1916',
+    requiredCcRuntime: 'copilot',
+  },
 };
 
 const ENV_TRUTHY = new Set(['1', 'true', 'on', 'yes']);
@@ -64,6 +88,7 @@ function listFeatures(config, registry = FEATURES) {
       addedIn: meta.addedIn || null,
       expires: meta.expires || null,
       expired: expiresAt < now,
+      requiredCcRuntime: meta.requiredCcRuntime || null,
     };
   });
 }

package/engine.js

@@ -823,7 +823,9 @@ async function spawnAgent(dispatchItem, config) {
     shared.assertWorktreeOutsideProject(worktreePath, rootDir);
 
     // If branch is already checked out in an existing worktree, reuse it
+    _phaseT.findExistingStart = Date.now();
     const existingWt = await findExistingWorktree(rootDir, branchName);
+    _phaseT.findExistingEnd = Date.now();
     if (existingWt) {
       // Same guard for reuse — a previously-created bad worktree must not
       // be silently reused either; the cleanup sweep flags these so the
@@ -834,13 +836,16 @@ async function spawnAgent(dispatchItem, config) {
       // Probe origin first — locally-created branches that were never pushed
       // (orphan/timeout retry before first push) would otherwise emit a
       // "couldn't find remote ref" warn pair on every reuse.
+      _phaseT.reuseSyncStart = Date.now();
       await syncReusedWorktree(rootDir, existingWt, branchName, _gitOpts);
+      _phaseT.reuseSyncEnd = Date.now();
     } else if (READ_ONLY_ROOT_TASK_TYPES.has(type) && !isPipelineBranchName(branchName)) {
       // Read-only tasks — no worktree needed, run in rootDir
       log('info', `${type}: read-only task, no worktree needed — running in rootDir`);
       branchName = null;
       worktreePath = null;
     } else {
+      _phaseT.createWorktreeStart = Date.now();
       try {
         if (!fs.existsSync(worktreePath)) {
           const isSharedBranch = meta?.branchStrategy === 'shared-branch' || meta?.useExistingBranch;
@@ -965,6 +970,7 @@ async function spawnAgent(dispatchItem, config) {
           return null;
         }
       }
+      _phaseT.createWorktreeEnd = Date.now();
     }
 
     // Shared-branch preflight (#2439): refuse to dispatch into a dirty shared
@@ -974,7 +980,9 @@ async function spawnAgent(dispatchItem, config) {
     // fires AFTER spawn — converting orchestration hygiene into fake
     // implementation failures and cascading dependent items.
     if (worktreePath && fs.existsSync(worktreePath) && meta?.branchStrategy === 'shared-branch' && branchName) {
+      _phaseT.cleanCheckStart = Date.now();
       const cleanResult = await assertCleanSharedWorktree(rootDir, worktreePath, branchName, id, _gitOpts);
+      _phaseT.cleanCheckEnd = Date.now();
       if (!cleanResult.clean) {
         const previewFiles = (cleanResult.dirtyFiles || []).slice(0, 5).join(', ');
         const reasonMsg = `DIRTY_WORKTREE: shared branch ${branchName} worktree at ${worktreePath} is dirty (${cleanResult.reason}); ${cleanResult.dirtyFiles?.length || 0} file(s)${previewFiles ? ': ' + previewFiles : ''}`;
@@ -1281,6 +1289,7 @@ async function spawnAgent(dispatchItem, config) {
   // Inject dirty file list when worktree has uncommitted changes (e.g., max_turns retry)
   // This signals to the respawned agent that prior work exists in the worktree (#960)
   if (worktreePath && fs.existsSync(worktreePath)) {
+    _phaseT.dirtyProbeStart = Date.now();
     try {
       const dirtyResult = await execAsync('git status --porcelain', { ..._gitOpts, cwd: worktreePath, timeout: 10000 });
       const dirtyOutput = (dirtyResult.stdout || '').trim();
@@ -1298,6 +1307,7 @@ async function spawnAgent(dispatchItem, config) {
         log('info', `Injected ${dirtyFiles.length} dirty files into prompt for ${id}`);
       }
     } catch (e) { log('warn', `git status --porcelain for dirty files: ${e.message}`); }
+    _phaseT.dirtyProbeEnd = Date.now();
   }
 
   // Safety check: warn if a write-capable task is running in the main repo without a worktree
@@ -1504,6 +1514,11 @@ async function spawnAgent(dispatchItem, config) {
     const timings = {
       prompt: _diff('start', 'afterPrompt'),
       worktree_total: _diff('afterPrompt', 'afterWorktree'),
+      wt_find_existing: _diff('findExistingStart', 'findExistingEnd'),
+      wt_reuse_sync: _diff('reuseSyncStart', 'reuseSyncEnd'),
+      wt_create: _diff('createWorktreeStart', 'createWorktreeEnd'),
+      wt_clean_check: _diff('cleanCheckStart', 'cleanCheckEnd'),
+      wt_dirty_probe: _diff('dirtyProbeStart', 'dirtyProbeEnd'),
       dep_fetch: _diff('depFetchStart', 'depFetchEnd'),
       dep_preflight: _diff('depPreflightStart', 'depPreflightEnd'),
       dep_merge: _diff('depMergeStart', 'depMergeEnd'),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1927",
+  "version": "0.1.1929",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"