@yemi33/minions 0.1.1924 → 0.1.1925

package/dashboard.js

@@ -1190,21 +1190,24 @@ function getDiskVersion() {
 }
 
 // ── MCP server discovery ─────────────────────────────────────────────────────
-// Mirrors what each CLI actually loads at runtime:
-//   • `claude mcp list`         → user + plugin (+ workspace if cwd in project)
-//   • `copilot mcp list --json` → user + workspace + plugin + builtin (merged)
+// Reads MCP server registrations directly from each CLI's config file:
+//   • `~/.claude.json` → `mcpServers` (Claude user scope)
+//   • `~/.copilot/mcp-config.json` → `mcpServers` (Copilot user scope)
 //   • Each registered project's `<localPath>/.mcp.json` → workspace scope
 //
-// CLI calls are slow (claude health-checks every server on stdio), so we cache
-// for ~5 minutes and refresh in the background. getMcpServers() always returns
-// synchronously from cache; first call before background fill returns [].
+// We used to shell out to `claude mcp list` + `copilot mcp list --json`, but
+// `claude mcp list` blocks on a TTY check when the dashboard daemon has no
+// parent console (bin/minions.js spawns it with windowsHide:true), so every
+// refresh timed out and the cache stayed empty. File reads are zero-spawn and
+// the config files are the authoritative source for registration.
+//
+// Cost: we lose live connection status (✓ Connected / ! Needs auth) and the
+// Claude plugin: <plugin>:<server> rows. The UI shows status only in a hover
+// tooltip, and plugin servers are rare; reliability matters more.
 
 const _MCP_CACHE_TTL = 5 * 60 * 1000;
-const _MCP_CLAUDE_TIMEOUT = 30000;
-const _MCP_COPILOT_TIMEOUT = 15000;
 let _mcpServersCache = null;
 let _mcpServersCacheTs = 0;
-let _mcpRefreshInflight = null;
 
 function _parseClaudeMcpListLine(line) {
   const trimmed = (line || '').trim();
@@ -1248,19 +1251,43 @@ function _parseCopilotMcpListJson(raw) {
   } catch { return []; }
 }
 
-function _runCliAsync(cmd, args, timeoutMs) {
-  return new Promise(resolve => {
-    try {
-      const { exec } = require('child_process');
-      // exec() runs through the shell so Windows resolves .cmd/.exe shims off
-      // PATH. Args are static so there's no injection surface.
-      const line = [cmd, ...args].join(' ');
-      exec(line, {
-        timeout: timeoutMs, windowsHide: true, encoding: 'utf8',
-        maxBuffer: 1024 * 1024,
-      }, (err, stdout) => resolve(err ? null : stdout));
-    } catch { resolve(null); }
-  });
+// Read Claude's user-scope MCP servers from `~/.claude.json` directly.
+// Shelling out to `claude mcp list` is unreliable from the dashboard daemon —
+// the CLI's MCP health probes block on a TTY check when the parent has no
+// console (bin/minions.js launches the dashboard with windowsHide:true), and
+// neither exec() nor spawn(..., {detached:true}) reliably sidesteps it.
+// Config-file reads are zero-spawn, instant, and the file is the authoritative
+// source for which servers are registered.
+function _readClaudeUserMcpServers() {
+  try {
+    const data = safeJsonObj(path.join(os.homedir(), '.claude.json'));
+    const servers = data?.mcpServers || {};
+    return Object.entries(servers).map(([name, cfg]) => ({
+      name,
+      source: 'Claude user',
+      command: cfg.command || cfg.url || '',
+      args: Array.isArray(cfg.args) ? cfg.args.join(' ') : (cfg.args || ''),
+    }));
+  } catch { return []; }
+}
+
+// Copilot stores its MCP config at `~/.copilot/mcp-config.json` (may have a
+// UTF-8 BOM — Windows tooling tends to write one).
+function _readCopilotUserMcpServers() {
+  try {
+    const configPath = path.join(os.homedir(), '.copilot', 'mcp-config.json');
+    if (!fs.existsSync(configPath)) return [];
+    let raw = fs.readFileSync(configPath, 'utf8');
+    if (raw.charCodeAt(0) === 0xFEFF) raw = raw.slice(1);
+    const data = JSON.parse(raw);
+    const servers = data?.mcpServers || {};
+    return Object.entries(servers).map(([name, cfg]) => ({
+      name,
+      source: 'Copilot',
+      command: cfg.command || cfg.url || '',
+      args: Array.isArray(cfg.args) ? cfg.args.join(' ') : (cfg.args || ''),
+    }));
+  } catch { return []; }
 }
 
 function _readWorkspaceMcpServers(projects) {
@@ -1293,42 +1320,26 @@ function _dedupeMcpServers(entries) {
   return out;
 }
 
-async function _refreshMcpServersCache() {
-  if (_mcpRefreshInflight) return _mcpRefreshInflight;
-  _mcpRefreshInflight = (async () => {
-    try {
-      const [claudeOut, copilotOut] = await Promise.all([
-        _runCliAsync('claude', ['mcp', 'list'], _MCP_CLAUDE_TIMEOUT),
-        _runCliAsync('copilot', ['mcp', 'list', '--json'], _MCP_COPILOT_TIMEOUT),
-      ]);
-      const claudeEntries = (claudeOut || '').split(/\r?\n/).map(_parseClaudeMcpListLine).filter(Boolean);
-      const copilotEntries = _parseCopilotMcpListJson(copilotOut || '{}');
-      const workspaceEntries = _readWorkspaceMcpServers(PROJECTS);
-      _mcpServersCache = _dedupeMcpServers([...claudeEntries, ...copilotEntries, ...workspaceEntries]);
-      _mcpServersCacheTs = Date.now();
-    } catch (e) {
-      console.error('[mcp-discovery] refresh failed:', e.message?.split('\n')?.[0]);
-      if (!_mcpServersCache) _mcpServersCache = [];
-      _mcpServersCacheTs = Date.now();
-    } finally {
-      _mcpRefreshInflight = null;
-    }
-  })();
-  return _mcpRefreshInflight;
-}
-
 function getMcpServers() {
   const now = Date.now();
-  if (!_mcpServersCache || (now - _mcpServersCacheTs) >= _MCP_CACHE_TTL) {
-    _refreshMcpServersCache().catch(() => {});
+  if (_mcpServersCache && (now - _mcpServersCacheTs) < _MCP_CACHE_TTL) {
+    return _mcpServersCache;
+  }
+  try {
+    const entries = [
+      ..._readClaudeUserMcpServers(),
+      ..._readCopilotUserMcpServers(),
+      ..._readWorkspaceMcpServers(PROJECTS),
+    ];
+    _mcpServersCache = _dedupeMcpServers(entries);
+  } catch (e) {
+    console.error('[mcp-discovery] refresh failed:', e.message?.split('\n')?.[0]);
+    if (!_mcpServersCache) _mcpServersCache = [];
   }
-  return _mcpServersCache || [];
+  _mcpServersCacheTs = now;
+  return _mcpServersCache;
 }
 
-// Kick off first discovery on startup so the dashboard has data before the
-// first slow-state rebuild.
-_refreshMcpServersCache().catch(() => {});
-
 function parsePinnedEntries(content) {
   if (!content) return [];
   const entries = [];

package/engine/copilot-models.json

@@ -0,0 +1,5 @@
+{
+  "runtime": "copilot",
+  "models": null,
+  "cachedAt": "2026-05-14T02:03:25.197Z"
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1924",
+  "version": "0.1.1925",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"