@yemi33/minions 0.1.1905 → 0.1.1907

package/bin/minions.js

@@ -168,12 +168,26 @@ function killMinionsProcesses(patterns) {
   } catch {}
 }
 
+/** Open append-mode FDs under engine/ for detached-process stdio. If the file
+ *  can't be opened we fall back to 'ignore' rather than blocking the restart. */
+function _openStdioLog(name) {
+  try {
+    const dir = path.join(MINIONS_HOME, 'engine');
+    if (!fs.existsSync(dir)) fs.mkdirSync(dir, { recursive: true });
+    return fs.openSync(path.join(dir, name), 'a');
+  } catch { return 'ignore'; }
+}
+
 /** Spawn a detached dashboard with self-open suppressed — the CLI decides
- *  when to open a browser based on whether a real tab reconnects post-health. */
+ *  when to open a browser based on whether a real tab reconnects post-health.
+ *  stdout/stderr land in engine/dashboard-stdio.log so silent startup crashes
+ *  leave a postmortem instead of vanishing. */
 function spawnDashboard() {
   const env = { ...process.env, MINIONS_NO_AUTO_OPEN: '1' };
+  const out = _openStdioLog('dashboard-stdio.log');
+  const err = _openStdioLog('dashboard-stdio.log');
   const proc = spawn(process.execPath, [path.join(MINIONS_HOME, 'dashboard.js')], {
-    cwd: MINIONS_HOME, stdio: 'ignore', detached: true, windowsHide: true, env
+    cwd: MINIONS_HOME, stdio: ['ignore', out, err], detached: true, windowsHide: true, env
   });
   proc.unref();
   return proc;
@@ -736,8 +750,10 @@ if (!cmd || cmd === 'help' || cmd === '--help' || cmd === '-h') {
   // Clear stale beacons AFTER the kill so the old dashboard's last writes
   // can't repopulate the file in the gap between clear and shutdown.
   _clearDashboardBrowserState(MINIONS_HOME);
+  const engineOut = _openStdioLog('engine-stdio.log');
+  const engineErr = _openStdioLog('engine-stdio.log');
   const engineProc = spawn(process.execPath, [path.join(MINIONS_HOME, 'engine.js'), 'start', ...rest], {
-    cwd: MINIONS_HOME, stdio: 'ignore', detached: true, windowsHide: true
+    cwd: MINIONS_HOME, stdio: ['ignore', engineOut, engineErr], detached: true, windowsHide: true
   });
   engineProc.unref();
   console.log(`\n  Engine started (PID: ${engineProc.pid})`);

package/engine/copilot-models.json

@@ -0,0 +1,5 @@
+{
+  "runtime": "copilot",
+  "models": null,
+  "cachedAt": "2026-05-12T22:39:24.196Z"
+}

package/engine/lifecycle.js

@@ -1847,15 +1847,32 @@ function recordPrNoOpFixAttempt(target, cause, source, dispatchItem, branchChang
   // filter can short-circuit duplicate build-fix dispatches against an
   // unchanged commit. Reset happens implicitly when headSha advances and the
   // discovery filter compares lastDispatchHeadSha to the current head.
+  //
+  // Tracking is partitioned by cause (`_lastDispatchByCause[cause]`) so a
+  // human-feedback noop on head X never suppresses an unrelated build-failure
+  // dispatch on head X (the PR-wide top-level fields would, see
+  // W-mp2vohea00112739). The legacy top-level fields are kept in sync for
+  // any external consumer (dashboards, debugging) but the build-fix
+  // eligibility filter reads ONLY the per-cause map.
   const headSha = getPrFixBaselineHead(target);
-  target.lastDispatchedAt = now;
-  target.lastDispatchOutcome = 'noop';
-  target.lastDispatchHeadSha = headSha;
-  target.lastDispatchReason = String(
+  const reasonText = String(
     noopReason
       || branchChange?.reason
       || 'fix completed without changing the PR branch'
   ).slice(0, 500);
+  target._lastDispatchByCause = target._lastDispatchByCause
+    && typeof target._lastDispatchByCause === 'object' ? target._lastDispatchByCause : {};
+  target._lastDispatchByCause[cause] = {
+    outcome: 'noop',
+    headSha,
+    reason: reasonText,
+    dispatchedAt: now,
+    dispatchId: dispatchItem?.id || null,
+  };
+  target.lastDispatchedAt = now;
+  target.lastDispatchOutcome = 'noop';
+  target.lastDispatchHeadSha = headSha;
+  target.lastDispatchReason = reasonText;
 
   if (cause === shared.PR_FIX_CAUSE.HUMAN_FEEDBACK && target.humanFeedback) {
     target.humanFeedback.pendingFix = !paused;
@@ -1877,10 +1894,19 @@ function clearPrNoOpFixAttempt(target, cause) {
   // the same head; once the agent actually pushed a fix we no longer want them
   // to suppress a fresh dispatch (the SHA may have moved or the next failure
   // is genuinely new).
-  delete target.lastDispatchedAt;
-  delete target.lastDispatchOutcome;
-  delete target.lastDispatchHeadSha;
-  delete target.lastDispatchReason;
+  if (target._lastDispatchByCause && typeof target._lastDispatchByCause === 'object') {
+    delete target._lastDispatchByCause[cause];
+    if (Object.keys(target._lastDispatchByCause).length === 0) delete target._lastDispatchByCause;
+  }
+  // Only clear the legacy top-level fields when no other cause still has a
+  // tracked noop — otherwise a successful fix for cause A would silently wipe
+  // out the same-head suppression record for unrelated cause B.
+  if (!target._lastDispatchByCause) {
+    delete target.lastDispatchedAt;
+    delete target.lastDispatchOutcome;
+    delete target.lastDispatchHeadSha;
+    delete target.lastDispatchReason;
+  }
 }
 
 function updatePrAfterFix(pr, project, source, options = {}, legacyDispatchId = '') {

package/engine/restart-health.js

@@ -92,7 +92,7 @@ async function checkRestartHealth(options = {}) {
   const engineAlive = pid ? isAlive(pid) : false;
   const engineOk = control && control.state === 'running' && engineAlive;
 
-  const dashboard = await getJson(dashboardUrl, 1000);
+  const dashboard = await getJson(dashboardUrl, 3000);
   const dashboardStatus = dashboard && dashboard.json && dashboard.json.status;
   const dashboardOk = !!(dashboard && dashboard.ok && dashboardStatus === 'healthy');
 

package/engine.js

@@ -2971,18 +2971,25 @@ async function discoverFromPrs(config, project) {
     const autoFixBuilds = config.engine?.autoFixBuilds ?? ENGINE_DEFAULTS.autoFixBuilds;
     if (pollEnabled && autoFixBuilds && pr.status === PR_STATUS.ACTIVE && pr.buildStatus === 'failing'
       && !isPrNoOpFixCauseSuppressed(pr, shared.PR_FIX_CAUSE.BUILD_FAILURE)) {
-      // P-b7e1c4d2: skip when the most recent dispatch already noop'd against
-      // the same head SHA — chronic across PRs #2315–#2323 where every fix
-      // agent rebutted "this is a pre-existing master baseline" but the
-      // cached buildStatus:failing kept re-triggering the loop. The check
-      // clears automatically once a new commit lands (lastDispatchHeadSha
-      // stops matching the current head).
+      // P-b7e1c4d2: skip when the most recent BUILD-FAILURE dispatch already
+      // noop'd against the same head SHA — chronic across PRs #2315–#2323
+      // where every fix agent rebutted "this is a pre-existing master baseline"
+      // but the cached buildStatus:failing kept re-triggering the loop. The
+      // check clears automatically once a new commit lands (the per-cause
+      // headSha stops matching the current head).
+      //
+      // W-mp2vohea00112739: this guard reads `_lastDispatchByCause['build-failure']`
+      // instead of the PR-wide `lastDispatch*` fields. The PR-wide fields are
+      // shared across all causes, so a `human-feedback` noop on head X used to
+      // suppress an unrelated `build-failure` dispatch on the same head until
+      // a new commit landed (live repro on PR #2433).
       const currentHeadSha = String(pr.headSha || pr._adoSourceCommit || pr._adoHeadCommit || '').trim();
-      if (pr.lastDispatchOutcome === 'noop'
-        && pr.lastDispatchHeadSha
+      const lastBuildDispatch = pr._lastDispatchByCause?.[shared.PR_FIX_CAUSE.BUILD_FAILURE];
+      if (lastBuildDispatch?.outcome === 'noop'
+        && lastBuildDispatch.headSha
         && currentHeadSha
-        && pr.lastDispatchHeadSha === currentHeadSha) {
-        log('info', `Skipping build-fix for ${pr.id}: last dispatch was noop on the same head ${currentHeadSha.slice(0, 8)} (${(pr.lastDispatchReason || '').slice(0, 120)})`);
+        && lastBuildDispatch.headSha === currentHeadSha) {
+        log('info', `Skipping build-fix for ${pr.id}: last build-failure dispatch was noop on the same head ${currentHeadSha.slice(0, 8)} (${(lastBuildDispatch.reason || '').slice(0, 120)})`);
         continue;
       }
       const buildCauseKey = getPrAutomationCauseKey('build', pr);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1905",
+  "version": "0.1.1907",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"