@yemi33/minions 0.1.1904 → 0.1.1905

package/engine/github.js

@@ -85,9 +85,54 @@ function _isNonActionableComment(c, config = {}) {
   if (_isAgentComment(c)) return true;
   if (_isCiReportCommentBody(c?.body)) return true;
   if (_isPreviewStatusComment(c)) return true;
+  if (_isAgentPositiveSignalComment(c, config)) return true;
   return false;
 }
 
+// P-a3f9b2c1 — Detect agent self-positive-signal comments (verification SUCCESS reports,
+// VERDICT:APPROVE recaps, noop:true confessions) posted via the shared `gh` PAT identity.
+//
+// Sibling to PR #2431's `_isAgentSelfReviewDeclinedComment` but keys off body-shape markers
+// + an opt-in shared-minions login allowlist (REST `/issues/:n/comments` doesn't expose
+// GraphQL's `viewerDidAuthor` flag, so we approximate via configured logins).
+//
+// Configuration:
+//   engine.botCommentLogins: string[]  — primary opt-in list (e.g. ['yemi33'])
+//   engine.ignoredCommentAuthors: string[]  — fallback (back-compat with existing knob)
+//
+// Reference: PR #2433 (3 consecutive noop fix-dispatches when verify agents posted
+// "Result: SUCCESS" comments via the shared yemi33 PAT identity).
+function _sharedMinionsLogins(config = {}) {
+  const primary = Array.isArray(config?.engine?.botCommentLogins) ? config.engine.botCommentLogins : [];
+  const fallback = Array.isArray(config?.engine?.ignoredCommentAuthors) ? config.engine.ignoredCommentAuthors : [];
+  return new Set([...primary, ...fallback].map(s => String(s || '').toLowerCase()).filter(Boolean));
+}
+
+// Pure body-shape matcher for agent positive-signal markers in PR comments.
+// Triggers on:
+//   - "Verification SUCCESS" / "Verification SUCCEEDED" / "Verification ran" (verify-dispatch reports)
+//   - "Result: SUCCESS" (verify-dispatch report header per playbooks/verify.md)
+//   - "VERDICT: APPROVE" (review-loop positive verdict — defense-in-depth alongside _hasMinionsReviewVerdict)
+//   - `noop: true` / `"noop": true` (completion-report-style noop confession copied to comment)
+function _hasAgentPositiveSignalBody(body) {
+  const text = String(body || '');
+  if (!text) return false;
+  if (/(?:^|\n)\s*\*{0,2}VERDICT[:\s]+\*{0,2}APPROVE\b/i.test(text)) return true;
+  if (/"?\bnoop\b"?\s*:\s*true\b/i.test(text)) return true;
+  if (/\bVerification\s+(?:SUCCESS(?:FUL|FULLY)?|SUCCEEDED|ran)\b/i.test(text)) return true;
+  if (/(?:^|\n)\s*#{0,3}\s*Result\s*:\s*SUCCESS\b/i.test(text)) return true;
+  return false;
+}
+
+function _isAgentPositiveSignalComment(c, config = {}) {
+  if (!c) return false;
+  const sharedLogins = _sharedMinionsLogins(config);
+  if (sharedLogins.size === 0) return false;
+  const login = String(c?.user?.login || '').toLowerCase();
+  if (!login || !sharedLogins.has(login)) return false;
+  return _hasAgentPositiveSignalBody(c.body);
+}
+
 // W-mp2h696g000a7bc0 — Detect agent self-review-declined no-op comments.
 //
 // Per the documented contract (memory `subject: self-review`, docs/completion-reports.md:83-105):
@@ -838,6 +883,26 @@ async function pollPrHumanComments(config) {
     }
     if (newComments.length === 0) return false;
 
+    // P-a3f9b2c1 — Defense-in-depth: when the PR is already approved AND every new comment
+    // is from a configured shared-minions PAT identity AND every new comment matches the
+    // positive-signal body shape, suppress pendingFix and advance cutoff. Belt-and-suspenders
+    // against future regressions in `_isAgentPositiveSignalComment`. This is intentionally
+    // narrow — a single human-shaped comment in newComments (e.g. "rename _foo to bar") will
+    // disqualify the entire batch and let the normal human-feedback flow run.
+    if (String(pr.reviewStatus || '').toLowerCase() === 'approved') {
+      const sharedLogins = _sharedMinionsLogins(config);
+      if (sharedLogins.size > 0) {
+        const allFromSharedPat = newComments.every(nc => sharedLogins.has(String(nc.author || '').toLowerCase()));
+        const allPositiveShape = newComments.every(nc => _hasAgentPositiveSignalBody(nc.content));
+        if (allFromSharedPat && allPositiveShape) {
+          const cutoff = allNewDates.sort().pop() || newComments[newComments.length - 1].date;
+          pr.humanFeedback = { ...(pr.humanFeedback || {}), lastProcessedCommentDate: cutoff };
+          log('info', `PR ${pr.id}: ${newComments.length} new shared-PAT positive-signal comment(s) on approved PR — defense-in-depth suppression`);
+          return true;
+        }
+      }
+    }
+
     // Sort all comments chronologically and build full context for the fix agent
     allCommentEntries.sort((a, b) => a.date.localeCompare(b.date));
     newComments.sort((a, b) => a.date.localeCompare(b.date));
@@ -1136,5 +1201,8 @@ module.exports = {
   _isAgentComment, // exported for testing
   _isNonActionableComment, // exported for testing
   _isAgentSelfReviewDeclinedComment, // exported for testing
+  _isAgentPositiveSignalComment, // exported for testing (P-a3f9b2c1)
+  _hasAgentPositiveSignalBody, // exported for testing (P-a3f9b2c1)
+  _sharedMinionsLogins, // exported for testing (P-a3f9b2c1)
   _isPreviewStatusComment, // exported for testing
 };

package/engine/shared.js

@@ -1099,6 +1099,7 @@ const ENGINE_DEFAULTS = {
   autoCompletePrs: false, // auto-merge PRs when builds green + review approved (opt-in)
   prMergeMethod: 'squash', // merge method: squash, merge, rebase
   ignoredCommentAuthors: [], // comments from these authors are auto-closed and never trigger fixes
+  botCommentLogins: [], // P-a3f9b2c1: opt-in shared-minions GH login list — comments from these logins are suppressed ONLY when body matches positive-signal markers (Verification SUCCESS / VERDICT:APPROVE / noop:true). Narrower than ignoredCommentAuthors which suppresses all comments by login.
   agentBusyReassignMs: 600000, // 10min — reassign work item to another agent if preferred agent is busy beyond this threshold
   ccEffort: null, // effort level for CC/doc-chat (null, 'low', 'medium', 'high')
   enablePreDispatchEval: false, // opt-in: cheap LLM gate before queueing — see engine/pre-dispatch-eval.js (Ripley §3 recommendation, 2026-05-11 architecture review)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1904",
+  "version": "0.1.1905",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"