@yemi33/minions 0.1.1903 → 0.1.1905

package/dashboard.js

@@ -73,19 +73,9 @@ function ensureConfiguredProjectStateFiles() {
     const root = p.localPath ? path.resolve(p.localPath) : null;
     if (!root || !fs.existsSync(root)) continue;
     try {
-      const state = shared.ensureProjectStateFiles(p, { migrateLegacy: true, removeLegacy: true });
-      if (state.migrated.length > 0 || state.removedLegacy.length > 0 || state.legacyDirRemoved) {
-        const parts = [];
-        if (state.migrated.length > 0) parts.push(`merged ${state.migrated.join(', ')}`);
-        if (state.removedLegacy.length > 0) parts.push(`removed ${state.removedLegacy.join(', ')}`);
-        if (state.legacyDirRemoved) parts.push(`removed legacy .minions dir`);
-        console.log(`[dashboard] migrated project state for "${p.name}" → projects/${p.name} (${parts.join('; ')})`);
-      }
-      if (state.legacyDirRemoveError) {
-        console.warn(`[dashboard] failed to remove legacy .minions dir for "${p.name}": ${state.legacyDirRemoveError}`);
-      }
+      shared.ensureProjectStateFiles(p);
     } catch (e) {
-      console.warn(`[dashboard] project state migration failed for "${p.name}": ${e.message}`);
+      console.warn(`[dashboard] project state setup failed for "${p.name}": ${e.message}`);
     }
   }
 }
@@ -5716,9 +5706,8 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         prUrlBase: detected.prUrlBase,
       });
 
-      // Create centralized project state and migrate any legacy project-local
-      // .minions state without leaving repo-local state files behind.
-      shared.ensureProjectStateFiles(project, { migrateLegacy: true, removeLegacy: true });
+      // Create centralized project state files.
+      shared.ensureProjectStateFiles(project);
 
       let duplicate = false;
       mutateDashboardConfig(config => {

package/docs/deprecated.json

@@ -1,10 +1 @@
-[
-  {
-    "id": "project-local-minions-state",
-    "summary": "Project-local .minions directories are migrated to central projects/<name>/ state and removed",
-    "deprecated": "2026-05-06",
-    "reason": "Project repos should not receive Minions runtime state because .minions can leak into source repositories.",
-    "locations": ["engine/shared.js ensureProjectStateFiles legacy migration", "dashboard.js handleProjectsAdd/dashboard startup", "minions.js addProject/scanAndAdd", "engine/cli.js start migration", "bin/minions.js user-scoped init root"],
-    "cleanup": "Remove legacyProjectStateDir/legacyProjectStatePath migration/deletion after existing project-local .minions directories have been migrated."
-  }
-]
+[]

package/engine/cli.js

@@ -468,20 +468,9 @@ const commands = {
         console.log(`  WARNING: ${p.name} path not found: ${p.localPath}`);
       } else {
         try {
-          const state = shared.ensureProjectStateFiles(p, { migrateLegacy: true, removeLegacy: true });
-          if (state.migrated.length > 0 || state.removedLegacy.length > 0 || state.legacyDirRemoved) {
-            const parts = [];
-            if (state.migrated.length > 0) parts.push(`merged ${state.migrated.join(', ')}`);
-            if (state.removedLegacy.length > 0) parts.push(`removed ${state.removedLegacy.join(', ')}`);
-            if (state.legacyDirRemoved) parts.push(`removed legacy .minions dir`);
-            e.log('info', `Migrated project state for "${p.name}" → projects/${p.name} (${parts.join('; ')})`);
-          }
-          if (state.legacyDirRemoveError) {
-            e.log('warn', `Failed to remove legacy .minions dir for "${p.name}": ${state.legacyDirRemoveError}`);
-            console.log(`  WARNING: legacy .minions dir for "${p.name}" could not be removed: ${state.legacyDirRemoveError}`);
-          }
+          shared.ensureProjectStateFiles(p);
         } catch (err) {
-          e.log('warn', `Project state migration failed for "${p.name}": ${err.message}`);
+          e.log('warn', `Project state setup failed for "${p.name}": ${err.message}`);
         }
         console.log(`  Project: ${p.name} (${root})`);
       }

package/engine/github.js

@@ -85,9 +85,54 @@ function _isNonActionableComment(c, config = {}) {
   if (_isAgentComment(c)) return true;
   if (_isCiReportCommentBody(c?.body)) return true;
   if (_isPreviewStatusComment(c)) return true;
+  if (_isAgentPositiveSignalComment(c, config)) return true;
   return false;
 }
 
+// P-a3f9b2c1 — Detect agent self-positive-signal comments (verification SUCCESS reports,
+// VERDICT:APPROVE recaps, noop:true confessions) posted via the shared `gh` PAT identity.
+//
+// Sibling to PR #2431's `_isAgentSelfReviewDeclinedComment` but keys off body-shape markers
+// + an opt-in shared-minions login allowlist (REST `/issues/:n/comments` doesn't expose
+// GraphQL's `viewerDidAuthor` flag, so we approximate via configured logins).
+//
+// Configuration:
+//   engine.botCommentLogins: string[]  — primary opt-in list (e.g. ['yemi33'])
+//   engine.ignoredCommentAuthors: string[]  — fallback (back-compat with existing knob)
+//
+// Reference: PR #2433 (3 consecutive noop fix-dispatches when verify agents posted
+// "Result: SUCCESS" comments via the shared yemi33 PAT identity).
+function _sharedMinionsLogins(config = {}) {
+  const primary = Array.isArray(config?.engine?.botCommentLogins) ? config.engine.botCommentLogins : [];
+  const fallback = Array.isArray(config?.engine?.ignoredCommentAuthors) ? config.engine.ignoredCommentAuthors : [];
+  return new Set([...primary, ...fallback].map(s => String(s || '').toLowerCase()).filter(Boolean));
+}
+
+// Pure body-shape matcher for agent positive-signal markers in PR comments.
+// Triggers on:
+//   - "Verification SUCCESS" / "Verification SUCCEEDED" / "Verification ran" (verify-dispatch reports)
+//   - "Result: SUCCESS" (verify-dispatch report header per playbooks/verify.md)
+//   - "VERDICT: APPROVE" (review-loop positive verdict — defense-in-depth alongside _hasMinionsReviewVerdict)
+//   - `noop: true` / `"noop": true` (completion-report-style noop confession copied to comment)
+function _hasAgentPositiveSignalBody(body) {
+  const text = String(body || '');
+  if (!text) return false;
+  if (/(?:^|\n)\s*\*{0,2}VERDICT[:\s]+\*{0,2}APPROVE\b/i.test(text)) return true;
+  if (/"?\bnoop\b"?\s*:\s*true\b/i.test(text)) return true;
+  if (/\bVerification\s+(?:SUCCESS(?:FUL|FULLY)?|SUCCEEDED|ran)\b/i.test(text)) return true;
+  if (/(?:^|\n)\s*#{0,3}\s*Result\s*:\s*SUCCESS\b/i.test(text)) return true;
+  return false;
+}
+
+function _isAgentPositiveSignalComment(c, config = {}) {
+  if (!c) return false;
+  const sharedLogins = _sharedMinionsLogins(config);
+  if (sharedLogins.size === 0) return false;
+  const login = String(c?.user?.login || '').toLowerCase();
+  if (!login || !sharedLogins.has(login)) return false;
+  return _hasAgentPositiveSignalBody(c.body);
+}
+
 // W-mp2h696g000a7bc0 — Detect agent self-review-declined no-op comments.
 //
 // Per the documented contract (memory `subject: self-review`, docs/completion-reports.md:83-105):
@@ -838,6 +883,26 @@ async function pollPrHumanComments(config) {
     }
     if (newComments.length === 0) return false;
 
+    // P-a3f9b2c1 — Defense-in-depth: when the PR is already approved AND every new comment
+    // is from a configured shared-minions PAT identity AND every new comment matches the
+    // positive-signal body shape, suppress pendingFix and advance cutoff. Belt-and-suspenders
+    // against future regressions in `_isAgentPositiveSignalComment`. This is intentionally
+    // narrow — a single human-shaped comment in newComments (e.g. "rename _foo to bar") will
+    // disqualify the entire batch and let the normal human-feedback flow run.
+    if (String(pr.reviewStatus || '').toLowerCase() === 'approved') {
+      const sharedLogins = _sharedMinionsLogins(config);
+      if (sharedLogins.size > 0) {
+        const allFromSharedPat = newComments.every(nc => sharedLogins.has(String(nc.author || '').toLowerCase()));
+        const allPositiveShape = newComments.every(nc => _hasAgentPositiveSignalBody(nc.content));
+        if (allFromSharedPat && allPositiveShape) {
+          const cutoff = allNewDates.sort().pop() || newComments[newComments.length - 1].date;
+          pr.humanFeedback = { ...(pr.humanFeedback || {}), lastProcessedCommentDate: cutoff };
+          log('info', `PR ${pr.id}: ${newComments.length} new shared-PAT positive-signal comment(s) on approved PR — defense-in-depth suppression`);
+          return true;
+        }
+      }
+    }
+
     // Sort all comments chronologically and build full context for the fix agent
     allCommentEntries.sort((a, b) => a.date.localeCompare(b.date));
     newComments.sort((a, b) => a.date.localeCompare(b.date));
@@ -1136,5 +1201,8 @@ module.exports = {
   _isAgentComment, // exported for testing
   _isNonActionableComment, // exported for testing
   _isAgentSelfReviewDeclinedComment, // exported for testing
+  _isAgentPositiveSignalComment, // exported for testing (P-a3f9b2c1)
+  _hasAgentPositiveSignalBody, // exported for testing (P-a3f9b2c1)
+  _sharedMinionsLogins, // exported for testing (P-a3f9b2c1)
   _isPreviewStatusComment, // exported for testing
 };

package/engine/shared.js

@@ -1099,6 +1099,7 @@ const ENGINE_DEFAULTS = {
   autoCompletePrs: false, // auto-merge PRs when builds green + review approved (opt-in)
   prMergeMethod: 'squash', // merge method: squash, merge, rebase
   ignoredCommentAuthors: [], // comments from these authors are auto-closed and never trigger fixes
+  botCommentLogins: [], // P-a3f9b2c1: opt-in shared-minions GH login list — comments from these logins are suppressed ONLY when body matches positive-signal markers (Verification SUCCESS / VERDICT:APPROVE / noop:true). Narrower than ignoredCommentAuthors which suppresses all comments by login.
   agentBusyReassignMs: 600000, // 10min — reassign work item to another agent if preferred agent is busy beyond this threshold
   ccEffort: null, // effort level for CC/doc-chat (null, 'low', 'medium', 'high')
   enablePreDispatchEval: false, // opt-in: cheap LLM gate before queueing — see engine/pre-dispatch-eval.js (Ripley §3 recommendation, 2026-05-11 architecture review)
@@ -1967,9 +1968,6 @@ function resolveProjectSource(source, projectsOrConfig, options = {}) {
       projectStateDir(project),
       projectWorkItemsPath(project),
       projectPrPath(project),
-      legacyProjectStateDir(project),
-      legacyProjectStatePath(project, 'work-items.json'),
-      legacyProjectStatePath(project, 'pull-requests.json'),
     ].filter(Boolean);
     if (candidates.some(candidate => _sameSourcePath(value, candidate, minionsDir))) {
       return _projectSourceDescriptor(project, value, explicit, minionsDir);
@@ -2023,36 +2021,6 @@ function projectPrPath(project) {
   return path.join(projectStateDir(project), 'pull-requests.json');
 }
 
-function legacyProjectStateDir(project) {
-  if (!project?.localPath) return null;
-  return path.join(path.resolve(project.localPath), '.minions');
-}
-
-function legacyProjectStatePath(project, fileName) {
-  const dir = legacyProjectStateDir(project);
-  return dir ? path.join(dir, fileName) : null;
-}
-
-function projectStateRecordKey(record) {
-  if (record && typeof record === 'object') {
-    const id = record.id ?? record.prId ?? record.workItemId ?? record.url ?? record.number;
-    if (id !== undefined && id !== null && String(id).trim()) return String(id);
-  }
-  try { return JSON.stringify(record); } catch { return String(record); }
-}
-
-function mergeProjectStateArrays(current, legacy) {
-  const merged = Array.isArray(current) ? current.slice() : [];
-  const seen = new Set(merged.map(projectStateRecordKey));
-  for (const entry of Array.isArray(legacy) ? legacy : []) {
-    const key = projectStateRecordKey(entry);
-    if (seen.has(key)) continue;
-    merged.push(entry);
-    seen.add(key);
-  }
-  return merged;
-}
-
 function sameResolvedPath(a, b) {
   if (!a || !b) return false;
   try {
@@ -2064,64 +2032,20 @@ function sameResolvedPath(a, b) {
   }
 }
 
-function removeLegacyProjectStateDir(project) {
-  const dir = legacyProjectStateDir(project);
-  if (!dir) return { removed: false, error: null };
-  if (sameResolvedPath(dir, MINIONS_DIR)) return { removed: false, error: null };
-  if (!fs.existsSync(dir)) return { removed: false, error: null };
-  try {
-    fs.rmSync(dir, { recursive: true, force: true });
-    return { removed: true, error: null };
-  } catch (err) {
-    return { removed: false, error: err && err.message ? err.message : String(err) };
-  }
-}
-
-function ensureProjectStateFiles(project, options = {}) {
-  const migrateLegacy = options.migrateLegacy !== false;
-  const removeLegacy = options.removeLegacy === true;
+function ensureProjectStateFiles(project) {
   const files = [
     { name: 'pull-requests.json', centralPath: projectPrPath(project) },
     { name: 'work-items.json', centralPath: projectWorkItemsPath(project) },
   ];
-  const result = { created: [], migrated: [], removedLegacy: [], legacyDirRemoved: false, legacyDirRemoveError: null };
+  const result = { created: [] };
 
   projectStateDirEnsure(project);
   for (const file of files) {
-    const legacyPath = legacyProjectStatePath(project, file.name);
-    const hasLegacyState = legacyPath && (fs.existsSync(legacyPath) || fs.existsSync(legacyPath + '.backup'));
-    const legacyData = migrateLegacy && hasLegacyState ? safeJson(legacyPath) : null;
-
-    if (Array.isArray(legacyData)) {
-      let changed = false;
-      mutateJsonFileLocked(file.centralPath, current => {
-        const merged = mergeProjectStateArrays(Array.isArray(current) ? current : [], legacyData);
-        changed = JSON.stringify(merged) !== JSON.stringify(current);
-        return merged;
-      }, { defaultValue: [], skipWriteIfUnchanged: true });
-      if (changed && legacyData.length > 0) result.migrated.push(file.name);
-      if (removeLegacy) {
-        try {
-          fs.unlinkSync(legacyPath);
-          result.removedLegacy.push(file.name);
-        } catch (err) {
-          if (!err || err.code !== 'ENOENT') throw err;
-        }
-        safeUnlink(legacyPath + '.backup');
-      }
-    }
-
     if (!fs.existsSync(file.centralPath)) {
       mutateJsonFileLocked(file.centralPath, data => Array.isArray(data) ? data : [], { defaultValue: [] });
       result.created.push(file.name);
     }
   }
-
-  if (removeLegacy) {
-    const res = removeLegacyProjectStateDir(project);
-    result.legacyDirRemoved = res.removed;
-    result.legacyDirRemoveError = res.error;
-  }
   return result;
 }
 
@@ -3620,12 +3544,8 @@ module.exports = {
   projectStateDirEnsure,
   projectWorkItemsPath,
   projectPrPath,
-  legacyProjectStateDir,
-  legacyProjectStatePath,
   ensureProjectStateFiles,
   sameResolvedPath,
-  projectStateRecordKey, // exported for testing
-  mergeProjectStateArrays, // exported for testing
   realPathForComparison, // exported for testing
   prPathComparisonCandidates, // exported for testing
   resolveProjectForPrPath, // exported for testing

package/minions.js

@@ -135,14 +135,11 @@ async function addProject(targetDir) {
     name, description, localPath: target, repoHost, repositoryId, org, project, repoName, mainBranch,
     prUrlBase: detected.prUrlBase,
   });
-  const state = shared.ensureProjectStateFiles(projectEntry, { migrateLegacy: true, removeLegacy: true });
+  shared.ensureProjectStateFiles(projectEntry);
   config.projects.push(projectEntry);
   saveConfig(config);
 
   console.log(`\n  Linked "${name}" (${target})`);
-  if (state.migrated.length > 0 || state.removedLegacy.length > 0) {
-    console.log(`  Migrated project state to ${shared.projectStateDir(projectEntry)}`);
-  }
   console.log(`  Total projects: ${config.projects.length}`);
   console.log(`\n  Start the minions from anywhere:`);
   console.log(`    node ${MINIONS_HOME}/engine.js         # Engine`);
@@ -359,7 +356,7 @@ async function scanAndAdd({ root, depth } = {}) {
       repoHost: repo.host, repositoryId: repo.repositoryId, org: repo.org, project: repo.project,
       repoName: repo.repoName, mainBranch: repo.mainBranch, prUrlBase: repo.prUrlBase,
     });
-    shared.ensureProjectStateFiles(projectEntry, { migrateLegacy: true, removeLegacy: true });
+    shared.ensureProjectStateFiles(projectEntry);
     config.projects.push(projectEntry);
     console.log(`  + ${name} (${repo.path})`);
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1903",
+  "version": "0.1.1905",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"