@yemi33/minions 0.1.1900 → 0.1.1902

package/engine/ado.js

@@ -1568,4 +1568,14 @@ module.exports = {
   _resetAdoThrottle, // exported for testing
   _setAdoThrottleForTest, // exported for testing
   _setAdoTokenForTest, // exported for testing
+  // Exported for unit tests — engine code MUST go through pollPrStatus / reconcilePrs.
+  decodeUrlSegment,
+  stripGitSuffix,
+  encodeAdoPathSegment,
+  buildAdoPrUrlBase,
+  adoRepoCandidateFromParts,
+  parseAdoRepoMetadata,
+  parseCanonicalAdoPrId,
+  isAdoRepairCandidateCompatible,
+  getMissingAdoProjectConfigFields,
 };

package/engine/github.js

@@ -88,6 +88,85 @@ function _isNonActionableComment(c, config = {}) {
   return false;
 }
 
+// W-mp2h696g000a7bc0 — Detect agent self-review-declined no-op comments.
+//
+// Per the documented contract (memory `subject: self-review`, docs/completion-reports.md:83-105):
+// when an agent is dispatched to review a PR they implemented, they post a `gh pr comment`
+// (no `VERDICT:` line) explaining the recusal and complete with `noop:true, verdict:null,
+// needs_rerun:true`. Because `gh` authenticates as the shared PAT user (`yemi33`), the
+// classifier can't tell the noop comment from a real human comment by author alone.
+//
+// Detection requires a stronger signal than author identity. Returns true only when BOTH:
+//   1. Body has NO `VERDICT:` line (we never want to swallow a real verdict comment), AND
+//   2. EITHER the body contains the canonical "Self-review declined" phrase AND references
+//      a dispatch id matching `<agent>-<type>-<uid>` that resolves to a same-agent
+//      review/implement dispatch in the completed history,
+//      OR the most recent review dispatch on this PR was assigned to the same agent as the
+//      PR author and completed with the noop:true / verdict:null / needs_rerun:true contract.
+//
+// This is a narrow allowlist for the noop pattern — generic PAT-user comments still flow
+// through `_isNonActionableComment` and trigger `humanFeedback.pendingFix=true` as before.
+function _isAgentSelfReviewDeclinedComment(c, { pr, dispatch } = {}) {
+  if (!c || !pr) return false;
+  const body = String(c.body || '');
+  if (!body) return false;
+  if (_hasMinionsReviewVerdict(body)) return false;
+
+  const prAuthorAgent = String(pr.agent || '').toLowerCase();
+  if (!prAuthorAgent) return false;
+
+  const completed = (dispatch && Array.isArray(dispatch.completed)) ? dispatch.completed : [];
+  const isNoopContract = (sc) => {
+    if (!sc || typeof sc !== 'object') return false;
+    if (sc.noop !== true && sc.noop !== 'true') return false;
+    if (sc.verdict !== null && sc.verdict !== undefined && sc.verdict !== '') return false;
+    if (sc.needs_rerun !== true && sc.needsRerun !== true) return false;
+    return true;
+  };
+
+  // Signal A — explicit "Self-review declined" phrase + verifiable dispatch id pointing
+  // at a same-agent review/implement/fix dispatch in the completed history.
+  const phraseMatch = /self[\s\-_]+review\s+declined/i.test(body);
+  if (phraseMatch) {
+    const dispatchIdMatches = body.match(/\b[a-z][a-z0-9]*-[a-z][a-z0-9]*-[a-z0-9]{8,}\b/g) || [];
+    for (const id of dispatchIdMatches) {
+      const entry = completed.find(d => d && d.id === id);
+      if (!entry) continue;
+      const agent = String(entry.agent || '').toLowerCase();
+      const t = String(entry.type || '').toLowerCase();
+      if (agent !== prAuthorAgent) continue;
+      if (t === 'review' || t === 'implement' || t === 'implement-large' || t === 'fix') {
+        return true;
+      }
+    }
+  }
+
+  // Signal B — most recent review dispatch on this PR was assigned to the PR author
+  // and completed with the documented noop contract. Catches the case where the agent
+  // forgot the canonical phrase but the completion-report contract still flags a noop.
+  const prId = String(pr.id || '');
+  const prNumberRaw = pr.prNumber;
+  const prNumber = prNumberRaw == null ? null : Number(prNumberRaw);
+  const reviewDispatches = completed.filter(d => {
+    if (!d || String(d.type || '').toLowerCase() !== 'review') return false;
+    const dpr = d.meta && d.meta.pr;
+    if (!dpr) return false;
+    if (prId && String(dpr.id || '') === prId) return true;
+    if (prNumber != null && Number(dpr.prNumber) === prNumber) return true;
+    return false;
+  });
+  if (reviewDispatches.length === 0) return false;
+  reviewDispatches.sort((a, b) => {
+    const ta = String(a.completed_at || a.created_at || '');
+    const tb = String(b.completed_at || b.created_at || '');
+    return tb.localeCompare(ta);
+  });
+  const latest = reviewDispatches[0];
+  if (!latest) return false;
+  if (String(latest.agent || '').toLowerCase() !== prAuthorAgent) return false;
+  return isNoopContract(latest.structuredCompletion);
+}
+
 // ─── Per-Repo Poll Backoff ──────────────────────────────────────────────────
 // Tracks consecutive poll failures per repo slug to avoid spamming logs when
 // a repo is inaccessible. Backoff doubles each failure: 2min, 4min, 8min, 16min, max 30min.
@@ -628,6 +707,14 @@ async function pollPrStatus(config) {
 // ─── Poll Human Comments on PRs ─────────────────────────────────────────────
 
 async function pollPrHumanComments(config) {
+  // Load dispatch state once per poll cycle (cached for ~2s by queries.getDispatch).
+  // Used by `_isAgentSelfReviewDeclinedComment` to verify dispatch ids referenced in
+  // candidate noop comments belong to the PR author.
+  const queries = require('./queries');
+  const dispatch = (() => {
+    try { return queries.getDispatch(); }
+    catch { return { pending: [], active: [], completed: [] }; }
+  })();
   const totalUpdated = await forEachActiveGhPr(config, async (project, pr, prNum, slug) => {
     // Get issue comments (general PR comments)
     const comments = await ghApi(`/issues/${prNum}/comments`, slug);
@@ -653,7 +740,12 @@ async function pollPrHumanComments(config) {
     for (const c of allComments) {
       const date = c.created_at || c.updated_at || '';
       const dateMs = date ? new Date(date).getTime() : 0;
-      const isNonActionable = _isNonActionableComment(c, config);
+      // W-mp2h696g000a7bc0 — agent self-review-declined no-op comments are posted via
+      // `gh pr comment` and authenticate as the shared PAT user, so author identity alone
+      // can't distinguish them from real human feedback. The narrow allowlist check uses
+      // the comment body + dispatch history to identify the documented noop pattern.
+      const isNonActionable = _isNonActionableComment(c, config)
+        || _isAgentSelfReviewDeclinedComment(c, { pr, dispatch });
       if (dateMs) allCommentDates.push(date);
       if (isNonActionable) continue;
       const entry = {
@@ -975,5 +1067,6 @@ module.exports = {
   _hasMinionsReviewVerdict, // exported for testing
   _isAgentComment, // exported for testing
   _isNonActionableComment, // exported for testing
+  _isAgentSelfReviewDeclinedComment, // exported for testing
   _isPreviewStatusComment, // exported for testing
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1900",
+  "version": "0.1.1902",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"