@yemi33/minions 0.1.1896 → 0.1.1897

package/dashboard/js/render-plans.js

@@ -412,13 +412,16 @@ async function planExecute(file, project, btn) {
     const data = await res.json();
     if (res.ok) {
       // Inject into local work items so the next render immediately hides Execute
-      if (!data.alreadyQueued) {
+      if (!data.alreadyQueued && data.id) {
         (window._lastWorkItems = window._lastWorkItems || []).push({
           id: data.id, type: 'plan-to-prd', status: 'pending', planFile: file
         });
       }
       closeModal();
-      showToast('cmd-toast', data.alreadyQueued ? 'Already queued (' + data.id + ')' : 'Queued ' + data.id + ' — agent will convert plan to PRD', true);
+      // Fall back to a clean message if the server didn't return an id (#2375).
+      const idLabel = data.id ? ' (' + data.id + ')' : '';
+      const queuedLabel = data.id ? 'Queued ' + data.id + ' — agent will convert plan to PRD' : 'Plan queued — agent will convert plan to PRD';
+      showToast('cmd-toast', data.alreadyQueued ? 'Already queued' + idLabel : queuedLabel, true);
       wakeEngine();
       refreshPlans();
     } else {

package/dashboard.js

@@ -4574,7 +4574,7 @@ const server = http.createServer(async (req, res) => {
         const projectTarget = resolveProjectSourceTarget(projectName, PROJECTS, { allowCentral: false });
         const targetProject = projectTarget.project || (PROJECTS.length === 1 ? PROJECTS[0] : null);
         if (targetProject) {
-          diffAwareQueued = shared.queuePlanToPrd({
+          const diffAwareResult = shared.queuePlanToPrd({
             planFile: plan.source_plan, prdFile: body.file,
             title: `Update PRD from revised plan: ${plan.source_plan}`,
             description: `mode: diff-aware-update\nPlan file: plans/${plan.source_plan}\nPRD file: prd/${body.file}\n\n` +
@@ -4584,6 +4584,7 @@ const server = http.createServer(async (req, res) => {
             project: targetProject.name, createdBy: 'dashboard:plan-resume',
             extra: { _existingPrdFile: body.file },
           });
+          diffAwareQueued = diffAwareResult.queued;
         }
       }
 
@@ -4731,15 +4732,15 @@ const server = http.createServer(async (req, res) => {
           '\n\nA prior PRD already exists for this plan. Read it, apply this feedback, and overwrite the PRD with the corrected version.';
       }
 
-      const queued = shared.queuePlanToPrd({
+      const queueResult = shared.queuePlanToPrd({
         planFile: body.file,
         title: 'Convert plan to PRD: ' + body.file.replace('.md', ''),
         description,
         project: declaredProject || body.project || '', createdBy: 'dashboard:execute',
       });
-      if (!queued) return jsonReply(res, 200, { ok: true, alreadyQueued: true });
+      if (!queueResult.queued) return jsonReply(res, 200, { ok: true, alreadyQueued: true, id: queueResult.id });
       invalidateStatusCache();
-      return jsonReply(res, 200, { ok: true });
+      return jsonReply(res, 200, { ok: true, id: queueResult.id });
     } catch (e) { return jsonReply(res, 400, { error: e.message }); }
   }
 

package/engine/shared.js

@@ -1628,17 +1628,30 @@ function trackReviewMetric(pr, newReviewStatus, config) {
   } catch (err) { log('warn', `Metrics update: ${err.message}`); }
 }
 
-/** Queue a plan-to-prd work item with dedup check inside lock. Returns true if queued. */
+/**
+ * Queue a plan-to-prd work item with dedup check inside lock.
+ *
+ * Returns { queued, alreadyQueued, id, item } so callers (e.g. POST /api/plans/execute)
+ * can surface the new or existing work item id back to the dashboard. Returning
+ * just a boolean caused the toast to render "queued undefined" (issue #2375).
+ */
 function queuePlanToPrd({ planFile, prdFile, title, description, project, createdBy, extra }) {
   // Use MINIONS_DIR (honors MINIONS_TEST_DIR override) instead of resolving from
   // __dirname — otherwise tests that exercise this helper leak work items into
   // the real package-root work-items.json even after createTestMinionsDir().
   const centralWiPath = path.join(MINIONS_DIR, 'work-items.json');
   let queued = false;
+  let id = null;
+  let item = null;
   mutateJsonFileLocked(centralWiPath, items => {
     if (!Array.isArray(items)) items = [];
-    if (items.some(w => w.type === 'plan-to-prd' && w.planFile === planFile && (w.status === 'pending' || w.status === 'dispatched'))) return items;
-    items.push({
+    const existing = items.find(w => w.type === 'plan-to-prd' && w.planFile === planFile && (w.status === 'pending' || w.status === 'dispatched'));
+    if (existing) {
+      id = existing.id;
+      item = existing;
+      return items;
+    }
+    const newItem = {
       id: 'W-' + uid(),
       title,
       type: 'plan-to-prd',
@@ -1650,11 +1663,14 @@ function queuePlanToPrd({ planFile, prdFile, title, description, project, create
       project,
       planFile,
       ...(extra || {}),
-    });
+    };
+    items.push(newItem);
     queued = true;
+    id = newItem.id;
+    item = newItem;
     return items;
   }, { defaultValue: [] });
-  return queued;
+  return { queued, alreadyQueued: !queued, id, item };
 }
 
 function extractPlanDeclaredProject(planContent) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1896",
+  "version": "0.1.1897",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"