@yemi33/minions 0.1.1894 → 0.1.1895

package/engine/cli.js

@@ -1144,7 +1144,8 @@ const commands = {
     const e = engine();
     if (!title) {
       console.log('Usage: node .minions/engine.js work "<title>" [options-json]');
-      console.log('Options: {"type":"implement","priority":"high","agent":"dallas","description":"...","branch":"feature/..."}');
+      console.log('Options: {"id":"W-customid","type":"implement","priority":"high","agent":"dallas","description":"...","branch":"feature/...","project":"minions"}');
+      console.log('  id  Optional caller-supplied work item ID. Defaults to a cuid-style W-<id>.');
       return;
     }
 
@@ -1157,7 +1158,7 @@ const commands = {
     }
 
     const config = getConfig();
-    const { getProjects, projectWorkItemsPath, resolveProjectSource } = require('./shared');
+    const { getProjects, projectWorkItemsPath, resolveProjectSource, uid, safeJsonArr } = require('./shared');
     const projects = getProjects(config);
     const target = opts.project ? resolveProjectSource(opts.project, projects, { allowCentral: false }) : null;
     if (target?.error) {
@@ -1166,10 +1167,36 @@ const commands = {
     }
     const targetProject = target?.project || (projects.length > 0 ? projects[0] : null);
     const wiPath = projectWorkItemsPath(targetProject);
+    const archivePath = wiPath.replace(/\.json$/, '-archive.json');
+
+    // Caller-supplied id: validate and pre-check live + archive for collisions
+    // BEFORE acquiring the work-items lock, so a rejection never mutates state.
+    let requestedId = null;
+    if (opts.id != null) {
+      if (typeof opts.id !== 'string' || !opts.id.trim()) {
+        console.log('Error: opts.id must be a non-empty string');
+        process.exit(1);
+      }
+      requestedId = opts.id.trim();
+      const liveItems = safeJsonArr(wiPath);
+      const archivedItems = safeJsonArr(archivePath);
+      if (liveItems.some(w => w?.id === requestedId) || archivedItems.some(w => w?.id === requestedId)) {
+        console.log(`Error: work item id "${requestedId}" already exists in ${path.basename(wiPath)} or its archive`);
+        process.exit(1);
+      }
+    }
+
     let item;
+    let collision = false;
     mutateWorkItems(wiPath, items => {
+      const id = requestedId || ('W-' + uid());
+      // Re-check inside the lock to close the TOCTOU race against other writers.
+      if (items.some(w => w?.id === id)) {
+        collision = true;
+        return items;
+      }
       item = {
-        id: `W${String(items.length + 1).padStart(3, '0')}`,
+        id,
         title: title,
         type: opts.type || 'implement',
         status: WI_STATUS.QUEUED,
@@ -1184,7 +1211,12 @@ const commands = {
       items.push(item);
     });
 
-    console.log(`Queued work item: ${item.id} — ${item.title} (project: ${targetProject.name || 'default'})`);
+    if (collision || !item) {
+      console.log(`Error: work item id collision detected for "${requestedId || 'auto-generated'}"`);
+      process.exit(1);
+    }
+
+    console.log(`Queued work item: ${item.id} — ${item.title} (project: ${targetProject?.name || 'default'})`);
     console.log(`  Type: ${item.type} | Priority: ${item.priority} | Agent: ${item.agent || 'auto'}`);
   },
 

package/engine/shared.js

@@ -1716,7 +1716,7 @@ const ESCALATION_POLICY = {
 };
 
 // Structured completion protocol — fields agents must produce in ```completion blocks
-const COMPLETION_FIELDS = ['status', 'summary', 'files_changed', 'tests', 'pr', 'pending', 'failure_class', 'retryable', 'needs_rerun', 'verdict', 'artifacts'];
+const COMPLETION_FIELDS = ['status', 'summary', 'files_changed', 'tests', 'pr', 'not_changed', 'failure_class', 'retryable', 'needs_rerun', 'verdict', 'artifacts'];
 
 const DEFAULT_AGENT_METRICS = {
   tasksCompleted: 0, tasksErrored: 0,

package/engine.js

@@ -1649,7 +1649,6 @@ async function spawnAgent(dispatchItem, config) {
       errorReason = structuredCompletion
         ? String(
             structuredCompletion.summary
-            || structuredCompletion.pending
             || structuredCompletion.failure_class
             || `Agent reported ${structuredCompletion.status || 'failure'}`
           ).slice(0, 300)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1894",
+  "version": "0.1.1895",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/shared-rules.md

@@ -67,7 +67,7 @@ Bias toward senior-engineer restraint:
 The engine provides a completion report path in the prompt and in `MINIONS_COMPLETION_REPORT`. Before exiting, write JSON there with the actual outcome:
 
 ```json
-{"status":"success","summary":"what changed and how it was validated","verdict":null,"pr":"PR id/url or N/A","failure_class":"N/A","retryable":false,"needs_rerun":false,"artifacts":[{"type":"note|plan|prd|pr|file","path":"relative/path/or/url","title":"short label"}]}
+{"status":"success","summary":"what changed and how it was validated","verdict":null,"pr":"PR id/url or N/A","failure_class":"N/A","retryable":false,"needs_rerun":false,"not_changed":"adjacent X left alone; refactor Y declined as out of scope","artifacts":[{"type":"note|plan|prd|pr|file","path":"relative/path/or/url","title":"short label"}]}
 ```
 
 For the canonical schema — every field, the `failure_class` enum, `noop:true` semantics, `retryable` / `needs_rerun` shape, and the artifacts array — see `docs/completion-reports.md`. The JSON report is the primary signal; fenced `completion` blocks in stdout are accepted only as a fallback.