@yemi33/minions 0.1.1878 → 0.1.1879

package/CHANGELOG.md

@@ -1,8 +1,9 @@
 # Changelog
 
-## 0.1.1878 (2026-05-12)
+## 0.1.1879 (2026-05-12)
 
 ### Fixes
+- reconcile stale failed plan follow-ups (#2366) (#2371)
 - Copilot resolver picks POSIX shim on Windows (#2370) (#2372)
 
 ## 0.1.1877 (2026-05-11)

package/dashboard/js/render-plans.js

@@ -61,12 +61,60 @@ async function refreshPlans() {
   } catch (e) { console.error('plans refresh:', e.message); }
 }
 
+/**
+ * Returns true when a failed plan follow-up work item's intended outcome has
+ * been satisfied by a later/alternate path — so the stale failure should not
+ * drive the plan's top-level "has failures" badge.
+ *
+ * Reconciliation rules (issue #2366):
+ * - Failed `itemType: 'pr'` (Create PR for plan): satisfied when a PR linked
+ *   to the same plan exists in any non-terminated state (active/merged/linked).
+ *   The original failure is preserved on the WI for audit; it just doesn't
+ *   count toward the rollup once a PR actually got created.
+ * - Failed `itemType: 'verify'`: satisfied when a newer verify WI for the
+ *   same plan + project exists and is done OR in-flight (pending/dispatched).
+ *
+ * Returns false when the outcome cannot be confirmed satisfied — failure
+ * remains live and drives the badge.
+ */
+function isFollowUpOutcomeSatisfied(wi, allWorkItems, allPrs) {
+  if (!wi || wi.status !== 'failed') return false;
+  if (wi.itemType === 'pr') {
+    // PR for this plan was created on any non-terminated path.
+    // "abandoned" / "closed" are terminal failures; everything else counts as
+    // the desired outcome being reached.
+    return (allPrs || []).some(pr =>
+      pr && pr.sourcePlan === wi.sourcePlan &&
+      pr.status !== 'abandoned' && pr.status !== 'closed'
+    );
+  }
+  if (wi.itemType === 'verify') {
+    // A newer verify WI for the same plan + project that is in flight or done.
+    const wiCreated = wi.created || '';
+    return (allWorkItems || []).some(other =>
+      other && other !== wi && other.itemType === 'verify' &&
+      other.sourcePlan === wi.sourcePlan &&
+      (other.project || '') === (wi.project || '') &&
+      (other.status === 'done' || other.status === 'pending' || other.status === 'dispatched') &&
+      (other.created || '') > wiCreated
+    );
+  }
+  return false;
+}
+
 /**
  * Derive effective plan/PRD status from work items (single source of truth).
  * PRD JSON status is treated as user intent (approved, paused, rejected),
  * but completion/progress is always derived from actual work item state.
+ *
+ * opts.allPrs — optional PR records used to reconcile stale failed follow-up
+ * tasks (issue #2366). Falls back to window._lastStatus.pullRequests in the
+ * browser. Pass `[]` to disable reconciliation.
  */
-function derivePlanStatus(prdFile, mdFile, prdJsonStatus, workItems) {
+function derivePlanStatus(prdFile, mdFile, prdJsonStatus, workItems, opts) {
+  const allPrs = (opts && opts.allPrs)
+    || (typeof window !== 'undefined' && window._lastStatus && window._lastStatus.pullRequests)
+    || [];
   const wi = workItems.filter(w =>
     w.sourcePlan === prdFile || w.sourcePlan === mdFile ||
     (w.type === 'plan-to-prd' && (w.planFile === prdFile || w.planFile === mdFile))
@@ -74,8 +122,18 @@ function derivePlanStatus(prdFile, mdFile, prdJsonStatus, workItems) {
   const implementWi = wi.filter(w => w.type !== 'plan-to-prd' && w.type !== 'verify');
   const hasPendingPrd = wi.some(w => w.type === 'plan-to-prd' && (w.status === 'pending' || w.status === 'dispatched'));
   const hasActiveWork = implementWi.some(w => w.status === 'pending' || w.status === 'dispatched');
-  const allDone = implementWi.length > 0 && implementWi.every(w => w.status === 'done' || w.status === 'decomposed');
-  const hasFailed = implementWi.some(w => w.status === 'failed');
+  // A WI is "effectively done" when it succeeded normally OR when it is a
+  // reconciled follow-up failure (intended outcome satisfied elsewhere — #2366).
+  // The original failure record is preserved on the WI for audit; it just
+  // stops blocking plan completion and stops driving the red badge.
+  const isReconciledFailure = (w) =>
+    w.status === 'failed' &&
+    (w.itemType === 'pr' || w.itemType === 'verify') &&
+    isFollowUpOutcomeSatisfied(w, workItems, allPrs);
+  const isEffectivelyDone = (w) =>
+    w.status === 'done' || w.status === 'decomposed' || isReconciledFailure(w);
+  const allDone = implementWi.length > 0 && implementWi.every(isEffectivelyDone);
+  const hasFailed = implementWi.some(w => w.status === 'failed' && !isReconciledFailure(w));
 
   // User-set statuses take priority when no work has started
   if (prdJsonStatus === 'rejected') return 'rejected';
@@ -897,4 +955,4 @@ async function planUnarchive(file, btn) {
   } catch (e) { showToast('cmd-toast', 'Error: ' + e.message, false); refresh(); }
 }
 
-window.MinionsPlans = { openCreatePlanModal, refreshPlans, derivePlanStatus, renderPlans, openArchivedPlansModal, planExecute, planReexecuteModal, planReexecuteSubmit, planSubmitRevise, planShowRevise, planHideRevise, planView, planApprove, planArchive, planUnarchive, planDelete, planPause, planReject, planDiscuss, planOpenInDocChat, planRegeneratePRD, openVerifyGuide, triggerVerify };
+window.MinionsPlans = { openCreatePlanModal, refreshPlans, derivePlanStatus, isFollowUpOutcomeSatisfied, renderPlans, openArchivedPlansModal, planExecute, planReexecuteModal, planReexecuteSubmit, planSubmitRevise, planShowRevise, planHideRevise, planView, planApprove, planArchive, planUnarchive, planDelete, planPause, planReject, planDiscuss, planOpenInDocChat, planRegeneratePRD, openVerifyGuide, triggerVerify };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1878",
+  "version": "0.1.1879",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"