@yemi33/minions 0.1.1859 → 0.1.1861

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.1.1861 (2026-05-10)
+
+### Fixes
+- surface phantom-completion as the failReason instead of "no PR detected"
+
+## 0.1.1860 (2026-05-10)
+
+### Fixes
+- treat exit-0 + empty-result as phantom completion, retry instead of hard-failing PR contract (#2335)
+
 ## 0.1.1859 (2026-05-10)
 
 ### Features

package/engine/lifecycle.js

@@ -1098,6 +1098,21 @@ function _outputContainsPrUrl(output) {
   return prUrlPattern.test(output);
 }
 
+// Detects the phantom-completion signature in the raw runtime output: the
+// runtime's terminating `{"type":"result"}` event never landed. When this is
+// true and the PR-attachment contract is about to hard-fail for "no PR
+// detected," it's far more accurate to say "runtime crashed before emitting a
+// result event" — the agent didn't fail silently, the runtime CLI did. Used by
+// enforcePrAttachmentContract to pick a truthful failReason.
+function _outputHasRuntimeResultEvent(output) {
+  if (!output || typeof output !== 'string') return false;
+  // Both Claude and Copilot emit a top-level `{"type":"result"…}` JSONL line as
+  // the conversation terminator. A literal substring match is enough; the
+  // captured streams are JSONL so the brace pattern can't legitimately appear
+  // mid-field-value without the prefix.
+  return /"type":\s*"result"/.test(output);
+}
+
 function markMissingPrAttachment(meta, agentId, reason, resultSummary, severity) {
   const noPrWiPath = resolveWorkItemPath(meta);
   const isHard = severity !== 'soft';
@@ -1239,9 +1254,20 @@ async function enforcePrAttachmentContract(type, meta, agentId, config, resultSu
   // was designed to catch) from "agent claimed a PR but engine couldn't attach
   // it canonically" (soft — verification gap, not a failure).
   const severity = _outputContainsPrUrl(output) ? 'soft' : 'hard';
-  const reason = severity === 'hard'
-    ? `${meta.item.id} completed but no PR URL was detected in the agent's output. Expected a PR — verify the agent didn't fail silently. (Branch: ${meta.branch || '(none)'}, agent: ${agentId})`
-    : `${meta.item.id} completed and a PR URL was found in the agent's output, but it couldn't be canonically attached. The work likely succeeded — verify by checking the PR list. (Branch: ${meta.branch || '(none)'}, agent: ${agentId})`;
+  // Hard-fail messaging: if the runtime never emitted its terminating result
+  // event, the failure is a phantom completion (runtime CLI crashed), not the
+  // agent silently skipping work. Surface that truthfully so operators don't
+  // chase "the agent didn't open a PR" when the real cause is "the runtime
+  // process died mid-conversation." Soft cases keep the original wording —
+  // they imply the runtime DID finish and a URL is in the stream.
+  let reason;
+  if (severity === 'hard') {
+    reason = _outputHasRuntimeResultEvent(output)
+      ? `${meta.item.id} completed but no PR URL was detected in the agent's output. Expected a PR — verify the agent didn't fail silently. (Branch: ${meta.branch || '(none)'}, agent: ${agentId})`
+      : `${meta.item.id} runtime exited without emitting a terminating result event — likely a phantom completion (the runtime CLI crashed mid-conversation, not a true agent failure). No PR was created. (Branch: ${meta.branch || '(none)'}, agent: ${agentId})`;
+  } else {
+    reason = `${meta.item.id} completed and a PR URL was found in the agent's output, but it couldn't be canonically attached. The work likely succeeded — verify by checking the PR list. (Branch: ${meta.branch || '(none)'}, agent: ${agentId})`;
+  }
   markMissingPrAttachment(meta, agentId, reason, resultSummary, severity);
   log(severity === 'hard' ? 'warn' : 'info', reason);
   return { reason, itemId: meta.item.id, severity };
@@ -2472,7 +2498,7 @@ const NON_TERMINAL_COMPLETION_STATUSES = new Set([
   'failed', 'failure', 'error',
 ]);
 
-function detectNonTerminalResultSummary(_resultSummary, structuredCompletion, completionReport) {
+function detectNonTerminalResultSummary(_resultSummary, structuredCompletion, completionReport, opts) {
   const candidates = [completionReport?.status, structuredCompletion?.status];
   for (const status of candidates) {
     const norm = normalizeCompletionStatus(status);
@@ -2487,6 +2513,31 @@ function detectNonTerminalResultSummary(_resultSummary, structuredCompletion, co
       };
     }
   }
+
+  // Phantom completion (opt-in via opts.detectPhantom): process exited 0 but
+  // the runtime never emitted any signal of what it actually did — no result-
+  // event prose, no fenced ```completion block, no on-disk completion report.
+  // This is the signature of a runtime CLI that crashed/aborted between session
+  // start and result emission (token expiry, MCP daemon drop, sandbox crash).
+  //
+  // Before PR #2266 these silently fell through the slow stale-orphan path and
+  // were retried. After #2266 the [process-exit] sentinel always lands, so
+  // completeFromOutput now classifies them as SUCCESS — and without this branch
+  // the PR-attachment contract hard-fails them with no retry.
+  //
+  // Only enabled at call sites where there is no other success signal (e.g.
+  // engine/timeout.js completeFromOutput). runPostCompletionHooks has richer
+  // signals (PRs created, plan-to-prd PRD file existence, autoRecover) and
+  // must not be demoted by this heuristic.
+  if (opts && opts.detectPhantom) {
+    const summaryEmpty = !_resultSummary || !String(_resultSummary).trim();
+    if (summaryEmpty && !structuredCompletion && !completionReport) {
+      return {
+        phrase: 'phantom-completion',
+        reason: 'Phantom completion: process exited cleanly but the runtime emitted no result event, no structured completion, and no completion report — likely a runtime crash before result emission',
+      };
+    }
+  }
   return null;
 }
 

package/engine/timeout.js

@@ -307,7 +307,7 @@ function checkTimeouts(config) {
       outputResultSummary = parseAgentOutput(fullLogForHooks, runtimeName).resultSummary || '';
       const gateSummary = outputResultSummary || (!fullLogForHooks.includes('"type":') ? fullLogForHooks : '');
       completionDetection = isSuccess
-        ? detectNonTerminalResultSummary(gateSummary, parseStructuredCompletion(fullLogForHooks, runtimeName), parseCompletionReportFile(item))
+        ? detectNonTerminalResultSummary(gateSummary, parseStructuredCompletion(fullLogForHooks, runtimeName), parseCompletionReportFile(item), { detectPhantom: true })
         : null;
     } catch (e) { log('warn', 'completion summary gate: ' + e.message); }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1859",
+  "version": "0.1.1861",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"