@yemi33/minions 0.1.1859 → 0.1.1860

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.1.1860 (2026-05-10)
+
+### Fixes
+- treat exit-0 + empty-result as phantom completion, retry instead of hard-failing PR contract (#2335)
+
 ## 0.1.1859 (2026-05-10)
 
 ### Features

package/engine/lifecycle.js

@@ -2472,7 +2472,7 @@ const NON_TERMINAL_COMPLETION_STATUSES = new Set([
   'failed', 'failure', 'error',
 ]);
 
-function detectNonTerminalResultSummary(_resultSummary, structuredCompletion, completionReport) {
+function detectNonTerminalResultSummary(_resultSummary, structuredCompletion, completionReport, opts) {
   const candidates = [completionReport?.status, structuredCompletion?.status];
   for (const status of candidates) {
     const norm = normalizeCompletionStatus(status);
@@ -2487,6 +2487,31 @@ function detectNonTerminalResultSummary(_resultSummary, structuredCompletion, co
       };
     }
   }
+
+  // Phantom completion (opt-in via opts.detectPhantom): process exited 0 but
+  // the runtime never emitted any signal of what it actually did — no result-
+  // event prose, no fenced ```completion block, no on-disk completion report.
+  // This is the signature of a runtime CLI that crashed/aborted between session
+  // start and result emission (token expiry, MCP daemon drop, sandbox crash).
+  //
+  // Before PR #2266 these silently fell through the slow stale-orphan path and
+  // were retried. After #2266 the [process-exit] sentinel always lands, so
+  // completeFromOutput now classifies them as SUCCESS — and without this branch
+  // the PR-attachment contract hard-fails them with no retry.
+  //
+  // Only enabled at call sites where there is no other success signal (e.g.
+  // engine/timeout.js completeFromOutput). runPostCompletionHooks has richer
+  // signals (PRs created, plan-to-prd PRD file existence, autoRecover) and
+  // must not be demoted by this heuristic.
+  if (opts && opts.detectPhantom) {
+    const summaryEmpty = !_resultSummary || !String(_resultSummary).trim();
+    if (summaryEmpty && !structuredCompletion && !completionReport) {
+      return {
+        phrase: 'phantom-completion',
+        reason: 'Phantom completion: process exited cleanly but the runtime emitted no result event, no structured completion, and no completion report — likely a runtime crash before result emission',
+      };
+    }
+  }
   return null;
 }
 

package/engine/timeout.js

@@ -307,7 +307,7 @@ function checkTimeouts(config) {
       outputResultSummary = parseAgentOutput(fullLogForHooks, runtimeName).resultSummary || '';
       const gateSummary = outputResultSummary || (!fullLogForHooks.includes('"type":') ? fullLogForHooks : '');
       completionDetection = isSuccess
-        ? detectNonTerminalResultSummary(gateSummary, parseStructuredCompletion(fullLogForHooks, runtimeName), parseCompletionReportFile(item))
+        ? detectNonTerminalResultSummary(gateSummary, parseStructuredCompletion(fullLogForHooks, runtimeName), parseCompletionReportFile(item), { detectPhantom: true })
         : null;
     } catch (e) { log('warn', 'completion summary gate: ' + e.message); }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1859",
+  "version": "0.1.1860",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"