@yemi33/minions 0.1.1838 → 0.1.1839

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.1.1839 (2026-05-10)
+
+### Other
+- refactor(cc): simplify CC migration code per /simplify review
+
 ## 0.1.1838 (2026-05-10)
 
 ### Features

package/dashboard.js

@@ -1592,21 +1592,20 @@ const DOC_CHAT_SYSTEM_PROMPT_RAW = (() => {
   }
 })();
 
-const DOC_CHAT_SYSTEM_PROMPT = DOC_CHAT_SYSTEM_PROMPT_RAW
-  .replace(/\{\{minions_dir\}\}/g, MINIONS_DIR);
+const DOC_CHAT_SYSTEM_PROMPT = shared.renderCcSystemPrompt(DOC_CHAT_SYSTEM_PROMPT_RAW, { liveRoot: MINIONS_DIR });
 
 function renderDocChatSystemPromptForTurn(turnId) {
-  return DOC_CHAT_SYSTEM_PROMPT_RAW
-    .replace(/\{\{minions_dir\}\}/g, MINIONS_DIR)
-    .replace(/\{\{cc_turn_id\}\}/g, String(turnId || ''))
-    .replace(/\{\{dashboard_port\}\}/g, String(PORT));
+  return shared.renderCcSystemPrompt(DOC_CHAT_SYSTEM_PROMPT_RAW, {
+    liveRoot: MINIONS_DIR,
+    turnId: turnId || '',
+    dashboardPort: PORT,
+  });
 }
 
 // Per-CC-turn correlation. CC's tool calls (Bash curl to /api/...) attach an
-// X-CC-Turn-Id header; the mutating endpoints record creations into this map
-// keyed by the turn ID so the CC handler can surface them as confirmation
-// chips in the user's reply. Complements (and will eventually replace) the
-// ===ACTIONS=== protocol — both currently active during transition.
+// X-CC-Turn-Id header; mutating endpoints record their creations into this
+// map keyed by the turn ID so the CC handler can surface them as confirmation
+// chips in the user's reply.
 const _ccTurnCreations = new Map();
 const CC_TURN_CREATION_TTL_MS = (() => {
   const env = parseInt(process.env.CC_TURN_CREATION_TTL_MS || '', 10);
@@ -1649,10 +1648,17 @@ function _readCcTurnIdHeader(req) {
   return trimmed;
 }
 
-// Build synthetic action results from the turn map so the existing renderer
-// (_ccActionContextSuffix in dashboard/js/command-center.js) shows the same
-// "Dispatched: <id>" chip whether the work item was created by a direct CC API
-// call or by the (now-removed) ===ACTIONS=== executor.
+// Mutating endpoint helper: records the creation under the request's CC turn
+// ID if one was sent, otherwise no-ops. Keeps the wiring at each handler down
+// to a single line.
+function recordCcTurnIfPresent(req, entry) {
+  const turnId = _readCcTurnIdHeader(req);
+  if (turnId) _recordCcTurnCreation(turnId, entry);
+}
+
+// Build action results from the turn map so the existing renderer
+// (_ccActionContextSuffix in dashboard/js/command-center.js) shows a
+// "Dispatched: <id>" chip for each direct CC API call.
 function _buildSyntheticActionResultsForTurn(turnId, message, requestedAt) {
   const entries = _consumeCcTurnCreations(turnId);
   if (entries.length === 0) return { actions: [], results: [] };
@@ -1696,19 +1702,22 @@ function _buildSyntheticActionResultsForTurn(turnId, message, requestedAt) {
 // Cheap mtime+size snapshot used by doc-chat to detect whether CC's `Edit` /
 // `Write` tool calls actually changed the target file during a turn. A diff
 // triggers a "Document saved" chip via the same _ccTurnCreations surface used
-// by mutating /api/* endpoints.
+// by mutating /api/* endpoints. Missing files snapshot as null so callers can
+// distinguish "file existed and was edited" from "file was deleted/never
+// existed" — only the former should surface a chip.
 function _snapshotDocFile(fullPath) {
   if (!fullPath) return null;
   try {
     const st = fs.statSync(fullPath);
     return { mtimeMs: st.mtimeMs, size: st.size };
-  } catch { return { mtimeMs: 0, size: 0 }; } // missing file → all changes look like edits
+  } catch { return null; }
 }
 
 function _docFileChanged(before, fullPath) {
   if (!fullPath) return false;
   const after = _snapshotDocFile(fullPath);
-  if (!before || !after) return false;
+  if (!after) return false;          // file gone or never existed — don't fire a chip
+  if (!before) return true;          // file created during the turn = a save
   return before.mtimeMs !== after.mtimeMs || before.size !== after.size;
 }
 
@@ -2893,11 +2902,10 @@ async function ccDocCall({ message, document, title, filePath, selection, canEdi
     return _docChatFailureResponse('doc-chat', filePath, result, sessionPreserved);
   }
 
-  // No more ===ACTIONS=== / ---DOCUMENT--- parsing — CC's text answer is the
-  // visible reply; file edits land via Edit/Write tools (validated in
-  // _finalizeDocChatEdit by re-reading disk); state mutations land via direct
-  // /api/* calls (correlated by X-CC-Turn-Id, surfaced as synthetic chips
-  // server-side).
+  // CC's text answer is the visible reply. File edits land via the Edit/Write
+  // tools (verified by _finalizeDocChatEdit re-reading disk); state mutations
+  // land via direct /api/* calls (correlated by X-CC-Turn-Id, surfaced as
+  // chips server-side).
   return { answer: result.text, toolUses: Array.isArray(result.toolUses) ? result.toolUses : [] };
 }
 
@@ -2955,11 +2963,10 @@ async function ccDocCallStreaming({ message, document, title, filePath, selectio
     return _docChatFailureResponse('doc-chat-stream', filePath, result, sessionPreserved);
   }
 
-  // No more ===ACTIONS=== / ---DOCUMENT--- parsing — CC's text answer is the
-  // visible reply; file edits land via Edit/Write tools (validated in
-  // _finalizeDocChatEdit by re-reading disk); state mutations land via direct
-  // /api/* calls (correlated by X-CC-Turn-Id, surfaced as synthetic chips
-  // server-side).
+  // CC's text answer is the visible reply. File edits land via the Edit/Write
+  // tools (verified by _finalizeDocChatEdit re-reading disk); state mutations
+  // land via direct /api/* calls (correlated by X-CC-Turn-Id, surfaced as
+  // chips server-side).
   return { answer: result.text, toolUses: Array.isArray(result.toolUses) ? result.toolUses : [] };
 }
 
@@ -3641,13 +3648,7 @@ const server = http.createServer(async (req, res) => {
         const duplicateId = createResult.duplicateOf || createResult.item?.id;
         return jsonReply(res, 200, { ok: true, id: duplicateId, duplicate: true, duplicateOf: duplicateId });
       }
-      // CC turn-ID correlation: record direct API creations so the CC handler
-      // can surface a "Dispatched: <id>" chip in the assistant reply without
-      // CC needing to also emit an ===ACTIONS=== block.
-      const _ccTurn = _readCcTurnIdHeader(req);
-      if (_ccTurn) _recordCcTurnCreation(_ccTurn, {
-        kind: 'work-item', id, title: item.title, project: item.project || null,
-      });
+      recordCcTurnIfPresent(req, { kind: 'work-item', id, title: item.title, project: item.project || null });
       return jsonReply(res, 200, { ok: true, id });
     } catch (e) { return jsonReply(res, 400, { error: e.message }); }
   }
@@ -3704,8 +3705,7 @@ const server = http.createServer(async (req, res) => {
       const content = `# ${body.title}\n\n**By:** ${author}\n**Date:** ${today}\n\n${body.what}\n${body.why ? '\n**Why:** ' + body.why + '\n' : ''}`;
       safeWrite(shared.uniquePath(path.join(inboxDir, filename)), content);
       invalidateStatusCache();
-      const _ccTurn = _readCcTurnIdHeader(req);
-      if (_ccTurn) _recordCcTurnCreation(_ccTurn, { kind: 'note', title: body.title.trim() });
+      recordCcTurnIfPresent(req, { kind: 'note', title: body.title.trim() });
       return jsonReply(res, 200, { ok: true });
     } catch (e) { return jsonReply(res, 400, { error: e.message }); }
   }
@@ -3719,8 +3719,7 @@ const server = http.createServer(async (req, res) => {
       // Write as a work item with type 'plan' — user must explicitly execute plan-to-prd after reviewing
       const wiPath = path.join(MINIONS_DIR, 'work-items.json');
       mutateWorkItems(wiPath, items => { items.push(planWorkItem.item); });
-      const _ccTurn = _readCcTurnIdHeader(req);
-      if (_ccTurn) _recordCcTurnCreation(_ccTurn, {
+      recordCcTurnIfPresent(req, {
         kind: 'plan', id: planWorkItem.id, title: planWorkItem.item?.title || body.title.trim(), project: planWorkItem.item?.project || null,
       });
       return jsonReply(res, 200, { ok: true, id: planWorkItem.id, agent: body.agent || '' });
@@ -5669,10 +5668,9 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         }
         const wasResume = !!(body.sessionId && body.sessionId === ccSession.sessionId && ccSessionValid());
 
-        // Per-turn correlation: CC includes X-CC-Turn-Id when calling /api/*
-        // mutating endpoints; the turn map collects creations so we can surface
-        // them as confirmation chips alongside any (now-legacy) ===ACTIONS===
-        // results.
+        // Per-turn correlation: CC includes X-CC-Turn-Id on its /api/* tool
+        // calls; the turn map collects creations so we surface them as
+        // confirmation chips in the assistant reply.
         const ccTurnId = 'cct-' + shared.uid();
         const turnSystemPrompt = renderCcSystemPromptForTurn(ccTurnId);
         const result = await ccCall(body.message, { store: 'cc', transcript: body.transcript, systemPrompt: turnSystemPrompt });
@@ -5928,9 +5926,8 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         const streamModel = CONFIG.engine?.ccModel || shared.ENGINE_DEFAULTS.ccModel;
         const streamEffort = CONFIG.engine?.ccEffort || shared.ENGINE_DEFAULTS.ccEffort;
         const ccMaxTurns = CONFIG.engine?.ccMaxTurns || shared.ENGINE_DEFAULTS.ccMaxTurns;
-        // Per-turn correlation header: CC threads X-CC-Turn-Id when calling
-        // /api/* endpoints; matching creations get surfaced as confirmation
-        // chips alongside any (legacy) ===ACTIONS=== executor results.
+        // Per-turn correlation header: CC threads X-CC-Turn-Id on its /api/*
+        // tool calls; matching creations get surfaced as confirmation chips.
         const ccTurnId = 'cct-' + shared.uid();
         const turnSystemPrompt = renderCcSystemPromptForTurn(ccTurnId);
         let toolUses = [];
@@ -6279,8 +6276,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
     try {
       const watch = watchesMod.createWatch({ target, targetType, condition, interval, owner, description, project, notify, stopAfter, onNotMet });
       invalidateStatusCache();
-      const _ccTurn = _readCcTurnIdHeader(req);
-      if (_ccTurn) _recordCcTurnCreation(_ccTurn, {
+      recordCcTurnIfPresent(req, {
         kind: 'watch', id: watch?.id || null, title: `Watch ${target}` + (condition ? ` (${condition})` : ''), project: project || null,
       });
       return jsonReply(res, 200, { ok: true, watch });
@@ -7237,8 +7233,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       safeWrite(filePath, header + content);
       queries.invalidateKnowledgeBaseCache();
       invalidateStatusCache();
-      const _ccTurn = _readCcTurnIdHeader(req);
-      if (_ccTurn) _recordCcTurnCreation(_ccTurn, { kind: 'knowledge', title, path: filePath });
+      recordCcTurnIfPresent(req, { kind: 'knowledge', title, path: filePath });
       return jsonReply(res, 200, { ok: true, path: filePath });
     }},
     { method: 'POST', path: '/api/knowledge/sweep', desc: 'Trigger async KB sweep (returns 202)', handler: handleKnowledgeSweep },
@@ -7671,7 +7666,7 @@ module.exports = {
   _inferDocChatProject,
   _linkPullRequestForTracking: linkPullRequestForTracking,
   _resolveSkillReadPath,
-  // Per-CC-turn correlation surface (replaces ===ACTIONS=== protocol)
+  // Per-CC-turn correlation surface
   _ccTurnCreations,
   _recordCcTurnCreation,
   _consumeCcTurnCreations,

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-10T02:49:08.142Z"
+  "cachedAt": "2026-05-10T02:54:40.580Z"
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1838",
+  "version": "0.1.1839",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"