@yemi33/minions 0.1.1802 → 0.1.1804

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.1.1804 (2026-05-08)
+
+### Fixes
+-  prevent Copilot CC response truncation
+
+## 0.1.1803 (2026-05-08)
+
+### Other
+- Guarantee Copilot steering delivery (#2225)
+
 ## 0.1.1800 (2026-05-08)
 
 ### Other

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-08T17:22:37.672Z"
+  "cachedAt": "2026-05-08T18:04:30.632Z"
 }

package/engine/llm.js

@@ -22,7 +22,6 @@ const { resolveRuntime } = require('./runtimes');
 
 const MINIONS_DIR = shared.MINIONS_DIR;
 const ENGINE_DIR = path.join(MINIONS_DIR, 'engine');
-const COPILOT_TASK_COMPLETE_GRACE_MS = 15000;
 const MISSING_RUNTIME_EXIT_CODE = 78;
 // When the spawned process emits 'exit' but 'close' is delayed (a detached
 // grandchild inherited stdio), wait this long for trailing stdout data to
@@ -627,17 +626,6 @@ function callLLM(promptText, sysPromptText, opts = {}) {
       maxBudget, bare, fallbackModel,
       ...runtimeFeatureOpts,
     });
-    let taskCompleteTimer = null;
-    const scheduleTaskCompleteClose = () => {
-      if (taskCompleteTimer) return;
-      taskCompleteTimer = setTimeout(() => { try { shared.killImmediate(proc); } catch {} }, COPILOT_TASK_COMPLETE_GRACE_MS);
-    };
-    const clearTaskCompleteTimer = () => {
-      if (taskCompleteTimer) {
-        clearTimeout(taskCompleteTimer);
-        taskCompleteTimer = null;
-      }
-    };
     let resolved = false;
     let exitFallbackTimer = null;
     let exitCode = null;
@@ -650,7 +638,6 @@ function callLLM(promptText, sysPromptText, opts = {}) {
       maxRawBytes: ENGINE_DEFAULTS.maxLlmRawBytes,
       maxStderrBytes: ENGINE_DEFAULTS.maxLlmStderrBytes,
       maxLineBufferBytes: ENGINE_DEFAULTS.maxLlmLineBufferBytes,
-      onTaskComplete: scheduleTaskCompleteClose,
       // Terminal text from the runtime adapter signals the LLM has logically
       // completed — kick the drain timer so we don't block on a delayed
       // 'exit'/'close' when an inherited pipe keeps the parent's FDs open.
@@ -668,7 +655,6 @@ function callLLM(promptText, sysPromptText, opts = {}) {
       if (resolved) return;
       resolved = true;
       clearTimeout(timer);
-      clearTaskCompleteTimer();
       if (exitFallbackTimer) { clearTimeout(exitFallbackTimer); exitFallbackTimer = null; }
       for (const f of cleanupFiles) safeUnlink(f);
       const parsed = acc.finalize();
@@ -706,7 +692,6 @@ function callLLM(promptText, sysPromptText, opts = {}) {
       if (resolved) return;
       resolved = true;
       clearTimeout(timer);
-      clearTaskCompleteTimer();
       if (exitFallbackTimer) { clearTimeout(exitFallbackTimer); exitFallbackTimer = null; }
       for (const f of cleanupFiles) safeUnlink(f);
       shared.log('error', `LLM spawn error (${label}): ${err.message}`);
@@ -753,17 +738,6 @@ function callLLMStreaming(promptText, sysPromptText, opts = {}) {
       maxBudget, bare, fallbackModel,
       ...runtimeFeatureOpts,
     });
-    let taskCompleteTimer = null;
-    const scheduleTaskCompleteClose = () => {
-      if (taskCompleteTimer) return;
-      taskCompleteTimer = setTimeout(() => { try { shared.killImmediate(proc); } catch {} }, COPILOT_TASK_COMPLETE_GRACE_MS);
-    };
-    const clearTaskCompleteTimer = () => {
-      if (taskCompleteTimer) {
-        clearTimeout(taskCompleteTimer);
-        taskCompleteTimer = null;
-      }
-    };
     let resolved = false;
     let exitFallbackTimer = null;
     let exitCode = null;
@@ -778,7 +752,6 @@ function callLLMStreaming(promptText, sysPromptText, opts = {}) {
       maxLineBufferBytes: ENGINE_DEFAULTS.maxLlmLineBufferBytes,
       onChunk,
       onToolUse,
-      onTaskComplete: scheduleTaskCompleteClose,
       // Terminal text from the runtime adapter signals the LLM has logically
       // completed — kick the drain timer so we don't block on a delayed
       // 'exit'/'close' when an inherited pipe keeps the parent's FDs open.
@@ -797,7 +770,6 @@ function callLLMStreaming(promptText, sysPromptText, opts = {}) {
       if (resolved) return;
       resolved = true;
       clearTimeout(timer);
-      clearTaskCompleteTimer();
       if (exitFallbackTimer) { clearTimeout(exitFallbackTimer); exitFallbackTimer = null; }
       for (const f of cleanupFiles) safeUnlink(f);
       const parsed = acc.finalize();
@@ -832,7 +804,6 @@ function callLLMStreaming(promptText, sysPromptText, opts = {}) {
       if (resolved) return;
       resolved = true;
       clearTimeout(timer);
-      clearTaskCompleteTimer();
       if (exitFallbackTimer) { clearTimeout(exitFallbackTimer); exitFallbackTimer = null; }
       for (const f of cleanupFiles) safeUnlink(f);
       shared.log('error', `LLM-stream spawn error (${label}): ${err.message}`);

package/engine/runtimes/copilot.js

@@ -550,7 +550,7 @@ function parseOutput(raw, { maxTextLength = 0 } = {}) {
     const type = obj.type;
     if (type === 'assistant.message_delta') {
       const delta = obj.data?.deltaContent;
-      if (typeof delta === 'string' && !taskCompleteSummary) pendingDeltaContent += delta;
+      if (typeof delta === 'string') pendingDeltaContent += delta;
     } else if (type === 'assistant.message') {
       const content = obj.data?.content;
       const toolRequests = obj.data?.toolRequests;
@@ -818,12 +818,13 @@ function createStreamConsumer(ctx) {
   // assistant messages or trailing deltas.
   let copilotMessageBuffer = '';
   let terminalText = '';
+  let taskCompleteSummary = '';
 
-  function _captureTaskComplete(summary, success = true) {
+  function _captureTaskComplete(summary, success = true, { clearBuffer = false } = {}) {
     if (typeof summary !== 'string' || !summary) return;
-    copilotMessageBuffer = '';
-    if (!terminalText) {
-      terminalText = summary;
+    taskCompleteSummary = summary;
+    if (clearBuffer) copilotMessageBuffer = '';
+    if (!terminalText && !copilotMessageBuffer) {
       ctx.pushText(summary);
     }
     ctx.notifyTaskComplete(summary, success !== false);
@@ -837,7 +838,8 @@ function createStreamConsumer(ctx) {
       // The result event is the first Copilot event that contains the resumable
       // sessionId. Do not mark the earlier assistant.message as terminal or
       // Minions can resolve before session persistence data is available.
-      if (terminalText) ctx.setText(terminalText);
+      const finalText = terminalText || copilotMessageBuffer || taskCompleteSummary;
+      if (finalText) ctx.setText(finalText);
     }
 
     if (obj.type === 'session.task_complete') {
@@ -877,7 +879,7 @@ function createStreamConsumer(ctx) {
         for (const tr of data.toolRequests) {
           if (!tr || !tr.name) continue;
           if (tr.name === 'task_complete') {
-            _captureTaskComplete(tr.arguments?.summary || tr.intentionSummary);
+            _captureTaskComplete(tr.arguments?.summary || tr.intentionSummary, true, { clearBuffer: true });
             continue;
           }
           ctx.pushToolUse(tr.name, tr.arguments || {});
@@ -888,7 +890,7 @@ function createStreamConsumer(ctx) {
 
     if (obj.type === 'tool.execution_start' && obj.data?.toolName) {
       if (obj.data.toolName === 'task_complete') {
-        _captureTaskComplete(obj.data.arguments?.summary);
+        _captureTaskComplete(obj.data.arguments?.summary, true, { clearBuffer: true });
         return;
       }
       const name = obj.data.toolName;
@@ -903,6 +905,8 @@ function createStreamConsumer(ctx) {
 
   function reset() {
     copilotMessageBuffer = '';
+    terminalText = '';
+    taskCompleteSummary = '';
   }
 
   return { consume, reset };

package/engine.js

@@ -407,6 +407,50 @@ function mergePendingSteeringEntries(...groups) {
   return merged;
 }
 
+function promoteCheckpointSteeringForClose(agentId, procInfo, runtime, liveOutputPath) {
+  if (!procInfo || procInfo._steeringMessage) return { status: 'none', entries: [] };
+  if (runtime?.capabilities?.midRunSessionId !== false) return { status: 'none', entries: [] };
+
+  const startedAtMs = Date.parse(procInfo.startedAt);
+  const runStartMs = Number.isFinite(startedAtMs) ? startedAtMs : 0;
+  const pendingPaths = new Set((procInfo._pendingSteeringFiles || []).map(entry => entry?.path || entry).filter(Boolean));
+  const deferredPaths = new Set((procInfo._deferredSteeringFiles || []).filter(Boolean));
+  const unread = steering.listUnreadSteeringMessages(agentId).filter(entry => entry.message.trim());
+  const entriesByPath = new Map(unread.map(entry => [entry.path, entry]));
+  const pendingDeferred = Array.from(deferredPaths)
+    .map(filePath => entriesByPath.get(filePath))
+    .filter(Boolean);
+  const lateCheckpoint = unread.filter(entry =>
+    entry.createdAtMs >= runStartMs
+    && !pendingPaths.has(entry.path)
+    && !deferredPaths.has(entry.path)
+  );
+  const checkpointEntries = mergePendingSteeringEntries(pendingDeferred, lateCheckpoint);
+  if (checkpointEntries.length === 0) {
+    delete procInfo._deferredSteeringFiles;
+    return { status: 'none', entries: [] };
+  }
+
+  if (!procInfo.sessionId) {
+    log('warn', `Steering: ${agentId} exited before a resumable sessionId was available - ${checkpointEntries.length} message(s) remain pending`);
+    try { fs.appendFileSync(liveOutputPath, `\n[steering-pending] Agent exited before a resumable session was available. Your message remains unread and will be retried on the next dispatch.\n`); } catch {}
+    return { status: 'pending', entries: checkpointEntries };
+  }
+
+  if (pendingDeferred.length > 0) {
+    log('info', `Steering: delivering ${pendingDeferred.length} deferred message(s) for ${agentId} at resumable checkpoint`);
+  }
+  if (lateCheckpoint.length > 0) {
+    log('info', `Steering: delivering ${lateCheckpoint.length} late checkpoint message(s) for ${agentId} at resumable checkpoint`);
+  }
+  procInfo._steeringMessage = checkpointEntries.map(entry => entry.message.trim()).join('\n\n');
+  procInfo._steeringSessionId = procInfo.sessionId;
+  procInfo._steeringEntry = checkpointEntries;
+  procInfo._steeringDeferredCheckpoint = true;
+  delete procInfo._deferredSteeringFiles;
+  return { status: 'promoted', entries: checkpointEntries };
+}
+
 // Resolve dependency plan item IDs to their PR branches
 function resolveDependencyBranches(depIds, sourcePlan, project, config) {
   const results = []; // [{ branch, prId }]
@@ -1193,6 +1237,7 @@ async function spawnAgent(dispatchItem, config) {
   const MAX_OUTPUT = 1024 * 1024; // 1MB
   let stdout = '';
   let stderr = '';
+  let steeringAckStdout = '';
   const sessionCaptureState = { sessionLineBuffer: '' };
   let _trustCheckDone = false;
   const _spawnTime = Date.now();
@@ -1207,6 +1252,7 @@ async function spawnAgent(dispatchItem, config) {
     const chunk = data.toString();
     realActivityMap.set(id, Date.now());
     if (stdout.length < MAX_OUTPUT) stdout += chunk.slice(0, MAX_OUTPUT - stdout.length);
+    if (steeringAckStdout.length < MAX_OUTPUT) steeringAckStdout += chunk.slice(0, MAX_OUTPUT - steeringAckStdout.length);
     try { fs.appendFileSync(liveOutputPath, chunk); } catch { /* optional */ }
 
     // Trust gate detection: check first 30s of output for trust/permission prompts
@@ -1254,26 +1300,8 @@ async function spawnAgent(dispatchItem, config) {
     }
 
     const procInfo = activeProcesses.get(id);
-    ackPendingSteeringFiles(agentId, procInfo, stdout);
-
-    if (procInfo?._deferredSteeringFiles?.length && procInfo.sessionId) {
-      const deferredPaths = new Set(procInfo._deferredSteeringFiles);
-      const pendingDeferred = steering.listUnreadSteeringMessages(agentId)
-        .filter(entry => deferredPaths.has(entry.path) && entry.message.trim());
-      if (pendingDeferred.length > 0) {
-        log('info', `Steering: delivering ${pendingDeferred.length} deferred message(s) for ${agentId} at resumable checkpoint`);
-        procInfo._steeringMessage = pendingDeferred.map(entry => entry.message.trim()).join('\n\n');
-        procInfo._steeringSessionId = procInfo.sessionId;
-        procInfo._steeringEntry = pendingDeferred;
-        procInfo._steeringDeferredCheckpoint = true;
-        delete procInfo._deferredSteeringFiles;
-      } else {
-        delete procInfo._deferredSteeringFiles;
-      }
-    } else if (procInfo?._deferredSteeringFiles?.length) {
-      log('warn', `Steering: ${agentId} exited before a resumable sessionId was available — message remains pending`);
-      try { fs.appendFileSync(liveOutputPath, `\n[steering-pending] Agent exited before a resumable session was available. Your message remains unread and will be retried on the next dispatch.\n`); } catch {}
-    }
+    ackPendingSteeringFiles(agentId, procInfo, steeringAckStdout);
+    promoteCheckpointSteeringForClose(agentId, procInfo, runtime, liveOutputPath);
 
     // Check if this was a steering kill — re-spawn with resume
     if (procInfo?._steeringMessage) {
@@ -1401,6 +1429,7 @@ async function spawnAgent(dispatchItem, config) {
         ),
       });
 
+      steeringAckStdout = '';
       // Live steering kills discard partial old output. Deferred checkpoint
       // steering keeps the completed turn output so completion parsing still
       // sees the original work if the follow-up only acknowledges steering.
@@ -1414,6 +1443,7 @@ async function spawnAgent(dispatchItem, config) {
         const chunk = data.toString();
         realActivityMap.set(id, Date.now());
         if (stdout.length < MAX_OUTPUT) stdout += chunk.slice(0, MAX_OUTPUT - stdout.length);
+        if (steeringAckStdout.length < MAX_OUTPUT) steeringAckStdout += chunk.slice(0, MAX_OUTPUT - steeringAckStdout.length);
         try { fs.appendFileSync(liveOutputPath, chunk); } catch { /* optional */ }
         const resumeInfo = activeProcesses.get(id);
         markRuntimeResumeOutputSeen(resumeInfo);
@@ -4719,6 +4749,7 @@ module.exports = {
   parseConflictFiles, pruneAncestorDeps, preflightMergeSimulation, // exported for testing
   isWorktreeRetryableError, removeStaleIndexLock, syncReusedWorktree, // exported for testing
   _maxTurnsForType, buildProjectContext, normalizeAc, _buildAgentSpawnFlags, _classifyAgentFailure, // exported for testing
+  promoteCheckpointSteeringForClose, // exported for testing
   normalizePrBranch, resolvePrBranch, prCausePart, getPrCauseHead, getPrCauseBase, getPrAutomationCauseKey, getPrAutomationDispatchKey, // exported for testing
 
   // Playbooks

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1802",
+  "version": "0.1.1804",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"