@yemi33/minions 0.1.1797 → 0.1.1799

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.1.1799 (2026-05-08)
+
+### Other
+- Clarify active dispatch PID liveness
+
+## 0.1.1798 (2026-05-08)
+
+### Other
+- Reap dead reattached dispatches
+
 ## 0.1.1797 (2026-05-08)
 
 ### Other

package/engine/cli.js

@@ -52,6 +52,44 @@ function isEngineProcessAlive(control) {
   }
 }
 
+function dispatchSafeId(itemId) {
+  return String(itemId || '').replace(/[:\\/*?"<>|]/g, '-');
+}
+
+function readDispatchPid(itemId) {
+  const pidFile = path.join(ENGINE_DIR, 'tmp', `pid-${dispatchSafeId(itemId)}.pid`);
+  let raw;
+  try { raw = fs.readFileSync(pidFile, 'utf8').trim(); }
+  catch { return null; }
+  if (!raw) return null;
+  try { return shared.validatePid(raw); }
+  catch { return null; }
+}
+
+function isPidAlive(pid) {
+  try {
+    process.kill(shared.validatePid(pid), 0);
+    return true;
+  } catch {
+    return false;
+  }
+}
+
+function summarizeActiveDispatchPids(activeItems = []) {
+  const summary = { live: 0, dead: 0, missing: 0 };
+  for (const item of activeItems || []) {
+    const pid = readDispatchPid(item.id);
+    if (!pid) {
+      summary.missing++;
+    } else if (isPidAlive(pid)) {
+      summary.live++;
+    } else {
+      summary.dead++;
+    }
+  }
+  return summary;
+}
+
 function createControlOwner(pid = process.pid) {
   return { pid, ownerToken: `${pid}-${shared.uid()}` };
 }
@@ -453,21 +491,13 @@ const commands = {
     e.loadCooldowns();
 
     // Re-attach to surviving agent processes from previous session
-    const { exec } = require('./shared');
     const dispatch = getDispatch();
     const activeOnStart = (dispatch.active || []);
     if (activeOnStart.length > 0) {
       let reattached = 0;
       for (const item of activeOnStart) {
         const agentId = item.agent;
-        let agentPid = null;
-
-        const safeId = item.id.replace(/[:\\/*?"<>|]/g, '-');
-        const pidFile = path.join(ENGINE_DIR, 'tmp', `pid-${safeId}.pid`);
-        try {
-          const pidStr = fs.readFileSync(pidFile, 'utf8').trim();
-          if (pidStr) agentPid = parseInt(pidStr);
-        } catch { /* optional */ }
+        let agentPid = readDispatchPid(item.id);
 
         if (!agentPid) {
           const status = getAgentStatus(agentId);
@@ -484,16 +514,7 @@ const commands = {
         }
 
         const hadPid = agentPid && agentPid > 0; // track before liveness check
-        if (agentPid && agentPid > 0) {
-          try {
-            if (process.platform === 'win32') {
-              const out = exec(`tasklist /FI "PID eq ${agentPid}" /NH`, { encoding: 'utf8', timeout: 3000 }).trim();
-              if (!new RegExp(`\\b${agentPid}\\b`).test(out)) agentPid = null;
-            } else {
-              process.kill(agentPid, 0);
-            }
-          } catch { agentPid = null; }
-        }
+        if (agentPid && agentPid > 0 && !isPidAlive(agentPid)) agentPid = null;
 
         // PID was found but confirmed dead — exempt from restart grace period (#869)
         if (hadPid && !agentPid) {
@@ -1003,7 +1024,8 @@ const commands = {
     const metrics = shared.safeJson(path.join(__dirname, 'metrics.json')) || {};
     const lifetimeCompleted = Object.entries(metrics).filter(([k]) => !k.startsWith('_')).reduce((sum, [, m]) => sum + (m.tasksCompleted || 0) + (m.tasksErrored || 0), 0);
     console.log(`Dispatch: ${dispatch.pending.length} pending | ${(dispatch.active || []).length} active | ${lifetimeCompleted} completed`);
-    console.log(`Active processes: ${e.activeProcesses.size}`);
+    const pidSummary = summarizeActiveDispatchPids(dispatch.active || []);
+    console.log(`Active dispatch PID files: ${pidSummary.live} live | ${pidSummary.dead} dead | ${pidSummary.missing} missing`);
 
     const metricsPath = path.join(ENGINE_DIR, 'metrics.json');
     const metricsData = safeJson(metricsPath);

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-08T16:25:36.069Z"
+  "cachedAt": "2026-05-08T16:51:53.990Z"
 }

package/engine/timeout.js

@@ -452,7 +452,9 @@ function checkTimeouts(config) {
     } catch { /* ENOENT — keep default */ }
 
     const confirmedDeadAtRestart = engineRestartGraceExempt?.has(item.id);
-    if (!processAlive && (confirmedDeadAtRestart || silentMs > staleOrphanTimeout) && (Date.now() > engineRestartGraceUntil || confirmedDeadAtRestart)) {
+    const reattachedProcessEnded = !!procInfo?.reattached && !processAlive;
+    const canReapDeadProcess = confirmedDeadAtRestart || reattachedProcessEnded;
+    if (!processAlive && (canReapDeadProcess || silentMs > staleOrphanTimeout) && (Date.now() > engineRestartGraceUntil || canReapDeadProcess)) {
       // Last-resort PID check: lost tracked handle but OS process may still be alive.
       if (isOsPidAliveForDispatch(item.id)) {
         log('info', `Orphan check: ${item.agent} (${item.id}) silent ${silentSec}s but OS PID is alive — keeping [${_logState}]`);
@@ -477,7 +479,8 @@ function checkTimeouts(config) {
         }
       } catch (e) { log('warn', 'orphan final output completion scan: ' + e.message); }
 
-      // No tracked process AND no recent output past stale-orphan timeout AND (grace period expired OR confirmed-dead at restart) → orphaned
+      // No tracked process AND no recent output past stale-orphan timeout AND (grace period expired OR confirmed-dead at restart)
+      // OR a re-attached process whose OS PID has since exited (no close event will fire for fake restart handles) → orphaned
       log('warn', `Orphan detected: ${item.agent} (${item.id}) — no live process tracked, silent for ${silentSec}s [logExists/logSize=${_logState}]`);
       dispatch().updateAgentStatus(item.id, AGENT_STATUS.TIMED_OUT, `Orphaned — no process, silent for ${silentSec}s`);
       // Clear session so retry starts fresh

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1797",
+  "version": "0.1.1799",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"