@yemi33/minions 0.1.1773 → 0.1.1774

package/CHANGELOG.md

@@ -1,11 +1,16 @@
 # Changelog
 
-## 0.1.1773 (2026-05-07)
+## 0.1.1774 (2026-05-07)
+
+### Features
+- suppress stale doc-chat model errors
+
+### Fixes
+- yemi33/minions#2168
+
+## 0.1.1772 (2026-05-07)
 
 ### Features
-- fix doc chat sticky scroll (#2176)
-- fix live output route and CLI docs (#2172)
-- make API project resolution strict (#2169)
 - fix copilot cc resume context (#2166)
 
 ## 0.1.1771 (2026-05-07)

package/dashboard.js

@@ -2721,23 +2721,19 @@ function _formatDocChatContext({ document, title, filePath, selection, canEdit,
   return context;
 }
 
-// Map errorClass codes from the runtime adapter to actionable user-facing messages.
+// Map runtime failures to user-facing messages.
 // sessionPreserved=true means ccCall preserved the session — user can retry immediately.
 // toolUses=[] from result.toolUses lets the message warn that tools may have already
 // modified files/state before the failure — the user shouldn't assume nothing happened.
-// errorMessage is the runtime adapter's own remediation string (from parseError) —
-// authoritative because it knows whether the runtime is Claude, Copilot, or another;
-// dashboard falls back to generic copy only when the adapter didn't supply one.
+// errorMessage is the runtime adapter's own text from parseError; when present it
+// is authoritative and is shown directly rather than replaced with dashboard copy.
 function _docChatErrorMessage(errorClass, sessionPreserved = false, toolUses = [], errorMessage = null) {
   const tools = Array.isArray(toolUses) ? toolUses : [];
   const toolHint = tools.length > 0
     ? ` (${tools.length} tool${tools.length === 1 ? '' : 's'} ran before the failure: ${tools.slice(0, 5).map(t => t.name).join(', ')}${tools.length > 5 ? '…' : ''} — files or state may have been modified.)`
     : '';
-  if (errorClass === 'auth-failure') return (errorMessage || 'Runtime authentication failed — check your CLI auth or API key, then try again.') + toolHint;
-  if (errorClass === 'context-limit') return 'Session context is too long. Click "Clear" to start a fresh conversation.' + toolHint;
-  if (errorClass === 'budget-exceeded') return (errorMessage || 'Runtime budget exceeded — check your account or quota.') + toolHint;
-  if (errorClass === 'crash') return (errorMessage || 'Runtime crashed unexpectedly. Try again.') + toolHint;
-  if (errorClass === 'unknown-model') return (errorMessage || 'Configured model is not valid for the active runtime. Update engine.ccModel or engine.defaultModel.') + toolHint;
+  const directError = typeof errorMessage === 'string' ? errorMessage.trim() : '';
+  if (directError) return directError + toolHint;
   if (sessionPreserved) return 'Temporary connection issue — your conversation is intact, send your message again.' + toolHint;
   if (tools.length > 0) return 'The agent stopped responding before producing a final answer.' + toolHint;
   return 'Failed to process request. Try again.';
@@ -2746,14 +2742,26 @@ function _docChatErrorMessage(errorClass, sessionPreserved = false, toolUses = [
 // Secondary note rendered alongside a recovered partial answer — distinct from the
 // hard-failure message because the answer/actions/document-edit DID land. The user
 // just needs to know the run wasn't clean.
-function _docChatPartialWarning(errorClass) {
-  if (errorClass === 'auth-failure') return 'Note: auth failed — answer recovered from partial output, but follow-up turns may not work.';
-  if (errorClass === 'context-limit') return 'Note: session context was too long — answer recovered. Click "Clear" before continuing.';
-  if (errorClass === 'budget-exceeded') return 'Note: runtime budget exceeded — answer recovered, but further calls may fail.';
-  if (errorClass === 'crash') return 'Note: runtime crashed before clean exit, but a complete response was recovered.';
+function _docChatPartialWarning(errorClass, errorMessage = null) {
+  const directError = typeof errorMessage === 'string' ? errorMessage.trim() : '';
+  if (directError) return `Note: ${directError}`;
   return 'Note: the agent exited unexpectedly. A complete response was recovered — verify any saved files or dispatched actions.';
 }
 
+function _docChatResultHasVisibleError(result) {
+  if (!result) return false;
+  if (result.errorClass) return true;
+  if (typeof result.errorMessage === 'string' && result.errorMessage.trim()) return true;
+  // stderr without a classified/runtime error is often CLI diagnostics; hard
+  // failures with no answer still surface stderr through _docChatFailureResponse.
+  return false;
+}
+
+function _docChatResultLooksSuccessful(result) {
+  if (!result || !result.text) return false;
+  return result.code === 0 || !_docChatResultHasVisibleError(result);
+}
+
 // Build the doc-chat extraContext for a single ccCall pass — refreshed on retry
 // so a fresh-session retry includes the full document instead of relying on the
 // dead session's prior turn for context.
@@ -2830,7 +2838,7 @@ function _recoverPartialDocChatResponse(result, sessionKey) {
   return {
     ...parsed,
     partial: true,
-    warning: _docChatPartialWarning(result.errorClass),
+    warning: _docChatPartialWarning(result.errorClass, result.errorMessage || result.stderr || null),
     toolUses: Array.isArray(result.toolUses) ? result.toolUses : [],
     // Recovery path still attaches the raw runtime failure — the answer landed
     // despite a non-zero exit; users still benefit from seeing why.
@@ -2838,6 +2846,41 @@ function _recoverPartialDocChatResponse(result, sessionKey) {
   };
 }
 
+function _shouldSuppressDocChatPostPatchError(ccError, finalize) {
+  if (!finalize || finalize.edited !== true) return false;
+  if (!ccError || ccError.errorClass !== 'unknown-model') return false;
+  return String(ccError.runtime || '').toLowerCase() === 'copilot';
+}
+
+function _buildDocChatResponsePayload({
+  answer,
+  actions,
+  actionResults,
+  actionParseError,
+  ccError,
+  partial,
+  warning,
+  toolUses,
+  finalize,
+} = {}) {
+  const final = finalize || { edited: false, content: null, answerSuffix: '' };
+  const suppressPostPatchError = _shouldSuppressDocChatPostPatchError(ccError, final);
+  const visibleAnswer = suppressPostPatchError && !partial ? 'Updated the document.' : answer;
+  const finalAnswer = final.answerSuffix ? visibleAnswer + final.answerSuffix : visibleAnswer;
+  return {
+    ok: !(ccError && !suppressPostPatchError),
+    answer: finalAnswer,
+    actions,
+    ...(actionResults ? { actionResults } : {}),
+    ...(actionParseError ? { actionParseError } : {}),
+    ...(ccError && !suppressPostPatchError ? { error: ccError } : {}),
+    ...(partial && !suppressPostPatchError ? { partial: true, warning } : {}),
+    ...(Array.isArray(toolUses) && toolUses.length ? { toolUses } : {}),
+    edited: final.edited,
+    ...(final.edited && final.content !== null ? { content: final.content } : {}),
+  };
+}
+
 
 // True when the file is a meeting JSON whose status forbids edits. Loaded
 // fresh on each call because meeting status can change while a doc-chat is
@@ -2990,7 +3033,7 @@ async function ccDocCall({ message, document, title, filePath, selection, canEdi
     // bleed into future interactions under the same key.
     docSessions.delete(sessionKey);
     schedulePersistDocSessions();
-  } else if (result.code === 0 && result.sessionId) {
+  } else if (_docChatResultLooksSuccessful(result) && result.sessionId) {
     // Store doc hash for next call's unchanged check
     const session = resolveSession('doc', sessionKey);
     if (session) session._docHash = initialPass.docHash;
@@ -3000,7 +3043,7 @@ async function ccDocCall({ message, document, title, filePath, selection, canEdi
     return { answer: result.text || result.stderr || 'Minions runtime is not installed or configured.', content: null, actions: [] };
   }
 
-  if (result.code !== 0 || !result.text) {
+  if (!_docChatResultLooksSuccessful(result)) {
     // Try to salvage a parseable answer / action / document edit before failing.
     const recovered = _recoverPartialDocChatResponse(result, sessionKey);
     if (recovered) return recovered;
@@ -3051,7 +3094,7 @@ async function ccDocCallStreaming({ message, document, title, filePath, selectio
   if (freshSession && sessionKey) {
     docSessions.delete(sessionKey);
     schedulePersistDocSessions();
-  } else if (result.code === 0 && result.sessionId) {
+  } else if (_docChatResultLooksSuccessful(result) && result.sessionId) {
     const session = resolveSession('doc', sessionKey);
     if (session) session._docHash = initialPass.docHash;
   }
@@ -3060,7 +3103,7 @@ async function ccDocCallStreaming({ message, document, title, filePath, selectio
     return { answer: result.text || result.stderr || 'Minions runtime is not installed or configured.', content: null, actions: [] };
   }
 
-  if (result.code !== 0 || !result.text) {
+  if (!_docChatResultLooksSuccessful(result)) {
     const recovered = _recoverPartialDocChatResponse(result, sessionKey);
     if (recovered) return recovered;
     const sessionPreserved = !!(resolveSession('doc', sessionKey)?.sessionId);
@@ -5201,20 +5244,11 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         filePath: body.filePath, fullPath, isJson, canEdit,
         originalContent: currentContent, delimiterContent: content,
       });
-      const finalAnswer = finalize.answerSuffix ? answer + finalize.answerSuffix : answer;
-      _docDone = true;
-      return jsonReply(res, 200, {
-        ok: !ccError,
-        answer: finalAnswer,
-        actions,
-        ...(actionResults ? { actionResults } : {}),
-        ...(actionParseError ? { actionParseError } : {}),
-        ...(ccError ? { error: ccError } : {}),
-        ...(partial ? { partial: true, warning } : {}),
-        ...(Array.isArray(toolUses) && toolUses.length ? { toolUses } : {}),
-        edited: finalize.edited,
-        ...(finalize.edited && finalize.content !== null ? { content: finalize.content } : {}),
+      const payload = _buildDocChatResponsePayload({
+        answer, actions, actionResults, actionParseError, ccError, partial, warning, toolUses, finalize,
       });
+      _docDone = true;
+      return jsonReply(res, 200, payload);
       } finally { _docAbort = null; _docDone = true; docChatInFlight.delete(docKey); }
     } catch (e) { return jsonReply(res, e.statusCode || 500, { error: e.message }); }
   }
@@ -5303,18 +5337,14 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           filePath: body.filePath, fullPath, isJson, canEdit,
           originalContent: currentContent, delimiterContent: content,
         });
-        const finalAnswer = finalize.answerSuffix ? answer + finalize.answerSuffix : answer;
+        const payload = _buildDocChatResponsePayload({
+          answer, actions, actionResults, actionParseError, ccError, partial, warning, toolUses, finalize,
+        });
+        const { answer: finalAnswer, ...donePayload } = payload;
         writeDocEvent({
           type: 'done',
           text: finalAnswer,
-          actions,
-          ...(actionResults ? { actionResults } : {}),
-          ...(actionParseError ? { actionParseError } : {}),
-          ...(ccError ? { error: ccError } : {}),
-          ...(partial ? { partial: true, warning } : {}),
-          ...(Array.isArray(toolUses) && toolUses.length ? { toolUses } : {}),
-          edited: finalize.edited,
-          ...(finalize.edited && finalize.content !== null ? { content: finalize.content } : {}),
+          ...donePayload,
         });
         _docStreamEnded = true;
         res.end();
@@ -7753,6 +7783,10 @@ module.exports = {
   _docChatPartialWarning,
   _docChatFailureResponse,
   _recoverPartialDocChatResponse,
+  _docChatResultHasVisibleError,
+  _docChatResultLooksSuccessful,
+  _shouldSuppressDocChatPostPatchError,
+  _buildDocChatResponsePayload,
   _linkPullRequestForTracking: linkPullRequestForTracking,
   _resolveSkillReadPath,
   DOC_CHAT_DOCUMENT_DELIMITER,

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-07T17:23:11.001Z"
+  "cachedAt": "2026-05-07T21:34:32.453Z"
 }

package/engine/runtimes/copilot.js

@@ -634,25 +634,77 @@ function parseStreamChunk(line) {
 
 // ── Error Normalization ─────────────────────────────────────────────────────
 
-function parseError(rawOutput) {
+function _collectErrorSignal(rawOutput) {
   const text = rawOutput == null ? '' : String(rawOutput);
+  if (!text) return '';
+
+  const signals = [];
+  let sawJsonLine = false;
+  for (const rawLine of text.split('\n')) {
+    const line = rawLine.trim();
+    if (!line) continue;
+    if (!line.startsWith('{')) {
+      signals.push(line);
+      continue;
+    }
+
+    let obj;
+    try { obj = JSON.parse(line); } catch { continue; }
+    if (!obj || typeof obj !== 'object') continue;
+    sawJsonLine = true;
+
+    const type = String(obj.type || '');
+    const subtype = String(obj.subtype || '');
+    const eventType = String(obj.event?.type || '');
+    const isErrorEvent = type === 'error'
+      || eventType === 'error'
+      || subtype.startsWith('error')
+      || obj.is_error === true
+      || obj.error != null
+      || obj.data?.error != null;
+    if (!isErrorEvent) continue;
+
+    for (const value of [
+      obj.error,
+      obj.message,
+      obj.stderr,
+      obj.result,
+      obj.data?.error,
+      obj.data?.message,
+      obj.data?.stderr,
+      obj.event?.error,
+      obj.event?.message,
+      subtype,
+    ]) {
+      if (typeof value === 'string' && value.trim()) signals.push(value.trim());
+    }
+  }
+
+  if (signals.length > 0) return signals.join('\n');
+  return sawJsonLine ? '' : text;
+}
+
+function parseError(rawOutput) {
+  const text = _collectErrorSignal(rawOutput);
   if (!text) return { message: '', code: null, retriable: true };
   const lower = text.toLowerCase();
 
-  if (/not authenticated|copilot login|please.*log.*in|401|403 forbidden|unauthorized/i.test(text)) {
-    return { message: 'Copilot/GitHub authentication failed. Run `gh auth login` or provide GH_TOKEN/COPILOT_GITHUB_TOKEN with Copilot access.', code: 'auth-failure', retriable: false };
+  const hasExplicitAuthFailure = /not authenticated|copilot login|please.*log.*in|\bunauthorized\b/i.test(text);
+  const hasAuthStatusCode = /\b(?:http(?:\/\d(?:\.\d)?)?|status(?:\s+code)?|statuscode|response(?:\s+status)?|api(?:\s+(?:error|response|status))?)\s*[:=]?\s*(?:401|403)\b|\b(?:401\s+unauthorized|403\s+forbidden)\b/i.test(text);
+  if (hasExplicitAuthFailure || hasAuthStatusCode) {
+    return { message: text, code: 'auth-failure', retriable: false };
   }
   if (/rate limit|too many requests|\b429\b/i.test(text)) {
-    return { message: 'Copilot rate limit hit', code: 'rate-limit', retriable: true };
+    return { message: text, code: 'rate-limit', retriable: true };
   }
   if (/unknown model|model not found|model.*invalid|invalid model/i.test(text)) {
-    return { message: 'Copilot rejected the requested model', code: 'unknown-model', retriable: false };
+    return { message: text, code: 'unknown-model', retriable: false };
   }
   if (/budget.*exceed|premium.*limit.*reach|quota.*exceed/i.test(lower)) {
-    return { message: 'Copilot premium-request budget exceeded — check your GitHub Copilot quota.', code: 'budget-exceeded', retriable: false };
+    return { message: text, code: 'budget-exceeded', retriable: false };
   }
   if (/internal error|panic|uncaught|copilot.*crashed|fatal: copilot/i.test(lower)) {
-    return { message: 'Copilot CLI crashed unexpectedly. Try again.', code: 'crash', retriable: true };
+    return { message: text, code: 'crash', retriable: true };
   }
   return { message: '', code: null, retriable: true };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1773",
+  "version": "0.1.1774",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"