@yemi33/minions 0.1.1765 → 0.1.1767

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.1.1767 (2026-05-07)
+
+### Fixes
+- stop test fixtures leaking into live engine/log.json (#2154)
+
 ## 0.1.1765 (2026-05-07)
 
 ### Features

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-07T03:29:49.996Z"
+  "cachedAt": "2026-05-07T15:01:54.451Z"
 }

package/engine/shared.js

@@ -168,12 +168,26 @@ function log(level, msg, meta = {}) {
  * That leaked test pollution into the live engine log (e.g. `_test/backoff-*`,
  * `this-playbook-does-not-exist-xyz`, `TEST-EXT-*` meeting IDs).
  *
- * Lazy resolution honors the *current* `MINIONS_TEST_DIR` at flush time, so
- * even unbussed dependents write to the test dir while the test owns it.
+ * Resolution order:
+ *   1. `MINIONS_TEST_DIR` — per-test isolation root (regression tests rely
+ *      on this — log goes to `<tmpdir>/engine/log.json`).
+ *   2. `MINIONS_LOG_PATH` — default test log target. Set at the top of
+ *      `test/unit.test.js` so tests that exercise log() without explicit
+ *      isolation (e.g. github backoff helpers, cooldown helpers) still land
+ *      in a benign tmp file instead of the live `D:/squad/engine/log.json`.
+ *   3. `MINIONS_HOME` / repo root fallback — production behavior.
+ *
+ * Lazy resolution honors the *current* env at flush time, so even unbussed
+ * dependents write to the test dir while the test owns it.
  */
 function _currentLogPath() {
-  const root = process.env.MINIONS_TEST_DIR
-    || (process.env.MINIONS_HOME ? path.resolve(process.env.MINIONS_HOME) : path.resolve(__dirname, '..'));
+  if (process.env.MINIONS_TEST_DIR) {
+    return path.join(path.resolve(process.env.MINIONS_TEST_DIR), 'engine', 'log.json');
+  }
+  if (process.env.MINIONS_LOG_PATH) {
+    return path.resolve(process.env.MINIONS_LOG_PATH);
+  }
+  const root = process.env.MINIONS_HOME ? path.resolve(process.env.MINIONS_HOME) : path.resolve(__dirname, '..');
   return path.join(root, 'engine', 'log.json');
 }
 

package/engine.js

@@ -431,6 +431,45 @@ function resolveDependencyBranches(depIds, sourcePlan, project, config) {
   return results;
 }
 
+/**
+ * Sync an existing worktree from origin on reuse: probe with
+ * `git ls-remote --exit-code --heads origin <branch>` first so that locally
+ * created branches whose first attempt died before push (agent timeout / orphan
+ * retry) skip fetch+pull silently instead of emitting a warn-level
+ * "couldn't find remote ref" pair on every reuse.
+ *
+ * Genuine fetch/pull failures (network, auth, conflict) still surface as warn.
+ * Never throws — the dispatch must continue regardless of sync outcome.
+ *
+ * Exported for testing; production callers ignore the return value.
+ *
+ * @returns {Promise<{skipped: boolean, reason?: string}>}
+ */
+async function syncReusedWorktree(rootDir, worktreePath, branchName, gitOpts = {}) {
+  // ls-remote --exit-code returns 2 when no matching refs are found on the
+  // remote. The probe only lists refs (no object transfer), so it's cheap
+  // even on slow links.
+  let onOrigin = true;
+  try {
+    await execAsync(
+      `git ls-remote --exit-code --heads origin "${branchName}"`,
+      { ...gitOpts, cwd: rootDir, timeout: 5000 },
+    );
+  } catch (e) {
+    // Exit code 2 = ref not on remote (the noisy case we want to silence).
+    // Any other failure (network, auth, timeout) we let pass through so the
+    // subsequent fetch surfaces a real warn with its native error message.
+    if (e && e.code === 2) onOrigin = false;
+  }
+  if (!onOrigin) {
+    log('info', `Branch ${branchName} not on origin yet — first push pending; skipping fetch/pull`);
+    return { skipped: true, reason: 'no-upstream' };
+  }
+  try { await execAsync(`git fetch origin "${branchName}"`, { ...gitOpts, cwd: rootDir }); } catch (e) { log('warn', 'git: ' + e.message); }
+  try { await execAsync(`git pull origin "${branchName}"`, { ...gitOpts, cwd: worktreePath }); } catch (e) { log('warn', 'git: ' + e.message); }
+  return { skipped: false };
+}
+
 // Find an existing worktree already checked out on a given branch
 async function findExistingWorktree(repoDir, branchName) {
   try {
@@ -592,8 +631,10 @@ async function spawnAgent(dispatchItem, config) {
     if (existingWt) {
       worktreePath = existingWt;
       log('info', `Reusing existing worktree for ${branchName}: ${existingWt}`);
-      try { await execAsync(`git fetch origin "${branchName}"`, { ..._gitOpts, cwd: rootDir }); } catch (e) { log('warn', 'git: ' + e.message); }
-      try { await execAsync(`git pull origin "${branchName}"`, { ..._gitOpts, cwd: existingWt }); } catch (e) { log('warn', 'git: ' + e.message); }
+      // Probe origin first — locally-created branches that were never pushed
+      // (orphan/timeout retry before first push) would otherwise emit a
+      // "couldn't find remote ref" warn pair on every reuse.
+      await syncReusedWorktree(rootDir, existingWt, branchName, _gitOpts);
     } else if (['meeting', 'ask', 'explore', 'plan-to-prd', 'plan'].includes(type)) {
       // Read-only tasks — no worktree needed, run in rootDir
       log('info', `${type}: read-only task, no worktree needed — running in rootDir`);
@@ -4666,7 +4707,7 @@ module.exports = {
   // Shared helpers (used by lifecycle.js and tests)
   reconcileItemsWithPrs, detectDependencyCycles,
   parseConflictFiles, pruneAncestorDeps, preflightMergeSimulation, // exported for testing
-  isWorktreeRetryableError, removeStaleIndexLock, // exported for testing
+  isWorktreeRetryableError, removeStaleIndexLock, syncReusedWorktree, // exported for testing
   _maxTurnsForType, buildProjectContext, normalizeAc, _buildAgentSpawnFlags, _classifyAgentFailure, // exported for testing
 
   // Playbooks

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1765",
+  "version": "0.1.1767",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"