@yemi33/minions 0.1.1760 → 0.1.1762

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.1.1762 (2026-05-07)
+
+### Fixes
+- detach agent process group so engine death never kills agents
+
+## 0.1.1761 (2026-05-07)
+
+### Fixes
+- kill engine PID only, not its tree, to preserve in-flight agents
+
 ## 0.1.1760 (2026-05-07)
 
 ### Fixes

package/bin/minions.js

@@ -59,22 +59,18 @@ function readEnginePid(minionsHome) {
 }
 
 /**
- * Force-kill a process and its descendants by PID. The /T flag on taskkill
- * recurses into the process tree on Windows, which `process.kill()` does not.
- * On POSIX, walk pgrep first so spawned children die before the parent.
+ * Force-kill a single process by PID — does NOT recurse into children.
+ * This preserves the engine→agent invariant: agents are independent processes
+ * spawned as children of the engine, but they must survive engine restarts so
+ * they can be re-attached on next start (CLAUDE.md timeouts/liveness section).
+ * Tree-kill (`taskkill /T`, `pgrep -P` walk) would orphan in-flight work.
  */
-function killPidTree(pid) {
+function killPidOnly(pid) {
   if (!pid || pid === process.pid) return;
   try {
     if (process.platform === 'win32') {
-      execSync(`taskkill /F /T /PID ${pid}`, { stdio: 'ignore', timeout: 5000, windowsHide: true });
+      execSync(`taskkill /F /PID ${pid}`, { stdio: 'ignore', timeout: 5000, windowsHide: true });
     } else {
-      try {
-        const out = execSync(`pgrep -P ${pid}`, { encoding: 'utf8', timeout: 3000 });
-        for (const c of out.split(/\r?\n/).map(s => Number(s.trim())).filter(n => Number.isInteger(n) && n > 0)) {
-          try { process.kill(c, 'SIGKILL'); } catch {}
-        }
-      } catch {}
       try { process.kill(pid, 'SIGKILL'); } catch {}
     }
   } catch {}
@@ -644,8 +640,9 @@ if (!cmd || cmd === 'help' || cmd === '--help' || cmd === '-h') {
   const oldEnginePid = readEnginePid(MINIONS_HOME);
   // 1. Graceful stop — short timeout so a hung engine can't block what follows.
   try { execSync(`node "${path.join(MINIONS_HOME, 'engine.js')}" stop`, { stdio: 'ignore', cwd: MINIONS_HOME, timeout: 10000, windowsHide: true }); } catch {}
-  // 2. Force-kill the recorded engine PID and its tree (most reliable — independent of cmdline matching).
-  killPidTree(oldEnginePid);
+  // 2. Force-kill the recorded engine PID (NOT the tree — agent children must
+  //    survive so the new engine can re-attach them via PID files).
+  killPidOnly(oldEnginePid);
   // 3. Free dashboard port (catches orphan dashboards with no recorded PID).
   killByPort(7331);
   // 4. Belt-and-suspenders cmdline match for anything still alive.

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-07T00:40:39.172Z"
+  "cachedAt": "2026-05-07T00:54:25.703Z"
 }

package/engine.js

@@ -1094,10 +1094,17 @@ async function spawnAgent(dispatchItem, config) {
 
   let proc;
   try {
+    // `detached: true` puts the agent in its own process group (POSIX) / job
+    // object (Windows), so when the engine dies — gracefully via stop, abruptly
+    // via taskkill, or because of a crash — the agent keeps running and can be
+    // re-attached on next start via PID file + live-output.log. We do NOT call
+    // proc.unref(): the engine still tracks exit while it's alive; detached
+    // only kicks in when the engine itself goes away.
     proc = runFile(process.execPath, spawnArgs, {
       cwd,
       stdio: ['pipe', 'pipe', 'pipe'],
       env: childEnv,
+      detached: true,
     });
   } catch (spawnErr) {
     // Synchronous spawn failure — record it to the (already-stamped) log so the
@@ -1308,10 +1315,12 @@ async function spawnAgent(dispatchItem, config) {
       }
       let resumeProc;
       try {
+        // detached so the resumed steering session also survives engine death (matches initial spawn)
         resumeProc = runFile(process.execPath, [spawnScript, steerPromptPath, sysPromptPath, ...resumeArgs], {
           cwd,
           stdio: ['pipe', 'pipe', 'pipe'],
           env: childEnv,
+          detached: true,
         });
       } catch (e) {
         log('warn', `Steering: spawn failed for ${agentId}: ${e.message}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1760",
+  "version": "0.1.1762",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"