@yemi33/minions 0.1.1757 → 0.1.1759

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.1.1759 (2026-05-07)
+
+### Fixes
+- isolate meeting tests, kill rename-live-dir antipattern (#2142)
+- honor no-op completions in PR attachment contract (#2141)
+
 ## 0.1.1757 (2026-05-06)
 
 ### Other

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-06T23:51:41.530Z"
+  "cachedAt": "2026-05-07T00:36:52.041Z"
 }

package/engine/lifecycle.js

@@ -542,6 +542,16 @@ function updateWorkItemStatus(meta, status, reason) {
         target.completedAt = ts();
         // Restore agent info from dispatch metadata (cleared on retry reset)
         if (meta._agentId && !target.dispatched_to) target.dispatched_to = meta._agentId;
+        // No-op marker (set by runPostCompletionHooks when the agent honored a
+        // verify-already-shipped / no-op-fix-review skill). Surfaces the
+        // rationale on the dashboard instead of marking the WI as failed.
+        if (meta._noopReason) {
+          target._noop = true;
+          target._noopReason = meta._noopReason;
+        } else {
+          delete target._noop;
+          delete target._noopReason;
+        }
       } else if (status === WI_STATUS.FAILED) {
         if (reason) target.failReason = reason;
         target.failedAt = ts();
@@ -2510,6 +2520,38 @@ function parseCompletionBoolean(value) {
   return undefined;
 }
 
+// Detect a deliberate no-op completion — the agent correctly declined to make
+// changes (work was already shipped, dispatch premise was wrong, self-authored
+// review with no actionable feedback, etc.) and should NOT be flagged as a
+// silent failure for missing a PR. Honored signals:
+//   - completion.noop === true (canonical, primary)
+//   - completion.result === 'noop'  OR  completion.result.type === 'noop'
+// Returns the no-op rationale string (for surfacing in WI metadata) when
+// detected, or null otherwise. The status must be a successful terminal state
+// — a failed/partial/in-progress completion that also claims `noop` is a
+// contradiction and falls through to the normal contract.
+function parseCompletionNoop(completion) {
+  if (!completion || typeof completion !== 'object') return null;
+  const explicit = parseCompletionBoolean(completion.noop);
+  let resultIsNoop = false;
+  if (typeof completion.result === 'string') {
+    resultIsNoop = completion.result.trim().toLowerCase() === 'noop';
+  } else if (completion.result && typeof completion.result === 'object') {
+    resultIsNoop = String(completion.result.type || '').trim().toLowerCase() === 'noop';
+  }
+  if (explicit !== true && !resultIsNoop) return null;
+  const status = normalizeCompletionStatus(completion.status);
+  if (status && status !== 'success' && status !== 'done' && status !== 'complete') return null;
+  const reason = String(
+    completion.noopReason
+      || completion.noop_reason
+      || completion.summary
+      || completion.reason
+      || ''
+  ).trim();
+  return reason || 'no-op completion';
+}
+
 function normalizeReviewVerdict(verdict) {
   const value = String(verdict || '').trim().toLowerCase().replace(/[\s-]+/g, '_');
   if (value === 'approve' || value === 'approved') return 'approved';
@@ -2867,7 +2909,17 @@ async function runPostCompletionHooks(dispatchItem, agentId, code, stdout, confi
     }
   }
 
-  if (effectiveSuccess && meta?.item?.id && !skipDoneStatus) {
+  // No-op signal: agent declared the work was correctly NOT done (already
+  // shipped, dispatch premise wrong, self-authored review, etc.). Skip the PR
+  // attachment contract — a missing PR is intentional, not a silent failure.
+  const noopRationale = (effectiveSuccess && meta?.item?.id && !skipDoneStatus)
+    ? parseCompletionNoop(structuredCompletion)
+    : null;
+  if (noopRationale) {
+    log('info', `No-op completion for ${meta.item.id}: ${noopRationale.slice(0, 200)}`);
+  }
+
+  if (effectiveSuccess && meta?.item?.id && !skipDoneStatus && !noopRationale) {
     completionContractFailure = await enforcePrAttachmentContract(type, meta, agentId, config, resultSummary, stdout);
     if (completionContractFailure?.severity === 'hard' || completionContractFailure?.nonTerminal) {
       skipDoneStatus = true;
@@ -2876,6 +2928,9 @@ async function runPostCompletionHooks(dispatchItem, agentId, code, stdout, confi
 
   if (effectiveSuccess && meta?.item?.id && !skipDoneStatus) {
     meta._agentId = agentId;
+    if (noopRationale) {
+      meta._noopReason = noopRationale.slice(0, 500);
+    }
     updateWorkItemStatus(meta, WI_STATUS.DONE, '');
   }
   // Failure retry is handled by completeDispatch in dispatch.js — not duplicated here.
@@ -3238,6 +3293,7 @@ module.exports = {
   isReviewBailout,
   parseStructuredCompletion,
   parseCompletionFieldSummary,
+  parseCompletionNoop,
   detectNonTerminalResultSummary,
   parseCompletionReportFile,
   persistCompletionReport,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1757",
+  "version": "0.1.1759",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/shared-rules.md

@@ -72,6 +72,8 @@ The engine provides a completion report path in the prompt and in `MINIONS_COMPL
 
 Use `status: "failed"` plus an accurate `failure_class`, `retryable`, and `needs_rerun` when the task could not be completed. For PR reviews, set `verdict` to `approved` or `changes-requested`. Include every durable artifact you created or updated in `artifacts` (PRs, notes, plans, PRDs, important files) so the dashboard can display them. Fenced `completion` blocks are still accepted as a fallback, but the JSON report is the primary signal.
 
+**No-op completions:** when you correctly decline to do the work — the change was already shipped on master, the dispatch premise is wrong, the flagged review comment is your own author-notes, etc. — write `status: "success"`, `pr: "N/A"`, AND add `"noop": true`. The engine treats `noop: true` as the canonical signal that no PR was expected, marks the work item done with the rationale surfaced in `_noopReason` for the dashboard, and skips the missing-PR-attachment failure. Without `noop: true`, an empty PR will still be flagged as a silent failure and auto-retried up to `maxRetries` times.
+
 ## Long-Running Commands
 
 Builds, dependency installs, tests, and local servers can be quiet for long periods. Run the repo's normal CLI commands and let them finish; do not add artificial progress output, heartbeat loops, or command-specific workarounds just to keep Minions active.