@yemi33/minions 0.1.1738 → 0.1.1739

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.1.1739 (2026-05-06)
+
+### Features
+- make Command Center chat sessions non-expiring (#2100)
+
 ## 0.1.1738 (2026-05-06)
 
 ### Features

package/dashboard/js/command-center.js

@@ -392,6 +392,12 @@ function ccCloseTab(id) {
     closingTab._queue = [];
     _ccSending = (_ccTabs.some(function(t) { return t._sending; }));
   }
+  // Tabs are non-expiring on the server — explicit close is the only path that
+  // removes the persisted session. Fire-and-forget DELETE so closing a tab
+  // also evicts the server-side cc-sessions.json entry.
+  try {
+    fetch('/api/cc-sessions/' + encodeURIComponent(id), { method: 'DELETE' }).catch(function() {});
+  } catch {}
   _ccTabs.splice(idx, 1);
   if (_ccActiveTabId === id) {
     // Switch to adjacent tab or create new

package/dashboard.js

@@ -932,9 +932,14 @@ setInterval(() => {
 
 // ── Command Center: session state + helpers ─────────────────────────────────
 
-// Bound resumed session growth so stale conversations do not accumulate unbounded context.
+// CC chat sessions do NOT auto-expire. A tab is removed only via explicit user
+// deletion (DELETE /api/cc-sessions/:id, wired from ccCloseTab). Doc-chat
+// sessions keep their own TTL (DOC_SESSION_TTL_MS) — that's a separate store.
+//
+// CC_SESSION_MAX_TURNS is reused by the doc-chat session pruner to cap
+// per-session turn growth there; CC chat sessions are not capped because
+// users are expected to keep long-running tabs alive indefinitely.
 const CC_SESSION_MAX_TURNS = shared.ENGINE_DEFAULTS.ccMaxTurns;
-const CC_SESSION_TTL_MS = shared.ENGINE_DEFAULTS.ccSessionTtlMs;
 let ccSession = { sessionId: null, createdAt: null, lastActiveAt: null, turnCount: 0 };
 const ccInFlightTabs = new Map(); // tabId → timestamp — per-tab in-flight tracking for parallel CC requests
 const ccInFlightAborts = new Map(); // tabId → abortFn — lets a new request kill the stale LLM
@@ -1070,18 +1075,17 @@ function _ccTabIsInFlight(tabId) {
 
 function ccSessionValid() {
   if (!ccSession.sessionId) return false;
-  // Invalidate session if system prompt changed (e.g. after code update + restart)
+  // Invalidate session if system prompt changed (e.g. after code update + restart).
+  // This is correctness-driven, not expiration-driven: a session created against
+  // a stale system prompt would carry the old persona/rules into resume turns.
   if (ccSession._promptHash && ccSession._promptHash !== _ccPromptHash) {
     console.log('[CC] System prompt changed — invalidating stale session');
     ccSession = { sessionId: null, createdAt: null, lastActiveAt: null, turnCount: 0 };
     return false;
   }
-  if (_sessionExpired(ccSession.lastActiveAt || ccSession.createdAt, CC_SESSION_TTL_MS)) {
-    console.log('[CC] Session expired by TTL — starting fresh');
-    ccSession = { sessionId: null, createdAt: null, lastActiveAt: null, turnCount: 0 };
-    return false;
-  }
-  return ccSession.turnCount < CC_SESSION_MAX_TURNS;
+  // No TTL or turn-count cap — CC chat sessions live until the user explicitly
+  // closes the tab (which calls DELETE /api/cc-sessions/:id).
+  return true;
 }
 
 // Static system prompt — baked into session on creation, never changes
@@ -1120,11 +1124,13 @@ function _sessionExpired(lastActiveAt, ttlMs) {
   return Date.now() - at > ttlMs;
 }
 
+// CC tab sessions never auto-expire — only invalid records (missing id /
+// sessionId) and prompt-hash mismatches are filtered out. Tabs are removed
+// from disk only when the user explicitly closes them via DELETE
+// /api/cc-sessions/:id.
 function _filterCcTabSessions(sessions) {
   return (Array.isArray(sessions) ? sessions : []).filter(s =>
     s && s.id && s.sessionId &&
-    (s.turnCount || 0) < CC_SESSION_MAX_TURNS &&
-    !_sessionExpired(s.lastActiveAt || s.createdAt, CC_SESSION_TTL_MS) &&
     (!s._promptHash || s._promptHash === _ccPromptHash)
   );
 }
@@ -1157,10 +1163,12 @@ function _buildTranscriptCarryover(transcript, { previousRuntime } = {}) {
   return `${header}\n\n${truncationNote}${lines.join('\n\n')}\n\n--- Current message follows ---`;
 }
 
-// Load persisted CC session on startup
+// Load persisted CC session on startup. CC chat sessions are non-expiring;
+// only restore-time validity checks here are sessionId presence (anything
+// else would auto-expire the user's chat without their consent).
 try {
   const saved = safeJson(path.join(ENGINE_DIR, 'cc-session.json'));
-  if (saved && saved.sessionId && !_sessionExpired(saved.lastActiveAt || saved.createdAt, CC_SESSION_TTL_MS)) ccSession = saved;
+  if (saved && saved.sessionId) ccSession = saved;
 } catch { /* optional */ }
 
 let _preambleCache = null;

package/docs/command-center.md

@@ -13,11 +13,12 @@ CC maintains a true multi-turn session using Claude CLI's `--resume` flag. Unlik
 **Session lifecycle:**
 - **Created** on first message (or after the system prompt changes, or when you click **New Session**)
 - **Resumed** on subsequent messages via `--resume <sessionId>`
-- **Invalidated** when the CC system prompt changes — detected by hashing `CC_STATIC_SYSTEM_PROMPT` into `_ccPromptHash` and comparing on each call. Sessions are also bounded by `ENGINE_DEFAULTS.ccMaxTurns` (default 50 turns) and `ENGINE_DEFAULTS.ccSessionTtlMs` (default 2h — resumed sessions older than this get rotated).
-- **Persisted** to `engine/cc-session.json` — survives dashboard restarts
+- **Invalidated** only when the CC system prompt changes — detected by hashing `CC_STATIC_SYSTEM_PROMPT` into `_ccPromptHash` and comparing on each call. CC chat sessions do **not** auto-expire by TTL or turn count; `ENGINE_DEFAULTS.ccMaxTurns` (default 50) is a per-call tool-use cap inside the Claude CLI, not a session lifetime cap.
+- **Persisted** to `engine/cc-session.json` (legacy global session) and `engine/cc-sessions.json` (per-tab sessions) — both survive dashboard restarts and engine cleanup ticks
 - **Frontend messages** saved to `localStorage` — survive page refresh
+- **Removed** only when the user explicitly closes a tab via the **×** button on the tab strip — that fires `DELETE /api/cc-sessions/:id` to evict the persisted session
 
-Click **New Session** in the drawer header to start fresh.
+Click **New Session** in the drawer header to start fresh; click the **×** on a tab to remove it permanently.
 
 ### Fresh State Each Turn
 

package/engine/cleanup.js

@@ -681,20 +681,11 @@ async function runCleanup(config, verbose = false) {
     }
   } catch (e) { log('warn', 'orphan PRD status reset: ' + e.message); }
 
-  // 10. Prune CC tab sessions — cap at 50 entries, remove oldest beyond cap
+  // 10. CC tab sessions are non-expiring by design — they persist until the
+  // user explicitly closes the tab (which fires DELETE /api/cc-sessions/:id).
+  // Cleanup intentionally does NOT prune cc-sessions.json; doing so would
+  // silently invalidate live chat tabs the user expects to keep.
   cleaned.ccSessions = 0;
-  try {
-    const ccSessionsPath = path.join(ENGINE_DIR, 'cc-sessions.json');
-    const sessions = shared.safeJsonArr(ccSessionsPath);
-    const CC_SESSIONS_CAP = 50;
-    if (sessions.length > CC_SESSIONS_CAP) {
-      // Sort by lastActiveAt descending, keep newest
-      sessions.sort((a, b) => new Date(b.lastActiveAt || 0) - new Date(a.lastActiveAt || 0));
-      const pruned = sessions.slice(0, CC_SESSIONS_CAP);
-      cleaned.ccSessions = sessions.length - pruned.length;
-      safeWrite(ccSessionsPath, pruned);
-    }
-  } catch (e) { log('warn', 'prune cc-sessions: ' + e.message); }
 
   // 10b. Prune doc-chat sessions — cap at 100 entries, remove oldest beyond cap
   cleaned.docSessions = 0;

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-06T00:16:35.626Z"
+  "cachedAt": "2026-05-06T00:40:29.215Z"
 }

package/engine/llm.js

@@ -787,6 +787,9 @@ function callLLMStreaming(promptText, sysPromptText, opts = {}) {
 
     proc.on('close', finish);
     proc.on('exit', (code) => {
+      // 'close' waits for stdio to close. If the runtime spawned a detached
+      // grandchild that inherited stdout/stderr, the OS pipe stays open and
+      // 'close' may never fire. Fall back to 'exit' after a drain window.
       if (settled) return;
       exitSettleTimer = setTimeout(() => finish(code), LLM_EXIT_SETTLE_GRACE_MS);
     });

package/engine/shared.js

@@ -914,7 +914,6 @@ const ENGINE_DEFAULTS = {
   removeWorktreeFailureTtlMs: 24 * 60 * 60 * 1000, // stale failed paths are forgotten after a day
   removeWorktreeFailureMaxEntries: 1000, // bound failed-worktree retry suppression cache
   ccMaxTurns: 50, // max tool-use turns for CC/doc-chat before CLI stops
-  ccSessionTtlMs: 7 * 24 * 60 * 60 * 1000, // 7d — keep chats resumable after breaks, still bounded by turn cap
   docSessionTtlMs: 7 * 24 * 60 * 60 * 1000, // 7d — longer-lived doc sessions, still bounded
   docSessionMaxEntries: 200, // cap doc-chat session map/disk store by least-recent activity
   ccLiveStreamMaxAgeMs: 30 * 60 * 1000, // hard cap reconnect buffers if abort/cleanup stalls

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1738",
+  "version": "0.1.1739",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"