@yemi33/minions 0.1.1693 → 0.1.1694

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,8 +1,9 @@
1
1
  # Changelog
2
2
 
3
- ## 0.1.1693 (2026-05-04)
3
+ ## 0.1.1694 (2026-05-04)
4
4
 
5
5
  ### Features
6
+ - remove stale permission mode settings (#2009)
6
7
  - sync review verdict PR status (#2008)
7
8
 
8
9
  ## 0.1.1691 (2026-05-04)
package/README.md CHANGED
@@ -406,7 +406,7 @@ No bash or shell involved — Node spawns Node directly. Dependency branches are
406
406
  - **Working directory** — project root (agent creates worktrees as needed)
407
407
  - **MCP servers** — inherited from `~/.claude.json` (no extra config needed)
408
408
  - **Full tool access** — all built-in tools plus all MCP tools
409
- - **Permission mode** — `bypassPermissions` (no interactive prompts)
409
+ - **Permission bypass** — runtime-owned; Claude uses `--dangerously-skip-permissions`, while Copilot uses `--autopilot --allow-all --no-ask-user` (no dashboard `permissionMode` control)
410
410
  - **Output format** — `stream-json` (real-time streaming for live dashboard + completion recovery)
411
411
 
412
412
  ### Post-Completion
@@ -54,7 +54,6 @@ function renderAgents(agents) {
54
54
  })()}
55
55
  ${a._blockingToolCall ? `<div style="margin-top:4px;padding:4px 8px;background:rgba(130,160,210,0.13);border:1px solid rgba(130,160,210,0.3);border-radius:4px;font-size:10px;color:var(--muted)">&#x23F3; Blocking tool call (${escapeHtml(a._blockingToolCall.tool)}) &mdash; silent ${Math.round(a._blockingToolCall.silentMs/60000)}min, timeout in ${Math.round(a._blockingToolCall.remainingMs/60000)}min</div>` : ''}
56
56
  ${a._warning ? `<div style="margin-top:4px;padding:4px 8px;background:rgba(210,153,34,0.15);border:1px solid rgba(210,153,34,0.3);border-radius:4px;font-size:10px;color:var(--yellow)">&#x26A0; ${escapeHtml(a._warning)}</div>` : ''}
57
- ${a._permissionMode && a._permissionMode !== 'bypassPermissions' && !a._warning ? `<div style="margin-top:4px;font-size:9px;color:var(--muted)">Permission mode: ${escapeHtml(a._permissionMode)}</div>` : ''}
58
57
  ${a.resultSummary ? `<div class="agent-result" title="${escapeHtml(a.resultSummary)}">${renderMd(a.resultSummary.slice(0, 200))}${a.resultSummary.length > 200 ? '...' : ''}</div>` : ''}
59
58
  </div>
60
59
  `).join('');
@@ -258,20 +258,12 @@ async function openSettings() {
258
258
  '</div>' +
259
259
 
260
260
  '<h3 style="font-size:13px;color:var(--blue);margin-bottom:8px">Claude CLI</h3>' +
261
- '<div style="display:grid;grid-template-columns:1fr 1fr;gap:8px;margin-bottom:16px">' +
261
+ '<div style="display:grid;grid-template-columns:1fr 1fr;gap:8px;margin-bottom:8px">' +
262
262
  settingsField('Output Format', 'set-outputFormat', c.outputFormat || 'stream-json', '', '') +
263
- settingsField('Allowed Tools', 'set-allowedTools', c.allowedTools || '', '', 'Tools agents can use without permission prompts. Add MCP tools here if using non-bypass mode (e.g. mcp__azure-ado__*)') +
263
+ settingsField('Allowed Tools', 'set-allowedTools', c.allowedTools || '', '', 'Claude allow-list passed through for compatibility; runtime bypass flags are adapter-owned.') +
264
264
  '</div>' +
265
- '<div style="margin-bottom:16px">' +
266
- '<label style="font-size:10px;color:var(--muted);display:block;margin-bottom:2px">Permission Mode <span style="opacity:0.6">(how agents handle tool approvals)</span></label>' +
267
- '<select id="set-permissionMode" style="width:100%;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--text);font-size:12px">' +
268
- '<option value="bypassPermissions"' + ((c.permissionMode || 'bypassPermissions') === 'bypassPermissions' ? ' selected' : '') + '>Bypass (recommended) — agents run autonomously without permission prompts</option>' +
269
- '<option value="auto"' + ((c.permissionMode) === 'auto' ? ' selected' : '') + '>Auto — auto-approve safe tools, prompt for risky ones (agents may hang on risky tools)</option>' +
270
- '<option value="default"' + ((c.permissionMode) === 'default' ? ' selected' : '') + '>Default — prompt for every tool (agents WILL hang — not recommended)</option>' +
271
- '</select>' +
272
- '<div id="set-permissionMode-warn" style="font-size:9px;margin-top:4px;padding:4px 8px;border-radius:4px;' + ((c.permissionMode && c.permissionMode !== 'bypassPermissions') ? 'display:block;background:rgba(248,81,73,0.1);color:var(--red)' : 'display:none') + '">' +
273
- '\u26A0 Tools listed in Allowed Tools above are auto-approved even in non-bypass modes. Agents will only hang if they try to use a tool NOT on that list (e.g. MCP tools). In bypass mode, all tools are approved automatically.' +
274
- '</div>' +
265
+ '<div style="font-size:10px;color:var(--muted);margin-bottom:16px;padding:6px 8px;border:1px solid var(--border);border-radius:4px;background:var(--surface-subtle, rgba(130,160,210,0.08))">' +
266
+ 'Permission bypass is runtime-owned: Claude agents use <code>--dangerously-skip-permissions</code>; Copilot agents use <code>--autopilot --allow-all --no-ask-user</code>. There is no dashboard permission-mode setting.' +
275
267
  '</div>' +
276
268
 
277
269
  '<h3 style="font-size:13px;color:var(--blue);margin-bottom:8px">Agents</h3>' +
@@ -314,20 +306,6 @@ async function openSettings() {
314
306
  document.getElementById('modal-body').style.whiteSpace = '';
315
307
  document.getElementById('modal').classList.add('open');
316
308
 
317
- // Wire permission mode warning toggle
318
- var pmSelect = document.getElementById('set-permissionMode');
319
- if (pmSelect) pmSelect.addEventListener('change', function() {
320
- var warn = document.getElementById('set-permissionMode-warn');
321
- if (!warn) return;
322
- if (this.value !== 'bypassPermissions') {
323
- warn.style.display = 'block';
324
- warn.style.background = 'rgba(248,81,73,0.1)';
325
- warn.style.color = 'var(--red)';
326
- } else {
327
- warn.style.display = 'none';
328
- }
329
- });
330
-
331
309
  // ── Runtime fleet wiring (P-7a5c1f8e) ──────────────────────────────────────
332
310
  // 1. Load registered runtimes into the defaultCli + ccCli dropdowns.
333
311
  // 2. Load models for the selected defaultCli into the defaultModel input.
@@ -595,7 +573,6 @@ async function saveSettings() {
595
573
  const claudePayload = {
596
574
  outputFormat: document.getElementById('set-outputFormat').value,
597
575
  allowedTools: document.getElementById('set-allowedTools').value,
598
- permissionMode: document.getElementById('set-permissionMode').value,
599
576
  };
600
577
 
601
578
  const teamsPayload = {
package/dashboard.js CHANGED
@@ -5405,6 +5405,12 @@ What would you like to discuss or change? When you're happy, say "approve" and I
5405
5405
  } catch (e) { return jsonReply(res, e.statusCode || 500, { error: e.message }); }
5406
5406
  }
5407
5407
 
5408
+ function settingsClaudeConfig(config) {
5409
+ const claude = { ...shared.DEFAULT_CLAUDE, ...(config.claude || {}) };
5410
+ delete claude.permissionMode;
5411
+ return claude;
5412
+ }
5413
+
5408
5414
  async function handleSettingsRead(req, res) {
5409
5415
  try {
5410
5416
  const config = queries.getConfig();
@@ -5414,7 +5420,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
5414
5420
  if (engine.prPollCommentsEvery === undefined && engine.adoPollCommentsEvery !== undefined) engine.prPollCommentsEvery = engine.adoPollCommentsEvery;
5415
5421
  return jsonReply(res, 200, {
5416
5422
  engine,
5417
- claude: { ...shared.DEFAULT_CLAUDE, ...(config.claude || {}) },
5423
+ claude: settingsClaudeConfig(config),
5418
5424
  agents: config.agents || {},
5419
5425
  teams: { ...shared.ENGINE_DEFAULTS.teams, ...(config.teams || {}) },
5420
5426
  projects: (config.projects || []).map(p => ({
@@ -5437,6 +5443,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
5437
5443
  if (!config.engine) config.engine = {};
5438
5444
  if (!config.claude) config.claude = {};
5439
5445
  if (!config.agents) config.agents = {};
5446
+ delete config.claude.permissionMode;
5440
5447
 
5441
5448
  const _clamped = [];
5442
5449
  const _engineModelDiscovery = require('./engine/model-discovery');
@@ -5607,10 +5614,6 @@ What would you like to discuss or change? When you're happy, say "approve" and I
5607
5614
  for (const key of ['allowedTools', 'outputFormat']) {
5608
5615
  if (body.claude[key] !== undefined) config.claude[key] = String(body.claude[key]);
5609
5616
  }
5610
- if (body.claude.permissionMode !== undefined) {
5611
- const valid = ['bypassPermissions', 'auto', 'default'];
5612
- config.claude.permissionMode = valid.includes(body.claude.permissionMode) ? body.claude.permissionMode : 'bypassPermissions';
5613
- }
5614
5617
  }
5615
5618
 
5616
5619
  if (body.agents) {
@@ -250,10 +250,12 @@ Combines:
250
250
  ```bash
251
251
  claude -p --system-prompt-file <sysprompt-file> \
252
252
  --output-format stream-json --max-turns 100 --verbose \
253
- --permission-mode bypassPermissions
253
+ --dangerously-skip-permissions
254
254
  # Prompt text is piped via stdin (not passed as an arg).
255
255
  # Agent dispatches route through engine/spawn-agent.js; CC / doc-chat use a direct
256
256
  # spawn path in engine/llm.js that bypasses spawn-agent.js entirely.
257
+ # Permission bypass is runtime-owned: Copilot uses
258
+ # --autopilot --allow-all --no-ask-user instead.
257
259
  ```
258
260
 
259
261
  - Process runs in the worktree directory (or rootDir for reviews)
@@ -63,9 +63,9 @@ proc.stdin.end();
63
63
 
64
64
  Fix: switched to `--output-format stream-json` — streams events as they happen.
65
65
 
66
- ### Permission Mode
66
+ ### Permission Bypass
67
67
 
68
- Agents would hang waiting for permission prompts (invisible in headless mode). Added `--permission-mode bypassPermissions`.
68
+ Agents would hang waiting for permission prompts (invisible in headless mode). Modern Minions keeps bypass behavior inside runtime adapters: Claude emits `--dangerously-skip-permissions`; Copilot emits `--autopilot --allow-all --no-ask-user`. The legacy `config.claude.permissionMode` key is ignored.
69
69
 
70
70
  ### CLAUDECODE Environment Variable
71
71
 
@@ -85,7 +85,7 @@ When the engine restarts, the in-memory `activeProcesses` Map is lost. Active di
85
85
 
86
86
  **Dispatch 1773292681199** — Dallas, central work item, auto-route:
87
87
 
88
- 1. Engine spawns `node spawn-agent.js prompt.md sysprompt.md --output-format stream-json --verbose --permission-mode bypassPermissions`
88
+ 1. Engine spawns `node spawn-agent.js prompt.md sysprompt.md --runtime claude --output-format stream-json --verbose`
89
89
  2. spawn-agent.js resolves `cli.js`, spawns `node cli.js -p --system-prompt <content> ...`
90
90
  3. Prompt piped via stdin — no shell interpretation
91
91
  4. MCP servers connect (azure-ado, azure-kusto, mobile, DevBox)
@@ -22,5 +22,13 @@
22
22
  "reason": "These cadence settings gate both ADO and GitHub PR polling, so the ADO-prefixed names are misleading.",
23
23
  "locations": ["engine.js read-side fallback from config.engine.adoPollStatusEvery/adoPollCommentsEvery", "dashboard.js handleSettingsRead/handleSettingsUpdate alias fallback for old keys"],
24
24
  "cleanup": "Remove the adoPoll* alias fallback reads after existing configs have been migrated to prPollStatusEvery/prPollCommentsEvery."
25
+ },
26
+ {
27
+ "id": "config-claude-permission-mode",
28
+ "summary": "config.claude.permissionMode ignored; runtime adapters own permission bypass flags",
29
+ "deprecated": "2026-05-04",
30
+ "reason": "Claude and Copilot require different non-interactive bypass flags, so a shared Claude config field was misleading and no longer controls spawns.",
31
+ "locations": ["dashboard.js settings update strips config.claude.permissionMode", "dashboard/js/settings.js no longer renders a Permission Mode selector"],
32
+ "cleanup": "After old configs have been rewritten through settings, remove the deprecated-field preflight warning entry for permissionMode."
25
33
  }
26
34
  ]
@@ -1,5 +1,5 @@
1
1
  {
2
2
  "runtime": "copilot",
3
3
  "models": null,
4
- "cachedAt": "2026-05-04T03:30:25.499Z"
4
+ "cachedAt": "2026-05-04T03:31:17.601Z"
5
5
  }
package/engine/queries.js CHANGED
@@ -428,25 +428,11 @@ function getAgentStatus(agentId) {
428
428
  if (active._blockingToolCall) {
429
429
  result._blockingToolCall = active._blockingToolCall;
430
430
  }
431
- // Detect permission-waiting and in-flight tools: read only head+tail of live-output.log (max 2KB total)
431
+ // Detect in-flight tools: read only head+tail of live-output.log (max 2KB total)
432
432
  try {
433
433
  const liveLogPath = path.join(AGENTS_DIR, agentId, 'live-output.log');
434
434
  const { head, tail } = readHeadTail(liveLogPath, 1024);
435
435
  if (head) {
436
- // Check init message (in head) for permission mode
437
- const initMatch = head.match(/"permissionMode"\s*:\s*"([^"]+)"/);
438
- if (initMatch && initMatch[1] !== 'bypassPermissions') {
439
- result._permissionMode = initMatch[1];
440
- }
441
- // Check if agent has been silent for >60s (use tail for recent activity)
442
- const lastLine = tail.trimEnd().split('\n').pop();
443
- if (lastLine && lastLine.includes('"type":"assistant"') && lastLine.includes('"tool_use"')) {
444
- const liveStat = fs.statSync(liveLogPath);
445
- const silentMs = Date.now() - liveStat.mtimeMs;
446
- if (silentMs > 60000 && result._permissionMode) {
447
- result._warning = 'Possibly waiting for permission approval — agent is not in bypass mode';
448
- }
449
- }
450
436
  // Detect in-flight tool calls (task_started with no task_notification)
451
437
  const inFlight = detectInFlightTool(tail);
452
438
  if (inFlight && inFlight.description) {
@@ -570,7 +556,6 @@ function getAgents(config) {
570
556
  completed_at: s.completed_at || null,
571
557
  _blockingToolCall: s._blockingToolCall || null,
572
558
  _warning: s._warning || null,
573
- _permissionMode: s._permissionMode || null,
574
559
  chartered, inboxCount: inboxFiles.length + steeringInboxFiles.length
575
560
  };
576
561
  });
package/engine/shared.js CHANGED
@@ -851,7 +851,7 @@ const ENGINE_DEFAULTS = {
851
851
  // Backward-compat: keep `engine.claude.*` field family deprecation tracker. Listed here so preflight
852
852
  // knows which subkeys to flag as deprecated. Do not consume `claude.*` in new code — use the runtime
853
853
  // adapter system (engine/runtimes/) and the resolveAgent*/resolveCc* helpers instead.
854
- _deprecatedConfigClaudeFields: ['binary', 'outputFormat', 'allowedTools', 'maxTurns', 'effort', 'budgetCap'],
854
+ _deprecatedConfigClaudeFields: ['binary', 'outputFormat', 'allowedTools', 'permissionMode', 'maxTurns', 'effort', 'budgetCap'],
855
855
  // Teams integration — config.teams shape: { enabled, appId, appPassword, certPath, privateKeyPath, tenantId, notifyEvents, ccMirror, inboxPollInterval }
856
856
  // Auth modes: (1) appId + appPassword (client secret), or (2) appId + certPath + privateKeyPath + tenantId (certificate)
857
857
  teams: {
package/minions.js CHANGED
@@ -470,6 +470,7 @@ async function initMinions({ skipScan = false, scanRoot, scanDepth } = {}) {
470
470
  if (config.engine[k] === undefined) config.engine[k] = v;
471
471
  }
472
472
  if (!config.claude) config.claude = {};
473
+ delete config.claude.permissionMode;
473
474
  for (const [k, v] of Object.entries(DEFAULT_CLAUDE)) {
474
475
  if (config.claude[k] === undefined) config.claude[k] = v;
475
476
  }
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@yemi33/minions",
3
- "version": "0.1.1693",
3
+ "version": "0.1.1694",
4
4
  "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
5
5
  "bin": {
6
6
  "minions": "bin/minions.js"