@yemi33/minions 0.1.1686 → 0.1.1688

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.1.1688 (2026-05-02)
+
+### Fixes
+-  bug sweep — PRD races, hardcoded retries, capability-flag drift
+
+## 0.1.1687 (2026-05-02)
+
+### Other
+- Show scan add feedback in modal
+
 ## 0.1.1686 (2026-05-02)
 
 ### Fixes

package/dashboard/js/render-other.js

@@ -335,6 +335,7 @@ async function openScanProjectsModal() {
         '<button onclick="_runProjectScan()" style="padding:6px 16px;background:var(--blue);color:#fff;border:none;border-radius:var(--radius-sm);cursor:pointer;white-space:nowrap">Scan</button>' +
       '</div>' +
       '<div id="scan-results" style="color:var(--muted);font-size:12px">Click Scan to find git repos in the directory.</div>' +
+      '<div class="cmd-toast" id="scan-toast" style="margin-top:0"></div>' +
     '</div>';
   document.getElementById('modal-body').style.whiteSpace = 'normal';
   document.getElementById('modal-body').style.fontFamily = "'Segoe UI', system-ui, sans-serif";
@@ -410,19 +411,20 @@ async function _addSelectedProjects() {
       var data = await res.json().catch(function() { return {}; });
       if (res.ok) {
         added++;
+        var addedName = data.name || repo.name;
         optimisticallyAddProject({
-          name: data.name || repo.name,
+          name: addedName,
           description: (data.detected && data.detected.description) || repo.description || '',
           path: data.path || repo.path,
           localPath: data.path || repo.path,
         });
         cb.disabled = true;
         cb.closest('label').style.opacity = '0.5';
+        showToast('scan-toast', added + ' project(s) added', true);
       }
     } catch { /* continue with next */ }
   }
   if (added > 0) {
-    showToast('cmd-toast', added + ' project(s) added', true);
     refresh();
   }
 }

package/dashboard/js/render-skills.js

@@ -69,12 +69,14 @@ function renderSkills(skills) {
   }
   html += '</div>';
 
-  // Note clarifying skill visibility — agents read these on demand, runtime
-  // assets (~/.claude/skills, ~/.copilot/skills) are not auto-injected for
-  // the OTHER runtime. A Copilot agent only sees Copilot-native + plugin skills.
+  // Note clarifying skill visibility — agents read these on demand. Runtime-
+  // native locations (~/.claude/skills, ~/.copilot/skills, plugin skills) are
+  // only visible to that runtime. The "agent" tab (~/.agents/skills) is the
+  // cross-runtime portable bucket and IS visible to every runtime.
   html += '<div style="font-size:9px;color:var(--muted);margin-bottom:8px;line-height:1.4">' +
     'Skills are reference docs agents read on demand — they are not injected wholesale into prompts. ' +
-    'Each tab reflects what the matching runtime would see; cross-runtime skills are NOT visible to a different runtime.' +
+    'Each tab reflects what the matching runtime would see; runtime-native skills are NOT cross-visible. ' +
+    'The agent tab (~/.agents/skills) is the cross-runtime portable bucket — visible to every runtime.' +
     '</div>';
 
   // Filter by tab

package/dashboard.js

@@ -4502,39 +4502,8 @@ What would you like to discuss or change? When you're happy, say "approve" and I
     const source = params.get('source') || '';
     if (!_isValidSkillFileName(file)) { res.statusCode = 400; res.end('Invalid file'); return; }
 
-    let content = '';
     const skillPath = _resolveSkillReadPath({ file, dir, source, config: CONFIG });
-    if (skillPath) content = safeRead(skillPath) || '';
-    // Fallback when caller didn't supply `dir`: try the source's known native
-    // locations. `_resolveSkillReadPath` only matches entries returned by
-    // `collectSkillFiles`, so a skill that already has `dir` will resolve there.
-    if (!content && !dir) {
-      const home = os.homedir();
-      const skillStem = file.replace(/\.md$/, '').replace(/^SKILL$/, '');
-      const candidates = [];
-      if (source === 'claude-code' || !source) {
-        candidates.push(path.join(home, '.claude', 'skills', skillStem, 'SKILL.md'));
-      }
-      if (source === 'copilot') {
-        candidates.push(path.join(home, '.copilot', 'skills', skillStem, 'SKILL.md'));
-      }
-      if (source === 'agent-skill') {
-        candidates.push(path.join(home, '.agents', 'skills', skillStem, 'SKILL.md'));
-      }
-      if (source.startsWith('project:')) {
-        const proj = PROJECTS.find(p => p.name === source.slice('project:'.length));
-        if (proj?.localPath) {
-          for (const sub of ['.claude', '.github', '.agents']) {
-            candidates.push(path.join(proj.localPath, sub, 'skills', file));
-            candidates.push(path.join(proj.localPath, sub, 'skills', skillStem, 'SKILL.md'));
-          }
-        }
-      }
-      for (const c of candidates) {
-        content = safeRead(c) || '';
-        if (content) break;
-      }
-    }
+    const content = skillPath ? (safeRead(skillPath) || '') : '';
     res.setHeader('Content-Type', 'text/plain; charset=utf-8');
     res.setHeader('Access-Control-Allow-Origin', '*');
     res.end(content || 'Skill not found.');

package/engine/cleanup.js

@@ -621,17 +621,20 @@ function runCleanup(config, verbose = false) {
     catch { orphanPrdEntries = []; }
     for (const pf of orphanPrdEntries) {
       const prdPath = path.join(PRD_DIR, pf);
-      const prd = safeJson(prdPath);
-      if (!prd?.missing_features) continue;
+      const peek = safeJson(prdPath);
+      if (!peek?.missing_features) continue;
       let reset = 0;
-      for (const feat of prd.missing_features) {
-        if ((feat.status === shared.WI_STATUS.DISPATCHED || feat.status === shared.WI_STATUS.FAILED) && !wiIds.has(feat.id)) {
-          feat.status = shared.WI_STATUS.PENDING;
-          reset++;
+      mutateJsonFileLocked(prdPath, (prd) => {
+        if (!prd?.missing_features) return prd;
+        for (const feat of prd.missing_features) {
+          if ((feat.status === shared.WI_STATUS.DISPATCHED || feat.status === shared.WI_STATUS.FAILED) && !wiIds.has(feat.id)) {
+            feat.status = shared.WI_STATUS.PENDING;
+            reset++;
+          }
         }
-      }
+        return prd;
+      }, { skipWriteIfUnchanged: true });
       if (reset > 0) {
-        safeWrite(prdPath, prd);
         log('info', `Reset ${reset} orphaned PRD item status(es) → pending in ${pf}`);
         cleaned.orphanedPrdStatuses += reset;
       }

package/engine/cli.js

@@ -146,21 +146,18 @@ function _parseRuntimeFlags(args) {
  * Heuristic flag for "this model is obviously wrong for this runtime". Used
  * to surface the "pass --model '' to clear" hint when a user switches CLIs
  * but leaves a stale model behind. Errs on the side of false-negatives —
- * unknown runtime → no opinion, unknown model on Copilot → no opinion.
+ * unknown runtime → no opinion, runtime adapter without `modelLooksFamiliar`
+ * → no opinion. Runtime-specific knowledge lives in the adapter (see
+ * claude.js#modelLooksFamiliar) so adding a new runtime never requires
+ * editing cli.js.
  */
 function _modelLooksIncompatible(runtime, model) {
   if (!model) return false;
-  const m = String(model).toLowerCase();
-  if (runtime === 'claude') {
-    if (m.startsWith('claude-')) return false;
-    if (m === 'sonnet' || m === 'opus' || m === 'haiku') return false;
-    return true; // gpt-*, o3-*, codex, etc. — wrong CLI for these
-  }
-  if (runtime === 'copilot') {
-    // Copilot adapter maps Minions' family aliases before spawning.
-    return false;
-  }
-  return false;
+  let adapter;
+  try { adapter = require('./runtimes').resolveRuntime(runtime); }
+  catch { return false; } // unknown runtime → no opinion
+  if (typeof adapter.modelLooksFamiliar !== 'function') return false; // adapter doesn't claim a model namespace → no opinion
+  return !adapter.modelLooksFamiliar(model);
 }
 
 /**

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-02T18:15:36.411Z"
+  "cachedAt": "2026-05-02T19:44:35.476Z"
 }

package/engine/lifecycle.js

@@ -1037,7 +1037,8 @@ async function findOpenPrForBranch(meta, config) {
   if (host === 'github') {
     const ghSlug = projectObj.prUrlBase?.match(/github\.com\/([^/]+\/[^/]+)\/pull/)?.[1];
     if (!ghSlug) return null;
-    for (let attempt = 0; attempt < 3; attempt++) {
+    const maxAttempts = ENGINE_DEFAULTS.prAutoLinkRetries;
+    for (let attempt = 0; attempt < maxAttempts; attempt++) {
       if (attempt > 0) await new Promise(r => setTimeout(r, 3000));
       let raw = '';
       try {
@@ -1047,13 +1048,13 @@ async function findOpenPrForBranch(meta, config) {
         if (hits.length > 0 && hits[0].state === 'OPEN') {
           return { project: projectObj, prNumber: hits[0].number, url: hits[0].url };
         }
-        if (attempt === 2) {
-          log('warn', `Auto-link fallback: no open PR found on branch ${meta.branch} after 3 attempts (raw: ${(raw || '').slice(0, 200)})`);
+        if (attempt === maxAttempts - 1) {
+          log('warn', `Auto-link fallback: no open PR found on branch ${meta.branch} after ${maxAttempts} attempts (raw: ${(raw || '').slice(0, 200)})`);
         }
       } catch (err) {
-        if (attempt === 2) {
+        if (attempt === maxAttempts - 1) {
           const rawSuffix = raw ? ` (raw: ${raw.slice(0, 200)})` : '';
-          log('warn', `Auto-link fallback: gh pr list lookup failed on branch ${meta.branch} after 3 attempts: ${err.message}${rawSuffix}`);
+          log('warn', `Auto-link fallback: gh pr list lookup failed on branch ${meta.branch} after ${maxAttempts} attempts: ${err.message}${rawSuffix}`);
         }
       }
     }
@@ -1475,7 +1476,7 @@ async function processPendingRebases(config) {
     const result = await rebaseBranchOntoMain(pr, project, config);
     if (!result.success) {
       entry.attempts = (entry.attempts || 0) + 1;
-      if (entry.attempts < 3) {
+      if (entry.attempts < ENGINE_DEFAULTS.rebaseQueueRetries) {
         remaining.push(entry);
       } else {
         log('warn', `Rebase failed after retries for ${pr.id} on ${pr.branch}: ${result.error}`);

package/engine/pipeline.js

@@ -730,14 +730,17 @@ function isStageComplete(stage, stageState, run, config) {
       if (stage.autoApprove && artifacts.prds?.length > 0) {
         for (const prdFile of artifacts.prds) {
           const prdPath = path.join(prdDir, prdFile);
-          const prd = safeJson(prdPath);
-          if (prd && prd.status === PLAN_STATUS.AWAITING_APPROVAL) {
-            prd.status = PLAN_STATUS.APPROVED;
-            prd.approvedAt = ts();
-            prd.approvedBy = 'pipeline:' + run.pipelineId;
-            safeWrite(prdPath, prd);
-            log('info', `Pipeline ${run.pipelineId}: auto-approved PRD ${prdFile}`);
-          }
+          let approved = false;
+          mutateJsonFileLocked(prdPath, (prd) => {
+            if (prd && prd.status === PLAN_STATUS.AWAITING_APPROVAL) {
+              prd.status = PLAN_STATUS.APPROVED;
+              prd.approvedAt = ts();
+              prd.approvedBy = 'pipeline:' + run.pipelineId;
+              approved = true;
+            }
+            return prd;
+          }, { skipWriteIfUnchanged: true });
+          if (approved) log('info', `Pipeline ${run.pipelineId}: auto-approved PRD ${prdFile}`);
         }
       }
 

package/engine/runtimes/claude.js

@@ -640,20 +640,28 @@ const capabilities = {
 // (fatal error message). Multi-line so all platforms see actionable guidance.
 const INSTALL_HINT = 'install from https://claude.ai/download or: npm install -g @anthropic-ai/claude-code';
 
+// Asset roots passed to spawn as `--add-dir` so worktrees can read globally
+// installed skills. `~/.agents/skills` is the cross-runtime portable location;
+// every runtime adapter exposes it so a skill placed there is genuinely visible
+// to every runtime (matches the directory name's promise).
 function getUserAssetDirs({ homeDir = os.homedir() } = {}) {
-  return [path.join(homeDir, '.claude')];
+  return [
+    path.join(homeDir, '.claude'),
+    path.join(homeDir, '.agents'),
+  ];
 }
 
 function getSkillRoots({ homeDir = os.homedir(), project = null } = {}) {
   const roots = [
     { dir: path.join(homeDir, '.claude', 'skills'), scope: 'claude-code' },
+    { dir: path.join(homeDir, '.agents', 'skills'), scope: 'agent-skill' },
   ];
   if (project?.localPath) {
-    roots.push({
-      dir: path.join(project.localPath, '.claude', 'skills'),
-      scope: 'project',
-      projectName: project.name || path.basename(project.localPath),
-    });
+    const projectName = project.name || path.basename(project.localPath);
+    roots.push(
+      { dir: path.join(project.localPath, '.claude', 'skills'), scope: 'project', projectName },
+      { dir: path.join(project.localPath, '.agents', 'skills'), scope: 'project', projectName },
+    );
   }
   return roots;
 }
@@ -666,6 +674,19 @@ function getSkillWriteTargets({ homeDir = os.homedir(), project = null } = {}) {
   return targets;
 }
 
+// Heuristic: does `model` look like a Claude model identifier? Powers the
+// preflight "stale model after CLI switch" warning in cli.js. Returning false
+// means "this looks wrong for Claude" — gpt-5.4 / o3-* / codex etc. Keep this
+// here (not in cli.js) so the runtime owns its own model namespace and adding
+// a future runtime never requires editing cli.js.
+function modelLooksFamiliar(model) {
+  if (!model) return true;
+  const m = String(model).toLowerCase();
+  if (m.startsWith('claude-')) return true;
+  if (m === 'sonnet' || m === 'opus' || m === 'haiku') return true;
+  return false;
+}
+
 module.exports = {
   name: 'claude',
   capabilities,
@@ -688,6 +709,7 @@ module.exports = {
   usesSystemPromptFile,
   classifyFailure,
   resolveModel,
+  modelLooksFamiliar,
   parseOutput,
   parseStreamChunk,
   parseError,

package/engine/runtimes/copilot.js

@@ -798,6 +798,11 @@ function getUserAssetDirs({ homeDir = os.homedir() } = {}) {
   ];
 }
 
+// Copilot CLI reads project skills from .github/skills, .claude/skills, AND
+// .agents/skills per the official docs (see "Adding agent skills for GitHub
+// Copilot CLI"). Listing all three keeps the dashboard accurate and ensures
+// spawned Copilot agents receive `--add-dir` for every dir Copilot would
+// natively read from.
 function getSkillRoots({ homeDir = os.homedir(), project = null } = {}) {
   const roots = [
     { dir: path.join(homeDir, '.copilot', 'skills'), scope: 'copilot' },
@@ -807,6 +812,7 @@ function getSkillRoots({ homeDir = os.homedir(), project = null } = {}) {
     const projectName = project.name || path.basename(project.localPath);
     roots.push(
       { dir: path.join(project.localPath, '.github', 'skills'), scope: 'project', projectName },
+      { dir: path.join(project.localPath, '.claude', 'skills'), scope: 'project', projectName },
       { dir: path.join(project.localPath, '.agents', 'skills'), scope: 'project', projectName },
     );
   }

package/engine/shared.js

@@ -793,6 +793,8 @@ const ENGINE_DEFAULTS = {
   minRetryGapMs: 120000, // 2min — minimum gap between retry dispatches for the same work item; prevents tight retry loops when an idempotent agent (e.g. review bailing out on a duplicate) cannot produce the expected output (#1770)
   pipelineApiRetries: 2, // max attempts for pipeline API calls
   pipelineApiRetryDelay: 2000, // ms delay between pipeline API retries
+  prAutoLinkRetries: 3, // max attempts for gh pr list lookup when auto-linking PR after merge (3s backoff between attempts)
+  rebaseQueueRetries: 3, // max rebase attempts per queued PR before giving up
   versionCheckInterval: 3600000, // 1 hour — how often to check npm for updates (ms)
   logFlushInterval: 5000, // 5s — how often to flush buffered log entries to disk
   logBufferSize: 50, // flush immediately when buffer exceeds this many entries
@@ -1096,15 +1098,19 @@ function runtimeConfigWarnings(config, registeredRuntimes) {
     }
   }
 
-  // 3. Bare-mode misconfig: claudeBareMode + Claude as CC runtime + no explicit
-  // CC system prompt. `--bare` suppresses CLAUDE.md auto-discovery; CC will
-  // lose project context unless the user wires an explicit prompt.
+  // 3. Bare-mode misconfig: claudeBareMode + a CC runtime that honours
+  // `--bare` + no explicit CC system prompt. `--bare` suppresses CLAUDE.md
+  // auto-discovery; CC will lose project context unless the user wires an
+  // explicit prompt. Gated on `capabilities.bareMode` rather than runtime
+  // name so any future runtime that adopts the same flag is covered.
   if (engine.claudeBareMode === true) {
     const ccCli = resolveCcCli(engine);
-    if (ccCli === 'claude' && !_isMeaningful(engine.ccSystemPrompt)) {
+    let ccRuntime = null;
+    try { ccRuntime = require('./runtimes').resolveRuntime(ccCli); } catch { /* unknown runtime — skip */ }
+    if (ccRuntime?.capabilities?.bareMode === true && !_isMeaningful(engine.ccSystemPrompt)) {
       warnings.push({
         id: 'bare-mode-misconfig',
-        message: 'engine.claudeBareMode is true but CC runs on Claude with no engine.ccSystemPrompt — CLAUDE.md auto-discovery is suppressed and CC will lose project context.',
+        message: `engine.claudeBareMode is true but CC runs on ${ccCli} (which honours --bare) with no engine.ccSystemPrompt — CLAUDE.md auto-discovery is suppressed and CC will lose project context.`,
       });
     }
   }

package/engine/spawn-agent.js

@@ -201,6 +201,36 @@ async function writeProcessExitSentinel({
   return { sentinel, stdoutFlushed, outputPathWritten };
 }
 
+/**
+ * Build the `--add-dir` list passed to the runtime CLI. Pure: takes
+ * `{ runtime, minionsDir, homeDir, exists }` and returns an ordered, deduped
+ * array of dirs the agent should be able to read from outside its worktree.
+ *
+ * Order: minionsDir first (so playbooks/system-prompt are always reachable),
+ * followed by every existing dir from `runtime.getUserAssetDirs({ homeDir })`.
+ * Non-existent asset dirs are dropped — Claude CLI rejects unknown `--add-dir`
+ * entries. The dedup compares resolved paths so we never emit minionsDir twice
+ * (e.g. when runtime asset dir IS the minions repo in unusual setups).
+ *
+ * `exists` is injectable for tests; defaults to `fs.existsSync`.
+ */
+function computeAddDirs({ runtime, minionsDir, homeDir, exists = fs.existsSync } = {}) {
+  const out = [minionsDir];
+  const seen = new Set([path.resolve(minionsDir)]);
+  const assetDirs = typeof runtime?.getUserAssetDirs === 'function'
+    ? runtime.getUserAssetDirs({ homeDir })
+    : [];
+  for (const d of assetDirs) {
+    if (!d) continue;
+    const resolved = path.resolve(d);
+    if (seen.has(resolved)) continue;
+    if (!exists(d)) continue;
+    out.push(d);
+    seen.add(resolved);
+  }
+  return out;
+}
+
 // ─── Main script execution ──────────────────────────────────────────────────
 
 function _installHint(name, runtime) {
@@ -252,15 +282,7 @@ function main() {
   // worktree, so runtime-native global assets would otherwise be invisible.
   // The adapter owns both where those assets live and how to surface them.
   const minionsDir = path.resolve(__dirname, '..');
-  const addDirs = [minionsDir];
-  const runtimeAssetDirs = typeof runtime.getUserAssetDirs === 'function'
-    ? runtime.getUserAssetDirs({ homeDir: os.homedir() })
-    : [];
-  for (const dir of runtimeAssetDirs) {
-    if (dir && fs.existsSync(dir) && path.resolve(dir) !== path.resolve(minionsDir)) {
-      addDirs.push(dir);
-    }
-  }
+  const addDirs = computeAddDirs({ runtime, minionsDir, homeDir: os.homedir() });
 
   let resolved;
   try { resolved = runtime.resolveBinary({ env }); }
@@ -378,6 +400,6 @@ function main() {
   });
 }
 
-module.exports = { parseSpawnArgs, buildSpawnInvocation, normalizeRuntimeExit, injectAdoTokenEnv, writeProcessExitSentinel };
+module.exports = { parseSpawnArgs, buildSpawnInvocation, normalizeRuntimeExit, injectAdoTokenEnv, writeProcessExitSentinel, computeAddDirs };
 
 if (require.main === module) main();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1686",
+  "version": "0.1.1688",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"