@yemi33/minions 0.1.1682 → 0.1.1684

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.1.1684 (2026-05-02)
+
+### Other
+- test(cooldown): add edge-case unit tests for _truncateContextEntry, loadCooldowns boundaries, isAlreadyDispatched (#1986)
+
+## 0.1.1683 (2026-05-02)
+
+### Fixes
+- rename Claude tab, merge plugins by runtime, fix detection and escaping
+
 ## 0.1.1682 (2026-05-02)
 
 ### Features

package/dashboard/js/render-skills.js

@@ -4,6 +4,33 @@ let _skillsTab = 'all';
 let _skillsPage = 0;
 const SKILLS_PER_PAGE = 5;
 
+// Per-runtime tabs that fold native and plugin skills into one bucket — agents
+// see "skills my Claude/Copilot install can use" rather than discovery-source
+// trivia. Project tabs are added dynamically per configured project.
+const SOURCE_META = {
+  'claude-code':    { icon: '⚡', label: 'claude',         group: 'claude'  },
+  'plugin':         { icon: '🔌', label: 'claude plugin',  group: 'claude'  },
+  'copilot':        { icon: '🤖', label: 'copilot',        group: 'copilot' },
+  'copilot-plugin': { icon: '🔌', label: 'copilot plugin', group: 'copilot' },
+  'agent-skill':    { icon: '🤝', label: 'agent',          group: 'agent'   },
+};
+
+function _skillMetaOf(s) {
+  if (SOURCE_META[s]) return SOURCE_META[s];
+  if (s && s.startsWith('project:')) {
+    const name = s.slice('project:'.length);
+    return { icon: '📁', label: name, group: name };
+  }
+  return { icon: '🔧', label: 'unknown', group: 'unknown' };
+}
+
+// Inline onclick handlers run in HTML-attr-then-JS context. escHtml alone is
+// unsafe (apostrophes survive into the JS string). JSON.stringify produces a
+// valid JS literal; HTML-escaping that literal is safe in either context.
+function _jsArg(value) {
+  return escHtml(JSON.stringify(value == null ? '' : String(value)));
+}
+
 function renderSkills(skills) {
   const el = document.getElementById('skills-list');
   const countEl = document.getElementById('skills-count');
@@ -13,32 +40,21 @@ function renderSkills(skills) {
     return;
   }
 
-  const SOURCE_META = {
-    'claude-code':    { icon: '⚡', label: 'global',  group: 'global'  },
-    'copilot':        { icon: '🤖', label: 'copilot', group: 'copilot' },
-    'agent-skill':    { icon: '🤝', label: 'agent',   group: 'agent'   },
-    'plugin':         { icon: '🔌', label: 'plugin',  group: 'plugins' },
-    'copilot-plugin': { icon: '🤖', label: 'copilot', group: 'copilot' },
-  };
-  const metaOf = (s) => {
-    if (SOURCE_META[s]) return SOURCE_META[s];
-    if (s && s.startsWith('project:')) {
-      const name = s.slice('project:'.length);
-      return { icon: '📁', label: name, group: name };
-    }
-    return { icon: '🔧', label: 'global', group: 'global' };
-  };
-  const sourceIcon = (s) => metaOf(s).icon;
-  const sourceLabel = (s) => metaOf(s).label;
-
   // Group by source
   const groups = {};
   for (const r of skills) {
-    const key = metaOf(r.source).group;
+    const key = _skillMetaOf(r.source).group;
     if (!groups[key]) groups[key] = [];
     groups[key].push(r);
   }
-  const groupKeys = Object.keys(groups).sort((a, b) => a === 'global' ? -1 : b === 'global' ? 1 : a.localeCompare(b));
+  const groupKeys = Object.keys(groups).sort((a, b) => {
+    const order = ['claude', 'copilot', 'agent'];
+    const ai = order.indexOf(a), bi = order.indexOf(b);
+    if (ai >= 0 && bi >= 0) return ai - bi;
+    if (ai >= 0) return -1;
+    if (bi >= 0) return 1;
+    return a.localeCompare(b);
+  });
 
   // Tab bar
   const tabs = [{ key: 'all', label: 'All (' + skills.length + ')' }];
@@ -49,10 +65,18 @@ function renderSkills(skills) {
     const active = _skillsTab === t.key;
     html += '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px;' +
       (active ? 'background:var(--green);color:#fff;border-color:var(--green)' : '') +
-      '" onclick="_skillsTab=\'' + escHtml(t.key) + '\';_skillsPage=0;renderSkills(window._lastSkills)">' + escHtml(t.label) + '</button>';
+      '" onclick="_skillsSelectTab(' + _jsArg(t.key) + ')">' + escHtml(t.label) + '</button>';
   }
   html += '</div>';
 
+  // Note clarifying skill visibility — agents read these on demand, runtime
+  // assets (~/.claude/skills, ~/.copilot/skills) are not auto-injected for
+  // the OTHER runtime. A Copilot agent only sees Copilot-native + plugin skills.
+  html += '<div style="font-size:9px;color:var(--muted);margin-bottom:8px;line-height:1.4">' +
+    'Skills are reference docs agents read on demand — they are not injected wholesale into prompts. ' +
+    'Each tab reflects what the matching runtime would see; cross-runtime skills are NOT visible to a different runtime.' +
+    '</div>';
+
   // Filter by tab
   const filtered = _skillsTab === 'all' ? skills : (groups[_skillsTab] || []);
 
@@ -63,10 +87,11 @@ function renderSkills(skills) {
 
   html += '<div style="display:flex;flex-direction:column;gap:6px">';
   for (const r of page) {
+    const meta = _skillMetaOf(r.source);
     const autoTag = r.autoGenerated ? '<span style="font-size:8px;background:rgba(63,185,80,0.15);color:var(--green);padding:1px 4px;border-radius:3px;margin-left:4px">auto</span>' : '';
-    html += '<div class="inbox-item" onclick="openSkill(\'' + escHtml(r.file) + '\',\'' + escHtml(r.source || 'claude-code') + '\',\'' + escHtml(r.dir || '') + '\')" style="border-left-color:var(--green)">' +
-      '<div class="inbox-name"><span style="color:var(--green);font-weight:600">' + sourceIcon(r.source) + ' ' + escHtml(r.name) + '</span>' + autoTag +
-        '<span style="font-size:9px;color:var(--muted);margin-left:auto">' + escHtml(sourceLabel(r.source)) + '</span>' +
+    html += '<div class="inbox-item" onclick="openSkill(' + _jsArg(r.file) + ',' + _jsArg(r.source || 'claude-code') + ',' + _jsArg(r.dir || '') + ')" style="border-left-color:var(--green)">' +
+      '<div class="inbox-name"><span style="color:var(--green);font-weight:600">' + meta.icon + ' ' + escHtml(r.name) + '</span>' + autoTag +
+        '<span style="font-size:9px;color:var(--muted);margin-left:auto">' + escHtml(meta.label) + '</span>' +
       '</div>' +
       (r.description ? '<div class="inbox-preview" style="color:var(--text)">' + escHtml(r.description) + '</div>' : '') +
     '</div>';
@@ -90,6 +115,12 @@ function renderSkills(skills) {
   window._lastSkills = skills;
 }
 
+function _skillsSelectTab(key) {
+  _skillsTab = key;
+  _skillsPage = 0;
+  renderSkills(window._lastSkills);
+}
+
 function openSkill(file, source, dir) {
   document.getElementById('modal-title').textContent = file;
   document.getElementById('modal-body').innerHTML = '<p style="color:var(--muted)">Loading...</p>';

package/dashboard/js/render-work-items.js

@@ -498,7 +498,6 @@ function openWorkItemDetail(id) {
       }
     });
   }
-  if (arts.skills && arts.skills.length > 0) arts.skills.forEach(function(s) { artPills += '<span onclick="openSkill(\'' + escapeHtml(s) + '\',\'minions\',\'\')" style="' + pillStyle + '">⚙ ' + escapeHtml(s) + '</span> '; });
   if (artPills) html += field('Artifacts', '<div style="display:flex;flex-wrap:wrap;gap:4px">' + artPills + '</div>');
 
   if (item._totalCostUsd != null) html += field('Cumulative Cost', '$' + Number(item._totalCostUsd).toFixed(4));

package/dashboard/pages/tools.html

@@ -1,5 +1,5 @@
       <section>
-        <h2>Minions Skills <span class="count" id="skills-count">0</span> <span style="font-size:10px;color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">auto-discovered from project repos</span></h2>
+        <h2>Minions Skills <span class="count" id="skills-count">0</span> <span style="font-size:10px;color:var(--muted);font-weight:400;text-transform:none;letter-spacing:0">discovered from runtime native dirs, plugin installs, and configured project repos</span></h2>
         <div id="skills-list"><p class="empty">No skills yet. Agents create these when they discover repeatable workflows.</p></div>
       </section>
       <section>

package/engine/cooldown.js

@@ -201,4 +201,5 @@ module.exports = {
   clearCooldown,
   isAlreadyDispatched,
   isBranchActive,
+  _truncateContextEntry, // exported for testing
 };

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-02T15:15:12.425Z"
+  "cachedAt": "2026-05-02T16:47:10.817Z"
 }

package/engine/lifecycle.js

@@ -1703,10 +1703,14 @@ function extractSkillsFromOutput(output, agentId, dispatchItem, config, runtimeN
       const skillDir = path.join(personalSkillRoot, name.replace(/[^a-z0-9-]/g, '-'));
       const skillPath = path.join(skillDir, 'SKILL.md');
       if (!fs.existsSync(skillPath)) {
-        // Native skill format: only name + description in frontmatter.
+        // Native skill format: only name + description in frontmatter. The
+        // `Auto-extracted` marker is an HTML comment so the dashboard's
+        // autoGenerated detection picks it up without polluting the body
+        // an agent reads.
         const description = m('description') || m('trigger') || `Auto-extracted skill from ${agentName}`;
         const body = fmMatch[2] || '';
-        const ccContent = `---\nname: ${name}\ndescription: ${description}\n---\n\n${body.trim()}\n`;
+        const marker = `<!-- Auto-extracted by ${agentName} on ${dateStamp()} -->`;
+        const ccContent = `---\nname: ${name}\ndescription: ${description}\n---\n\n${marker}\n\n${body.trim()}\n`;
         if (!fs.existsSync(skillDir)) fs.mkdirSync(skillDir, { recursive: true });
         shared.safeWrite(skillPath, ccContent);
         try { require('./queries').invalidateSkillsCache(); } catch {}

package/engine/playbook.js

@@ -395,7 +395,7 @@ function renderPlaybook(type, vars) {
   content += '````\n```skill\n';
   content += `---\nname: short-descriptive-name\ndescription: One-line description of what this skill does\nallowed-tools: Bash, Read, Edit\ntrigger: when should an agent use this\nscope: minions\nproject: any\n---\n\n# Skill Title\n\n## Steps\n1. ...\n2. ...\n\n## Notes\n...\n`;
   content += '```\n````\n\n';
-  content += `- Set \`scope: minions\` for cross-project or Minions-wide skills; the engine writes them to the selected runtime's native personal skills directory\n`;
+  content += `- Set \`scope: minions\` for cross-project or Minions-wide skills; the engine writes them to the selected runtime's native personal skills directory so they are available in normal runtime windows too\n`;
   content += `- Set \`scope: project\` + \`project: <name>\` only for repo-specific skills; the engine queues a PR to the selected runtime's native project skills directory\n`;
   content += `- Emit at most one skill block per task unless you uncovered two clearly distinct reusable workflows\n`;
   content += `- Do NOT create a skill for one-off bug fixes, isolated command output, obvious repo facts, or anything already covered by existing docs/playbooks/skills\n`;
@@ -546,7 +546,8 @@ function buildAgentContext(agentId, config, project) {
     context += `## Your Recent History (last 5 tasks)\n\n${trimmed}\n\n`;
   }
 
-  // Project conventions (from CLAUDE.md) — always relevant for code quality
+  // Project conventions and instruction files — explicit, inert context for
+  // every runtime. Runtime-native skills/commands stay in their native indexes.
   if (project.localPath) {
     appendContextFile('Project Conventions (from CLAUDE.md)', path.join(project.localPath, 'CLAUDE.md'), 8192);
     appendContextFile('Project Agent Instructions (from AGENTS.md)', path.join(project.localPath, 'AGENTS.md'), 8192,

package/engine/runtimes/claude.js

@@ -16,6 +16,9 @@
  *   - spawnScript: absolute path of the spawn wrapper (or null if direct-only)
  *   - buildArgs(opts) → string[] — CLI args excluding the binary
  *   - buildPrompt(promptText, sysPromptText) → string — final prompt delivered
+ *   - getUserAssetDirs(opts) → string[] — runtime-native global asset roots
+ *   - getSkillRoots(opts) → {scope,dir,projectName?}[] — skill discovery roots
+ *   - getSkillWriteTargets(opts) → {personal,project} — extraction targets
  *   - resolveModel(input) → string|undefined — shorthand expansion / passthrough
  *   - parseOutput(raw) → { text, usage, sessionId, model }
  *   - parseStreamChunk(line) → parsed event object or null
@@ -247,6 +250,31 @@ function buildSpawnFlags(opts = {}) {
   return flags;
 }
 
+function getUserAssetDirs({ homeDir = os.homedir() } = {}) {
+  return [path.join(homeDir, '.claude')];
+}
+
+function getSkillRoots({ homeDir = os.homedir(), project = null } = {}) {
+  const roots = [
+    { scope: 'claude-code', dir: path.join(homeDir, '.claude', 'skills') },
+  ];
+  if (project?.localPath) {
+    roots.push({
+      scope: 'project',
+      projectName: project.name,
+      dir: path.join(project.localPath, '.claude', 'skills'),
+    });
+  }
+  return roots;
+}
+
+function getSkillWriteTargets({ homeDir = os.homedir(), project = null } = {}) {
+  return {
+    personal: path.join(homeDir, '.claude', 'skills'),
+    project: project?.localPath ? path.join(project.localPath, '.claude', 'skills') : null,
+  };
+}
+
 function getResumeSessionId({ agentId, branchName, agentsDir, maxAgeMs = 2 * 60 * 60 * 1000, logger = console } = {}) {
   if (!agentId || agentId.startsWith('temp-') || !agentsDir) return null;
   try {
@@ -322,29 +350,6 @@ function buildPrompt(promptText, /* sysPromptText */ _sys) {
   return String(promptText == null ? '' : promptText);
 }
 
-function getUserAssetDirs({ homeDir = os.homedir() } = {}) {
-  return [path.join(homeDir, '.claude')];
-}
-
-function getSkillRoots({ homeDir = os.homedir(), project = null } = {}) {
-  const roots = [{ dir: path.join(homeDir, '.claude', 'skills'), scope: 'claude-code' }];
-  if (project?.localPath) {
-    roots.push({
-      dir: path.resolve(project.localPath, '.claude', 'skills'),
-      scope: 'project',
-      projectName: project.name,
-    });
-  }
-  return roots;
-}
-
-function getSkillWriteTargets({ homeDir = os.homedir(), project = null } = {}) {
-  return {
-    personal: path.join(homeDir, '.claude', 'skills'),
-    project: project?.localPath ? path.resolve(project.localPath, '.claude', 'skills') : null,
-  };
-}
-
 // ── Output Parsing ───────────────────────────────────────────────────────────
 
 /**

package/engine/runtimes/copilot.js

@@ -270,6 +270,42 @@ function buildSpawnFlags(opts = {}) {
   return flags;
 }
 
+function getUserAssetDirs({ homeDir = os.homedir() } = {}) {
+  return [
+    path.join(homeDir, '.copilot'),
+    path.join(homeDir, '.agents'),
+  ];
+}
+
+function getSkillRoots({ homeDir = os.homedir(), project = null } = {}) {
+  const roots = [
+    { scope: 'copilot', dir: path.join(homeDir, '.copilot', 'skills') },
+    { scope: 'agent-skill', dir: path.join(homeDir, '.agents', 'skills') },
+  ];
+  if (project?.localPath) {
+    roots.push(
+      {
+        scope: 'project',
+        projectName: project.name,
+        dir: path.join(project.localPath, '.github', 'skills'),
+      },
+      {
+        scope: 'project',
+        projectName: project.name,
+        dir: path.join(project.localPath, '.agents', 'skills'),
+      },
+    );
+  }
+  return roots;
+}
+
+function getSkillWriteTargets({ homeDir = os.homedir(), project = null } = {}) {
+  return {
+    personal: path.join(homeDir, '.copilot', 'skills'),
+    project: project?.localPath ? path.join(project.localPath, '.github', 'skills') : null,
+  };
+}
+
 function getResumeSessionId({ agentId, branchName, agentsDir, maxAgeMs = 2 * 60 * 60 * 1000, logger = console } = {}) {
   if (!agentId || agentId.startsWith('temp-') || !agentsDir) return null;
   try {
@@ -349,41 +385,6 @@ function buildPrompt(promptText, sysPromptText, opts = {}) {
   return `<system>\n${String(sysPromptText)}\n</system>\n\n${user}`;
 }
 
-function getUserAssetDirs({ homeDir = os.homedir() } = {}) {
-  return [
-    path.join(homeDir, '.copilot'),
-    path.join(homeDir, '.agents'),
-  ];
-}
-
-function getSkillRoots({ homeDir = os.homedir(), project = null } = {}) {
-  const roots = [
-    { dir: path.join(homeDir, '.copilot', 'skills'), scope: 'copilot' },
-    { dir: path.join(homeDir, '.agents', 'skills'), scope: 'agent-skill' },
-  ];
-  if (project?.localPath) {
-    for (const rel of [
-      ['.github', 'skills'],
-      ['.claude', 'skills'],
-      ['.agents', 'skills'],
-    ]) {
-      roots.push({
-        dir: path.resolve(project.localPath, ...rel),
-        scope: 'project',
-        projectName: project.name,
-      });
-    }
-  }
-  return roots;
-}
-
-function getSkillWriteTargets({ homeDir = os.homedir(), project = null } = {}) {
-  return {
-    personal: path.join(homeDir, '.copilot', 'skills'),
-    project: project?.localPath ? path.resolve(project.localPath, '.github', 'skills') : null,
-  };
-}
-
 // ── Output Parsing ──────────────────────────────────────────────────────────
 //
 // Whitelist of event types observed during the spike (docs/copilot-cli-schema.md

package/engine/spawn-agent.js

@@ -174,17 +174,17 @@ function main() {
     opts.sysPromptFile = sysTmpPath;
   }
 
-  // User asset discovery dirs — agents run with CWD set to an external repo
-  // worktree, so the adapter supplies any runtime-native global asset roots
-  // that should be visible from that cwd.
+  // Skill discovery dirs — agents run with CWD set to an external repo
+  // worktree, so runtime-native global assets would otherwise be invisible.
+  // The adapter owns both where those assets live and how to surface them.
   const minionsDir = path.resolve(__dirname, '..');
+  const addDirs = [minionsDir];
   const runtimeAssetDirs = typeof runtime.getUserAssetDirs === 'function'
     ? runtime.getUserAssetDirs({ homeDir: os.homedir() })
     : [];
-  const addDirs = [minionsDir];
-  for (const userAssetDir of runtimeAssetDirs) {
-    if (fs.existsSync(userAssetDir) && path.resolve(userAssetDir) !== path.resolve(minionsDir)) {
-      addDirs.push(userAssetDir);
+  for (const dir of runtimeAssetDirs) {
+    if (dir && fs.existsSync(dir) && path.resolve(dir) !== path.resolve(minionsDir)) {
+      addDirs.push(dir);
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1682",
+  "version": "0.1.1684",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"